[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-19 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r427087643 ## File path: gradle/validation/check-broken-links.gradle ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-19 Thread GitBox
dweiss commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r427089469 ## File path: gradle/validation/check-broken-links.gradle ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Commented] (SOLR-9679) Exception when removing zk node /security.json

2020-05-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110945#comment-17110945 ] Jan Høydahl commented on SOLR-9679: --- I updated the PR with a unit test. Please review.

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 8.0

2020-05-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110952#comment-17110952 ] Jan Høydahl commented on SOLR-12823: SOLR-14303 is for deprecating /admin/zookeeper

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-19 Thread GitBox
dweiss commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r427124063 ## File path: gradle/validation/check-broken-links.gradle ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Created] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Dawid Weiss (Jira)
Dawid Weiss created SOLR-14497: -- Summary: Move the project to become Apache TLP Key: SOLR-14497 URL: https://issues.apache.org/jira/browse/SOLR-14497 Project: Solr Issue Type: Task Securit

[jira] [Created] (LUCENE-9375) Post Solr TLP move cleanup tasks

2020-05-19 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9375: --- Summary: Post Solr TLP move cleanup tasks Key: LUCENE-9375 URL: https://issues.apache.org/jira/browse/LUCENE-9375 Project: Lucene - Core Issue Type: Task

[jira] [Updated] (LUCENE-9375) Post Solr TLP move cleanup tasks

2020-05-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9375: Description: Please comment on SOLR-14497 unless it's Lucene specific.   # Reorganize Lucene rep

[jira] [Updated] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-14497: --- Description: This issue is about the process of moving Solr to become an Apache TLP. Elements to han

[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111015#comment-17111015 ] Robert Muir commented on SOLR-14142: Please, lets open a separate issue for that. It

[jira] [Commented] (SOLR-14419) Query DLS {"param":"ref"}

2020-05-19 Thread Cao Manh Dat (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111061#comment-17111061 ] Cao Manh Dat commented on SOLR-14419: - Hi [~mkhl], I'm going to look into the patch t

[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111079#comment-17111079 ] Uwe Schindler commented on SOLR-14142: -- I agree. Because of the security question co

[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111080#comment-17111080 ] Uwe Schindler commented on SOLR-14142: -- Maybe make days to keep confirgurable and st

[jira] [Updated] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-14497: - Description: This issue is about the process of moving Solr to become an Apache TLP. Elements to

[jira] [Updated] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated SOLR-14497: - Description: This issue is about the process of moving Solr to become an Apache TLP. Elements to

[jira] [Commented] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111085#comment-17111085 ] Uwe Schindler commented on SOLR-14497: -- As already discussed on Mailing list, I'd su

[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2020-05-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1708#comment-1708 ] Robert Muir commented on SOLR-14142: Days, bytes, maybe there are lots of options tow

[GitHub] [lucene-solr] mocobeta commented on a change in pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-19 Thread GitBox
mocobeta commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r427249419 ## File path: gradle/validation/check-broken-links.gradle ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-19 Thread GitBox
uschindler commented on a change in pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#discussion_r427252786 ## File path: gradle/validation/check-broken-links.gradle ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene-solr] uschindler commented on pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-19 Thread GitBox
uschindler commented on pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#issuecomment-630779242 I think you can do the same "Provider -> DirectoryProperty" change in the changes-to-html task that you modified yesterday. -

[jira] [Commented] (LUCENE-9333) Gradle task equivalent to ant's "change-to-html"

2020-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1731#comment-1731 ] ASF subversion and git services commented on LUCENE-9333: - Commi

[GitHub] [lucene-solr] mocobeta commented on pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-19 Thread GitBox
mocobeta commented on pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#issuecomment-630789427 I fixed it on https://github.com/apache/lucene-solr/commit/51c15b8660b9d6a3e5979bf1e53a98262db413e9 (and accidentally logged "merge" commit in the master https://github.co

[jira] [Created] (SOLR-14498) BlockCache gets stuck not accepting new stores

2020-05-19 Thread Jakub Zytka (Jira)
Jakub Zytka created SOLR-14498: -- Summary: BlockCache gets stuck not accepting new stores Key: SOLR-14498 URL: https://issues.apache.org/jira/browse/SOLR-14498 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-14498) BlockCache gets stuck not accepting new stores

2020-05-19 Thread Jakub Zytka (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakub Zytka updated SOLR-14498: --- Affects Version/s: master (9.0) > BlockCache gets stuck not accepting new stores > --

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1527: SOLR-14384 Stack SolrRequestInfo

2020-05-19 Thread GitBox
dsmiley commented on a change in pull request #1527: URL: https://github.com/apache/lucene-solr/pull/1527#discussion_r427323443 ## File path: solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java ## @@ -52,35 +54,44 @@ private static final Logger log = LoggerFacto

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1527: SOLR-14384 Stack SolrRequestInfo

2020-05-19 Thread GitBox
dsmiley commented on a change in pull request #1527: URL: https://github.com/apache/lucene-solr/pull/1527#discussion_r427323730 ## File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java ## @@ -456,6 +457,7 @@ public void doFilter(ServletRequest _request,

[jira] [Assigned] (SOLR-14498) BlockCache gets stuck not accepting new stores

2020-05-19 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki reassigned SOLR-14498: --- Assignee: Andrzej Bialecki > BlockCache gets stuck not accepting new stores > --

[jira] [Commented] (SOLR-14105) Http2SolrClient SSL not working in branch_8x

2020-05-19 Thread Tim Taranov (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111236#comment-17111236 ] Tim Taranov commented on SOLR-14105: [~janhoy]  unfortunately we can't retest this wi

[jira] [Created] (LUCENE-9376) Fix or suppress 20 resource leak precommit warnings in lucene/search

2020-05-19 Thread Andras Salamon (Jira)
Andras Salamon created LUCENE-9376: -- Summary: Fix or suppress 20 resource leak precommit warnings in lucene/search Key: LUCENE-9376 URL: https://issues.apache.org/jira/browse/LUCENE-9376 Project: Luc

[jira] [Updated] (LUCENE-9376) Fix or suppress 20 resource leak precommit warnings in lucene/search

2020-05-19 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated LUCENE-9376: --- Description: There are 20 resource leak precommit warnings in org/apache/lucene/search: {nof

[jira] [Updated] (LUCENE-9376) Fix or suppress 20 resource leak precommit warnings in lucene/search

2020-05-19 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated LUCENE-9376: --- Status: Patch Available (was: Open) > Fix or suppress 20 resource leak precommit warnings i

[jira] [Updated] (LUCENE-9376) Fix or suppress 20 resource leak precommit warnings in lucene/search

2020-05-19 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated LUCENE-9376: --- Attachment: LUCENE-9376.patch > Fix or suppress 20 resource leak precommit warnings in lucen

[GitHub] [lucene-solr] dweiss commented on pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-19 Thread GitBox
dweiss commented on pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#issuecomment-630892331 It's fine, although the snippet I copy-pasted showed a way which I think is more elegant in the long term: separates the actual property configuration bit from its declaratio

[jira] [Commented] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111285#comment-17111285 ] Jan Høydahl commented on SOLR-14497: I started a WIKI page at [https://cwiki.apache.

[jira] [Updated] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14497: --- Description: This issue is about the process of moving Solr to become an Apache TLP. Se [https://cwi

[jira] [Commented] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111295#comment-17111295 ] Dawid Weiss commented on SOLR-14497: Thanks Jan, very clear. > Move the project to b

[jira] [Created] (SOLR-14499) New Solr TLP site

2020-05-19 Thread Jira
Jan Høydahl created SOLR-14499: -- Summary: New Solr TLP site Key: SOLR-14499 URL: https://issues.apache.org/jira/browse/SOLR-14499 Project: Solr Issue Type: Sub-task Security Level: Public

[jira] [Commented] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111309#comment-17111309 ] Jan Høydahl commented on SOLR-14497: Agree with Uwe we should set some conditions for

[jira] [Commented] (SOLR-14497) Move the project to become Apache TLP

2020-05-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111312#comment-17111312 ] Dawid Weiss commented on SOLR-14497: Well, a patch will still apply (even if stripped

[jira] [Assigned] (LUCENE-9376) Fix or suppress 20 resource leak precommit warnings in lucene/search

2020-05-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned LUCENE-9376: -- Assignee: Erick Erickson > Fix or suppress 20 resource leak precommit warnings in luc

[jira] [Commented] (LUCENE-9376) Fix or suppress 20 resource leak precommit warnings in lucene/search

2020-05-19 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111325#comment-17111325 ] Erick Erickson commented on LUCENE-9376: [~asalamon74] Please mention me when yo

[GitHub] [lucene-solr] markharwood merged pull request #1521: Lucene-9371: Allow external access to RegExp's parsed structure

2020-05-19 Thread GitBox
markharwood merged pull request #1521: URL: https://github.com/apache/lucene-solr/pull/1521 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (LUCENE-9371) Make RegExp internal state more visible to support more rendering formats

2020-05-19 Thread Mark Harwood (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111342#comment-17111342 ] Mark Harwood commented on LUCENE-9371: -- Resolved in [https://github.com/apache/luc

[jira] [Commented] (SOLR-14486) Autoscaling simulation framework should stop using /clusterstate.json

2020-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111349#comment-17111349 ] ASF subversion and git services commented on SOLR-14486: Commit 5

[jira] [Resolved] (SOLR-14486) Autoscaling simulation framework should stop using /clusterstate.json

2020-05-19 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki resolved SOLR-14486. - Fix Version/s: master (9.0) Resolution: Fixed > Autoscaling simulation framework s

[jira] [Commented] (SOLR-14486) Autoscaling simulation framework should stop using /clusterstate.json

2020-05-19 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111353#comment-17111353 ] Andrzej Bialecki commented on SOLR-14486: - I changed the implementation so that i

[GitHub] [lucene-solr] markharwood opened a new pull request #1529: Lucene-9371: Allow external access to RegExp's parsed structure (#1521)

2020-05-19 Thread GitBox
markharwood opened a new pull request #1529: URL: https://github.com/apache/lucene-solr/pull/1529 Made RegExp internal fields public final to allow external classes to render eg English explanations of pattern logic Backport of https://github.com/apache/lucene-solr/pull/1521 --

[GitHub] [lucene-solr] markharwood merged pull request #1529: Lucene-9371: Allow external access to RegExp's parsed structure (#1521)

2020-05-19 Thread GitBox
markharwood merged pull request #1529: URL: https://github.com/apache/lucene-solr/pull/1529 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Resolved] (LUCENE-9371) Make RegExp internal state more visible to support more rendering formats

2020-05-19 Thread Mark Harwood (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Harwood resolved LUCENE-9371. -- Resolution: Fixed Fixed in master and backported to branch_8x in  https://github.com/apache/lu

[jira] [Commented] (LUCENE-9376) Fix or suppress 20 resource leak precommit warnings in lucene/search

2020-05-19 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111440#comment-17111440 ] Lucene/Solr QA commented on LUCENE-9376: | (/) *{color:green}+1 overall{color}*

[jira] [Commented] (SOLR-14484) NPE in ConcurrentUpdateHttp2SolrClient MDC logging

2020-05-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111446#comment-17111446 ] David Smiley commented on SOLR-14484: - I propose simply using {{String.valueOf(client

[jira] [Resolved] (LUCENE-9355) missing releases from testbackwardscompatibility

2020-05-19 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-9355. --- Assignee: Mike Drob Resolution: Fixed cherry-picked commits from branch_7 to branch_8 and that

[jira] [Commented] (SOLR-14470) Add streaming expressions to /export handler

2020-05-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111458#comment-17111458 ] David Smiley commented on SOLR-14470: - Sounds great but hopefully can be done in a la

[GitHub] [lucene-solr] NazerkeBS commented on a change in pull request #1527: SOLR-14384 Stack SolrRequestInfo

2020-05-19 Thread GitBox
NazerkeBS commented on a change in pull request #1527: URL: https://github.com/apache/lucene-solr/pull/1527#discussion_r427552166 ## File path: solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java ## @@ -52,35 +54,44 @@ private static final Logger log = LoggerFac

[jira] [Created] (SOLR-14500) currency function doesn't work for asymmetric rates

2020-05-19 Thread Murray Johnston (Jira)
Murray Johnston created SOLR-14500: -- Summary: currency function doesn't work for asymmetric rates Key: SOLR-14500 URL: https://issues.apache.org/jira/browse/SOLR-14500 Project: Solr Issue Ty

[GitHub] [lucene-solr] madrob commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
madrob commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r427580023 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -491,6 +493,40 @@ public boolean isClosed() { assert ObjectReleaseT

[jira] [Created] (SOLR-14501) Reduce retention period of Jetty NCSA request log

2020-05-19 Thread David Smiley (Jira)
David Smiley created SOLR-14501: --- Summary: Reduce retention period of Jetty NCSA request log Key: SOLR-14501 URL: https://issues.apache.org/jira/browse/SOLR-14501 Project: Solr Issue Type: Impr

[jira] [Updated] (SOLR-14500) currency function doesn't work for asymmetric rates

2020-05-19 Thread Murray Johnston (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Murray Johnston updated SOLR-14500: --- Attachment: test.patch > currency function doesn't work for asymmetric rates > --

[jira] [Commented] (SOLR-14500) currency function doesn't work for asymmetric rates

2020-05-19 Thread Murray Johnston (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111552#comment-17111552 ] Murray Johnston commented on SOLR-14500: I've added a patch to illustrate the iss

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r427625766 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -236,21 +235,19 @@ public void call(ClusterSta

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1527: SOLR-14384 Stack SolrRequestInfo

2020-05-19 Thread GitBox
mkhludnev commented on a change in pull request #1527: URL: https://github.com/apache/lucene-solr/pull/1527#discussion_r427625556 ## File path: solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java ## @@ -52,35 +54,44 @@ private static final Logger log = LoggerFac

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r427627276 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -491,6 +493,40 @@ public boolean isClosed() { assert ObjectReleas

[GitHub] [lucene-solr] janhoy commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
janhoy commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r427627240 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -236,21 +235,19 @@ public void call(ClusterState

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r427636430 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -236,21 +235,19 @@ public void call(ClusterSta

[GitHub] [lucene-solr] murblanc commented on pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
murblanc commented on pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#issuecomment-631124718 > Didn't get all the way through the tests, so it might be there even though I didn't see it - would be nice to have a test that makes sure an older client that still sends

[GitHub] [lucene-solr] murblanc commented on pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
murblanc commented on pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#issuecomment-631131151 Rebased on master. The recent fix to SOLR-14486 solved the failures in the autoscaling sim tests. I'm submitting this officially for review now (moving it out of draf

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 8.0

2020-05-19 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111605#comment-17111605 ] Ilan Ginzburg commented on SOLR-12823: -- I changed the status of [https://github.com/

[GitHub] [lucene-solr] murblanc edited a comment on pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
murblanc edited a comment on pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#issuecomment-631124718 > Didn't get all the way through the tests, so it might be there even though I didn't see it - would be nice to have a test that makes sure an older client that stil

[GitHub] [lucene-solr] mrsoong commented on pull request #1502: SOLR-13203: Added 400 status code to exception in DynamicField

2020-05-19 Thread GitBox
mrsoong commented on pull request #1502: URL: https://github.com/apache/lucene-solr/pull/1502#issuecomment-631138690 Hi @madrob. Just wanted to drop a friendly reminder that this PR is still waiting for the changed entry that you mentioned more than a week ago. --

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r427655602 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java ## @@ -491,6 +493,40 @@ public boolean isClosed() { assert ObjectReleas

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1528: SOLR-12823: remove /clusterstate.json

2020-05-19 Thread GitBox
murblanc commented on a change in pull request #1528: URL: https://github.com/apache/lucene-solr/pull/1528#discussion_r427655970 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java ## @@ -468,36 +467,6 @@ void checkResul

[jira] [Commented] (SOLR-14384) Stack SolrRequestInfo

2020-05-19 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111627#comment-17111627 ] Noble Paul commented on SOLR-14384: --- Can we have a better description? I'm sure this ma

[GitHub] [lucene-solr] mocobeta commented on pull request #1522: LUCENE-9374: Add checkBrokenLinks gradle task

2020-05-19 Thread GitBox
mocobeta commented on pull request #1522: URL: https://github.com/apache/lucene-solr/pull/1522#issuecomment-631169757 Thanks for reviewing. I plan to merge the branch to the master in shortly (if there's no other feedback).

[jira] [Commented] (SOLR-14484) NPE in ConcurrentUpdateHttp2SolrClient MDC logging

2020-05-19 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111826#comment-17111826 ] Andras Salamon commented on SOLR-14484: --- Yes, that's even simpler. Uploaded a new p

[jira] [Updated] (SOLR-14484) NPE in ConcurrentUpdateHttp2SolrClient MDC logging

2020-05-19 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14484: -- Attachment: SOLR-14484-02.patch > NPE in ConcurrentUpdateHttp2SolrClient MDC logging >