[jira] [Commented] (LUCENE-9475) Enhance the Gradle build as necessary after removing Ant support

2020-08-31 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188150#comment-17188150 ] Robert Muir commented on LUCENE-9475: - If solr wants to add such restrictions, they should form

[jira] [Commented] (LUCENE-9475) Enhance the Gradle build as necessary after removing Ant support

2020-08-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188148#comment-17188148 ] David Smiley commented on LUCENE-9475: -- [~rmuir] I noticed that yesterday you committed a change to

[jira] [Commented] (SOLR-14641) PeerSync, remove canHandleVersionRanges check

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188130#comment-17188130 ] ASF subversion and git services commented on SOLR-14641: Commit

[GitHub] [lucene-solr] CaoManhDat opened a new pull request #1814: SOLR-14776: Precompute the fingerprint during PeerSync

2020-08-31 Thread GitBox
CaoManhDat opened a new pull request #1814: URL: https://github.com/apache/lucene-solr/pull/1814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-14776) Precompute the fingerprint during PeerSync

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188127#comment-17188127 ] ASF subversion and git services commented on SOLR-14776: Commit

[jira] [Updated] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-08-31 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankur updated LUCENE-9444: -- Attachment: LUCENE-9444.patch Lucene Fields: New,Patch Available (was: New) Labels: facet

[jira] [Updated] (LUCENE-9444) Need an API to easily fetch facet labels for a field in a document

2020-08-31 Thread Ankur (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankur updated LUCENE-9444: -- Status: Patch Available (was: Open) > Need an API to easily fetch facet labels for a field in a document >

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1804: SOLR-14151: Bug fixes

2020-08-31 Thread GitBox
noblepaul commented on a change in pull request #1804: URL: https://github.com/apache/lucene-solr/pull/1804#discussion_r480663558 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -190,10 +197,41 @@ public IndexSchema(String name, InputSource is,

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1804: SOLR-14151: Bug fixes

2020-08-31 Thread GitBox
noblepaul commented on a change in pull request #1804: URL: https://github.com/apache/lucene-solr/pull/1804#discussion_r480663558 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -190,10 +197,41 @@ public IndexSchema(String name, InputSource is,

[jira] [Comment Edited] (SOLR-14774) HealthCheckHandler shouldn't be an implicit SolrCore level handler and should be configurable

2020-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188110#comment-17188110 ] Noble Paul edited comment on SOLR-14774 at 9/1/20, 3:03 AM: [~tflobbe] sure.

[jira] [Commented] (SOLR-14774) HealthCheckHandler shouldn't be an implicit SolrCore level handler and should be configurable

2020-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188110#comment-17188110 ] Noble Paul commented on SOLR-14774: --- [~tflobbe] sure. Let's address the `solr.xml` beats later

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1804: SOLR-14151: Bug fixes

2020-08-31 Thread GitBox
noblepaul commented on a change in pull request #1804: URL: https://github.com/apache/lucene-solr/pull/1804#discussion_r480663558 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -190,10 +197,41 @@ public IndexSchema(String name, InputSource is,

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188108#comment-17188108 ] Noble Paul commented on SOLR-14579: --- [~erickerickson] are you going to do this only on master or on

[jira] [Comment Edited] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188078#comment-17188078 ] Noble Paul edited comment on SOLR-14680 at 9/1/20, 2:41 AM: Thanks for the

[jira] [Commented] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188097#comment-17188097 ] Erick Erickson commented on SOLR-14579: --- [~noble.paul] I guess I'll take this one. The PR has some

[jira] [Comment Edited] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188097#comment-17188097 ] Erick Erickson edited comment on SOLR-14579 at 9/1/20, 2:08 AM:

[jira] [Assigned] (SOLR-14579) Remove SolrJ 'Utils' generic map functions

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-14579: - Assignee: Erick Erickson (was: Noble Paul) > Remove SolrJ 'Utils' generic map

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188095#comment-17188095 ] Erick Erickson commented on SOLR-14781: --- Yes, this inspection is available from the Community

[jira] [Assigned] (SOLR-14781) Remove unused classes

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-14781: - Assignee: (was: Erick Erickson) > Remove unused classes > - > >

[jira] [Commented] (SOLR-14613) Provide a clean API for pluggable replica assignment implementations

2020-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188084#comment-17188084 ] Noble Paul commented on SOLR-14613: --- We are making a Frankenstein framework which is getting harder day

[GitHub] [lucene-solr] noblepaul opened a new pull request #1813: SOLR-14613: No new APIs. use the existing APIs

2020-08-31 Thread GitBox
noblepaul opened a new pull request #1813: URL: https://github.com/apache/lucene-solr/pull/1813 WIP , do not commit. Untested We are spending too much time to create and manage a new set of APIs instead of solving the real problem at hand What does this PR do - No new

[jira] [Comment Edited] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188078#comment-17188078 ] Noble Paul edited comment on SOLR-14680 at 9/1/20, 1:14 AM: Thanks for the

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-31 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188078#comment-17188078 ] Noble Paul commented on SOLR-14680: --- Thanks for the review [~ab] {quote} why not use the standard

[jira] [Commented] (SOLR-14151) Make schema components load from packages

2020-08-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188077#comment-17188077 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14151: -- Noble, note that I asked for

[jira] [Commented] (SOLR-14151) Make schema components load from packages

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188068#comment-17188068 ] ASF subversion and git services commented on SOLR-14151: Commit

[jira] [Commented] (SOLR-14151) Make schema components load from packages

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188069#comment-17188069 ] ASF subversion and git services commented on SOLR-14151: Commit

[jira] [Commented] (SOLR-14151) Make schema components load from packages

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188067#comment-17188067 ] ASF subversion and git services commented on SOLR-14151: Commit

[jira] [Commented] (SOLR-14151) Make schema components load from packages

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188060#comment-17188060 ] ASF subversion and git services commented on SOLR-14151: Commit

[GitHub] [lucene-solr] erikhatcher closed pull request #1811: SOLR-14799: JWT authentication plugin only requires "sub" claim when principalClaim=sub

2020-08-31 Thread GitBox
erikhatcher closed pull request #1811: URL: https://github.com/apache/lucene-solr/pull/1811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] erikhatcher commented on pull request #1811: SOLR-14799: JWT authentication plugin only requires "sub" claim when principalClaim=sub

2020-08-31 Thread GitBox
erikhatcher commented on pull request #1811: URL: https://github.com/apache/lucene-solr/pull/1811#issuecomment-684084492 oops, from wrong branch This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene-solr] erikhatcher opened a new pull request #1812: SOLR-14799: JWT authentication plugin only requires sub claim when pr…

2020-08-31 Thread GitBox
erikhatcher opened a new pull request #1812: URL: https://github.com/apache/lucene-solr/pull/1812 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the

[GitHub] [lucene-solr] erikhatcher opened a new pull request #1811: SOLR-14799: JWT authentication plugin only requires "sub" claim when principalClaim=sub

2020-08-31 Thread GitBox
erikhatcher opened a new pull request #1811: URL: https://github.com/apache/lucene-solr/pull/1811 # Description Change for JWT authentication plugin to only require "sub" claim when principalClaim=sub # Solution Removed setSubject() call. # Tests

[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-684077608 > NO You need to make a realistic proposal here IMO @noblepaul. And we need something that **already exists**. If placement plugins depend on some future rehaul

[jira] [Created] (SOLR-14799) JWT authentication plugin should not require subject, unless set as principalClaim

2020-08-31 Thread Erik Hatcher (Jira)
Erik Hatcher created SOLR-14799: --- Summary: JWT authentication plugin should not require subject, unless set as principalClaim Key: SOLR-14799 URL: https://issues.apache.org/jira/browse/SOLR-14799

[jira] [Commented] (SOLR-14778) Disabling UpdateLog leads to silently lost updates

2020-08-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188032#comment-17188032 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14778: -- I didn't know disabling the

[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-684067188 > Let us take a step back and reassess at what we have today. ... > There is already an interface called `AssignStrategy` .Can you believe that it's as simple as

[GitHub] [lucene-solr] murblanc commented on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
murblanc commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-684063923 > I totally disagree that my proposal will be not performant. It has zero impact on performance whatsoever. Here's an example @noblepaul of how your proposal would

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1804: SOLR-14151: Bug fixes

2020-08-31 Thread GitBox
tflobbe commented on a change in pull request #1804: URL: https://github.com/apache/lucene-solr/pull/1804#discussion_r480308790 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -190,10 +197,41 @@ public IndexSchema(String name, InputSource is,

[jira] [Commented] (SOLR-14787) Inequality support in Payload Check query parser

2020-08-31 Thread Kevin Watters (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188010#comment-17188010 ] Kevin Watters commented on SOLR-14787: -- As far as I can tell,  between Solr 8.2.0 and solr 8.3.0 a

[GitHub] [lucene-solr] kwatters opened a new pull request #1810: SOLR-14787 - supporting an operator for the payload check query parser to support greater than / less than payload check queries.

2020-08-31 Thread GitBox
kwatters opened a new pull request #1810: URL: https://github.com/apache/lucene-solr/pull/1810 …ll fails. # Description This is a change to the payload check query parser. It allows users to pass an "op" and a "threshold" value as a local param. Those are wired

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-31 Thread GitBox
jimczi commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r480399378 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-08-31 Thread GitBox
jpountz commented on a change in pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#discussion_r480385432 ## File path: lucene/core/src/java/org/apache/lucene/index/SortingCodecReader.java ## @@ -1090,20 +1150,64 @@ public Bits getLiveDocs() { }

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-31 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r480386087 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,185 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] dsmiley commented on pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
dsmiley commented on pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#issuecomment-683986439 CC @dweiss you might want to briefly review this new module for the gradle aspect This is an automated

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
dsmiley commented on a change in pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480351353 ## File path: solr/docker/tests/shared.sh ## @@ -90,18 +90,44 @@ function prepare_dir_to_mount { fi rm -fr "$folder" >/dev/null 2>&1 mkdir

[jira] [Commented] (SOLR-14680) Provide simple interfaces to our concrete SolrCloud classes

2020-08-31 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187964#comment-17187964 ] Andrzej Bialecki commented on SOLR-14680: - On further reflection I think that this change needs

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-08-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187963#comment-17187963 ] David Smiley commented on SOLR-14781: -

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
HoustonPutman commented on a change in pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480333750 ## File path: solr/docker/docs/docker-compose.yml ## @@ -0,0 +1,13 @@ +version: '3' +services: + solr: +image: solr Review comment:

[GitHub] [lucene-solr] dweiss opened a new pull request #1809: LUCENE-9493: Remove obsolete dev-tools/{idea,netbeans,maven} folders

2020-08-31 Thread GitBox
dweiss opened a new pull request #1809: URL: https://github.com/apache/lucene-solr/pull/1809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187955#comment-17187955 ] Erick Erickson commented on SOLR-14781: --- I'll certainly try to merge the changes into 8x, but if it

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
HoustonPutman commented on a change in pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480320419 ## File path: solr/docker/docs/docker-compose.yml ## @@ -0,0 +1,13 @@ +version: '3' +services: + solr: +image: solr Review comment:

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-08-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187951#comment-17187951 ] David Smiley commented on SOLR-14781: - Thanks for volunteering! master-only is fine; it'd be nice to

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187942#comment-17187942 ] Erick Erickson commented on SOLR-14781: --- I'll play with this a bit later today. I assume you were

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1804: SOLR-14151: Bug fixes

2020-08-31 Thread GitBox
tflobbe commented on a change in pull request #1804: URL: https://github.com/apache/lucene-solr/pull/1804#discussion_r480308790 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -190,10 +197,41 @@ public IndexSchema(String name, InputSource is,

[jira] [Commented] (SOLR-14656) Deprecate current autoscaling framework, remove from master

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187927#comment-17187927 ] ASF subversion and git services commented on SOLR-14656: Commit

[jira] [Commented] (SOLR-14774) HealthCheckHandler shouldn't be an implicit SolrCore level handler and should be configurable

2020-08-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187905#comment-17187905 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14774: -- Hi Noble, As I mentioned in

[GitHub] [lucene-solr] madrob commented on pull request #1795: LUCENE-9487: Add a null check on BooleanWeight

2020-08-31 Thread GitBox
madrob commented on pull request #1795: URL: https://github.com/apache/lucene-solr/pull/1795#issuecomment-683917423 Closing PR to reflect closed JIRA status This is an automated message from the Apache Git Service. To

[GitHub] [lucene-solr] madrob closed pull request #1795: LUCENE-9487: Add a null check on BooleanWeight

2020-08-31 Thread GitBox
madrob closed pull request #1795: URL: https://github.com/apache/lucene-solr/pull/1795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9140) Clean up Solr dependencies to use transitives and explicit exclusions

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187884#comment-17187884 ] Dawid Weiss commented on LUCENE-9140: - It'd be awesome if this was cleaned up. Not an easy thing to

[jira] [Commented] (LUCENE-9140) Clean up Solr dependencies to use transitives and explicit exclusions

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187886#comment-17187886 ] Dawid Weiss commented on LUCENE-9140: - Oh, I think this can be moved from Lucene to Solr project too

[jira] [Created] (LUCENE-9493) Remove obsolete dev-tools/{idea,netbeans,maven} folders

2020-08-31 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9493: --- Summary: Remove obsolete dev-tools/{idea,netbeans,maven} folders Key: LUCENE-9493 URL: https://issues.apache.org/jira/browse/LUCENE-9493 Project: Lucene - Core

[jira] [Assigned] (LUCENE-9140) Clean up Solr dependencies to use transitives and explicit exclusions

2020-08-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned LUCENE-9140: Assignee: David Smiley > Clean up Solr dependencies to use transitives and explicit

[jira] [Updated] (LUCENE-9120) Ability to run gradle tests with security auditing or any other JVM-level messaging

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9120: Parent: (was: LUCENE-9077) Issue Type: Wish (was: Sub-task) > Ability to run gradle

[jira] [Updated] (LUCENE-9140) Clean up Solr dependencies to use transitives and explicit exclusions

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9140: Parent: (was: LUCENE-9077) Issue Type: Bug (was: Sub-task) > Clean up Solr

[jira] [Resolved] (LUCENE-9332) Migrate validate source patterns task from ant/groovy to gradle/groovy

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9332. - Resolution: Duplicate > Migrate validate source patterns task from ant/groovy to gradle/groovy

[jira] [Updated] (LUCENE-9077) Gradle build

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9077: Description: This task focuses on providing gradle-based build equivalent for Lucene and Solr

[jira] [Commented] (SOLR-14656) Deprecate current autoscaling framework, remove from master

2020-08-31 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187842#comment-17187842 ] Cassandra Targett commented on SOLR-14656: -- Sounds good Ilan, I like your change. We can figure

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1310: SOLR-13350: Multithreaded search using collector managers

2020-08-31 Thread GitBox
dsmiley commented on a change in pull request #1310: URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r480235055 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -1712,33 +1806,47 @@ public ScoreMode scoreMode() { // no

[jira] [Resolved] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9492. --- Resolution: Fixed > "gradlew beast" has some minor problems >

[GitHub] [lucene-solr] uschindler merged pull request #1808: LUCENE-9492: Fix beasting to accept also task names in form ":project…

2020-08-31 Thread GitBox
uschindler merged pull request #1808: URL: https://github.com/apache/lucene-solr/pull/1808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187837#comment-17187837 ] ASF subversion and git services commented on LUCENE-9492: - Commit

[jira] [Updated] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9492: -- Fix Version/s: master (9.0) > "gradlew beast" has some minor problems >

[GitHub] [lucene-solr] uschindler opened a new pull request #1808: LUCENE-9492: Fix beasting to accept also task names in form ":project…

2020-08-31 Thread GitBox
uschindler opened a new pull request #1808: URL: https://github.com/apache/lucene-solr/pull/1808 …:beast"; fix bug with default value rejected by Integer.parseInt This is an automated message from the Apache Git Service. To

[jira] [Assigned] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-9492: - Assignee: Uwe Schindler > "gradlew beast" has some minor problems >

[jira] [Updated] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9492: -- Affects Version/s: master (9.0) > "gradlew beast" has some minor problems >

[jira] [Updated] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9492: -- Description: Hi Dawid, I tried the "beast" task today, works - if you know howto, it's easy,

[jira] [Commented] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187826#comment-17187826 ] Uwe Schindler commented on LUCENE-9492: --- I fixed both issues, here is the PR:

[jira] [Commented] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187816#comment-17187816 ] Uwe Schindler commented on LUCENE-9492: --- Ah, i know the issue, its easy to fix: the default is a

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
HoustonPutman commented on a change in pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480219024 ## File path: solr/docker/tests/shared.sh ## @@ -90,18 +90,44 @@ function prepare_dir_to_mount { fi rm -fr "$folder" >/dev/null 2>&1

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
HoustonPutman commented on a change in pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480216593 ## File path: solr/docker/tests/shared.sh ## @@ -90,18 +90,44 @@ function prepare_dir_to_mount { fi rm -fr "$folder" >/dev/null 2>&1

[jira] [Created] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-9492: - Summary: "gradlew beast" has some minor problems Key: LUCENE-9492 URL: https://issues.apache.org/jira/browse/LUCENE-9492 Project: Lucene - Core Issue

[jira] [Commented] (SOLR-14677) DIH doesnt close DataSource when import encounters errors

2020-08-31 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187798#comment-17187798 ] Jason Gerlowski commented on SOLR-14677: No, this bug fix was very recent - well after the plugin

[jira] [Assigned] (SOLR-14781) Remove unused classes

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-14781: - Assignee: Erick Erickson > Remove unused classes > - > >

[GitHub] [lucene-solr] mkhludnev closed pull request #1625: Highlighting the actual state observed in LUCENE-9328

2020-08-31 Thread GitBox
mkhludnev closed pull request #1625: URL: https://github.com/apache/lucene-solr/pull/1625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] mkhludnev commented on pull request #1625: Highlighting the actual state observed in LUCENE-9328

2020-08-31 Thread GitBox
mkhludnev commented on pull request #1625: URL: https://github.com/apache/lucene-solr/pull/1625#issuecomment-683828936 > it wouldn't be worth removing it now. ok. It's fair. Thanks. @ctargett This is an automated

[jira] [Updated] (LUCENE-9328) Sorting by DocValues while grouping is slower than old good FieldCache

2020-08-31 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Issue Type: Bug (was: Improvement) > Sorting by DocValues while grouping is slower

[jira] [Commented] (LUCENE-9438) Add gradle workflow support for Eclipse IDE

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187744#comment-17187744 ] ASF subversion and git services commented on LUCENE-9438: - Commit

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683771821 >I’d be happy to change the current proposal for something easier to use (not pretending it’s perfect) but I’m not willing to sacrifice on performance in order to

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683778043 Let us take a step back and reassess at what we have today.

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1310: SOLR-13350: Multithreaded search using collector managers

2020-08-31 Thread GitBox
mkhludnev commented on a change in pull request #1310: URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r480132272 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -1712,33 +1806,47 @@ public ScoreMode scoreMode() { //

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1310: SOLR-13350: Multithreaded search using collector managers

2020-08-31 Thread GitBox
mkhludnev commented on a change in pull request #1310: URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r480114845 ## File path: solr/core/src/java/org/apache/solr/core/NodeConfig.java ## @@ -309,6 +317,7 @@ public boolean isFromZookeeper() { private final

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683778043 Let us take a step back and reassess at what we have today.

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683771821 >I’d be happy to change the current proposal for something easier to use (not pretending it’s perfect) but I’m not willing to sacrifice on performance in order to do so.

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683772488 > the way forward should be to maybe use Solr.XML only for now to unblock you, but revisit it later to leverage clusterprops before the release. @noble, is that okay

[jira] [Commented] (LUCENE-9435) Clean up ant compatability remnants in Gradle build

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187710#comment-17187710 ] Dawid Weiss commented on LUCENE-9435: - I reverted the old hairy code (for Solr only) since it'll

[jira] [Commented] (LUCENE-9435) Clean up ant compatability remnants in Gradle build

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187708#comment-17187708 ] ASF subversion and git services commented on LUCENE-9435: - Commit

[jira] [Resolved] (SOLR-14786) Delete SOLR-2452.patch.hack.pl

2020-08-31 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch resolved SOLR-14786. -- Resolution: Fixed > Delete SOLR-2452.patch.hack.pl >

[jira] [Commented] (SOLR-14786) Delete SOLR-2452.patch.hack.pl

2020-08-31 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187702#comment-17187702 ] Alexandre Rafalovitch commented on SOLR-14786: -- Somehow merge did not follow-up. I must have

[GitHub] [lucene-solr] arafalov merged pull request #1800: SOLR-14786: Delete ancient patch file

2020-08-31 Thread GitBox
arafalov merged pull request #1800: URL: https://github.com/apache/lucene-solr/pull/1800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9434) Update release step to remove creating a wiki page for every Solr release

2020-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187700#comment-17187700 ] Jan Høydahl commented on LUCENE-9434: - Cassandra, the patch looks fine, but would be better if it

  1   2   >