[GitHub] [lucene-solr] dweiss commented on pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
dweiss commented on pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#issuecomment-683612482 Mike Drob did some work on inputs/ outputs here, it was too early though (ant compatibility). https://github.com/apache/lucene-solr/pull/1441 The outputs can be empt

[jira] [Updated] (SOLR-6152) Pre-populating values into search parameters on the query page of solr admin

2020-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-6152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-6152: -- Status: Patch Available (was: Open) > Pre-populating values into search parameters on the query page of

[GitHub] [lucene-solr] uschindler commented on pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
uschindler commented on pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#issuecomment-683614441 Oh haven't seen that PR. I was just annoyed by the warning. This is an automated message from the Apache

[GitHub] [lucene-solr] uschindler commented on pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
uschindler commented on pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#issuecomment-683614711 I wanted to change the task in the same way after all. 👍🏻 This is an automated message from the Apache Gi

[jira] [Updated] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Thomas Schmiereck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Schmiereck updated SOLR-14782: - Description: h1. Description if the elevate.xml contains a entry with spaces: <{color:#

[jira] [Updated] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Thomas Schmiereck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Schmiereck updated SOLR-14782: - Description: h1. Description if the elevate.xml contains a entry with spaces: <{color:#

[GitHub] [lucene-site] bdelacretaz opened a new pull request #28: Add GitHub Topics, helps find ASF website examples

2020-08-31 Thread GitBox
bdelacretaz opened a new pull request #28: URL: https://github.com/apache/lucene-site/pull/28 https://infra.apache.org/project-site.html already has queries to find ASF websites created using various tools [1], I suggest adding the "website, pelican" topics to this repo so it can be listed

[jira] [Updated] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Thomas Schmiereck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Schmiereck updated SOLR-14782: - Attachment: SOLR-14782.patch > QueryElevationComponent does not handle escaped query term

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Thomas Schmiereck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187555#comment-17187555 ] Thomas Schmiereck commented on SOLR-14782: -- Hi [~broustant], I've added my patch

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187563#comment-17187563 ] Bruno Roustant commented on SOLR-14782: --- [~smk] could you retry to attach the patch

[jira] [Comment Edited] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187563#comment-17187563 ] Bruno Roustant edited comment on SOLR-14782 at 8/31/20, 8:45 AM: --

[GitHub] [lucene-solr] uschindler closed pull request #1441: LUCENE-9332 validate source patterns using gradle

2020-08-31 Thread GitBox
uschindler closed pull request #1441: URL: https://github.com/apache/lucene-solr/pull/1441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] uschindler commented on pull request #1441: LUCENE-9332 validate source patterns using gradle

2020-08-31 Thread GitBox
uschindler commented on pull request #1441: URL: https://github.com/apache/lucene-solr/pull/1441#issuecomment-683654005 Hi, I will take some parts to my new pull request #1806. This one does not merge anymore, so it needs to be redone. The problem with RAT is already solved there (the depe

[GitHub] [lucene-solr] s1monw commented on pull request #1789: LUCENE-9484: Allow sorting an index after the fact

2020-08-31 Thread GitBox
s1monw commented on pull request #1789: URL: https://github.com/apache/lucene-solr/pull/1789#issuecomment-683654109 @jpountz I pushed some improvements and inherited from CodecReader, can you take another look This is an aut

[GitHub] [lucene-solr] uschindler commented on pull request #1802: LUCENE-9215: replace checkJavaDocs.py with doclet

2020-08-31 Thread GitBox
uschindler commented on pull request #1802: URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683655486 > That is really wrong to do. If master is on java 11, then master is on java 11. If i had more energy i would heavy commit the fix to master just for emphasis. I

[jira] [Updated] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Thomas Schmiereck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Schmiereck updated SOLR-14782: - Attachment: (was: SOLR-14782.patch) > QueryElevationComponent does not handle escaped

[jira] [Updated] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Thomas Schmiereck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Schmiereck updated SOLR-14782: - Attachment: SOLR-14782.patch > QueryElevationComponent does not handle escaped query term

[jira] [Commented] (SOLR-14782) QueryElevationComponent does not handle escaped query terms

2020-08-31 Thread Thomas Schmiereck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187579#comment-17187579 ] Thomas Schmiereck commented on SOLR-14782: -- [~broustant] Sorry, was the wrong fi

[jira] [Created] (LUCENE-9491) Consolidate test options and improve support for dynamically computed values

2020-08-31 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9491: --- Summary: Consolidate test options and improve support for dynamically computed values Key: LUCENE-9491 URL: https://issues.apache.org/jira/browse/LUCENE-9491 Project: L

[GitHub] [lucene-solr] uschindler commented on pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
uschindler commented on pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#issuecomment-683666774 Hi I converted this PR to a draft, because I am incorporating changes from #1441 (which I closed, as outdated). -

[GitHub] [lucene-solr] dweiss opened a new pull request #1807: LUCENE-9491: Consolidate test options and improve support for dynamic…

2020-08-31 Thread GitBox
dweiss opened a new pull request #1807: URL: https://github.com/apache/lucene-solr/pull/1807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-14794) Pass global cloud configuration to Collection API command execution

2020-08-31 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187610#comment-17187610 ] Andrzej Bialecki commented on SOLR-14794: - Wouldn't this be much easier if we sim

[GitHub] [lucene-solr] uschindler commented on pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
uschindler commented on pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#issuecomment-683688206 I think it's now ready. I did not change the inner closures to be real class members. The most important thing to me was to make the inputs declared and the outputs alway

[GitHub] [lucene-solr] apoorvprecisely commented on pull request #1775: SOLR-14767 : fix long field parsing from string

2020-08-31 Thread GitBox
apoorvprecisely commented on pull request #1775: URL: https://github.com/apache/lucene-solr/pull/1775#issuecomment-683688265 will make changes, will use double parsing only as a fallback This is an automated message from the

[GitHub] [lucene-solr] uschindler commented on pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
uschindler commented on pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#issuecomment-683689216 In case you ask: Making is a class extends DefaultTask allows to better declare inputs/outputs. I am not a fan of manually adding them. This code is much more readable (b

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
dweiss commented on a change in pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#discussion_r480030991 ## File path: gradle/validation/validate-source-patterns.gradle ## @@ -15,27 +15,233 @@ * limitations under the License. */ -// This should be ev

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
dweiss commented on a change in pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#discussion_r480031302 ## File path: gradle/validation/validate-source-patterns.gradle ## @@ -15,27 +15,233 @@ * limitations under the License. */ -// This should be ev

[jira] [Commented] (LUCENE-9491) Consolidate test options and improve support for dynamically computed values

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187627#comment-17187627 ] ASF subversion and git services commented on LUCENE-9491: - Commi

[GitHub] [lucene-solr] dweiss merged pull request #1807: LUCENE-9491: Consolidate test options and improve support for dynamic…

2020-08-31 Thread GitBox
dweiss merged pull request #1807: URL: https://github.com/apache/lucene-solr/pull/1807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9491) Consolidate test options and improve support for dynamically computed values

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187628#comment-17187628 ] ASF subversion and git services commented on LUCENE-9491: - Commi

[jira] [Resolved] (LUCENE-9491) Consolidate test options and improve support for dynamically computed values

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9491. - Fix Version/s: master (9.0) Resolution: Fixed > Consolidate test options and improve supp

[GitHub] [lucene-solr] uschindler commented on pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
uschindler commented on pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#issuecomment-683701375 Thanks Dawid, I will merge this soon. Robert's issue about `var` should be decided later. In #1802 I will add an exclude just for him. ---

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-31 Thread GitBox
jimczi commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r480039931 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [lucene-solr] uschindler commented on pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
uschindler commented on pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#issuecomment-683701983 By the way: Due to my changes, also `gradle/**`` is now checked by validateSourcePatterns. I also added the `.gradle` file extension (you might have noticed). -

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
uschindler edited a comment on pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806#issuecomment-683701983 By the way: Due to my changes, also `gradle/**` is now checked by validateSourcePatterns. I also added the `.gradle` file extension (you might have noticed). ---

[GitHub] [lucene-solr] mocobeta commented on pull request #1802: LUCENE-9215: replace checkJavaDocs.py with doclet

2020-08-31 Thread GitBox
mocobeta commented on pull request #1802: URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683702823 > That is really wrong to do. If master is on java 11, then master is on java 11. If i had more energy i would heavy commit the fix to master just for emphasis. > Either

[jira] [Commented] (SOLR-14794) Pass global cloud configuration to Collection API command execution

2020-08-31 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187634#comment-17187634 ] Ilan Ginzburg commented on SOLR-14794: -- Makes sense [~ab] I'll fix that as soon as

[GitHub] [lucene-solr] uschindler merged pull request #1806: LUCENE-9475: Switch validateSourcePatterns away from Ant legacy

2020-08-31 Thread GitBox
uschindler merged pull request #1806: URL: https://github.com/apache/lucene-solr/pull/1806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9475) Enhance the Gradle build as necessary after removing Ant support

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187637#comment-17187637 ] ASF subversion and git services commented on LUCENE-9475: - Commi

[jira] [Commented] (LUCENE-9491) Consolidate test options and improve support for dynamically computed values

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187642#comment-17187642 ] ASF subversion and git services commented on LUCENE-9491: - Commi

[jira] [Commented] (LUCENE-9491) Consolidate test options and improve support for dynamically computed values

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187643#comment-17187643 ] ASF subversion and git services commented on LUCENE-9491: - Commi

[jira] [Commented] (LUCENE-9215) replace checkJavaDocs.py with doclet

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187645#comment-17187645 ] ASF subversion and git services commented on LUCENE-9215: - Commi

[jira] [Commented] (LUCENE-9475) Enhance the Gradle build as necessary after removing Ant support

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187644#comment-17187644 ] ASF subversion and git services commented on LUCENE-9475: - Commi

[GitHub] [lucene-solr] uschindler commented on pull request #1802: LUCENE-9215: replace checkJavaDocs.py with doclet

2020-08-31 Thread GitBox
uschindler commented on pull request #1802: URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683713105 > +1 from me... same from me, but this should not be heavy-committed without issue. There was a lengthly discussion already (search JIRA and mailing list). I

[jira] [Commented] (LUCENE-9435) Clean up ant compatability remnants in Gradle build

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187688#comment-17187688 ] Erick Erickson commented on LUCENE-9435: [~dweiss]  I think this broke "gradlew

[jira] [Commented] (LUCENE-9435) Clean up ant compatability remnants in Gradle build

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187691#comment-17187691 ] Dawid Weiss commented on LUCENE-9435: - Indeed, it might have. That workaround wasn't

[jira] [Commented] (LUCENE-9434) Update release step to remove creating a wiki page for every Solr release

2020-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187700#comment-17187700 ] Jan Høydahl commented on LUCENE-9434: - Cassandra, the patch looks fine, but would be

[GitHub] [lucene-solr] arafalov merged pull request #1800: SOLR-14786: Delete ancient patch file

2020-08-31 Thread GitBox
arafalov merged pull request #1800: URL: https://github.com/apache/lucene-solr/pull/1800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Resolved] (SOLR-14786) Delete SOLR-2452.patch.hack.pl

2020-08-31 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Rafalovitch resolved SOLR-14786. -- Resolution: Fixed > Delete SOLR-2452.patch.hack.pl > --

[jira] [Commented] (SOLR-14786) Delete SOLR-2452.patch.hack.pl

2020-08-31 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187702#comment-17187702 ] Alexandre Rafalovitch commented on SOLR-14786: -- Somehow merge did not follow

[jira] [Commented] (LUCENE-9435) Clean up ant compatability remnants in Gradle build

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187708#comment-17187708 ] ASF subversion and git services commented on LUCENE-9435: - Commi

[jira] [Commented] (LUCENE-9435) Clean up ant compatability remnants in Gradle build

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187710#comment-17187710 ] Dawid Weiss commented on LUCENE-9435: - I reverted the old hairy code (for Solr only)

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683772488 > the way forward should be to maybe use Solr.XML only for now to unblock you, but revisit it later to leverage clusterprops before the release. @noble, is that okay f

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683771821 >I’d be happy to change the current proposal for something easier to use (not pretending it’s perfect) but I’m not willing to sacrifice on performance in order to do so.

[GitHub] [lucene-solr] noblepaul commented on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683778043 Let us take a step back and reassess at what we have today. https://github.com/apache/lucene-solr/blob/4a2a2da462ef017154856edd92b9f4f8c549c084/solr/core/src/java/or

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1310: SOLR-13350: Multithreaded search using collector managers

2020-08-31 Thread GitBox
mkhludnev commented on a change in pull request #1310: URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r480114845 ## File path: solr/core/src/java/org/apache/solr/core/NodeConfig.java ## @@ -309,6 +317,7 @@ public boolean isFromZookeeper() { private final S

[GitHub] [lucene-solr] mkhludnev commented on a change in pull request #1310: SOLR-13350: Multithreaded search using collector managers

2020-08-31 Thread GitBox
mkhludnev commented on a change in pull request #1310: URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r480132272 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -1712,33 +1806,47 @@ public ScoreMode scoreMode() { // n

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683778043 Let us take a step back and reassess at what we have today. https://github.com/apache/lucene-solr/blob/4a2a2da462ef017154856edd92b9f4f8c549c084/solr/core/src/

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #1684: SOLR-14613: strongly typed initial proposal for placement plugin interface

2020-08-31 Thread GitBox
noblepaul edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683771821 >I’d be happy to change the current proposal for something easier to use (not pretending it’s perfect) but I’m not willing to sacrifice on performance in order to d

[jira] [Commented] (LUCENE-9438) Add gradle workflow support for Eclipse IDE

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187744#comment-17187744 ] ASF subversion and git services commented on LUCENE-9438: - Commi

[jira] [Updated] (LUCENE-9328) Sorting by DocValues while grouping is slower than old good FieldCache

2020-08-31 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Issue Type: Bug (was: Improvement) > Sorting by DocValues while grouping is slower than

[GitHub] [lucene-solr] mkhludnev closed pull request #1625: Highlighting the actual state observed in LUCENE-9328

2020-08-31 Thread GitBox
mkhludnev closed pull request #1625: URL: https://github.com/apache/lucene-solr/pull/1625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] mkhludnev commented on pull request #1625: Highlighting the actual state observed in LUCENE-9328

2020-08-31 Thread GitBox
mkhludnev commented on pull request #1625: URL: https://github.com/apache/lucene-solr/pull/1625#issuecomment-683828936 > it wouldn't be worth removing it now. ok. It's fair. Thanks. @ctargett This is an automated mess

[jira] [Assigned] (SOLR-14781) Remove unused classes

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-14781: - Assignee: Erick Erickson > Remove unused classes > - > >

[jira] [Commented] (SOLR-14677) DIH doesnt close DataSource when import encounters errors

2020-08-31 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187798#comment-17187798 ] Jason Gerlowski commented on SOLR-14677: No, this bug fix was very recent - well

[jira] [Created] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
Uwe Schindler created LUCENE-9492: - Summary: "gradlew beast" has some minor problems Key: LUCENE-9492 URL: https://issues.apache.org/jira/browse/LUCENE-9492 Project: Lucene - Core Issue Type:

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
HoustonPutman commented on a change in pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480216593 ## File path: solr/docker/tests/shared.sh ## @@ -90,18 +90,44 @@ function prepare_dir_to_mount { fi rm -fr "$folder" >/dev/null 2>&1 mk

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
HoustonPutman commented on a change in pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480219024 ## File path: solr/docker/tests/shared.sh ## @@ -90,18 +90,44 @@ function prepare_dir_to_mount { fi rm -fr "$folder" >/dev/null 2>&1 mk

[jira] [Commented] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187816#comment-17187816 ] Uwe Schindler commented on LUCENE-9492: --- Ah, i know the issue, its easy to fix: th

[jira] [Commented] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187826#comment-17187826 ] Uwe Schindler commented on LUCENE-9492: --- I fixed both issues, here is the PR: htt

[jira] [Updated] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9492: -- Description: Hi Dawid, I tried the "beast" task today, works - if you know howto, it's easy, b

[jira] [Updated] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9492: -- Affects Version/s: master (9.0) > "gradlew beast" has some minor problems > --

[GitHub] [lucene-solr] uschindler opened a new pull request #1808: LUCENE-9492: Fix beasting to accept also task names in form ":project…

2020-08-31 Thread GitBox
uschindler opened a new pull request #1808: URL: https://github.com/apache/lucene-solr/pull/1808 …:beast"; fix bug with default value rejected by Integer.parseInt This is an automated message from the Apache Git Service. To r

[jira] [Assigned] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reassigned LUCENE-9492: - Assignee: Uwe Schindler > "gradlew beast" has some minor problems > ---

[jira] [Updated] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9492: -- Fix Version/s: master (9.0) > "gradlew beast" has some minor problems > --

[jira] [Commented] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187837#comment-17187837 ] ASF subversion and git services commented on LUCENE-9492: - Commi

[GitHub] [lucene-solr] uschindler merged pull request #1808: LUCENE-9492: Fix beasting to accept also task names in form ":project…

2020-08-31 Thread GitBox
uschindler merged pull request #1808: URL: https://github.com/apache/lucene-solr/pull/1808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (LUCENE-9492) "gradlew beast" has some minor problems

2020-08-31 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9492. --- Resolution: Fixed > "gradlew beast" has some minor problems > --

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1310: SOLR-13350: Multithreaded search using collector managers

2020-08-31 Thread GitBox
dsmiley commented on a change in pull request #1310: URL: https://github.com/apache/lucene-solr/pull/1310#discussion_r480235055 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -1712,33 +1806,47 @@ public ScoreMode scoreMode() { // no

[jira] [Commented] (SOLR-14656) Deprecate current autoscaling framework, remove from master

2020-08-31 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187842#comment-17187842 ] Cassandra Targett commented on SOLR-14656: -- Sounds good Ilan, I like your change

[jira] [Updated] (LUCENE-9077) Gradle build

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9077: Description: This task focuses on providing gradle-based build equivalent for Lucene and Solr (on

[jira] [Resolved] (LUCENE-9332) Migrate validate source patterns task from ant/groovy to gradle/groovy

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9332. - Resolution: Duplicate > Migrate validate source patterns task from ant/groovy to gradle/groovy >

[jira] [Updated] (LUCENE-9140) Clean up Solr dependencies to use transitives and explicit exclusions

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9140: Parent: (was: LUCENE-9077) Issue Type: Bug (was: Sub-task) > Clean up Solr dependenci

[jira] [Updated] (LUCENE-9120) Ability to run gradle tests with security auditing or any other JVM-level messaging

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9120: Parent: (was: LUCENE-9077) Issue Type: Wish (was: Sub-task) > Ability to run gradle t

[jira] [Assigned] (LUCENE-9140) Clean up Solr dependencies to use transitives and explicit exclusions

2020-08-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned LUCENE-9140: Assignee: David Smiley > Clean up Solr dependencies to use transitives and explicit exclu

[jira] [Created] (LUCENE-9493) Remove obsolete dev-tools/{idea,netbeans,maven} folders

2020-08-31 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9493: --- Summary: Remove obsolete dev-tools/{idea,netbeans,maven} folders Key: LUCENE-9493 URL: https://issues.apache.org/jira/browse/LUCENE-9493 Project: Lucene - Core

[jira] [Commented] (LUCENE-9140) Clean up Solr dependencies to use transitives and explicit exclusions

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187886#comment-17187886 ] Dawid Weiss commented on LUCENE-9140: - Oh, I think this can be moved from Lucene to

[jira] [Commented] (LUCENE-9140) Clean up Solr dependencies to use transitives and explicit exclusions

2020-08-31 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187884#comment-17187884 ] Dawid Weiss commented on LUCENE-9140: - It'd be awesome if this was cleaned up. Not a

[GitHub] [lucene-solr] madrob commented on pull request #1795: LUCENE-9487: Add a null check on BooleanWeight

2020-08-31 Thread GitBox
madrob commented on pull request #1795: URL: https://github.com/apache/lucene-solr/pull/1795#issuecomment-683917423 Closing PR to reflect closed JIRA status This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] madrob closed pull request #1795: LUCENE-9487: Add a null check on BooleanWeight

2020-08-31 Thread GitBox
madrob closed pull request #1795: URL: https://github.com/apache/lucene-solr/pull/1795 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14774) HealthCheckHandler shouldn't be an implicit SolrCore level handler and should be configurable

2020-08-31 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187905#comment-17187905 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-14774: -- Hi Noble, As

[jira] [Commented] (SOLR-14656) Deprecate current autoscaling framework, remove from master

2020-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187927#comment-17187927 ] ASF subversion and git services commented on SOLR-14656: Commit 8

[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1804: SOLR-14151: Bug fixes

2020-08-31 Thread GitBox
tflobbe commented on a change in pull request #1804: URL: https://github.com/apache/lucene-solr/pull/1804#discussion_r480308790 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -190,10 +197,41 @@ public IndexSchema(String name, InputSource is, Vers

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187942#comment-17187942 ] Erick Erickson commented on SOLR-14781: --- I'll play with this a bit later today. I a

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-08-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187951#comment-17187951 ] David Smiley commented on SOLR-14781: - Thanks for volunteering! master-only is fine;

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
HoustonPutman commented on a change in pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480320419 ## File path: solr/docker/docs/docker-compose.yml ## @@ -0,0 +1,13 @@ +version: '3' +services: + solr: +image: solr Review comment:

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-08-31 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187955#comment-17187955 ] Erick Erickson commented on SOLR-14781: --- I'll certainly try to merge the changes in

[GitHub] [lucene-solr] dweiss opened a new pull request #1809: LUCENE-9493: Remove obsolete dev-tools/{idea,netbeans,maven} folders

2020-08-31 Thread GitBox
dweiss opened a new pull request #1809: URL: https://github.com/apache/lucene-solr/pull/1809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #1769: SOLR-14789: Absorb the docker-solr repo.

2020-08-31 Thread GitBox
HoustonPutman commented on a change in pull request #1769: URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r480333750 ## File path: solr/docker/docs/docker-compose.yml ## @@ -0,0 +1,13 @@ +version: '3' +services: + solr: +image: solr Review comment:

[jira] [Commented] (SOLR-14781) Remove unused classes

2020-08-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187963#comment-17187963 ] David Smiley commented on SOLR-14781: - https://www.jetbrains.com/help/idea/running-in

  1   2   >