[GitHub] [lucene-solr] dweiss opened a new pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
dweiss opened a new pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] dweiss commented on pull request #1816: LUCENE-9497: Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-04 Thread GitBox
dweiss commented on pull request #1816: URL: https://github.com/apache/lucene-solr/pull/1816#issuecomment-686969828 I made a few changes to consolidate the version used across compilations. Still don't know what the original problem was, let's see if this passes though. https://github.co

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Markus Kalkbrenner (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190622#comment-17190622 ] Markus Kalkbrenner commented on SOLR-13973: --- In fact you don't need to deprecat

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190623#comment-17190623 ] Ishan Chattopadhyaya commented on SOLR-13973: - [~mkalkbrenner], I think we sh

[jira] [Assigned] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya reassigned SOLR-13973: --- Assignee: Ishan Chattopadhyaya > Deprecate Tika > -- > >

[jira] [Commented] (LUCENE-9497) Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190628#comment-17190628 ] Dawid Weiss commented on LUCENE-9497: - The compilation problem was caused by the fac

[jira] [Commented] (LUCENE-9418) Ordered intervals can give inaccurate hits on interleaved terms

2020-09-04 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190630#comment-17190630 ] Alan Woodward commented on LUCENE-9418: --- Hi [~Brain2000], I think you have a diffe

[jira] [Created] (LUCENE-9505) Gradle tasks with outputs.upToDateWhen {true} are hard to re-run in separation

2020-09-04 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9505: --- Summary: Gradle tasks with outputs.upToDateWhen {true} are hard to re-run in separation Key: LUCENE-9505 URL: https://issues.apache.org/jira/browse/LUCENE-9505 Project:

[GitHub] [lucene-solr] dweiss opened a new pull request #1829: LUCENE-9505: add dummy outputs to tasks with no outputs

2020-09-04 Thread GitBox
dweiss opened a new pull request #1829: URL: https://github.com/apache/lucene-solr/pull/1829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (LUCENE-9505) Gradle tasks with outputs.upToDateWhen {true} are hard to re-run in separation

2020-09-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9505. - Fix Version/s: master (9.0) Resolution: Fixed > Gradle tasks with outputs.upToDateWhen {t

[GitHub] [lucene-solr] dweiss merged pull request #1829: LUCENE-9505: add dummy outputs to tasks with no outputs

2020-09-04 Thread GitBox
dweiss merged pull request #1829: URL: https://github.com/apache/lucene-solr/pull/1829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9505) Gradle tasks with outputs.upToDateWhen {true} are hard to re-run in separation

2020-09-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190641#comment-17190641 ] ASF subversion and git services commented on LUCENE-9505: - Commi

[jira] [Created] (LUCENE-9506) Gradle: split validateSourcePatterns into per-project and root-specific tasks (allow parallelism)

2020-09-04 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9506: --- Summary: Gradle: split validateSourcePatterns into per-project and root-specific tasks (allow parallelism) Key: LUCENE-9506 URL: https://issues.apache.org/jira/browse/LUCENE-9506

[GitHub] [lucene-solr] dweiss opened a new pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-04 Thread GitBox
dweiss opened a new pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] dweiss commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-04 Thread GitBox
dweiss commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-687038375 @uschindler you know these checks better - to me I refactored this stuff in the same way as before (and they're running much faster now since they can run in parallel). If yo

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190652#comment-17190652 ] ASF subversion and git services commented on LUCENE-9500: - Commi

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-04 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190653#comment-17190653 ] Uwe Schindler commented on LUCENE-9500: --- Thanks Adrien! Was this causing javadocs

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-04 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190658#comment-17190658 ] Uwe Schindler commented on LUCENE-9500: --- Ah, ECJ was complaining :-) Tahnks for fi

[jira] [Commented] (LUCENE-9500) Did we hit a DEFLATE bug?

2020-09-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190659#comment-17190659 ] Dawid Weiss commented on LUCENE-9500: - bq. I missed to run precommit after cherry-pi

[GitHub] [lucene-solr] epugh commented on pull request #1827: SOLR-14792: Remove VelocityResponseWriter

2020-09-04 Thread GitBox
epugh commented on pull request #1827: URL: https://github.com/apache/lucene-solr/pull/1827#issuecomment-687060583 @erikhatcher BTW, the .adoc format renders nicely in Github if you were to pull the ref guide docs over to https://github.com/erikhatcher/solritas. We could also update the

[GitHub] [lucene-solr] jimczi commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-04 Thread GitBox
jimczi commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r483531827 ## File path: lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java ## @@ -290,5 +299,114 @@ public void testFloatSortO

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-04 Thread GitBox
mayya-sharipova commented on pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#issuecomment-687065707 @jimczi Thanks for the review so far, I am wondering if you have any further comments? This is an a

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Markus Kalkbrenner (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190681#comment-17190681 ] Markus Kalkbrenner commented on SOLR-13973: --- {quote}Perhaps even a simple Tika

[jira] [Comment Edited] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Markus Kalkbrenner (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190681#comment-17190681 ] Markus Kalkbrenner edited comment on SOLR-13973 at 9/4/20, 11:18 AM: --

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1815: SOLR-14151: Bug fixes

2020-09-04 Thread GitBox
noblepaul commented on a change in pull request #1815: URL: https://github.com/apache/lucene-solr/pull/1815#discussion_r483561919 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -81,8 +81,7 @@ public final ConfigSet loadConfigSet(CoreDescriptor

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1815: SOLR-14151: Bug fixes

2020-09-04 Thread GitBox
noblepaul commented on a change in pull request #1815: URL: https://github.com/apache/lucene-solr/pull/1815#discussion_r483562559 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -1582,6 +1582,13 @@ private CoreDescriptor reloadCoreDescriptor(Core

[GitHub] [lucene-solr] noblepaul commented on pull request #1815: SOLR-14151: Bug fixes

2020-09-04 Thread GitBox
noblepaul commented on pull request #1815: URL: https://github.com/apache/lucene-solr/pull/1815#issuecomment-687092388 > Noble, could you be more specific about the bugs that this is fixing? I'm not sure exactly what the bug is `TestBulkSchemaConcurrent` was failing consistently aft

[GitHub] [lucene-solr] sigram opened a new pull request #1831: SOLR-14749 the scheduler part

2020-09-04 Thread GitBox
sigram opened a new pull request #1831: URL: https://github.com/apache/lucene-solr/pull/1831 See PR 1758 for the background on this. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1831: SOLR-14749 the scheduler part

2020-09-04 Thread GitBox
murblanc commented on a change in pull request #1831: URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r483580777 ## File path: solr/core/src/java/org/apache/solr/cloud/ClusterSingleton.java ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1831: SOLR-14749 the scheduler part

2020-09-04 Thread GitBox
murblanc commented on a change in pull request #1831: URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r483581489 ## File path: solr/core/src/java/org/apache/solr/cloud/Overseer.java ## @@ -775,6 +779,42 @@ private void doCompatCheck(BiConsumer consumer) {

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1831: SOLR-14749 the scheduler part

2020-09-04 Thread GitBox
murblanc commented on a change in pull request #1831: URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r483583874 ## File path: solr/core/src/java/org/apache/solr/cluster/scheduler/impl/CompiledSchedule.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache So

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1831: SOLR-14749 the scheduler part

2020-09-04 Thread GitBox
murblanc commented on a change in pull request #1831: URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r483584416 ## File path: solr/core/src/java/org/apache/solr/cluster/scheduler/impl/CompiledSchedule.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache So

[jira] [Commented] (SOLR-13652) Remove update from initParams in example solrconfig files that only mention "df"

2020-09-04 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190697#comment-17190697 ] Alexandre Rafalovitch commented on SOLR-13652: -- Added a section on Learning

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1831: SOLR-14749 the scheduler part

2020-09-04 Thread GitBox
murblanc commented on a change in pull request #1831: URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r483590300 ## File path: solr/core/src/java/org/apache/solr/cluster/scheduler/impl/SolrSchedulerImpl.java ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (SOLR-14821) docValuesTermsFilter should support single-valued docValues fields

2020-09-04 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190701#comment-17190701 ] Jason Gerlowski commented on SOLR-14821: We do have a test for this it turns out,

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1831: SOLR-14749 the scheduler part

2020-09-04 Thread GitBox
murblanc commented on a change in pull request #1831: URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r483592144 ## File path: solr/core/src/java/org/apache/solr/cluster/scheduler/SolrScheduler.java ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1831: SOLR-14749 the scheduler part

2020-09-04 Thread GitBox
murblanc commented on a change in pull request #1831: URL: https://github.com/apache/lucene-solr/pull/1831#discussion_r483593482 ## File path: solr/core/src/java/org/apache/solr/cluster/scheduler/Schedulable.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [lucene-solr] noblepaul commented on pull request #1813: SOLR-14613: No new APIs. use the existing APIs

2020-09-04 Thread GitBox
noblepaul commented on pull request #1813: URL: https://github.com/apache/lucene-solr/pull/1813#issuecomment-687126415 >Really? This is like saying that we only ever need collection admin APIs and we don't need any autoscaling. I don't think I made myself clear. Users would d

[jira] [Commented] (SOLR-7633) Change the ExtractingRequestHandler to use Tika-Server

2020-09-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190703#comment-17190703 ] Erick Erickson commented on SOLR-7633: -- Might be able to close this one, there's more

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190704#comment-17190704 ] Erick Erickson commented on SOLR-13973: --- 7632 is at least related... > Deprecate T

[jira] [Created] (LUCENE-9507) Custom order for leaves in DirectoryReader, IndexWriter and searcher

2020-09-04 Thread Jim Ferenczi (Jira)
Jim Ferenczi created LUCENE-9507: Summary: Custom order for leaves in DirectoryReader, IndexWriter and searcher Key: LUCENE-9507 URL: https://issues.apache.org/jira/browse/LUCENE-9507 Project: Lucene

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Tim Allison (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190711#comment-17190711 ] Tim Allison commented on SOLR-13973: [~mkalkbrenner] I've been thinking about adding

[jira] [Commented] (SOLR-14821) docValuesTermsFilter should support single-valued docValues fields

2020-09-04 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190712#comment-17190712 ] Jason Gerlowski commented on SOLR-14821: Ah, hmm, I can see it locally now - I in

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Markus Kalkbrenner (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190714#comment-17190714 ] Markus Kalkbrenner commented on SOLR-13973: --- {quote}to get Tika out of Solr's j

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Tim Allison (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190716#comment-17190716 ] Tim Allison commented on SOLR-13973: So that'd be SOLR-7632 as [~erickerickson] point

[GitHub] [lucene-solr] gus-asf merged pull request #1715: SOLR-14704 add download option to cloud.sh

2020-09-04 Thread GitBox
gus-asf merged pull request #1715: URL: https://github.com/apache/lucene-solr/pull/1715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14704) Add download option to solr/cloud-dev/cloud.sh

2020-09-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190718#comment-17190718 ] ASF subversion and git services commented on SOLR-14704: Commit 6

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Markus Kalkbrenner (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190720#comment-17190720 ] Markus Kalkbrenner commented on SOLR-13973: --- {quote}So that'd be SOLR-7632 as [

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190728#comment-17190728 ] Alexandre Rafalovitch commented on SOLR-13973: -- Sanity check on the links an

[jira] [Commented] (SOLR-7632) Change the ExtractingRequestHandler to use Tika-Server

2020-09-04 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190730#comment-17190730 ] Alexandre Rafalovitch commented on SOLR-7632: - Actually, does this have to be

[jira] [Commented] (SOLR-7632) Change the ExtractingRequestHandler to use Tika-Server

2020-09-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190745#comment-17190745 ] Erick Erickson commented on SOLR-7632: -- The critical bit is moving it out of the Solr

[jira] [Commented] (SOLR-7632) Change the ExtractingRequestHandler to use Tika-Server

2020-09-04 Thread Alexandre Rafalovitch (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190751#comment-17190751 ] Alexandre Rafalovitch commented on SOLR-7632: - I agree on the critical path. I

[jira] [Created] (SOLR-14831) remove deprecated-and-unused "facet.distrib.mco" constant

2020-09-04 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-14831: -- Summary: remove deprecated-and-unused "facet.distrib.mco" constant Key: SOLR-14831 URL: https://issues.apache.org/jira/browse/SOLR-14831 Project: Solr

[GitHub] [lucene-solr] cpoerschke opened a new pull request #1832: SOLR-14831: remove deprecated-and-unused "facet.distrib.mco" constant

2020-09-04 Thread GitBox
cpoerschke opened a new pull request #1832: URL: https://github.com/apache/lucene-solr/pull/1832 https://issues.apache.org/jira/browse/SOLR-14831 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [lucene-solr] madrob merged pull request #1731: LUCENE-9451 Sort.rewrite does not always return this when unchanged

2020-09-04 Thread GitBox
madrob merged pull request #1731: URL: https://github.com/apache/lucene-solr/pull/1731 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (LUCENE-9451) Sort.rewrite doesn't always return this when unchanged

2020-09-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-9451. --- Fix Version/s: master (9.0) Resolution: Fixed > Sort.rewrite doesn't always return this when

[jira] [Commented] (LUCENE-9451) Sort.rewrite doesn't always return this when unchanged

2020-09-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190755#comment-17190755 ] ASF subversion and git services commented on LUCENE-9451: - Commi

[jira] [Commented] (SOLR-13973) Deprecate Tika

2020-09-04 Thread Markus Kalkbrenner (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190758#comment-17190758 ] Markus Kalkbrenner commented on SOLR-13973: --- I just wanted to emphasize Solr's

[GitHub] [lucene-solr] HoustonPutman commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-04 Thread GitBox
HoustonPutman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-687193971 I completely agree with David and Andrzej on all points. No one is going through the comments with a fine tooth comb, it is blatantly disrespectful. And doubling down

[GitHub] [lucene-solr] madrob commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
madrob commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483663516 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene-solr] cpoerschke commented on pull request #1823: SOLR-14510: Remove deprecations added with BMW support

2020-09-04 Thread GitBox
cpoerschke commented on pull request #1823: URL: https://github.com/apache/lucene-solr/pull/1823#issuecomment-687200873 > Remove deprecations added with BMW support > ... It would be useful to add this deprecation information ... +1 to make it a clearer what is being deprecate

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1743: Gradual naming convention enforcement.

2020-09-04 Thread GitBox
cpoerschke commented on a change in pull request #1743: URL: https://github.com/apache/lucene-solr/pull/1743#discussion_r483679806 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java ## @@ -613,6 +613,7 @@ public static TestRuleIgnoreAfterMa

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1743: Gradual naming convention enforcement.

2020-09-04 Thread GitBox
dweiss commented on a change in pull request #1743: URL: https://github.com/apache/lucene-solr/pull/1743#discussion_r483684317 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java ## @@ -613,6 +613,7 @@ public static TestRuleIgnoreAfterMaxFai

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1743: Gradual naming convention enforcement.

2020-09-04 Thread GitBox
dweiss commented on a change in pull request #1743: URL: https://github.com/apache/lucene-solr/pull/1743#discussion_r483684981 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/VerifyTestClassNamingConvention.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the A

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
dweiss commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483689014 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene-solr] erikhatcher commented on pull request #1827: SOLR-14792: Remove VelocityResponseWriter

2020-09-04 Thread GitBox
erikhatcher commented on pull request #1827: URL: https://github.com/apache/lucene-solr/pull/1827#issuecomment-687232685 > @erikhatcher BTW, the .adoc format renders nicely in Github if you were to pull the ref guide docs over to https://github.com/erikhatcher/solritas. We could also updat

[jira] [Commented] (SOLR-7632) Change the ExtractingRequestHandler to use Tika-Server

2020-09-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190787#comment-17190787 ] David Smiley commented on SOLR-7632: I don't think an URP makes sense for this because

[jira] [Updated] (SOLR-14439) Upgrade to Tika 1.24.1

2020-09-04 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14439: -- Attachment: SOLR-14339.patch > Upgrade to Tika 1.24.1 > -- > >

[GitHub] [lucene-solr] vthacker commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
vthacker commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483717480 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene-solr] vthacker commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
vthacker commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483719049 ## File path: lucene/core/src/java/org/apache/lucene/analysis/CharArrayMap.java ## @@ -523,6 +523,7 @@ public void clear() { * @throws NullPointe

[GitHub] [lucene-solr] dsmiley commented on pull request #1827: SOLR-14792: Remove VelocityResponseWriter

2020-09-04 Thread GitBox
dsmiley commented on pull request #1827: URL: https://github.com/apache/lucene-solr/pull/1827#issuecomment-687245022 BTW the more up do date https://github.com/erikhatcher/solritas is in the next few days, the better as I'll be doing a recorded Activate session on this September 10th with

[GitHub] [lucene-solr] vthacker commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
vthacker commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483720288 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Commented] (LUCENE-9497) Integerate Error Prone ( Static Analysis Tool ) during compilation

2020-09-04 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190810#comment-17190810 ] Varun Thacker commented on LUCENE-9497: --- > error prone uses regular SuppressWarnin

[jira] [Commented] (SOLR-14829) Default components are missing facet_module and terms in documentation

2020-09-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190814#comment-17190814 ] David Smiley commented on SOLR-14829: - In your own/custom definition of your request

[GitHub] [lucene-solr] madrob commented on a change in pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-04 Thread GitBox
madrob commented on a change in pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r483773660 ## File path: gradle/validation/validate-source-patterns.gradle ## @@ -29,50 +33,117 @@ buildscript { } } -configure(rootProject) { - task("vali

[jira] [Commented] (SOLR-14579) Comment SolrJ 'Utils' generic map functions

2020-09-04 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190872#comment-17190872 ] Uwe Schindler commented on SOLR-14579: -- bq. I have no recollection of doing so, cert

[GitHub] [lucene-solr] uschindler commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-04 Thread GitBox
uschindler commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-687317814 I will check over the weekend. Was too busy today! This is an automated message from the Apache Git Servi

[GitHub] [lucene-solr] vthacker edited a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-04 Thread GitBox
vthacker edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-687318445 > The fact is, all of has the same objective: to make the product better. > he purpose is to ensure that the feature/change is >correct >perfo

[GitHub] [lucene-solr] vthacker commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-04 Thread GitBox
vthacker commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-687318445 > The fact is, all of has the same objective: to make the product better. > he purpose is to ensure that the feature/change is >correct >performant/e

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
dweiss commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483793090 ## File path: lucene/core/src/java/org/apache/lucene/analysis/CharArrayMap.java ## @@ -523,6 +523,7 @@ public void clear() { * @throws NullPointerE

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
dweiss commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483793353 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene-solr] dweiss commented on pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-04 Thread GitBox
dweiss commented on pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#issuecomment-687320373 No worries. Not very urgent. This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1830: LUCENE-9506: Gradle: split validateSourcePatterns into per-project an…

2020-09-04 Thread GitBox
dweiss commented on a change in pull request #1830: URL: https://github.com/apache/lucene-solr/pull/1830#discussion_r483793729 ## File path: gradle/validation/validate-source-patterns.gradle ## @@ -29,50 +33,117 @@ buildscript { } } -configure(rootProject) { - task("vali

[GitHub] [lucene-solr] vthacker commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
vthacker commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483794345 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene-solr] chatman commented on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-04 Thread GitBox
chatman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-687329334 I withdraw all outstanding concerns. Verbosity, clunkiness of configuration etc are all my "perceptions" that I don't want to come in the way of the completion of this e

[GitHub] [lucene-solr] chatman edited a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-04 Thread GitBox
chatman edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686355702 > @noblepaul & @chatman I find the tone of your latest comments offensive - that's no way to build a consensus. Please think twice before posting and calm down - if y

[GitHub] [lucene-solr] chatman edited a comment on pull request #1684: SOLR-14613: strongly typed placement plugin interface and implementation

2020-09-04 Thread GitBox
chatman edited a comment on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-687329334 I withdraw all outstanding concerns. Verbosity, clunkiness/ineffectiveness/misplacement of configuration etc are all my "perceptions" that I don't want to come in t

[jira] [Created] (SOLR-14832) Inversion Eglish and numbers characters in Arabic documents

2020-09-04 Thread Vlad (Jira)
Vlad created SOLR-14832: --- Summary: Inversion Eglish and numbers characters in Arabic documents Key: SOLR-14832 URL: https://issues.apache.org/jira/browse/SOLR-14832 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-14832) Inversion Eglish and numbers characters in Arabic documents

2020-09-04 Thread Vlad (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vlad updated SOLR-14832: Description: Hi Support,   please help to resolve an issue. I upload/index several documents in English and in A

[GitHub] [lucene-solr] jtibshirani opened a new pull request #1833: LUCENE-9501: Fix invariant violation in IndexSortSortedNumericDocValuesRangeQuery.

2020-09-04 Thread GitBox
jtibshirani opened a new pull request #1833: URL: https://github.com/apache/lucene-solr/pull/1833 Previously the DocIdSetIterator returned an old value for docID even after advance returned NO_MORE_DOCS. This violates the DocIdSetIterator contract and made it possible for the iterator

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #1833: LUCENE-9501: Fix invariant violation in IndexSortSortedNumericDocValuesRangeQuery.

2020-09-04 Thread GitBox
jtibshirani commented on a change in pull request #1833: URL: https://github.com/apache/lucene-solr/pull/1833#discussion_r483868710 ## File path: lucene/sandbox/src/test/org/apache/lucene/search/TestIndexSortSortedNumericDocValuesRangeQuery.java ## @@ -65,7 +65,7 @@ public voi

[GitHub] [lucene-solr] jtibshirani opened a new pull request #1834: Make sure to test normal scorers with asserting wrappers.

2020-09-04 Thread GitBox
jtibshirani opened a new pull request #1834: URL: https://github.com/apache/lucene-solr/pull/1834 When a query is run at the top-level, the searcher uses `Weight#bulkScorer`. Many queries don't implement this explicitly and instead rely on the default implementation which delegates to

[jira] [Created] (LUCENE-9508) DocumentsWriter doesn't check for BlockedFlushes in stall mode``

2020-09-04 Thread Sorabh Hamirwasia (Jira)
Sorabh Hamirwasia created LUCENE-9508: - Summary: DocumentsWriter doesn't check for BlockedFlushes in stall mode`` Key: LUCENE-9508 URL: https://issues.apache.org/jira/browse/LUCENE-9508 Project: L

[jira] [Commented] (LUCENE-9501) IndexSortSortedNumericDocValuesRangeQuery violates iterator invariant.

2020-09-04 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190949#comment-17190949 ] Julie Tibshirani commented on LUCENE-9501: -- The fix to the query itself: https:

[jira] [Created] (SOLR-14833) Empty highlight entry on match only for some queries

2020-09-04 Thread Hossameldin Khalifa (Jira)
Hossameldin Khalifa created SOLR-14833: -- Summary: Empty highlight entry on match only for some queries Key: SOLR-14833 URL: https://issues.apache.org/jira/browse/SOLR-14833 Project: Solr

[jira] [Updated] (SOLR-14833) Empty highlight entry on match only for some queries

2020-09-04 Thread Hossameldin Khalifa (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hossameldin Khalifa updated SOLR-14833: --- Attachment: Screen Shot 1442-01-17 at 3.56.16 AM.png Screen Shot 1442-

[jira] [Resolved] (SOLR-14832) Inversion Eglish and numbers characters in Arabic documents

2020-09-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14832. --- Resolution: Invalid Please raise questions like this on the user's list, we try to reserve JI

[jira] [Commented] (SOLR-14833) Empty highlight entry on match only for some queries

2020-09-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190976#comment-17190976 ] David Smiley commented on SOLR-14833: - Can you try {{hl.method=unified}}? Another de

[jira] [Commented] (LUCENE-9498) Move matchhighlighter to a separate subproject

2020-09-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190979#comment-17190979 ] David Smiley commented on LUCENE-9498: -- I think it would be weird to separate one h

[jira] [Commented] (LUCENE-9461) Query hit highlighting components on top of matches API

2020-09-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190981#comment-17190981 ] David Smiley commented on LUCENE-9461: -- Maybe not as a sub-task, but would it make

  1   2   >