[jira] [Commented] (LUCENE-9563) Add .editorConfig

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208532#comment-17208532 ] Dawid Weiss commented on LUCENE-9563: - I really don't know about where to put it - I

[jira] [Created] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9564: --- Summary: Format code automatically and enforce it Key: LUCENE-9564 URL: https://issues.apache.org/jira/browse/LUCENE-9564 Project: Lucene - Core Issue Type: Ta

[GitHub] [lucene-solr] dweiss opened a new pull request #1950: LUCENE-9564: add spotless and gjf.

2020-10-06 Thread GitBox
dweiss opened a new pull request #1950: URL: https://github.com/apache/lucene-solr/pull/1950 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9564: Description: This is a trivial change but a bold move. And I'm sure it's not for everyone. I star

[jira] [Commented] (LUCENE-9493) Remove obsolete dev-tools/{idea,netbeans,maven} folders

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208555#comment-17208555 ] Dawid Weiss commented on LUCENE-9493: - > It'd be interesting if the gradle build cou

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-06 Thread GitBox
uschindler commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r500087063 ## File path: solr/packaging/build.gradle ## @@ -62,12 +63,17 @@ dependencies { example project(path: ":solr:example", configuration: "packagi

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-06 Thread GitBox
uschindler commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r500088372 ## File path: solr/packaging/build.gradle ## @@ -62,12 +63,17 @@ dependencies { example project(path: ":solr:example", configuration: "packagi

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208556#comment-17208556 ] Dawid Weiss commented on SOLR-14870: > The main thing that bogged me down is that the

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-06 Thread GitBox
dweiss commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r500092191 ## File path: solr/packaging/build.gradle ## @@ -62,12 +63,17 @@ dependencies { example project(path: ":solr:example", configuration: "packaging")

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-06 Thread GitBox
uschindler commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r500096124 ## File path: solr/packaging/build.gradle ## @@ -62,12 +63,17 @@ dependencies { example project(path: ":solr:example", configuration: "packagi

[GitHub] [lucene-solr] sigram opened a new pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-06 Thread GitBox
sigram opened a new pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951 This replaces nearly all Map / List usage in `MetricUtils` with `MapWriter` / `IteratorWriter`. The PR includes also changes to `Utils.MapWriterJSONWriter` to similarly avoid creating Map / List in

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-06 Thread GitBox
dweiss commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r500100437 ## File path: solr/packaging/build.gradle ## @@ -62,12 +63,17 @@ dependencies { example project(path: ":solr:example", configuration: "packaging")

[jira] [Commented] (SOLR-14691) Metrics reporting should avoid creating objects

2020-10-06 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208572#comment-17208572 ] Andrzej Bialecki commented on SOLR-14691: - PR 1951 replaces all use of Map / List

[jira] [Commented] (LUCENE-9542) Score returned in search request is original score and not reranked score

2020-10-06 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208576#comment-17208576 ] Christine Poerschke commented on LUCENE-9542: - Thanks [~krishan1390] for ope

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1905: LUCENE-9488 Release with Gradle Part 2

2020-10-06 Thread GitBox
dweiss commented on a change in pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#discussion_r500092191 ## File path: solr/packaging/build.gradle ## @@ -62,12 +63,17 @@ dependencies { example project(path: ":solr:example", configuration: "packaging")

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208615#comment-17208615 ] Michael McCandless commented on LUCENE-9564: +1 to achieve more consistent c

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208625#comment-17208625 ] Dawid Weiss commented on LUCENE-9564: - The check itself could run in precommit. A "c

[jira] [Updated] (SOLR-14914) Add option to disable metrics collection

2020-10-06 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14914: Fix Version/s: (was: master (9.0)) > Add option to disable metrics collection > ---

[jira] [Created] (SOLR-14914) Add option to disable metrics collection

2020-10-06 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-14914: --- Summary: Add option to disable metrics collection Key: SOLR-14914 URL: https://issues.apache.org/jira/browse/SOLR-14914 Project: Solr Issue Type: Impro

[jira] [Updated] (SOLR-14914) Add option to disable metrics collection

2020-10-06 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14914: Fix Version/s: master (9.0) > Add option to disable metrics collection > --

[jira] [Updated] (SOLR-14914) Add option to disable metrics collection

2020-10-06 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14914: Fix Version/s: 8.7 > Add option to disable metrics collection > ---

[jira] [Updated] (SOLR-14914) Add option to disable metrics collection

2020-10-06 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-14914: Description: Some users have expressed concerns about the overhead of metrics collection,

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208663#comment-17208663 ] Andrzej Bialecki commented on LUCENE-9564: -- +1 to consistent and enforced forma

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-06 Thread GitBox
noblepaul commented on a change in pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#discussion_r500206089 ## File path: solr/core/src/java/org/apache/solr/util/stats/MetricUtils.java ## @@ -385,10 +406,10 @@ static double nsToMs(boolean convert, double v

[GitHub] [lucene-solr] noblepaul commented on pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-06 Thread GitBox
noblepaul commented on pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704215473 Can we get rid of the interface `PropertyFilter` and replace it with a `Predicate`? You can use the class `ConditionalKeyMapWriter` to filter `MetricUtils.add

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208679#comment-17208679 ] Erick Erickson commented on LUCENE-9564: +1 I can adapt to most any style more e

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-06 Thread GitBox
noblepaul commented on a change in pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#discussion_r500216190 ## File path: solr/core/src/test/org/apache/solr/handler/admin/MetricsHandlerTest.java ## @@ -308,19 +318,24 @@ public void testKeyMetrics() throws

[GitHub] [lucene-solr] mayya-sharipova edited a comment on pull request #1943: LUCENE-9555 Advance conjuction Iterator for two phase iteration

2020-10-06 Thread GitBox
mayya-sharipova edited a comment on pull request #1943: URL: https://github.com/apache/lucene-solr/pull/1943#issuecomment-703885914 @jpountz Sorry for the noise, I have found the cause of this error, and the latest commit addresses it. Basically this PR will just address the failing test

[GitHub] [lucene-solr] mayya-sharipova edited a comment on pull request #1943: LUCENE-9555 Advance conjuction Iterator for two phase iteration

2020-10-06 Thread GitBox
mayya-sharipova edited a comment on pull request #1943: URL: https://github.com/apache/lucene-solr/pull/1943#issuecomment-703885914 @jpountz Sorry for the noise, I have found the cause of this error, and the latest commit addresses it. Basically this PR will just address the failing test

[GitHub] [lucene-solr] mayya-sharipova edited a comment on pull request #1943: LUCENE-9555 Advance conjuction Iterator for two phase iteration

2020-10-06 Thread GitBox
mayya-sharipova edited a comment on pull request #1943: URL: https://github.com/apache/lucene-solr/pull/1943#issuecomment-703885914 @jpountz Sorry for the noise, I have found the cause of this error, and the latest commit addresses it. Basically this PR will just address the failing test

[GitHub] [lucene-solr] mayya-sharipova edited a comment on pull request #1943: LUCENE-9555 Advance conjuction Iterator for two phase iteration

2020-10-06 Thread GitBox
mayya-sharipova edited a comment on pull request #1943: URL: https://github.com/apache/lucene-solr/pull/1943#issuecomment-703885914 @jpountz Sorry for the noise, I have found the cause of this error, and the latest commit addresses it. Basically this PR will just address the failing test

[GitHub] [lucene-solr] noblepaul commented on pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-06 Thread GitBox
noblepaul commented on pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704237134 Is it possible to change `MetricsMap implements Gauge>` to ` MetricsMap implements Gauge` Th

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208702#comment-17208702 ] Dawid Weiss commented on LUCENE-9564: - > I'd recommend it be as close to the current

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208720#comment-17208720 ] Dawid Weiss commented on LUCENE-9564: - Google's style guide: https://google.github.i

[jira] [Updated] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9564: Description: This is a trivial change but a bold move. And I'm sure it's not for everyone. I star

[jira] [Updated] (LUCENE-9555) Advance conjunction Iterator for two phase iteration

2020-10-06 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9555: Summary: Advance conjunction Iterator for two phase iteration (was: Sort optimization fai

[jira] [Updated] (LUCENE-9555) Advance conjunction Iterator for two phase iteration

2020-10-06 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-9555: Description: LUCENE-9280 introduced a sort optimization where documents can be skipped. Bu

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208739#comment-17208739 ] Erick Erickson commented on LUCENE-9564: Ah, so you're saying that the bits I po

[jira] [Commented] (LUCENE-9555) Advance conjunction Iterator for two phase iteration

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208741#comment-17208741 ] ASF subversion and git services commented on LUCENE-9555: - Commi

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208763#comment-17208763 ] Dawid Weiss commented on LUCENE-9564: - Ideally, they should be wrapped in code block

[jira] [Commented] (LUCENE-9555) Advance conjunction Iterator for two phase iteration

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208752#comment-17208752 ] ASF subversion and git services commented on LUCENE-9555: - Commi

[jira] [Created] (LUCENE-9565) Fix iteration over competitive iterators

2020-10-06 Thread Mayya Sharipova (Jira)
Mayya Sharipova created LUCENE-9565: --- Summary: Fix iteration over competitive iterators Key: LUCENE-9565 URL: https://issues.apache.org/jira/browse/LUCENE-9565 Project: Lucene - Core Issue

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
mayya-sharipova opened a new pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952 PR #1351 introduced a sort optimization where documents can be skipped. But iteration over competitive iterators was not properly organized, as they were not storing the current docID,

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
mayya-sharipova commented on pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#issuecomment-704311136 This patch works well with checks in [ConjunctionDISI](https://github.com/apache/lucene-solr/pull/1937), and all tests pass as well. After we merge this PR,

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
jpountz commented on a change in pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#discussion_r500372658 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -204,9 +204,14 @@ public int score(LeafCollector collector, Bits acceptD

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208840#comment-17208840 ] Varun Thacker commented on LUCENE-9564: --- +1 to consistent and enforced formatting.

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208845#comment-17208845 ] Dawid Weiss commented on LUCENE-9564: - Yes, you're correct. I don't know if there is

[jira] [Updated] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9564: Description: This is a trivial change but a bold move. And I'm sure it's not for everyone. I star

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208856#comment-17208856 ] Dawid Weiss commented on SOLR-14870: I took a peek. Is there any particular reason wh

[GitHub] [lucene-solr] mayya-sharipova merged pull request #1943: LUCENE-9555: Advance conjuction Iterator for two phase iteration

2020-10-06 Thread GitBox
mayya-sharipova merged pull request #1943: URL: https://github.com/apache/lucene-solr/pull/1943 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Commented] (SOLR-14066) Deprecate DIH and migrate to a community supported package

2020-10-06 Thread Rui Pimentel (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208861#comment-17208861 ] Rui Pimentel commented on SOLR-14066: - Hi Erich Siffert, Did you try with Oracle >

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
mayya-sharipova commented on a change in pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#discussion_r500412063 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -204,9 +204,14 @@ public int score(LeafCollector collector, Bits

[jira] [Commented] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208864#comment-17208864 ] Dawid Weiss commented on SOLR-14870: Perhaps I should clarify that if the intention w

[jira] [Comment Edited] (SOLR-14870) gradle build does not validate ref-guide -> javadoc links

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208864#comment-17208864 ] Dawid Weiss edited comment on SOLR-14870 at 10/6/20, 3:56 PM: -

[jira] [Comment Edited] (SOLR-14066) Deprecate DIH and migrate to a community supported package

2020-10-06 Thread Rui Pimentel (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208861#comment-17208861 ] Rui Pimentel edited comment on SOLR-14066 at 10/6/20, 4:03 PM:

[jira] [Comment Edited] (SOLR-14066) Deprecate DIH and migrate to a community supported package

2020-10-06 Thread Rui Pimentel (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208861#comment-17208861 ] Rui Pimentel edited comment on SOLR-14066 at 10/6/20, 4:03 PM:

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
jpountz commented on a change in pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#discussion_r500453140 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -204,9 +204,14 @@ public int score(LeafCollector collector, Bits acceptD

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
mayya-sharipova commented on a change in pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#discussion_r500461526 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -204,9 +204,14 @@ public int score(LeafCollector collector, Bits

[GitHub] [lucene-solr] mayya-sharipova merged pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
mayya-sharipova merged pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Commented] (LUCENE-9565) Fix iteration over competitive iterators

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208971#comment-17208971 ] ASF subversion and git services commented on LUCENE-9565: - Commi

[jira] [Commented] (LUCENE-9541) Ensure sub-iterators of ConjunctionDISI are on the same document

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208974#comment-17208974 ] ASF subversion and git services commented on LUCENE-9541: - Commi

[jira] [Commented] (LUCENE-9541) Ensure sub-iterators of ConjunctionDISI are on the same document

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208973#comment-17208973 ] ASF subversion and git services commented on LUCENE-9541: - Commi

[jira] [Commented] (LUCENE-9565) Fix iteration over competitive iterators

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208979#comment-17208979 ] ASF subversion and git services commented on LUCENE-9565: - Commi

[jira] [Commented] (LUCENE-9541) Ensure sub-iterators of ConjunctionDISI are on the same document

2020-10-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208980#comment-17208980 ] ASF subversion and git services commented on LUCENE-9541: - Commi

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209000#comment-17209000 ] Robert Muir commented on LUCENE-9564: - https://github.com/psf/black#migrating-your-c

[GitHub] [lucene-solr] sigram commented on pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-06 Thread GitBox
sigram commented on pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704446815 > Can we get rid of the interface PropertyFilter and replace it with a Predicate? Again, we're limited by back-compat in 8x. We could add another set of methods in `Metric

[GitHub] [lucene-solr] sigram edited a comment on pull request #1951: SOLR-14691: Reduce object creation by using MapWriter / IteratorWriter.

2020-10-06 Thread GitBox
sigram edited a comment on pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704446815 > Can we get rid of the interface PropertyFilter and replace it with a Predicate? Again, we're limited by back-compat in 8x. We could add another set of methods

[jira] [Created] (SOLR-14915) Prometheus-exporter should not depend on Solr-core

2020-10-06 Thread David Smiley (Jira)
David Smiley created SOLR-14915: --- Summary: Prometheus-exporter should not depend on Solr-core Key: SOLR-14915 URL: https://issues.apache.org/jira/browse/SOLR-14915 Project: Solr Issue Type: Imp

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209025#comment-17209025 ] Dawid Weiss commented on LUCENE-9564: - Bull's eye! Thanks Robert. Interesting tool t

[jira] [Commented] (SOLR-13392) Unable to start prometheus-exporter in 7x branch

2020-10-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209031#comment-17209031 ] David Smiley commented on SOLR-13392: - bq. Do we have a test that tries to launch the

[jira] [Created] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-14916: - Summary: Add split parameter to timeseries Streaming Expression Key: SOLR-14916 URL: https://issues.apache.org/jira/browse/SOLR-14916 Project: Solr Issue T

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Commented] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209046#comment-17209046 ] Joel Bernstein commented on SOLR-14916: --- [~aroopganguly], how does this design look

[jira] [Created] (SOLR-14917) Move DOMUtil and PropertiesUtil to SolrJ, o.a.s.common/util

2020-10-06 Thread David Smiley (Jira)
David Smiley created SOLR-14917: --- Summary: Move DOMUtil and PropertiesUtil to SolrJ, o.a.s.common/util Key: SOLR-14917 URL: https://issues.apache.org/jira/browse/SOLR-14917 Project: Solr Issue

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Commented] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Aroop (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209051#comment-17209051 ] Aroop commented on SOLR-14916: -- [~jbernste] this looks very neat! > Add split parameter to

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Created] (LUCENE-9566) TestApproximationSearchEquivalence.testExclusion fails

2020-10-06 Thread Mayya Sharipova (Jira)
Mayya Sharipova created LUCENE-9566: --- Summary: TestApproximationSearchEquivalence.testExclusion fails Key: LUCENE-9566 URL: https://issues.apache.org/jira/browse/LUCENE-9566 Project: Lucene - Core

[jira] [Updated] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14916: -- Description: Currently the time series function only supports aggregations across the time dim

[jira] [Commented] (LUCENE-9540) Investigate double indexing of the fullPathField in the DirectoryTaxonomyWriter

2020-10-06 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209076#comment-17209076 ] Michael McCandless commented on LUCENE-9540: Phew, thanks for bringing closu

[GitHub] [lucene-solr] dsmiley opened a new pull request #1953: SOLR-14917: Move DOMUtil and PropertiesUtil to SolrJ

2020-10-06 Thread GitBox
dsmiley opened a new pull request #1953: URL: https://github.com/apache/lucene-solr/pull/1953 https://issues.apache.org/jira/browse/SOLR-14917 Not worth a CHANGES.txt. On 8x, will keep the classes marked with Deprecated annotation and as subclasses so there's no code to maintain

[jira] [Commented] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Aroop (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209108#comment-17209108 ] Aroop commented on SOLR-14916: -- [~jbernste] what possible values of "gap" will we support an

[GitHub] [lucene-solr] kwatters closed pull request #1810: SOLR-14787 - supporting an operator for the payload check query parser to support greater than / less than payload check queries.

2020-10-06 Thread GitBox
kwatters closed pull request #1810: URL: https://github.com/apache/lucene-solr/pull/1810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Commented] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209128#comment-17209128 ] Joel Bernstein commented on SOLR-14916: --- The gap parameter maps to the JSON facet r

[jira] [Comment Edited] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209128#comment-17209128 ] Joel Bernstein edited comment on SOLR-14916 at 10/6/20, 8:18 PM: --

[jira] [Commented] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209133#comment-17209133 ] Joel Bernstein commented on SOLR-14916: --- This covers some of gap information: http

[jira] [Comment Edited] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209133#comment-17209133 ] Joel Bernstein edited comment on SOLR-14916 at 10/6/20, 8:21 PM: --

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1952: LUCENE-9565 Fix competitive iteration

2020-10-06 Thread GitBox
jpountz commented on a change in pull request #1952: URL: https://github.com/apache/lucene-solr/pull/1952#discussion_r500574341 ## File path: lucene/core/src/java/org/apache/lucene/search/Weight.java ## @@ -266,4 +274,45 @@ static void scoreAll(LeafCollector collector, DocIdSe

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-10-06 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209146#comment-17209146 ] Adrien Grand commented on LUCENE-9564: -- There are downsides to code formatting (I'l

[jira] [Commented] (SOLR-14916) Add split parameter to timeseries Streaming Expression

2020-10-06 Thread Aroop (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209147#comment-17209147 ] Aroop commented on SOLR-14916: -- Thanks Joel > Add split parameter to timeseries Streaming E

  1   2   >