sigram commented on pull request #1951: URL: https://github.com/apache/lucene-solr/pull/1951#issuecomment-704446815
> Can we get rid of the interface PropertyFilter and replace it with a Predicate<String>? Again, we're limited by back-compat in 8x. We could add another set of methods in `MetricUtils` that use `Predicate<String>` and deprecate `PropertyFilter` ... but that would double the number of methods. > MetricUtils.addMetrics() Not sure what you're referring to - this method doesn't create a NamedList. It's used only in `OverseerStatusCmd`, which creates a NamedList anyway for other stuff. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
