[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214449#comment-17214449 ] Robert Muir commented on LUCENE-9576: - 2nd patch has only javadocs/CHANGES.txt modifications. If we

[jira] [Updated] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9576: Attachment: LUCENE-9576.patch > IndexWriter::commit() hangs when the server has a stale NFS

[jira] [Comment Edited] (SOLR-14915) Prometheus-exporter should not depend on Solr-core

2020-10-14 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214446#comment-17214446 ] Ishan Chattopadhyaya edited comment on SOLR-14915 at 10/15/20, 5:40 AM:

[jira] [Commented] (SOLR-14915) Prometheus-exporter should not depend on Solr-core

2020-10-14 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214446#comment-17214446 ] Ishan Chattopadhyaya commented on SOLR-14915: - bq. I personally think there should be no

[jira] [Commented] (SOLR-14647) Importing Gradle Projects into Eclipse pollutes checkout

2020-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214445#comment-17214445 ] Robert Muir commented on SOLR-14647: I experience the issue as well. And I use only {{gradle

[jira] [Reopened] (SOLR-14907) Support single file upload/overwrite in configSet API

2020-10-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reopened SOLR-14907: --- Suggestion for making this V2 friendly > Support single file upload/overwrite in configSet API >

[jira] [Comment Edited] (SOLR-14907) Support single file upload/overwrite in configSet API

2020-10-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214427#comment-17214427 ] Noble Paul edited comment on SOLR-14907 at 10/15/20, 4:34 AM: -- Can we move

[jira] [Commented] (SOLR-14907) Support single file upload/overwrite in configSet API

2020-10-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214427#comment-17214427 ] Noble Paul commented on SOLR-14907: --- Can we move this to a V2 API (and possibly V2 API only) ? I would

[jira] [Commented] (SOLR-14647) Importing Gradle Projects into Eclipse pollutes checkout

2020-10-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214418#comment-17214418 ] David Smiley commented on SOLR-14647: - "bin/default" -- weird. I don't want our .gitignore ignoring

[jira] [Commented] (LUCENE-9455) ExitableTermsEnum (in ExitableDirectoryReader) should sample next()

2020-10-14 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214417#comment-17214417 ] Zach Chen commented on LUCENE-9455: --- This seems to be a good starter task for newbie. Can I pick this

[jira] [Commented] (SOLR-14935) Solr can forward request ( remoteQuery ) even if there are local cores present

2020-10-14 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214406#comment-17214406 ] Varun Thacker commented on SOLR-14935: -- https://issues.apache.org/jira/browse/SOLR-14630 - Is a very

[jira] [Created] (SOLR-14935) Solr can forward request ( remoteQuery ) even if there are local cores present

2020-10-14 Thread Varun Thacker (Jira)
Varun Thacker created SOLR-14935: Summary: Solr can forward request ( remoteQuery ) even if there are local cores present Key: SOLR-14935 URL: https://issues.apache.org/jira/browse/SOLR-14935

[jira] [Commented] (SOLR-14915) Prometheus-exporter should not depend on Solr-core

2020-10-14 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214401#comment-17214401 ] David Smiley commented on SOLR-14915: - That works for me too! Though I wonder if that adds to the

[jira] [Comment Edited] (SOLR-14575) Solr restore is failing when basic authentication is enabled

2020-10-14 Thread Yaswanth (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214388#comment-17214388 ] Yaswanth edited comment on SOLR-14575 at 10/15/20, 3:22 AM: here is my

[jira] [Commented] (SOLR-14575) Solr restore is failing when basic authentication is enabled

2020-10-14 Thread Yaswanth (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214388#comment-17214388 ] Yaswanth commented on SOLR-14575: - here is my jetty-ssl.xml

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #1357: SOLR-13807: Introduce a cache for term facet counts

2020-10-14 Thread GitBox
muse-dev[bot] commented on a change in pull request #1357: URL: https://github.com/apache/lucene-solr/pull/1357#discussion_r505131797 ## File path: solr/core/src/java/org/apache/solr/search/facet/SlotAcc.java ## @@ -733,7 +833,7 @@ public ReadOnlyCountSlotAcc add(String key,

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #1978: LUCENE-9524: Fix NPE in SpanWeight#explain when no scoring is require…

2020-10-14 Thread GitBox
zacharymorn commented on a change in pull request #1978: URL: https://github.com/apache/lucene-solr/pull/1978#discussion_r505127766 ## File path: lucene/memory/src/test/org/apache/lucene/index/memory/TestMemoryIndex.java ## @@ -618,4 +622,21 @@ public void testToStringDebug()

[GitHub] [lucene-solr] noblepaul commented on pull request #1964: SOLR-14749: Cluster singleton part of PR-1785

2020-10-14 Thread GitBox
noblepaul commented on pull request #1964: URL: https://github.com/apache/lucene-solr/pull/1964#issuecomment-708855063 I've added a listener functionality to `CustomContainerPlugins` . let's remove that `handleClusterSingletons()` from that class

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #1978: LUCENE-9524: Fix NPE in SpanWeight#explain when no scoring is require…

2020-10-14 Thread GitBox
zacharymorn commented on a change in pull request #1978: URL: https://github.com/apache/lucene-solr/pull/1978#discussion_r505124529 ## File path: lucene/memory/src/test/org/apache/lucene/index/memory/TestMemoryIndex.java ## @@ -618,4 +622,21 @@ public void testToStringDebug()

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1964: SOLR-14749: Cluster singleton part of PR-1785

2020-10-14 Thread GitBox
noblepaul commented on a change in pull request #1964: URL: https://github.com/apache/lucene-solr/pull/1964#discussion_r505123486 ## File path: solr/core/src/java/org/apache/solr/handler/admin/ContainerPluginsApi.java ## @@ -51,7 +51,7 @@ public class ContainerPluginsApi {

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1964: SOLR-14749: Cluster singleton part of PR-1785

2020-10-14 Thread GitBox
noblepaul commented on a change in pull request #1964: URL: https://github.com/apache/lucene-solr/pull/1964#discussion_r505123274 ## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ## @@ -168,6 +172,33 @@ public CoreLoadFailure(CoreDescriptor cd,

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
gus-asf commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r505119975 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestTypeAsSynonymFilter.java ## @@ -0,0 +1,99 @@ +/* + *

[jira] [Commented] (SOLR-14575) Solr restore is failing when basic authentication is enabled

2020-10-14 Thread Yaswanth (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214365#comment-17214365 ] Yaswanth commented on SOLR-14575: - Thanks [~janhoy] for the reply, mean while I try 8.6 can you please

[GitHub] [lucene-solr] noblepaul opened a new pull request #1984: SOLR-14930: Deprecate rulebased replica placement strategy(in 8.x)

2020-10-14 Thread GitBox
noblepaul opened a new pull request #1984: URL: https://github.com/apache/lucene-solr/pull/1984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (SOLR-14930) Deprecate rulebased replica placement strategy

2020-10-14 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-14930: -- Description: This should be removed from 9.0 This will be replaced in Solr 9.0 by APIs for replica

[GitHub] [lucene-solr] JohnHillegass commented on pull request #1949: Jinja2_autoescape_false set to True

2020-10-14 Thread GitBox
JohnHillegass commented on pull request #1949: URL: https://github.com/apache/lucene-solr/pull/1949#issuecomment-708718694 Hey @madrob and @janhoy, the opportunity to exploit this probably very small. I picked it up in the ApacheCon Bug Bash/MuseDev hackathon as was submitting as a fix

[jira] [Commented] (SOLR-14934) Multiple Code Paths for determining "solr home" can return differnet answers

2020-10-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214335#comment-17214335 ] Chris M. Hostetter commented on SOLR-14934: --- The most prominent place I've seen

[jira] [Created] (SOLR-14934) Multiple Code Paths for determining "solr home" can return differnet answers

2020-10-14 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-14934: - Summary: Multiple Code Paths for determining "solr home" can return differnet answers Key: SOLR-14934 URL: https://issues.apache.org/jira/browse/SOLR-14934

[GitHub] [lucene-solr] uschindler commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
uschindler commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-708703297 I just recommend a small change in the test to use Set.of(), hwich is new in Java 11 (I think already in 9) for static sets.

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
uschindler commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r505042493 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestTypeAsSynonymFilter.java ## @@ -0,0 +1,99 @@ +/* + *

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
uschindler commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r505041733 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestTypeAsSynonymFilter.java ## @@ -0,0 +1,99 @@ +/* + *

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1976: LUCENE-9578: TermRangeQuery empty string lower bound edge case

2020-10-14 Thread GitBox
jpountz commented on a change in pull request #1976: URL: https://github.com/apache/lucene-solr/pull/1976#discussion_r505012026 ## File path: lucene/core/src/java/org/apache/lucene/util/automaton/Automata.java ## @@ -85,7 +85,15 @@ public static Automaton makeAnyBinary() {

[GitHub] [lucene-solr] gus-asf commented on pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
gus-asf commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-708688007 > I don't fully understand why this flags handling is needed in the tokenfilter, because i have not yet reviewed the new Solr feature. LUCENE-9575 (patch waiting for

[GitHub] [lucene-solr] jpountz commented on a change in pull request #1978: LUCENE-9524: Fix NPE in SpanWeight#explain when no scoring is require…

2020-10-14 Thread GitBox
jpountz commented on a change in pull request #1978: URL: https://github.com/apache/lucene-solr/pull/1978#discussion_r505009820 ## File path: lucene/memory/src/test/org/apache/lucene/index/memory/TestMemoryIndex.java ## @@ -618,4 +622,21 @@ public void testToStringDebug() {

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
gus-asf commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r504996141 ## File path: lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java ## @@ -125,7 +125,7 @@ public void

[GitHub] [lucene-solr] janhoy commented on pull request #1949: Jinja2_autoescape_false set to True

2020-10-14 Thread GitBox
janhoy commented on pull request #1949: URL: https://github.com/apache/lucene-solr/pull/1949#issuecomment-708664029 I wrote this script. It is a script being run from command line, and it generates a static HTML file for prettier output. Are you saying that if the developer opens this

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214283#comment-17214283 ] Robert Muir commented on LUCENE-9576: - I attached a patch with what i had in mind. The defaults are

[jira] [Resolved] (LUCENE-8851) Test issue for Adrien - ignore

2020-10-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-8851. -- Resolution: Not A Problem > Test issue for Adrien - ignore > -- >

[jira] [Updated] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9576: Attachment: LUCENE-9576.patch > IndexWriter::commit() hangs when the server has a stale NFS

[jira] [Resolved] (LUCENE-9234) Keep write support for old codecs?

2020-10-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9234. -- Resolution: Won't Fix > Keep write support for old codecs? >

[jira] [Comment Edited] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-10-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214273#comment-17214273 ] Timothy Potter edited comment on SOLR-12182 at 10/14/20, 8:47 PM: -- I

[jira] [Assigned] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-10-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter reassigned SOLR-12182: - Assignee: Timothy Potter > Can not switch urlScheme in 7x if there are any cores in the

[jira] [Updated] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-10-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-12182: -- Fix Version/s: master (9.0) > Can not switch urlScheme in 7x if there are any cores in the

[jira] [Commented] (SOLR-12182) Can not switch urlScheme in 7x if there are any cores in the cluster

2020-10-14 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214273#comment-17214273 ] Timothy Potter commented on SOLR-12182: --- I think with Solr 9, we shouldn't store the scheme in

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Chris Marzullo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214238#comment-17214238 ] Chris Marzullo commented on LUCENE-9576: {quote}The bad thing is: it can be caused by any mount,

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214234#comment-17214234 ] Uwe Schindler commented on LUCENE-9576: --- In addition, virtual disks by vmware or kvm often return

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214233#comment-17214233 ] Uwe Schindler commented on LUCENE-9576: --- The detection is also often wrong: on policeman jenkins

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214231#comment-17214231 ] Uwe Schindler commented on LUCENE-9576: --- We also had a question on Java-User about this today:

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214229#comment-17214229 ] Uwe Schindler commented on LUCENE-9576: --- I can confirm that any type of stale file mount causes

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-14 Thread GitBox
jtibshirani commented on a change in pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#discussion_r504927238 ## File path: lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java ## @@ -271,13 +273,26 @@ protected boolean lessThan(TermsEnumIndex a,

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214222#comment-17214222 ] Robert Muir commented on LUCENE-9576: - Also I'm willing to guess, simply wiring the default will

[jira] [Commented] (LUCENE-9576) IndexWriter::commit() hangs when the server has a stale NFS mount.

2020-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214219#comment-17214219 ] Robert Muir commented on LUCENE-9576: - I propose to remove this janky SSD detection logic, and

[GitHub] [lucene-solr] wojtek2kdev opened a new pull request #1983: [LUCENE-9410] German/French stemmers fail for common forms maux, gegrüßt, grüßend, schlummert

2020-10-14 Thread GitBox
wojtek2kdev opened a new pull request #1983: URL: https://github.com/apache/lucene-solr/pull/1983 https://issues.apache.org/jira/browse/LUCENE-9410 I don't know if it's just an acceptable exception or something serious? I wrote test cases for these words. Should them be mapped by

[jira] [Commented] (SOLR-10321) Unified highlighter returns empty fields when using glob

2020-10-14 Thread Mitchell Kotler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214207#comment-17214207 ] Mitchell Kotler commented on SOLR-10321: I just ran into this issue and it is not just a nuisance

[jira] [Commented] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2020-10-14 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214201#comment-17214201 ] Gus Heck commented on LUCENE-9574: -- Actually, I had expected when I started this, that 8.7 branch might

[GitHub] [lucene-solr] madrob commented on pull request #1949: Jinja2_autoescape_false set to True

2020-10-14 Thread GitBox
madrob commented on pull request #1949: URL: https://github.com/apache/lucene-solr/pull/1949#issuecomment-708600777 Thanks for bringing this to our attention, John! This is for preventing XSS if there is some nasty string in... a GitHub PR title? Trying to make sure I understand the

[jira] [Resolved] (LUCENE-9579) Update JUnit to latest 4.x release

2020-10-14 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved LUCENE-9579. --- Fix Version/s: 8.7 master (9.0) Resolution: Fixed > Update JUnit to

[GitHub] [lucene-solr] ctargett commented on a change in pull request #1870: SOLR-14865: 'Index Merge Metrics' documentation correction

2020-10-14 Thread GitBox
ctargett commented on a change in pull request #1870: URL: https://github.com/apache/lucene-solr/pull/1870#discussion_r504903798 ## File path: solr/solr-ref-guide/src/metrics-reporting.adoc ## @@ -534,15 +534,34 @@ These metrics are available only on a per-core basis. Metrics

[jira] [Commented] (LUCENE-9579) Update JUnit to latest 4.x release

2020-10-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214200#comment-17214200 ] ASF subversion and git services commented on LUCENE-9579: - Commit

[GitHub] [lucene-solr] madrob merged pull request #1982: LUCENE-9579 Update to JUnit 4.13.1

2020-10-14 Thread GitBox
madrob merged pull request #1982: URL: https://github.com/apache/lucene-solr/pull/1982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-14 Thread GitBox
jtibshirani commented on a change in pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#discussion_r504899193 ## File path: lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java ## @@ -271,13 +273,26 @@ protected boolean lessThan(TermsEnumIndex a,

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-14 Thread GitBox
jtibshirani commented on a change in pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#discussion_r504899193 ## File path: lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java ## @@ -271,13 +273,26 @@ protected boolean lessThan(TermsEnumIndex a,

[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-14 Thread GitBox
jtibshirani commented on a change in pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#discussion_r504888212 ## File path: lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java ## @@ -271,13 +273,26 @@ protected boolean lessThan(TermsEnumIndex a,

[GitHub] [lucene-solr] madrob opened a new pull request #1982: LUCENE-9579 Update to JUnit 4.13.1

2020-10-14 Thread GitBox
madrob opened a new pull request #1982: URL: https://github.com/apache/lucene-solr/pull/1982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #1948: LUCENE-9536: Optimize OrdinalMap when one segment contains all distinct values.

2020-10-14 Thread GitBox
mikemccand commented on a change in pull request #1948: URL: https://github.com/apache/lucene-solr/pull/1948#discussion_r504863887 ## File path: lucene/core/src/java/org/apache/lucene/index/OrdinalMap.java ## @@ -271,13 +273,26 @@ protected boolean lessThan(TermsEnumIndex a,

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
gus-asf commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r504867934 ## File path: lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java ## @@ -190,7 +196,8 @@ public static void

[jira] [Commented] (LUCENE-9579) Update JUnit to latest 4.x release

2020-10-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214107#comment-17214107 ] ASF subversion and git services commented on LUCENE-9579: - Commit

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
uschindler commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r504863498 ## File path: lucene/test-framework/src/java/org/apache/lucene/analysis/BaseTokenStreamTestCase.java ## @@ -190,7 +196,8 @@ public static void

[GitHub] [lucene-solr] madrob merged pull request #1981: LUCENE-9579 Update to JUnit 4.13.1

2020-10-14 Thread GitBox
madrob merged pull request #1981: URL: https://github.com/apache/lucene-solr/pull/1981 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9568) FuzzyTermEnums sets negative boost for fuzzy search & highlight

2020-10-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214102#comment-17214102 ] Robert Muir commented on LUCENE-9568: - I'm not sure its so simple: today with TopTermsRewrite we may

[jira] [Commented] (LUCENE-9575) Add PatternTypingFilter

2020-10-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214100#comment-17214100 ] Uwe Schindler commented on LUCENE-9575: --- One you have a pull request, I'm happy to review the

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
uschindler commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r504856970 ## File path: lucene/CHANGES.txt ## @@ -15,7 +15,7 @@ API Changes * LUCENE-8474: RAMDirectory and associated deprecated classes have been

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1965: LUCENE-9572 - TypeAsSynonymFilter gains selective flag transfer and an ignore list.

2020-10-14 Thread GitBox
uschindler commented on a change in pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#discussion_r504855884 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/TypeAsSynonymFilter.java ## @@ -64,9 +82,15 @@ public

[jira] [Commented] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2020-10-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214091#comment-17214091 ] Uwe Schindler commented on LUCENE-9574: --- Thanks! > Add a token filter to drop tokens based on

[jira] [Comment Edited] (SOLR-14930) Deprecate rulebased replica placement strategy

2020-10-14 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214087#comment-17214087 ] Cassandra Targett edited comment on SOLR-14930 at 10/14/20, 5:32 PM: -

[jira] [Comment Edited] (SOLR-14930) Deprecate rulebased replica placement strategy

2020-10-14 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214087#comment-17214087 ] Cassandra Targett edited comment on SOLR-14930 at 10/14/20, 5:32 PM: -

[jira] [Commented] (SOLR-14930) Deprecate rulebased replica placement strategy

2020-10-14 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214087#comment-17214087 ] Cassandra Targett commented on SOLR-14930: -- bq. I think this Jira should be called "remove" and

[jira] [Commented] (LUCENE-9568) FuzzyTermEnums sets negative boost for fuzzy search & highlight

2020-10-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214084#comment-17214084 ] Michael McCandless commented on LUCENE-9568: Whoa, thanks [~rcmuir] – that is indeed a very

[jira] [Commented] (LUCENE-9574) Add a token filter to drop tokens based on flags.

2020-10-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214082#comment-17214082 ] ASF subversion and git services commented on LUCENE-9574: - Commit

[GitHub] [lucene-solr] gus-asf merged pull request #1979: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-14 Thread GitBox
gus-asf merged pull request #1979: URL: https://github.com/apache/lucene-solr/pull/1979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (SOLR-14915) Prometheus-exporter should not depend on Solr-core

2020-10-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214045#comment-17214045 ] Dawid Weiss commented on SOLR-14915: I personally think there should be no single binary Solr

[GitHub] [lucene-solr] munendrasn merged pull request #1975: Include missing commands in package tool help section

2020-10-14 Thread GitBox
munendrasn merged pull request #1975: URL: https://github.com/apache/lucene-solr/pull/1975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-14647) Importing Gradle Projects into Eclipse pollutes checkout

2020-10-14 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214040#comment-17214040 ] James Dyer commented on SOLR-14647: --- I am an eclipse user, not an expert but my belief is that every

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1979: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-14 Thread GitBox
uschindler edited a comment on pull request #1979: URL: https://github.com/apache/lucene-solr/pull/1979#issuecomment-708504330 > I don't see how this would allow me to set flags on the individual tokens? Do you have an example of that? Sorry I missed that. The Token class ha bit of

[GitHub] [lucene-solr] uschindler commented on pull request #1979: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-14 Thread GitBox
uschindler commented on pull request #1979: URL: https://github.com/apache/lucene-solr/pull/1979#issuecomment-708504330 > I don't see how this would allow me to set flags on the individual tokens? Do you have an example of that? Sorry I missed that. The Token class ha bit of bad

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1979: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-14 Thread GitBox
uschindler commented on a change in pull request #1979: URL: https://github.com/apache/lucene-solr/pull/1979#discussion_r504798160 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/DropIfFlaggedFilter.java ## @@ -0,0 +1,52 @@ +/* + *

[GitHub] [lucene-solr] gus-asf commented on pull request #1979: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-14 Thread GitBox
gus-asf commented on pull request #1979: URL: https://github.com/apache/lucene-solr/pull/1979#issuecomment-708492412 > I am not so happy about the tests using the "obsolete" Token class. I'd use a MockTokenizer with a string instead. I don't see how this would allow me to set flags

[GitHub] [lucene-solr] nknize commented on pull request #1940: LUCENE-9552: Adds a LatLonPoint query that accepts an array of LatLonGeometries

2020-10-14 Thread GitBox
nknize commented on pull request #1940: URL: https://github.com/apache/lucene-solr/pull/1940#issuecomment-708491077 Circle approximation vs distance aside I think the real benefit of this PR is that it creates a single query for multiple geometry types whereas right now we have to create

[GitHub] [lucene-solr] sigram commented on a change in pull request #1974: SOLR-14914: Add option to disable metrics collection

2020-10-14 Thread GitBox
sigram commented on a change in pull request #1974: URL: https://github.com/apache/lucene-solr/pull/1974#discussion_r504781919 ## File path: solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java ## @@ -110,19 +110,22 @@ public static final int

[GitHub] [lucene-solr] madrob opened a new pull request #1981: LUCENE-9579 Update to JUnit 4.13.1

2020-10-14 Thread GitBox
madrob opened a new pull request #1981: URL: https://github.com/apache/lucene-solr/pull/1981 @dweiss I didn't see any compat issues that this caused with carrot search runner, but will give you a chance to look before I merge this.

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1979: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-14 Thread GitBox
gus-asf commented on a change in pull request #1979: URL: https://github.com/apache/lucene-solr/pull/1979#discussion_r504726501 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/DropIfFlaggedFilter.java ## @@ -0,0 +1,52 @@ +/* + * Licensed

[jira] [Commented] (SOLR-14654) Remove plugin loading from .system collection (for 9.0)

2020-10-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214004#comment-17214004 ] ASF subversion and git services commented on SOLR-14654: Commit

[GitHub] [lucene-solr] madrob commented on a change in pull request #1974: SOLR-14914: Add option to disable metrics collection

2020-10-14 Thread GitBox
madrob commented on a change in pull request #1974: URL: https://github.com/apache/lucene-solr/pull/1974#discussion_r504767202 ## File path: solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java ## @@ -110,19 +110,22 @@ public static final int

[GitHub] [lucene-solr] madrob commented on a change in pull request #1974: SOLR-14914: Add option to disable metrics collection

2020-10-14 Thread GitBox
madrob commented on a change in pull request #1974: URL: https://github.com/apache/lucene-solr/pull/1974#discussion_r504766830 ## File path: solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java ## @@ -110,19 +110,22 @@ public static final int

[jira] [Commented] (SOLR-14282) /get handler doesn't return copied fields

2020-10-14 Thread Andrei Minin (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213958#comment-17213958 ] Andrei Minin commented on SOLR-14282: - Erik, you are right about tokens / analyzers - tokens not

[jira] [Updated] (LUCENE-9579) Update JUnit to latest 4.x release

2020-10-14 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated LUCENE-9579: -- Summary: Update JUnit to latest 4.x release (was: Update Unit to latest 4.x release) > Update JUnit

[jira] [Created] (LUCENE-9579) Update Unit to latest 4.x release

2020-10-14 Thread Mike Drob (Jira)
Mike Drob created LUCENE-9579: - Summary: Update Unit to latest 4.x release Key: LUCENE-9579 URL: https://issues.apache.org/jira/browse/LUCENE-9579 Project: Lucene - Core Issue Type: Test

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1980: SOLR-14930: Deprecate rulebased replica placement strategy

2020-10-14 Thread GitBox
murblanc commented on a change in pull request #1980: URL: https://github.com/apache/lucene-solr/pull/1980#discussion_r504718678 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java ## @@ -556,19 +500,8 @@ public static AssignStrategy

[jira] [Commented] (SOLR-14930) Deprecate rulebased replica placement strategy

2020-10-14 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213945#comment-17213945 ] Ilan Ginzburg commented on SOLR-14930: -- I think this Jira should be called "remove" and not

[GitHub] [lucene-solr] gus-asf commented on a change in pull request #1979: LUCENE-9574 Add DropIfFlaggedFilterFactory

2020-10-14 Thread GitBox
gus-asf commented on a change in pull request #1979: URL: https://github.com/apache/lucene-solr/pull/1979#discussion_r504710181 ## File path: lucene/CHANGES.txt ## @@ -19,7 +19,7 @@ API Changes * LUCENE-8474: RAMDirectory and associated deprecated classes have been

  1   2   >