[jira] [Commented] (LUCENE-8982) Make NativeUnixDirectory pure java now that direct IO is possible

[ https://issues.apache.org/jira/browse/LUCENE-8982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227746#comment-17227746 ] Zach Chen commented on LUCENE-8982: --- [~mdrob] It does seems *ant build-native-unix* is no longer

[GitHub] [lucene-solr] zacharymorn opened a new pull request #2068: LUCENE-8982: Separate out native code to another module to allow cpp build with gradle

zacharymorn opened a new pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068 # Description When working on https://issues.apache.org/jira/browse/LUCENE-8982, we realized that there may no longer be a way to build native cpp code due to migration away from ant. This

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r519135013 ## File path: lucene/misc/src/java/org/apache/lucene/store/DirectIODirectory.java ## @@ -66,45 +66,32 @@ * * @lucene.experimental */

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r519134822 ## File path: lucene/CHANGES.txt ## @@ -156,6 +156,9 @@ Improvements * LUCENE-9531: Consolidated CharStream and FastCharStream classes: these

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r519134971 ## File path: lucene/misc/src/java/org/apache/lucene/store/DirectIODirectory.java ## @@ -164,15 +149,16 @@ public IndexOutput createOutput(String

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-723400516 > Thank you @zacharymorn! It's so nice we can move this to pure java now -- this makes it much easier and lower risk for Lucene users to test. > > I suspect for

[jira] [Comment Edited] (SOLR-14977) Container plugins need a way to be configured

[ https://issues.apache.org/jira/browse/SOLR-14977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225848#comment-17225848 ] Noble Paul edited comment on SOLR-14977 at 11/7/20, 5:08 AM: - Let's have a

[jira] [Commented] (SOLR-9956) Solr java.lang.ArrayIndexOutOfBoundsException when indexed large amount of documents

[ https://issues.apache.org/jira/browse/SOLR-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227727#comment-17227727 ] sajit vasudevan commented on SOLR-9956: --- We are encountering a similar issue for large document and

[jira] [Created] (SOLR-14988) CoreContainer.getCores should should return transient cores that are loaded

David Smiley created SOLR-14988: --- Summary: CoreContainer.getCores should should return transient cores that are loaded Key: SOLR-14988 URL: https://issues.apache.org/jira/browse/SOLR-14988 Project:

[jira] [Commented] (SOLR-14975) Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames

[ https://issues.apache.org/jira/browse/SOLR-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227654#comment-17227654 ] David Smiley commented on SOLR-14975: - Queries are blocked because a SolrCore needs to be looked up

[jira] [Updated] (SOLR-14987) SolrStream ends up creating a new HttpSolrClient for every replica being queried instead of reusing for the same node

[ https://issues.apache.org/jira/browse/SOLR-14987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-14987: -- Status: Patch Available (was: Open) > SolrStream ends up creating a new HttpSolrClient for

[jira] [Updated] (LUCENE-9378) Configurable compression for BinaryDocValues

[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-9378: - Priority: Major (was: Minor) We normally don't pay attention much to the "Priority"

[jira] [Commented] (SOLR-14942) Reduce leader election time on node shutdown

[ https://issues.apache.org/jira/browse/SOLR-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227639#comment-17227639 ] David Smiley commented on SOLR-14942: - I am seeing this just now... and after looking at the

[GitHub] [lucene-solr] thelabdude opened a new pull request #2067: SOLR-14987: Reuse HttpSolrClient per node vs. one per Solr core when using CloudSolrStream

thelabdude opened a new pull request #2067: URL: https://github.com/apache/lucene-solr/pull/2067 # Description For collections with many shards (or aliases with many collections and some shards), `CloudSolrStream` will end up creating a new `HttpSolrClient` for every `SolrStream`

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

msokolov commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519007187 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/BoundsChecker.java ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

msokolov commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519006572 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

msokolov commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519004731 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

msokolov commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519001123 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

msokolov commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519001030 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

msokolov commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r519000323 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

msokolov commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r518999576 ## File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

msokolov commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r518997811 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -74,6 +74,18 @@ public BytesRef binaryValue() throws IOException

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

dsmiley commented on a change in pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066#discussion_r518937449 ## File path: solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java ## @@ -69,7 +71,10 @@ public void startReplication(boolean

[jira] [Commented] (LUCENE-9537) Add Indri Search Engine Functionality to Lucene

[ https://issues.apache.org/jira/browse/LUCENE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227581#comment-17227581 ] Cameron VandenBerg commented on LUCENE-9537: Hi [~mikemccand] , Thank you for your

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2064: LUCENE-9600: Clean up package name conflicts between misc and core modules

dsmiley commented on a change in pull request #2064: URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r518931251 ## File path: lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java ## @@ -95,7 +95,7 @@ private static BytesRef

[jira] [Commented] (SOLR-14975) Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames

[ https://issues.apache.org/jira/browse/SOLR-14975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227546#comment-17227546 ] Bruno Roustant commented on SOLR-14975: --- I added a PR. I believe descriptors are superset of

[GitHub] [lucene-site] atris commented on pull request #33: Fix change log URL

atris commented on pull request #33: URL: https://github.com/apache/lucene-site/pull/33#issuecomment-723212628 I think this is just a realignment -- I did it from commandline and has the same changes. I manually verifies and saw that the overall structure is still the same.

[GitHub] [lucene-site] atris merged pull request #33: Fix change log URL

atris merged pull request #33: URL: https://github.com/apache/lucene-site/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene-solr] bruno-roustant opened a new pull request #2066: SOLR-14975: Optimize CoreContainer.getAllCoreNames and getLoadedCoreNames.

bruno-roustant opened a new pull request #2066: URL: https://github.com/apache/lucene-solr/pull/2066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (SOLR-14987) SolrStream ends up creating a new HttpSolrClient for every replica being queried instead of reusing for the same node

Timothy Potter created SOLR-14987: - Summary: SolrStream ends up creating a new HttpSolrClient for every replica being queried instead of reusing for the same node Key: SOLR-14987 URL:

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

msokolov commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r518902276 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -74,6 +74,18 @@ public BytesRef binaryValue() throws IOException

[jira] [Commented] (LUCENE-9583) How should we expose VectorValues.RandomAccess?

[ https://issues.apache.org/jira/browse/LUCENE-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227534#comment-17227534 ] Michael Sokolov commented on LUCENE-9583: - I worked up a version of LUCENE-9004 that uses docids

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518869895 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/TeamDraftInterleaving.java ## @@ -0,0 +1,87 @@ +/* + * Licensed

[jira] [Commented] (LUCENE-9378) Configurable compression for BinaryDocValues

[ https://issues.apache.org/jira/browse/LUCENE-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227469#comment-17227469 ] Michael McCandless commented on LUCENE-9378: {quote}I'm wondering if there is anything I

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

mikemccand commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r518846067 ## File path: lucene/misc/src/java/org/apache/lucene/store/DirectIODirectory.java ## @@ -164,15 +149,16 @@ public IndexOutput createOutput(String

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#issuecomment-723131924 @msokolov Thanks a lot for another round of review, I tried to address it in c52d9a73 This is an

[jira] [Commented] (LUCENE-9537) Add Indri Search Engine Functionality to Lucene

[ https://issues.apache.org/jira/browse/LUCENE-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227444#comment-17227444 ] Michael McCandless commented on LUCENE-9537: Thank you for all the hard work here

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518813515 ## File path: lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java ## @@ -485,4 +491,249 @@ public void

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518811869 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldComparator.java ## @@ -387,125 +346,225 @@ protected SortedDocValues

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518803324 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldComparator.java ## @@ -387,125 +346,225 @@ protected SortedDocValues

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518800810 ## File path: lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java ## @@ -485,4 +491,249 @@ public void

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518799913 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java ## @@ -218,7 +237,7 @@ public void visit(int

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518799074 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ## @@ -139,6 +140,7 @@ void collectAnyHit(int doc, int

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2063: LUCENE-9599 Make comparator aware of index sorting

mayya-sharipova commented on a change in pull request #2063: URL: https://github.com/apache/lucene-solr/pull/2063#discussion_r518798756 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ## @@ -100,6 +100,7 @@ boolean thresholdCheck(int doc)

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2022: LUCENE-9004: KNN vector search using NSW graphs

mikemccand commented on a change in pull request #2022: URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r518797861 ## File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java ## @@ -74,6 +74,18 @@ public BytesRef binaryValue() throws

[jira] [Commented] (SOLR-8673) o.a.s.search.facet classes not public/extendable

[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227421#comment-17227421 ] Tim Owen commented on SOLR-8673: Good idea, I've updated my patch with a new test - it simply confirms

[jira] [Updated] (SOLR-8673) o.a.s.search.facet classes not public/extendable

[ https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Owen updated SOLR-8673: --- Attachment: SOLR-8673.patch > o.a.s.search.facet classes not public/extendable >

[jira] [Commented] (SOLR-14986) Restrict the properties possible to define with "property.name=value" when creating a collection

[ https://issues.apache.org/jira/browse/SOLR-14986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227418#comment-17227418 ] Erick Erickson commented on SOLR-14986: --- I want some opinions on what to do here. Thinking about

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518736297 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java ## @@ -146,93 +149,114 @@ public

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

cpoerschke commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518725166 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/TeamDraftInterleaving.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518716331 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRInterleavingRescorer.java ## @@ -0,0 +1,156 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

muse-dev[bot] commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518714285 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRInterleavingTransformerFactory.java ## @@ -0,0 +1,121 @@ +/*

[jira] [Assigned] (SOLR-6399) Implement unloadCollection in the Collections API

[ https://issues.apache.org/jira/browse/SOLR-6399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shalin Shekhar Mangar reassigned SOLR-6399: --- Assignee: (was: Shalin Shekhar Mangar) > Implement unloadCollection in

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518696688 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java ## @@ -146,93 +149,114 @@ public

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518665886 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/TeamDraftInterleaving.java ## @@ -0,0 +1,87 @@ +/* + * Licensed

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

cpoerschke commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518659433 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/interleaving/TeamDraftInterleaving.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the

[GitHub] [lucene-solr] alessandrobenedetti commented on a change in pull request #1571: SOLR-14560: Interleaving for Learning To Rank

alessandrobenedetti commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518653490 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/search/LTRQParserPlugin.java ## @@ -146,93 +149,114 @@ public