[jira] [Resolved] (LUCENE-9717) Hunspell: support CHECKCOMPOUNDPATTERN

2021-02-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9717. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: support CHECKCOMPOUNDPATTERN >

[GitHub] [lucene-solr] dweiss merged pull request #2280: LUCENE-9717: Hunspell: support CHECKCOMPOUNDPATTERN

2021-02-02 Thread GitBox
dweiss merged pull request #2280: URL: https://github.com/apache/lucene-solr/pull/2280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (SOLR-15100) add ConfigSetService extension ability

2021-02-02 Thread bai sui (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bai sui updated SOLR-15100: --- Status: Patch Available (was: Reopened) > add ConfigSetService extension ability >

[jira] [Resolved] (SOLR-15100) add ConfigSetService extension ability

2021-02-02 Thread bai sui (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bai sui resolved SOLR-15100. Resolution: Fixed > add ConfigSetService extension ability > -- > >

[jira] [Reopened] (SOLR-15100) add ConfigSetService extension ability

2021-02-02 Thread bai sui (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bai sui reopened SOLR-15100: > add ConfigSetService extension ability > -- > > Key:

[jira] [Commented] (SOLR-15124) Remove node/container level admin handlers from ImplicitPlugins.json (core level).

2021-02-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277653#comment-17277653 ] David Smiley commented on SOLR-15124: - These handlers are already registered at the node level; that

[jira] [Resolved] (SOLR-15011) /admin/logging handler should be able to configure logs on all nodes

2021-02-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15011. - Fix Version/s: master (9.0) Resolution: Fixed Thanks for contributing Nazerke! >

[GitHub] [lucene-solr] ShangwenWang commented on pull request #354: SOLR-12244: Change method names

2021-02-02 Thread GitBox
ShangwenWang commented on pull request #354: URL: https://github.com/apache/lucene-solr/pull/354#issuecomment-772175261 There is already a List variable named _shardNames_ and the method's function is to add content to this list. So how about naming these methods **addNames**? Is it

[jira] [Commented] (SOLR-15011) /admin/logging handler should be able to configure logs on all nodes

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277646#comment-17277646 ] ASF subversion and git services commented on SOLR-15011: Commit

[GitHub] [lucene-solr] dsmiley merged pull request #2230: SOLR-15011: /admin/logging handler is configured logs to all nodes

2021-02-02 Thread GitBox
dsmiley merged pull request #2230: URL: https://github.com/apache/lucene-solr/pull/2230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] dweiss commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
dweiss commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-771677497 Hi Peter. I pushed a commit which replaces bom consumption with a small function so that either it's read atomically or nothing is consumed at all. Looking at the code also

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2263: SOLR-14978 OOM Killer in Foreground (#2055)

2021-02-02 Thread GitBox
cpoerschke commented on a change in pull request #2263: URL: https://github.com/apache/lucene-solr/pull/2263#discussion_r568436589 ## File path: solr/bin/solr ## @@ -2115,6 +2128,15 @@ function start_solr() { SOLR_OPTS+=($AUTHC_OPTS) fi + # If a heap dump directory

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
donnerpeter commented on a change in pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#discussion_r568575767 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -696,45 +690,25 @@ char affixData(int

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
murblanc commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568912229 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -90,7 +96,9 @@ public void

[GitHub] [lucene-solr] jpountz commented on a change in pull request #2268: LUCENE-9705: Move Lucene50CompoundFormat to Lucene90CompoundFormat

2021-02-02 Thread GitBox
jpountz commented on a change in pull request #2268: URL: https://github.com/apache/lucene-solr/pull/2268#discussion_r568617447 ## File path: lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene50/Lucene50CompoundFormat.java ## @@ -0,0 +1,88 @@ +/* + *

[GitHub] [lucene-solr] dnhatn merged pull request #2288: LUCENE-9722: Close merged readers on abort

2021-02-02 Thread GitBox
dnhatn merged pull request #2288: URL: https://github.com/apache/lucene-solr/pull/2288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] orenovadia commented on a change in pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-02 Thread GitBox
orenovadia commented on a change in pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231#discussion_r568890937 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4600,4 +4600,49 @@ public void

[GitHub] [lucene-solr] dweiss merged pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
dweiss merged pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dweiss merged pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss merged pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] madrob commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568852727 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -144,7 +152,25 @@ public synchronized

[GitHub] [lucene-solr] dnhatn commented on pull request #2288: LUCENE-9722: Close merged readers on abort

2021-02-02 Thread GitBox
dnhatn commented on pull request #2288: URL: https://github.com/apache/lucene-solr/pull/2288#issuecomment-771758863 Thanks Simon. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2256: LUCENE-9507 Custom order for leaves in IndexReader and IndexWriter

2021-02-02 Thread GitBox
mayya-sharipova commented on a change in pull request #2256: URL: https://github.com/apache/lucene-solr/pull/2256#discussion_r568520864 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -941,6 +969,11 @@ public IndexWriter(Directory d,

[GitHub] [lucene-solr] msokolov merged pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-02 Thread GitBox
msokolov merged pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] dweiss commented on pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss commented on pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#issuecomment-771498850 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-02 Thread GitBox
bruno-roustant commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771782427 I expect you don't need to change Lucene code but just write a new custom codec (with a specific name) which provides a custom DocValuesFormat. It extends

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #2284: SOLR-11233: Add optional JAVA8_GC_LOG_FILE_OPTS for bin/solr.

2021-02-02 Thread GitBox
cpoerschke commented on a change in pull request #2284: URL: https://github.com/apache/lucene-solr/pull/2284#discussion_r568428808 ## File path: solr/bin/solr ## @@ -2026,7 +2026,11 @@ if [ "$GC_LOG_OPTS" != "" ]; then if [ "$JAVA_VENDOR" == "IBM J9" ]; then

[GitHub] [lucene-solr] donnerpeter commented on pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
donnerpeter commented on pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#issuecomment-771492242 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-02 Thread GitBox
msokolov commented on a change in pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231#discussion_r568979069 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4600,4 +4600,49 @@ public void testIndexWriterBlocksOnStall()

[GitHub] [lucene-solr] jtibshirani commented on pull request #2276: Improve backwards compatibility tests for sorted indexes.

2021-02-02 Thread GitBox
jtibshirani commented on pull request #2276: URL: https://github.com/apache/lucene-solr/pull/2276#issuecomment-771834969 @mikemccand I tagged you for a (hopefully quick) review, as I think you added the TODOs? This is an

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
dweiss commented on a change in pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#discussion_r568569461 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -696,45 +690,25 @@ char affixData(int

[GitHub] [lucene-solr] sigram commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
sigram commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568832617 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -90,7 +95,10 @@ public void

[GitHub] [lucene-solr] msokolov merged pull request #2282: LUCENE-9615: Expose HnswGraphBuilder index-time hyperparameters as FieldType attributes

2021-02-02 Thread GitBox
msokolov merged pull request #2282: URL: https://github.com/apache/lucene-solr/pull/2282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] donnerpeter commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
donnerpeter commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-771711060 Thank you, LGTM! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-02 Thread GitBox
zhaih commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r568246420 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -736,49 +736,92 @@ private void

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-02 Thread GitBox
zacharymorn commented on a change in pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258#discussion_r568293170 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -381,17 +377,18 @@ public long length() {

[GitHub] [lucene-solr] jaisonbi edited a comment on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-02 Thread GitBox
jaisonbi edited a comment on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771296030 If I understood correctly, the route via PerFieldDocValuesFormat need to change the usage of SortedSetDocValues. The idea is adding another constructor for

[GitHub] [lucene-solr] zacharymorn commented on pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-02 Thread GitBox
zacharymorn commented on pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258#issuecomment-771322610 > Hi Zach. Sorry for belated reply. Please take a look at my comments attached to the context. I have some doubts whether EOF should leave the channel undrained. Maybe

[GitHub] [lucene-solr] sbeniwal12 commented on a change in pull request #2282: LUCENE-9615: Expose HnswGraphBuilder index-time hyperparameters as FieldType attributes

2021-02-02 Thread GitBox
sbeniwal12 commented on a change in pull request #2282: URL: https://github.com/apache/lucene-solr/pull/2282#discussion_r568327126 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorWriter.java ## @@ -188,9 +190,29 @@ private void writeGraph(

[GitHub] [lucene-solr] dweiss merged pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-02 Thread GitBox
dweiss merged pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
dweiss commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568397883 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/SpellCheckerTest.java ## @@ -61,59 +61,74 @@ public void

[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2267: LUCENE-9707: Hunspell: check Lucene's implementation against Hunspel's test data

2021-02-02 Thread GitBox
donnerpeter commented on a change in pull request #2267: URL: https://github.com/apache/lucene-solr/pull/2267#discussion_r568394955 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/SpellCheckerTest.java ## @@ -61,59 +61,74 @@ public void

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2230: SOLR-15011: /admin/logging handler is configured logs to all nodes

2021-02-02 Thread GitBox
dsmiley commented on a change in pull request #2230: URL: https://github.com/apache/lucene-solr/pull/2230#discussion_r568204361 ## File path: solr/CHANGES.txt ## @@ -69,6 +69,8 @@ Improvements * SOLR-14949: Docker: Ability to customize the FROM image when building.

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2258: LUCENE-9686: Fix read past EOF handling in DirectIODirectory

2021-02-02 Thread GitBox
dweiss commented on a change in pull request #2258: URL: https://github.com/apache/lucene-solr/pull/2258#discussion_r568395337 ## File path: lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java ## @@ -381,17 +377,18 @@ public long length() { @Override

[GitHub] [lucene-solr] jaisonbi commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-02 Thread GitBox
jaisonbi commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771296030 If I understood correctly, the route via PerFieldDocValuesFormat need to change the usage of SortedSetDocValues. The idea is adding another constructor for enabling

[GitHub] [lucene-solr] zhaih commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-02 Thread GitBox
zhaih commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771265310 I see, so I think for now I could test it via a customized PerFieldDocValuesFormat, I'll give PerFieldDocValuesFormat route a try then. Tho IMO I would prefer a simpler

[jira] [Commented] (LUCENE-9725) Allow BM25FQuery to use other similarities

2021-02-02 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277545#comment-17277545 ] Julie Tibshirani commented on LUCENE-9725: -- I opened

[GitHub] [lucene-solr] jtibshirani opened a new pull request #2293: LUCENE-9725: Allow BM25FQuery to use other similarities.

2021-02-02 Thread GitBox
jtibshirani opened a new pull request #2293: URL: https://github.com/apache/lucene-solr/pull/2293 From a high level, BM25FQuery (1) computes statistic that represent the combined field content and (2) passes these to a score function. This model makes sense for many similarities

[jira] [Commented] (SOLR-15127) All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags

2021-02-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277542#comment-17277542 ] Chris M. Hostetter commented on SOLR-15127: --- bq. David Smiley's suggestion of using the Solr

[jira] [Updated] (LUCENE-9725) Allow BM25FQuery to use other similarities

2021-02-02 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-9725: - Description: >From a high level, BM25FQuery works as follows: # Given a list of fields

[jira] [Comment Edited] (SOLR-15127) All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags

2021-02-02 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277530#comment-17277530 ] Houston Putman edited comment on SOLR-15127 at 2/2/21, 11:49 PM: - I think

[GitHub] [lucene-solr] HoustonPutman opened a new pull request #2292: SOLR-15102: Use Solr distribution TGZ as docker context

2021-02-02 Thread GitBox
HoustonPutman opened a new pull request #2292: URL: https://github.com/apache/lucene-solr/pull/2292 https://issues.apache.org/jira/browse/SOLR-15102 This should work, but there is still cleanup needed with the gradle changes. Also we might want to infer the Solr version

[jira] [Created] (LUCENE-9725) Allow BM25FQuery to use other similarities

2021-02-02 Thread Julie Tibshirani (Jira)
Julie Tibshirani created LUCENE-9725: Summary: Allow BM25FQuery to use other similarities Key: LUCENE-9725 URL: https://issues.apache.org/jira/browse/LUCENE-9725 Project: Lucene - Core

[jira] [Created] (SOLR-15129) Use the Solr TGZ artifact as Docker context

2021-02-02 Thread Houston Putman (Jira)
Houston Putman created SOLR-15129: - Summary: Use the Solr TGZ artifact as Docker context Key: SOLR-15129 URL: https://issues.apache.org/jira/browse/SOLR-15129 Project: Solr Issue Type:

[jira] [Commented] (SOLR-15127) All-In-One Dockerfile for building local images as well as reproducible release builds directly from (remote) git tags

2021-02-02 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277530#comment-17277530 ] Houston Putman commented on SOLR-15127: --- I think there are two possible ways of going forward with

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277529#comment-17277529 ] Ilan Ginzburg commented on SOLR-15122: -- I've never used this specific class but if you make it so

[jira] [Commented] (SOLR-5480) Make MoreLikeThisHandler distributable

2021-02-02 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277522#comment-17277522 ] Isabelle Giguere commented on SOLR-5480: [~erickerickson], [~noble.paul], [~anshum], [~hossman]

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277519#comment-17277519 ] Mike Drob commented on SOLR-15122: -- I was thinking about this some more, and think we should use a

[jira] [Commented] (LUCENE-9680) Re-add IndexWriter.getFieldNames

2021-02-02 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277510#comment-17277510 ] Michael Sokolov commented on LUCENE-9680: - [~oren.ovadia] do you also want to backport to

[jira] [Commented] (LUCENE-9680) Re-add IndexWriter.getFieldNames

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277508#comment-17277508 ] ASF subversion and git services commented on LUCENE-9680: - Commit

[GitHub] [lucene-solr] msokolov merged pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-02 Thread GitBox
msokolov merged pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-02 Thread GitBox
msokolov commented on a change in pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231#discussion_r568979069 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4600,4 +4600,49 @@ public void testIndexWriterBlocksOnStall()

[GitHub] [lucene-solr] madrob commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568977953 ## File path: solr/core/src/test/org/apache/solr/cluster/CountingStateChangeListener.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (LUCENE-9615) Expose HnswGraphBuilder index-time hyperparameters

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277502#comment-17277502 ] ASF subversion and git services commented on LUCENE-9615: - Commit

[GitHub] [lucene-solr] msokolov merged pull request #2282: LUCENE-9615: Expose HnswGraphBuilder index-time hyperparameters as FieldType attributes

2021-02-02 Thread GitBox
msokolov merged pull request #2282: URL: https://github.com/apache/lucene-solr/pull/2282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
murblanc commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568968626 ## File path: solr/core/src/test/org/apache/solr/cluster/CountingStateChangeListener.java ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache

[GitHub] [lucene-solr] madrob commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568944250 ## File path: solr/core/src/test/org/apache/solr/cluster/events/ClusterEventProducerTest.java ## @@ -102,7 +105,7 @@ public void teardown() throws

[GitHub] [lucene-solr] madrob commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568943853 ## File path: solr/core/src/test/org/apache/solr/cluster/VersionTrackerImpl.java ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (SOLR-15092) Loosen Ref Guide link checking to allow empty anchors in links

2021-02-02 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15092: -- Attachment: SOLR-15092.patch Assignee: Chris M. Hostetter Status: Open

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277448#comment-17277448 ] Ilan Ginzburg commented on SOLR-15122: -- Added a few comments. I like this approach much better.

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
murblanc commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568912229 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -90,7 +96,9 @@ public void

[jira] [Commented] (LUCENE-9716) Hunspell: support flag usage before its format is even specified

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277437#comment-17277437 ] ASF subversion and git services commented on LUCENE-9716: - Commit

[jira] [Resolved] (LUCENE-9716) Hunspell: support flag usage before its format is even specified

2021-02-02 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9716. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: support flag usage before its

[GitHub] [lucene-solr] dweiss merged pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
dweiss merged pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] orenovadia commented on a change in pull request #2231: LUCENE-9680 - Re-add IndexWriter::getFieldNames

2021-02-02 Thread GitBox
orenovadia commented on a change in pull request #2231: URL: https://github.com/apache/lucene-solr/pull/2231#discussion_r568890937 ## File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java ## @@ -4600,4 +4600,49 @@ public void

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277423#comment-17277423 ] Mike Drob commented on SOLR-15122: -- Refactored the code in anticipation of working over

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277406#comment-17277406 ] Ilan Ginzburg commented on SOLR-15122: -- You're right about no mutable Integer. Would there be a way

[GitHub] [lucene-solr] madrob commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568852727 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -144,7 +152,25 @@ public synchronized

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277399#comment-17277399 ] Mike Drob commented on SOLR-15122: -- I'm pretty comfortable with that blanket statement. If you're using

[jira] [Resolved] (SOLR-15128) nodeName does not contain expected ':' separator: localhost

2021-02-02 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter resolved SOLR-15128. --- Resolution: Won't Fix Ignore this ;-) Was using the wrong method to get the nodeName in some

[jira] [Commented] (SOLR-15128) nodeName does not contain expected ':' separator: localhost

2021-02-02 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277376#comment-17277376 ] Timothy Potter commented on SOLR-15128: --- Not sure why master is seeing {{localhost}} as the

[jira] [Created] (SOLR-15128) nodeName does not contain expected ':' separator: localhost

2021-02-02 Thread Timothy Potter (Jira)
Timothy Potter created SOLR-15128: - Summary: nodeName does not contain expected ':' separator: localhost Key: SOLR-15128 URL: https://issues.apache.org/jira/browse/SOLR-15128 Project: Solr

[jira] [Updated] (SOLR-15128) nodeName does not contain expected ':' separator: localhost

2021-02-02 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter updated SOLR-15128: -- Fix Version/s: master (9.0) > nodeName does not contain expected ':' separator: localhost >

[GitHub] [lucene-solr] sigram commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
sigram commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568833741 ## File path: solr/core/src/test/org/apache/solr/cluster/events/ClusterEventProducerTest.java ## @@ -292,7 +287,7 @@ public void

[GitHub] [lucene-solr] sigram commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
sigram commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568833400 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -144,7 +152,25 @@ public synchronized

[GitHub] [lucene-solr] sigram commented on a change in pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
sigram commented on a change in pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291#discussion_r568832617 ## File path: solr/core/src/java/org/apache/solr/cluster/events/impl/DelegatingClusterEventProducer.java ## @@ -90,7 +95,10 @@ public void

[jira] [Comment Edited] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277360#comment-17277360 ] Ilan Ginzburg edited comment on SOLR-15122 at 2/2/21, 6:16 PM: --- ??We

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277360#comment-17277360 ] Ilan Ginzburg commented on SOLR-15122: -- ??We shouldn't use postfix increment with a volatile

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277353#comment-17277353 ] Mike Drob commented on SOLR-15122: -- I put up a PR to demonstrate what I meant, I think the same pattern

[jira] [Commented] (SOLR-15124) Remove node/container level admin handlers from ImplicitPlugins.json (core level).

2021-02-02 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277347#comment-17277347 ] Cassandra Targett commented on SOLR-15124: -- I'm not able to understand entirely from the

[GitHub] [lucene-solr] madrob opened a new pull request #2291: SOLR-15122 Replace volatile+sleep with wait/notify

2021-02-02 Thread GitBox
madrob opened a new pull request #2291: URL: https://github.com/apache/lucene-solr/pull/2291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-02 Thread Nhat Nguyen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nhat Nguyen updated LUCENE-9722: Fix Version/s: 8.9 master (9.0) 8.0.1 Resolution:

[GitHub] [lucene-solr] jtibshirani commented on pull request #2276: Improve backwards compatibility tests for sorted indexes.

2021-02-02 Thread GitBox
jtibshirani commented on pull request #2276: URL: https://github.com/apache/lucene-solr/pull/2276#issuecomment-771834969 @mikemccand I tagged you for a (hopefully quick) review, as I think you added the TODOs? This is an

[jira] [Updated] (LUCENE-9724) Hunspell: tolerate existing aff/dic file typos

2021-02-02 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gromov updated LUCENE-9724: - Summary: Hunspell: tolerate existing aff/dic file typos (was: Hunspell: tolerate extra content

[jira] [Commented] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277339#comment-17277339 ] ASF subversion and git services commented on LUCENE-9722: - Commit

[jira] [Commented] (LUCENE-9722) Aborted merge can leak readers if the output is empty

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277288#comment-17277288 ] ASF subversion and git services commented on LUCENE-9722: - Commit

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-02-02 Thread GitBox
bruno-roustant commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-771782427 I expect you don't need to change Lucene code but just write a new custom codec (with a specific name) which provides a custom DocValuesFormat. It extends

[jira] [Commented] (SOLR-14886) Suppress stack trace in Query response.

2021-02-02 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277272#comment-17277272 ] Isabelle Giguere commented on SOLR-14886: - Patch off current Solr master branch (9.x) - Add a

[jira] [Updated] (SOLR-14886) Suppress stack trace in Query response.

2021-02-02 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Isabelle Giguere updated SOLR-14886: Attachment: SOLR-14886.patch > Suppress stack trace in Query response. >

[jira] [Updated] (LUCENE-9724) Hunspell: tolerate extra content on REP lines

2021-02-02 Thread Peter Gromov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Gromov updated LUCENE-9724: - Summary: Hunspell: tolerate extra content on REP lines (was: Hunspell: load dictionaries with

[jira] [Created] (LUCENE-9724) Hunspell: load dictionaries with extra content on REP lines

2021-02-02 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9724: Summary: Hunspell: load dictionaries with extra content on REP lines Key: LUCENE-9724 URL: https://issues.apache.org/jira/browse/LUCENE-9724 Project: Lucene - Core

  1   2   >