[jira] [Created] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9849: --- Summary: Lucene snapshot javadocs are published with local URLs on jenkins Key: LUCENE-9849 URL: https://issues.apache.org/jira/browse/LUCENE-9849 Project: Lucene - Cor

[GitHub] [lucene-solr] asalamon74 commented on pull request #2406: SOLR-15169: SolrPaths.assertPathAllowed normalization problem

2021-03-17 Thread GitBox
asalamon74 commented on pull request #2406: URL: https://github.com/apache/lucene-solr/pull/2406#issuecomment-800912822 @madrob I uploaded a new pull request to the new solr repo: https://github.com/apache/solr/pull/22 I modified it based on your request. -

[GitHub] [lucene] rmuir commented on pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2021-03-17 Thread GitBox
rmuir commented on pull request #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-801000190 I think it would be best if we removed it from this PR and look at it as a followup. There are other alternatives that can be done in a safe or transparent way. For example we can "loo

[GitHub] [lucene] rmuir commented on pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2021-03-17 Thread GitBox
rmuir commented on pull request #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-801001464 > My conception of this arg is as an "expert" option that can significantly improve performance, but requires users to know (and externally compensate for, with specific ICUNormalizer2

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303336#comment-17303336 ] Uwe Schindler commented on LUCENE-9849: --- Which jenkins job is that? > Lucene snap

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303337#comment-17303337 ] Uwe Schindler commented on LUCENE-9849: --- Ah that's the Maven job. This one has no

[jira] [Comment Edited] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303337#comment-17303337 ] Uwe Schindler edited comment on LUCENE-9849 at 3/17/21, 12:19 PM:

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303343#comment-17303343 ] Dawid Weiss commented on LUCENE-9849: - Yes, these are from maven artifacts uploaded

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303346#comment-17303346 ] Dawid Weiss commented on LUCENE-9849: - https://repository.apache.org/content/groups/

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303347#comment-17303347 ] Uwe Schindler commented on LUCENE-9849: --- Files here are correct: https://ci-build

[jira] [Updated] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9849: -- Attachment: screenshot-1.png > Lucene snapshot javadocs are published with local URLs on jenki

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303353#comment-17303353 ] Dawid Weiss commented on LUCENE-9849: - It's the javadoc jar artifacts uploaded to th

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303357#comment-17303357 ] Uwe Schindler commented on LUCENE-9849: --- Hi, this should not happen. I have the fe

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303362#comment-17303362 ] Uwe Schindler commented on LUCENE-9849: --- OK, now i understand: the per module java

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303363#comment-17303363 ] Dawid Weiss commented on LUCENE-9849: - Something is wrong but I can't look at it now

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303367#comment-17303367 ] Dawid Weiss commented on LUCENE-9849: - The reason I took a look is SOLR-15265. > Lu

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303370#comment-17303370 ] Uwe Schindler commented on LUCENE-9849: --- We need to disable external links in the

[jira] [Resolved] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9836. --- Fix Version/s: 8.9 Assignee: Uwe Schindler Resolution: Fixed Hi, I don't pla

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303416#comment-17303416 ] Robert Muir commented on LUCENE-9849: - I think Uwe is correct: we need to pass sligh

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303419#comment-17303419 ] Robert Muir commented on LUCENE-9849: - Here is the current code configuring links:

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303424#comment-17303424 ] Robert Muir commented on LUCENE-9849: - OK I see it now: sorry i am slow with gradle.

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303436#comment-17303436 ] Uwe Schindler commented on LUCENE-9849: --- Exactly that's how I would do it. We can

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303437#comment-17303437 ] Robert Muir commented on LUCENE-9849: - Another question i would have is, what would

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303440#comment-17303440 ] Robert Muir commented on LUCENE-9849: - Yeah we commented at the same time: {quote}

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303442#comment-17303442 ] Uwe Schindler commented on LUCENE-9849: --- Maybe do it like that: - If the global li

[jira] [Comment Edited] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303442#comment-17303442 ] Uwe Schindler edited comment on LUCENE-9849 at 3/17/21, 1:54 PM: -

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303444#comment-17303444 ] Uwe Schindler commented on LUCENE-9849: --- I think we have the logic already. If you

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303446#comment-17303446 ] Uwe Schindler commented on LUCENE-9849: --- On the solr side, the javadocs URL has ch

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303458#comment-17303458 ] Uwe Schindler commented on LUCENE-9849: --- The issue is coming from here: https://g

[GitHub] [lucene] rmuir commented on a change in pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2021-03-17 Thread GitBox
rmuir commented on a change in pull request #15: URL: https://github.com/apache/lucene/pull/15#discussion_r595948260 ## File path: lucene/analysis/icu/src/java/org/apache/lucene/analysis/icu/ICUTransformFilter.java ## @@ -77,17 +77,26 @@ @SuppressWarnings("deprecation")

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303478#comment-17303478 ] Robert Muir commented on LUCENE-9849: - {quote} The javadocs link checker is a differ

[jira] [Commented] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-03-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303487#comment-17303487 ] ASF subversion and git services commented on LUCENE-9663: - Commi

[jira] [Commented] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-03-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303492#comment-17303492 ] ASF subversion and git services commented on LUCENE-9663: - Commi

[jira] [Updated] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-03-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated LUCENE-9663: --- Fix Version/s: (was: main (9.0)) 8.9 > Adding compression to terms di

[jira] [Commented] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

2021-03-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303494#comment-17303494 ] Bruno Roustant commented on LUCENE-9663: Ok, I backported to 8.x branch, and I u

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303496#comment-17303496 ] Dawid Weiss commented on LUCENE-9849: - We could publish per-module documentation tha

[GitHub] [lucene] magibney commented on a change in pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

2021-03-17 Thread GitBox
magibney commented on a change in pull request #15: URL: https://github.com/apache/lucene/pull/15#discussion_r596142606 ## File path: lucene/analysis/icu/src/java/org/apache/lucene/analysis/icu/ICUTransformCharFilter.java ## @@ -0,0 +1,686 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] ctargett closed pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP

2021-03-17 Thread GitBox
ctargett closed pull request #2447: URL: https://github.com/apache/lucene-solr/pull/2447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] ctargett commented on pull request #2447: SOLR-15212: Update Ref Guide URLs for new Solr TLP

2021-03-17 Thread GitBox
ctargett commented on pull request #2447: URL: https://github.com/apache/lucene-solr/pull/2447#issuecomment-801305264 Moving PR to new `solr` repo. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596299038 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -796,167 +565,97 @@ public void add(FieldInfos other) { /** Creat

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303677#comment-17303677 ] Uwe Schindler commented on LUCENE-9849: --- Solr's crossreferencing does not work at

[GitHub] [lucene-solr] dsmiley commented on pull request #2278: SOLR-15124: Remove node/container level admin handlers from ImplicitP…

2021-03-17 Thread GitBox
dsmiley commented on pull request #2278: URL: https://github.com/apache/lucene-solr/pull/2278#issuecomment-801347988 Just a gentle reminder of this one. I'm sure you're busy with configSet refactoring but I didn't want this completely forgotten. --

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303682#comment-17303682 ] Dawid Weiss commented on LUCENE-9849: - Ok, let me take a look at this. > Lucene sna

[jira] [Commented] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303683#comment-17303683 ] Uwe Schindler commented on LUCENE-9849: --- I changed the Maven snapshot builds to pa

[jira] [Comment Edited] (LUCENE-9849) Lucene snapshot javadocs are published with local URLs on jenkins

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303683#comment-17303683 ] Uwe Schindler edited comment on LUCENE-9849 at 3/17/21, 7:38 PM: -

[GitHub] [lucene] msokolov opened a new pull request #20: LUCENE-9844: document disk layout of Lucene90VectorFormat

2021-03-17 Thread GitBox
msokolov opened a new pull request #20: URL: https://github.com/apache/lucene/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene] dweiss opened a new pull request #21: LUCENE-9849: Don't cross-link between modules for interim snapshot builds.

2021-03-17 Thread GitBox
dweiss opened a new pull request #21: URL: https://github.com/apache/lucene/pull/21 This isn't ideal - I think the root property luceneDocUrl should be moved to render-javadoc, but it's a start? This is an automated message

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596373649 ## File path: lucene/core/src/java/org/apache/lucene/index/TermVectorsConsumerPerField.java ## @@ -149,9 +149,6 @@ boolean start(IndexableField field,

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596374710 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -111,6 +111,43 @@ public FieldInfo( /** Performs internal consiste

[jira] [Commented] (LUCENE-9640) Add TrackingQuery to track matching documents

2021-03-17 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303720#comment-17303720 ] Uwe Schindler commented on LUCENE-9640: --- Elasticsearch has this functionality usin

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596378102 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -111,6 +111,43 @@ public FieldInfo( /** Performs internal consiste

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596378537 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596373649 ## File path: lucene/core/src/java/org/apache/lucene/index/TermVectorsConsumerPerField.java ## @@ -149,9 +149,6 @@ boolean start(IndexableField field,

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596387798 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596388076 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596387988 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596388235 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596388310 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596388510 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() { }

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596391496 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -796,167 +565,97 @@ public void add(FieldInfos other) { /** Creat

[GitHub] [lucene] mayya-sharipova commented on a change in pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
mayya-sharipova commented on a change in pull request #11: URL: https://github.com/apache/lucene/pull/11#discussion_r596397825 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -339,110 +350,17 @@ synchronized int addOrGet( String fieldNa

[GitHub] [lucene-solr] madrob commented on pull request #2403: SOLR-15164: Implement Task Management Interface

2021-03-17 Thread GitBox
madrob commented on pull request #2403: URL: https://github.com/apache/lucene-solr/pull/2403#issuecomment-801460550 Have you done performance testing with this? I'm concerned about how this could affect query throughput if we're funneling everything on a CHM --

[jira] [Created] (LUCENE-9850) Explore PFOR for Doc ID delta encoding (instead of FOR)

2021-03-17 Thread Greg Miller (Jira)
Greg Miller created LUCENE-9850: --- Summary: Explore PFOR for Doc ID delta encoding (instead of FOR) Key: LUCENE-9850 URL: https://issues.apache.org/jira/browse/LUCENE-9850 Project: Lucene - Core

[jira] [Commented] (LUCENE-9850) Explore PFOR for Doc ID delta encoding (instead of FOR)

2021-03-17 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303762#comment-17303762 ] Greg Miller commented on LUCENE-9850: - I've got a (somewhat hacky) tool in the works

[GitHub] [lucene] rmuir merged pull request #14: SOLR-15002: Upgrade httpclient to 4.5.13 and httpcore to 4.4.13

2021-03-17 Thread GitBox
rmuir merged pull request #14: URL: https://github.com/apache/lucene/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene] rmuir commented on pull request #20: LUCENE-9844: document disk layout of Lucene90VectorFormat

2021-03-17 Thread GitBox
rmuir commented on pull request #20: URL: https://github.com/apache/lucene/pull/20#issuecomment-801576257 these docs were helpful already to me in confirming what I thought I understood of the code about how sparsity and such was currently handled. Looking at the docs this way is an easy w

[GitHub] [lucene] rmuir commented on pull request #11: LUCENE-9334 Consistency of field data structures

2021-03-17 Thread GitBox
rmuir commented on pull request #11: URL: https://github.com/apache/lucene/pull/11#issuecomment-801583847 this problem is a hard one, it makes the manual review difficult. I think there is a pre-existing condition around this stuff with the tests, they are weak. It is part of what m

[jira] [Created] (LUCENE-9851) look at reducing depencies for lucene/replicator

2021-03-17 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9851: --- Summary: look at reducing depencies for lucene/replicator Key: LUCENE-9851 URL: https://issues.apache.org/jira/browse/LUCENE-9851 Project: Lucene - Core Issue

[jira] [Commented] (LUCENE-9851) look at reducing depencies for lucene/replicator

2021-03-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303835#comment-17303835 ] Robert Muir commented on LUCENE-9851: - Currently all dependencies in question (servl

[jira] [Commented] (LUCENE-9385) Skip indexing facet drill down terms

2021-03-17 Thread Zach Chen (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303886#comment-17303886 ] Zach Chen commented on LUCENE-9385: --- Hi [~goankur], I came across this issue and am wo