dweiss commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r651498995
##
File path: gradle/testing/alternative-jdk-support.gradle
##
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different Java
r
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363412#comment-17363412
]
Dawid Weiss commented on LUCENE-10003:
--
Hi David. I've used plenty of those style-
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861222097
Here is the results of the original pull request without the unsafe memory
copy, using the `fromArray()` and slicing code. During runtime, the benchmark
runs 72 seconds vs 60 se
zacharymorn commented on a change in pull request #180:
URL: https://github.com/apache/lucene/pull/180#discussion_r651468446
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexReader.java
##
@@ -310,6 +311,9 @@ public final int hashCode() {
*/
public abstrac
zacharymorn commented on a change in pull request #180:
URL: https://github.com/apache/lucene/pull/180#discussion_r651468301
##
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##
@@ -118,6 +121,65 @@ public final Fields getTermVectors(int docID)
zacharymorn commented on pull request #180:
URL: https://github.com/apache/lucene/pull/180#issuecomment-861193051
Thanks @jpountz for the review and suggestions! I have implemented the
`TermVectors` idea in
https://github.com/apache/lucene/pull/180/commits/0f8b0f49faab675b735c2c2f9713acdf1
[
https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10004:
-
Description:
In CompressingStoredFieldsWriter.merge(): if the segment meet the following
conditions:
{
[
https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10004:
-
Description:
In CompressingStoredFieldsWriter.merge(): if the segment meet the following
conditions:
{
[
https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kkewwei updated LUCENE-10004:
-
Description:
In CompressingStoredFieldsWriter.merge(): if the segment meet the following
conditions:
`
kkewwei created LUCENE-10004:
Summary: Delete unnecessary flush in
Lucene90CompressingStoredFieldsWriter.copyChunks() to reduce dirty chunks
Key: LUCENE-10004
URL: https://issues.apache.org/jira/browse/LUCENE-10004
gautamworah96 commented on a change in pull request #175:
URL: https://github.com/apache/lucene/pull/175#discussion_r651422401
##
File path: gradle/testing/alternative-jdk-support.gradle
##
@@ -18,60 +18,60 @@
// This adds support for compiling and testing against a different
gautamworah96 commented on a change in pull request #181:
URL: https://github.com/apache/lucene/pull/181#discussion_r651419099
##
File path: lucene/CHANGES.txt
##
@@ -127,6 +127,10 @@ API Changes
* LUCENE-8143: SpanBoostQuery has been removed. (Alan Woodward)
+* LUCENE-100
gautamworah96 commented on a change in pull request #181:
URL: https://github.com/apache/lucene/pull/181#discussion_r651418529
##
File path: lucene/core/src/java/org/apache/lucene/search/MultiCollector.java
##
@@ -25,13 +25,39 @@
/**
* A {@link Collector} which allows runnin
dnhatn opened a new pull request #182:
URL: https://github.com/apache/lucene/pull/182
The newly added
[assertion](https://github.com/apache/lucene/blob/50607e0fb9090a1321093aca4117b6560c511af0/lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingTermVectorsW
[
https://issues.apache.org/jira/browse/LUCENE-9145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-9145.
---
Fix Version/s: 9.0
Resolution: Fixed
Fine to close, I think there's been work done in other p
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861046986
I did more testig and was able to make MMapDirectory work the same speed.
This patch fixing the perf issue shows the problems:
https://github.com/uschindler/lucene/commit
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861046986
I did more testig and was able to make MMapDirectory work the same speed.
This patch fixing the perf issue shows the problems:
https://github.com/uschindler/lucene/commit
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861046986
I did more testig and was able to make MMapDirectory work the same speed.
This patch fixing the perf issue shows the problems:
https://github.com/uschindler/lucene/commit
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-861046986
I did more testig and was able to make MMapDirectory work the same speed.
This path shows the problems:
https://github.com/uschindler/lucene/commit/b057213cc6548ffa29b8e2810f39e
[
https://issues.apache.org/jira/browse/LUCENE-9983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363284#comment-17363284
]
Haoyu Zhai commented on LUCENE-9983:
{quote}Could you maybe open PR to add that init
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363221#comment-17363221
]
Robert Muir commented on LUCENE-10003:
--
In this particular case, i'm specifically
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363218#comment-17363218
]
Robert Muir commented on LUCENE-10003:
--
What is the bug caused by this? It is 100%
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363170#comment-17363170
]
David Smiley commented on LUCENE-10003:
---
I had IntelliJ check for this, and it ha
[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned LUCENE-10003:
-
Assignee: David Smiley
> Disallow C-style array declarations
> ---
David Smiley created LUCENE-10003:
-
Summary: Disallow C-style array declarations
Key: LUCENE-10003
URL: https://issues.apache.org/jira/browse/LUCENE-10003
Project: Lucene - Core
Issue Type: I
[
https://issues.apache.org/jira/browse/LUCENE-9145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363149#comment-17363149
]
David Smiley commented on LUCENE-9145:
--
Should this remain open or maybe close it a
[
https://issues.apache.org/jira/browse/LUCENE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved LUCENE-3973.
--
Resolution: Won't Fix
We use error-prone now. Closing this issue.
> Incorporate PMD / FindBu
[
https://issues.apache.org/jira/browse/LUCENE-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved LUCENE-7764.
--
Resolution: Won't Fix
We use "error-prone" instead now.
> Add FindBugs analysis to precommit
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-860900058
With my patch to bulk methods results look like this:
```
TaskQPS baseline StdDevQPS my_modified_version
StdDevPct diff p-
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-860889941
After analyzing the heap dumps provided by JFR, I was able to figure out
what the problem is.
Basically, all native, VarHandle backed methods are fast and optimize nice.
zhaih commented on pull request #163:
URL: https://github.com/apache/lucene/pull/163#issuecomment-860880755
Thank you @bruno-roustant for approving this, I've refined the javadoc
according to your comment
--
This is an automated message from the Apache Git Service.
To respond to the mess
uschindler removed a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-860731308
I used the wrong benchmark task (not wikimediumall but wikimedium10k,
copypastershitnwaste). New benchmarks coming soon.
--
This is an automated message from the Apach
uschindler edited a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-860641916
Hi,
I executed luceneutil bench using jdk-17-ea+b25:
```
TaskQPS baseline StdDevQPS my_modified_version
StdDevPc
[
https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363038#comment-17363038
]
ASF subversion and git services commented on LUCENE-9935:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363019#comment-17363019
]
Robert Muir commented on LUCENE-9935:
-
ah ok, sorry, i read the linked issues wrong.
[
https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363008#comment-17363008
]
Nhat Nguyen commented on LUCENE-9935:
-
Thanks [~rcmuir]. The change for term vectors
[
https://issues.apache.org/jira/browse/LUCENE-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363005#comment-17363005
]
kkewwei commented on LUCENE-9998:
-
It's my please to do it.
> The param 'fis' in Stored
[
https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir reopened LUCENE-9935:
-
Reopening as the term vectors support was reverted from main (but not 8.x?).
cc: [~dnhatn]
> Bulk
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-860731308
I used the wrong benchmark task (not wikimediumall but wikimedium10k,
copypastershitnwaste). New benchmarks coming soon.
--
This is an automated message from the Apache Git Se
uschindler removed a comment on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-860649214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
[
https://issues.apache.org/jira/browse/LUCENE-9996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362960#comment-17362960
]
Adrien Grand commented on LUCENE-9996:
--
Actually I didn't know/remember but Indexin
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-860665332
> I will now download the JFR files created by the tool and analyze them
locally.
No info from JFR files :-(
--
This is an automated message from the Apache Git Service
[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362937#comment-17362937
]
Greg Miller commented on LUCENE-10002:
--
+1. I also don't love that users can setup
[
https://issues.apache.org/jira/browse/LUCENE-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362936#comment-17362936
]
Greg Miller commented on LUCENE-10001:
--
[~jpountz] thanks for the feedback! The sp
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-860649214
I will now download the JFR files created by the tool and analyze them
locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/LUCENE-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362922#comment-17362922
]
Adrien Grand commented on LUCENE-9998:
--
I'm tempted to remove it as I can't think o
uschindler commented on pull request #177:
URL: https://github.com/apache/lucene/pull/177#issuecomment-860641916
Hi,
I executed luceneutil bench using jdk-17-ea+b25:
```
TaskQPS baseline StdDevQPS my_modified_version
StdDevPct diff
bszabo97 opened a new pull request #2513:
URL: https://github.com/apache/lucene-solr/pull/2513
https://issues.apache.org/jira/browse/SOLR-15378
# Description
Backup/restore doesn't support SimpleTextCodec and because of this
testFailedRestore in TestRestoreCore with given seed
uschindler commented on a change in pull request #177:
URL: https://github.com/apache/lucene/pull/177#discussion_r650824464
##
File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java
##
@@ -16,28 +16,17 @@
*/
package org.apache.lucene.store;
-import stat
uschindler commented on a change in pull request #177:
URL: https://github.com/apache/lucene/pull/177#discussion_r650822414
##
File path: lucene/core/src/java/org/apache/lucene/store/MMapDirectory.java
##
@@ -16,28 +16,17 @@
*/
package org.apache.lucene.store;
-import stat
bruno-roustant commented on a change in pull request #163:
URL: https://github.com/apache/lucene/pull/163#discussion_r650761025
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/StateSet.java
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundat
jpountz commented on a change in pull request #180:
URL: https://github.com/apache/lucene/pull/180#discussion_r650714447
##
File path: lucene/core/src/java/org/apache/lucene/index/BaseCompositeReader.java
##
@@ -118,6 +121,65 @@ public final Fields getTermVectors(int docID) thr
[
https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362813#comment-17362813
]
Adrien Grand commented on LUCENE-9959:
--
bq. Is the implementation what you are expe
dweiss commented on a change in pull request #163:
URL: https://github.com/apache/lucene/pull/163#discussion_r650372453
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/StateSet.java
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
gsmiller opened a new pull request #181:
URL: https://github.com/apache/lucene/pull/181
# Description
There could be use-cases where a user wants to terminate all wrapped
collectors in a MultiCollector when one terminates. Today, other collectors
continue collecting. For example, a
zacharymorn opened a new pull request #180:
URL: https://github.com/apache/lucene/pull/180
*This is a WIP PR for discussion only*
# Description
This PR is to try out the idea proposed in
https://github.com/apache/lucene/pull/137#issuecomment-840111367, and is for
discussion only
zhaih commented on a change in pull request #163:
URL: https://github.com/apache/lucene/pull/163#discussion_r650443185
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/StateSet.java
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mikemccand commented on a change in pull request #163:
URL: https://github.com/apache/lucene/pull/163#discussion_r650412326
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/StateSet.java
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation
dsmiley merged pull request #2510:
URL: https://github.com/apache/lucene-solr/pull/2510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
zacharymorn commented on a change in pull request #180:
URL: https://github.com/apache/lucene/pull/180#discussion_r650443353
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexReader.java
##
@@ -310,6 +311,9 @@ public final int hashCode() {
*/
public abstrac
dweiss merged pull request #178:
URL: https://github.com/apache/lucene/pull/178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
balmukundblr commented on pull request #132:
URL: https://github.com/apache/lucene/pull/132#issuecomment-859316131
@mikemccand
Mike, We've committed the code 4 days before and it still in Checking
phase. Ideally **'musedev'** should not take longer time. Looks like, there is
some probl
uschindler commented on pull request #173:
URL: https://github.com/apache/lucene/pull/173#issuecomment-859613146
> Is the plan to work on this and #177 in parallel until we know which is
the more sustainable option, or abandon this one altogether with expectations
that JDK 17 will be bette
16pierre commented on a change in pull request #1294:
URL: https://github.com/apache/lucene-solr/pull/1294#discussion_r649923783
##
File path: lucene/core/src/java/org/apache/lucene/search/SliceExecutor.java
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation
gautamworah96 opened a new pull request #179:
URL: https://github.com/apache/lucene/pull/179
# Description
In LUCENE-9450 we switched the Taxonomy index from Stored Fields to
BinaryDocValues. In the resulting implementation of the getPath code, we create
a new BinaryDocV
65 matches
Mail list logo
