[
https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363170#comment-17363170
]
David Smiley commented on LUCENE-10003:
---------------------------------------
I had IntelliJ check for this, and it happens in hundreds of spots. It can fix
them automatically as well. I'm happy to submit a PR to fix these.
I reported this to the Google Java Format plugin and they rejected the idea
because it's just a formatter of source code, and this matter isn't formatting
(strictly speaking). I figure the same fate might apply to suggesting it to
Spotless.
We can do this in {{error-prone.gradle}} via a config arg like so:
{{'-Xep:MixedArrayDimensions:ERROR'}}
Sadly our "error-prone" checks only run nightly but let's just add it here any
way?
> Disallow C-style array declarations
> -----------------------------------
>
> Key: LUCENE-10003
> URL: https://issues.apache.org/jira/browse/LUCENE-10003
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: David Smiley
> Priority: Minor
>
> The Google Java Format, that which we adhere to, disallows c-style array
> declarations: https://google.github.io/styleguide/javaguide.html#s4.8.3-arrays
> It's also known to "Error Prone":
> https://errorprone.info/bugpattern/MixedArrayDimensions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
