[ https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363218#comment-17363218 ]
Robert Muir commented on LUCENE-10003: -------------------------------------- What is the bug caused by this? It is 100% formatting. Please, if it is not actually static analysis detection of an actual problem, let's not enforce it in the build like this. Style crap like this can be enforced with spotless. Maybe it has an option for it already! If not, that is the correct place to add it. Error-prone is extremely slow, runs only nightly, has compatibility issues with java, and I'm not even sure it is doing anything for us. Most static analysis checks are being done with javac or ecj, which perform better and have integration options with IDEs. > Disallow C-style array declarations > ----------------------------------- > > Key: LUCENE-10003 > URL: https://issues.apache.org/jira/browse/LUCENE-10003 > Project: Lucene - Core > Issue Type: Improvement > Reporter: David Smiley > Assignee: David Smiley > Priority: Minor > > The Google Java Format, that which we adhere to, disallows c-style array > declarations: https://google.github.io/styleguide/javaguide.html#s4.8.3-arrays > It's also known to "Error Prone": > https://errorprone.info/bugpattern/MixedArrayDimensions -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org