zacharymorn commented on a change in pull request #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r692722475
##
File path:
lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/tasks/ReadTask.java
##
@@ -180,6 +185,7 @@ protected int withTopDocs(IndexSea
zacharymorn commented on a change in pull request #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r692722544
##
File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java
##
@@ -527,7 +503,10 @@ public TopDocs search(Query query, int n) throws
zacharymorn commented on pull request #240:
URL: https://github.com/apache/lucene/pull/240#issuecomment-902489306
> Left a few comments. Looks good overall. Lots of little changes! Those
test cases... :)
Thanks @gsmiller for the review! Yes there are indeed many small changes,
and m
mikemccand commented on pull request #254:
URL: https://github.com/apache/lucene/pull/254#issuecomment-902651596
In the mean time, @dungba88 could you please also open a backport PR for
Lucene/Solr 8.x? It is a different git repository
(https://github.com/apache/lucene-solr/tree/branch_8x
mikemccand merged pull request #254:
URL: https://github.com/apache/lucene/pull/254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
[
https://issues.apache.org/jira/browse/LUCENE-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402181#comment-17402181
]
ASF subversion and git services commented on LUCENE-10059:
--
Co
mikemccand commented on a change in pull request #179:
URL: https://github.com/apache/lucene/pull/179#discussion_r69227
##
File path: lucene/CHANGES.txt
##
@@ -137,6 +137,9 @@ API Changes
Improvements
+* LUCENE-9476: Add new getBulkPath API to DirectoryTaxonomyReader t
[
https://issues.apache.org/jira/browse/LUCENE-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402203#comment-17402203
]
Greg Miller commented on LUCENE-9918:
-
[~gworah] could be worth trying. I wasn't awa
[
https://issues.apache.org/jira/browse/LUCENE-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402212#comment-17402212
]
Greg Miller commented on LUCENE-9969:
-
[~chengfengfeng] did you see [~gworah]'s sugg
[
https://issues.apache.org/jira/browse/LUCENE-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller reassigned LUCENE-5309:
---
Assignee: Greg Miller
> when using SortedSetDV faceting, specialize the case when all docs
[
https://issues.apache.org/jira/browse/LUCENE-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402235#comment-17402235
]
Greg Miller commented on LUCENE-5309:
-
This is a small change and I'll give it a try
dungba88 commented on pull request #254:
URL: https://github.com/apache/lucene/pull/254#issuecomment-902731868
@mikemccand Thanks for reviewing and merging! I'll prepare a backport PR for
version 8.x
--
This is an automated message from the Apache Git Service.
To respond to the message,
dungba88 opened a new pull request #2557:
URL: https://github.com/apache/lucene-solr/pull/2557
# Description
This is a backport of https://github.com/apache/lucene/pull/254
There is an issue which causes an `AssertionError` in the backtrace step of
`JapaneseTokenizer`. If ther
dungba88 commented on pull request #254:
URL: https://github.com/apache/lucene/pull/254#issuecomment-902748267
I've opened a backport PR for 8.x:
https://github.com/apache/lucene-solr/pull/2557
--
This is an automated message from the Apache Git Service.
To respond to the message, please
msokolov commented on pull request #251:
URL: https://github.com/apache/lucene/pull/251#issuecomment-902778915
OK, so it's a real weird behavior that manifests for very large K or very
small N, weird cases. I agree, let's relax the assertion. I am not sure this
will be fixed by a multi-lev
msokolov commented on a change in pull request #251:
URL: https://github.com/apache/lucene/pull/251#discussion_r693039774
##
File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java
##
@@ -350,7 +350,9 @@ public void testDeletes() throws IOException {
msokolov commented on a change in pull request #250:
URL: https://github.com/apache/lucene/pull/250#discussion_r693041906
##
File path: lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java
##
@@ -56,22 +56,28 @@
public final class HnswGraph extends KnnGraphValues {
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402289#comment-17402289
]
Michael Sokolov commented on LUCENE-10054:
--
Thanks for looking into this!
cou
[
https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402311#comment-17402311
]
Greg Miller commented on LUCENE-10033:
--
HI [~weizijun], just my opinion, but I thi
[
https://issues.apache.org/jira/browse/LUCENE-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402385#comment-17402385
]
Michael McCandless commented on LUCENE-5309:
Woot! Thanks [~gsmiller]!
> w
[
https://issues.apache.org/jira/browse/LUCENE-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402386#comment-17402386
]
Greg Miller commented on LUCENE-5309:
-
Hmm, well it looks like there might be a nice
gsmiller opened a new pull request #255:
URL: https://github.com/apache/lucene/pull/255
# Description
This change introduces special-case logic when facet counting on a
`SortedDocValues` field. Instead of using the more-general logic that supports
multi-valued fields (i.e., `SortedS
gsmiller commented on a change in pull request #255:
URL: https://github.com/apache/lucene/pull/255#discussion_r693177246
##
File path: lucene/core/src/java/org/apache/lucene/index/MultiDocValues.java
##
@@ -82,7 +82,6 @@ public int nextDoc() throws IOException {
i
gsmiller commented on a change in pull request #255:
URL: https://github.com/apache/lucene/pull/255#discussion_r693177372
##
File path: lucene/core/src/java/org/apache/lucene/index/MultiDocValues.java
##
@@ -452,7 +449,6 @@ public static SortedNumericDocValues getSortedNumericV
gsmiller commented on a change in pull request #255:
URL: https://github.com/apache/lucene/pull/255#discussion_r693177498
##
File path: lucene/core/src/java/org/apache/lucene/index/MultiDocValues.java
##
@@ -680,9 +673,9 @@ public static SortedSetDocValues getSortedSetValues(fi
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401172#comment-17401172
]
Mayya Sharipova edited comment on LUCENE-10054 at 8/20/21, 7:39 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401172#comment-17401172
]
Mayya Sharipova edited comment on LUCENE-10054 at 8/20/21, 7:40 PM:
-
[
https://issues.apache.org/jira/browse/LUCENE-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402399#comment-17402399
]
Mayya Sharipova commented on LUCENE-10054:
--
[~sokolov] Thanks your for your fe
gsmiller commented on a change in pull request #255:
URL: https://github.com/apache/lucene/pull/255#discussion_r693200369
##
File path: lucene/CHANGES.txt
##
@@ -415,6 +415,8 @@ Improvements
This prevents caching a query clause when it is much more expensive than
running
[
https://issues.apache.org/jira/browse/LUCENE-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402405#comment-17402405
]
Greg Miller commented on LUCENE-5309:
-
Went ahead and put a [PR|https://github.com/a
[
https://issues.apache.org/jira/browse/LUCENE-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-5309:
Status: Patch Available (was: Open)
> when using SortedSetDV faceting, specialize the case when a
[
https://issues.apache.org/jira/browse/LUCENE-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402411#comment-17402411
]
ASF subversion and git services commented on LUCENE-10017:
--
Co
madrob merged pull request #200:
URL: https://github.com/apache/lucene/pull/200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/LUCENE-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-10017.
Fix Version/s: main (9.0)
Assignee: Mike Drob
Resolution: Fixed
> Do not check fo
[
https://issues.apache.org/jira/browse/LUCENE-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17402468#comment-17402468
]
Greg Miller commented on LUCENE-5309:
-
I kicked off a run of {{wikimediumall}} as we
35 matches
Mail list logo
