zacharymorn edited a comment on pull request #588:
URL: https://github.com/apache/lucene/pull/588#issuecomment-1010702372
Thanks @jtibshirani for the suggestions here! I have a few follow-up
questions:
> @zacharymorn here's my understanding of our usual strategy: on every
branch of
zacharymorn commented on pull request #588:
URL: https://github.com/apache/lucene/pull/588#issuecomment-1010702372
Thanks @jtibshirani for the suggestions here! I have a few follow-up
questions:
> @zacharymorn here's my understanding of our usual strategy: on every
branch of the sam
gf2121 edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1010612581
@uschindler Thank you for the benchmark guidance!
I made a new change in this
[commit](https://github.com/apache/lucene/pull/592/commits/347fdb13d60f620064290123f5122e
gf2121 edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1010612581
@uschindler Thank you for the benchmark guidance!
I made a new change in this
[commit](https://github.com/apache/lucene/pull/592/commits/347fdb13d60f620064290123f5122e
spike-liu commented on a change in pull request #464:
URL: https://github.com/apache/lucene/pull/464#discussion_r782719816
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectDocValuesProducer.java
##
@@ -0,0 +1,910 @@
+/*
+ * Licensed to the Apache Soft
spike-liu commented on a change in pull request #464:
URL: https://github.com/apache/lucene/pull/464#discussion_r782719730
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectDocValuesConsumer.java
##
@@ -0,0 +1,1101 @@
+/*
+ * Licensed to the Apache Sof
gf2121 edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1010612581
@uschindler Thank you for the benchmark guidance!
I made a new change in this
[commit](https://github.com/apache/lucene/pull/592/commits/347fdb13d60f620064290123f5122e
dsmiley commented on pull request #1703:
URL: https://github.com/apache/lucene-solr/pull/1703#issuecomment-1010632734
This PR has been moved and updated: https://github.com/apache/solr/pull/517
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dsmiley closed pull request #1703:
URL: https://github.com/apache/lucene-solr/pull/1703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
gf2121 edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1010612581
@uschindler Thank you for the benchmark guidance!
I made a new change in this
[commit](https://github.com/apache/lucene/pull/592/commits/347fdb13d60f620064290123f5122e
gf2121 commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1010612581
@uschindler Thank you for the benchmark guidance!
I made a new change in this
[commit](https://github.com/apache/lucene/pull/592/commits/347fdb13d60f620064290123f5122e6ea78ac
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473238#comment-17473238
]
Cameron VandenBerg commented on LUCENE-10157:
-
Hi [~jpountz], when I origin
[
https://issues.apache.org/jira/browse/LUCENE-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani reassigned LUCENE-9583:
Assignee: Julie Tibshirani
> How should we expose VectorValues.RandomAccess?
> --
Greg Miller created LUCENE-10373:
Summary: Can we optimize TaxonomyFacetSumIntAssociations#sumValues?
Key: LUCENE-10373
URL: https://issues.apache.org/jira/browse/LUCENE-10373
Project: Lucene - Core
jtibshirani commented on pull request #588:
URL: https://github.com/apache/lucene/pull/588#issuecomment-1010270045
@zacharymorn here's my understanding of our usual strategy: on every branch
of the same major release, the change always appears under the same release
(like `9.1.0`), corresp
gf2121 commented on pull request #541:
URL: https://github.com/apache/lucene/pull/541#issuecomment-101025
Thanks @jpountz !
> I'd be curious to see how it would compare with a similar approach where
we would use an int[] to hold the doc IDs instead of longs.
I wrote a simp
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472965#comment-17472965
]
Adrien Grand commented on LUCENE-10157:
---
Indeed forking the code means that both
jpountz commented on a change in pull request #541:
URL: https://github.com/apache/lucene/pull/541#discussion_r782366414
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDForUtil.java
##
@@ -0,0 +1,126 @@
+// This file has been automatically generated, DO NOT EDI
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472952#comment-17472952
]
Cameron VandenBerg commented on LUCENE-10157:
-
I like your idea of forking
[
https://issues.apache.org/jira/browse/LUCENE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472945#comment-17472945
]
Adrien Grand commented on LUCENE-10367:
---
I wonder if this could be handled by a r
jpountz commented on a change in pull request #578:
URL: https://github.com/apache/lucene/pull/578#discussion_r782360467
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##
@@ -74,11 +74,6 @@ protected boolean useHashTable(FacetsColle
[
https://issues.apache.org/jira/browse/LUCENE-10157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472866#comment-17472866
]
Adrien Grand commented on LUCENE-10157:
---
I understand you don't like this option
freedev closed pull request #1034:
URL: https://github.com/apache/lucene-solr/pull/1034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
[
https://issues.apache.org/jira/browse/LUCENE-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-10288:
--
Priority: Blocker (was: Major)
> Are 1-dimensional kd trees in pre-86 indices always unbalan
[
https://issues.apache.org/jira/browse/LUCENE-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-10288:
--
Fix Version/s: 9.1
> Are 1-dimensional kd trees in pre-86 indices always unbalanced trees?
>
gsmiller commented on pull request #597:
URL: https://github.com/apache/lucene/pull/597#issuecomment-1010090864
Note that we also [moved to JDK
17](https://github.com/apache/lucene/commit/2ebc57a465fc584cf2242765898290a6c2f0f420)
yesterday as well. While changes specifically to taxo-faceti
gsmiller commented on pull request #597:
URL: https://github.com/apache/lucene/pull/597#issuecomment-1010061194
Let's not jump to reverting this change too hastily. It would be nice to
reproduce the regressions locally and try to understand what's going on a
little more. It seems very coun
mayya-sharipova commented on pull request #598:
URL: https://github.com/apache/lucene/pull/598#issuecomment-1010045372
a great guide! Thanks for composing it, Adrien!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
mayya-sharipova commented on pull request #536:
URL: https://github.com/apache/lucene/pull/536#issuecomment-1010033192
@jtibshirani Thanks for the guide on the format change, I will study it and
follow it.
Indeed this PR was merged into the `hnsw` branch, so we will do the format
change
[
https://issues.apache.org/jira/browse/LUCENE-10369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472776#comment-17472776
]
ASF subversion and git services commented on LUCENE-10369:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-10369.
---
Fix Version/s: 9.1
Resolution: Fixed
Thanks [~grcevski] , in particular for adding a
[
https://issues.apache.org/jira/browse/LUCENE-10369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472769#comment-17472769
]
ASF subversion and git services commented on LUCENE-10369:
--
Co
jpountz merged pull request #596:
URL: https://github.com/apache/lucene/pull/596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
jpountz merged pull request #598:
URL: https://github.com/apache/lucene/pull/598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
jpountz commented on a change in pull request #416:
URL: https://github.com/apache/lucene/pull/416#discussion_r782157204
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsFormat.java
##
@@ -54,13 +63,19 @@
* [int32] vector similarity f
jpountz commented on pull request #416:
URL: https://github.com/apache/lucene/pull/416#issuecomment-1009970568
Sorry @mayya-sharipova I had missed your ping. I realize we don't have good
guidelines on writing file formats so I started something at
https://github.com/apache/lucene/pull/598.
uschindler edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009921377
The param must go away or change - to +. Mike's commit fixed the tiered
compilation problem and I was not sure if you have used his latest commit.
To get better pr
uschindler commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009921377
The param must go away or change - to +. Mike's commit fixed the tieren
compilation problem and I was not sure if you have used his latest commit.
To get better predicata
gf2121 edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009907675
Thanks @jpountz @uschindler , this is the benchmark result based on the
newest codes
```
TaskQPS baseline StdDevQPS
my_modified_ve
gf2121 edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009907675
Thanks @jpountz @uschindler , this is the benchmark result based on the
newest codes
```
TaskQPS baseline StdDevQPS
my_modified_ve
gf2121 commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009907675
Thanks @jpountz @uschindler , this is the benchmark result based on the
newest result
```
TaskQPS baseline StdDevQPS
my_modified_version
gf2121 closed pull request #592:
URL: https://github.com/apache/lucene/pull/592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
mocobeta commented on pull request #567:
URL: https://github.com/apache/lucene/pull/567#issuecomment-1009901254
> I can't look closely at or review the whole change soon since I have to
leave for a while (my father just passed away due to old age and lots of work
is waiting for me), so ple
jpountz commented on a change in pull request #464:
URL: https://github.com/apache/lucene/pull/464#discussion_r781979863
##
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/memory/DirectDocValuesProducer.java
##
@@ -0,0 +1,910 @@
+/*
+ * Licensed to the Apache Softwa
uschindler edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009767556
The problem here is that we just reducing the number of guard checks and at
same time raising the risk to segv: ReadVint uses multiple atomic reads and all
of those read
uschindler edited a comment on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009767556
The problem here is that we just reducing the number of guard checks and at
same time raising the risk to segv: ReadVint uses multiple atomic reads and all
of those read
uschindler commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009767556
The problem here is that we just reducing the number of guard checks bit
raising the risk to segv. Read int uses multiple atomic reads and all of those
reads can segv.
S
jpountz commented on pull request #592:
URL: https://github.com/apache/lucene/pull/592#issuecomment-1009750876
Thanks @gf2121 the implementation looks correct to me now. Are you still
seeing a good speedup with this change?
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/LUCENE-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472589#comment-17472589
]
ASF subversion and git services commented on LUCENE-10370:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472586#comment-17472586
]
ASF subversion and git services commented on LUCENE-10370:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472552#comment-17472552
]
ASF subversion and git services commented on LUCENE-10370:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472551#comment-17472551
]
ASF subversion and git services commented on LUCENE-10370:
--
Co
gf2121 opened a new pull request #597:
URL: https://github.com/apache/lucene/pull/597
link:
https://home.apache.org/~mikemccand/lucenebench/2022.01.10.18.03.12.html
```
BrowseDayOfYearTaxoFacets7.6 (12.1%) 6.3 (26.7%) 0.8 X 0.010
BrowseDateTaxoFacets 7.6 (
53 matches
Mail list logo
