[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-05-18 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r876602835 ## lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/HyperRectangleFacetCounts.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [lucene] mocobeta commented on a diff in pull request #904: LUCENE-10312: Revert changes in PersianAnalyzer

2022-05-18 Thread GitBox
mocobeta commented on code in PR #904: URL: https://github.com/apache/lucene/pull/904#discussion_r876545144 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/fa/TestPersianStemFilter.java: ## @@ -32,7 +32,14 @@ public class TestPersianStemFilter extends BaseTokenStr

[GitHub] [lucene] mocobeta commented on a diff in pull request #904: LUCENE-10312: Revert changes in PersianAnalyzer

2022-05-18 Thread GitBox
mocobeta commented on code in PR #904: URL: https://github.com/apache/lucene/pull/904#discussion_r876540849 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/fa/PersianAnalyzer.java: ## @@ -136,11 +121,7 @@ protected TokenStreamComponents createComponents(String fie

[jira] [Commented] (LUCENE-10312) Add PersianStemmer

2022-05-18 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539169#comment-17539169 ] Tomoko Uchida commented on LUCENE-10312: [~romseygeek] thanks for noticing this

[GitHub] [lucene] mocobeta opened a new pull request, #904: LUCENE-10312: Revert changes in PersianAnalyzer

2022-05-18 Thread GitBox
mocobeta opened a new pull request, #904: URL: https://github.com/apache/lucene/pull/904 This reverts changes in PersianAnalyzer #540 from 9x branch. Users who want to use the new PersianStemmer in 9.x will be able to customer analyzer on their own. -- This is an automated message from

[jira] [Reopened] (LUCENE-10312) Add PersianStemmer

2022-05-18 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida reopened LUCENE-10312: > Add PersianStemmer > -- > > Key: LUCENE-10312 >

[GitHub] [lucene] rmuir commented on pull request #903: LUCENE-10579: fix smoketester backwards-check to not parse stdout

2022-05-18 Thread GitBox
rmuir commented on PR #903: URL: https://github.com/apache/lucene/pull/903#issuecomment-1130814798 See JIRA issue for more background and example data files: https://issues.apache.org/jira/browse/LUCENE-10579 When reviewing the code, it may not be obvious that currently we are parsing

[jira] [Commented] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-05-18 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539132#comment-17539132 ] Julie Tibshirani commented on LUCENE-10527: --- The nightly search and indexing

[jira] [Updated] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-05-18 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10527: -- Attachment: Screen Shot 2022-05-18 at 4.27.37 PM.png > Use bigger maxConn for last la

[jira] [Updated] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-05-18 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10527: -- Attachment: Screen Shot 2022-05-18 at 4.26.24 PM.png > Use bigger maxConn for last la

[jira] [Updated] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-05-18 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10527: -- Attachment: Screen Shot 2022-05-18 at 4.26.14 PM.png > Use bigger maxConn for last la

[jira] [Updated] (LUCENE-10527) Use bigger maxConn for last layer in HNSW

2022-05-18 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani updated LUCENE-10527: -- Description: Recently I was rereading the HNSW paper ([https://arxiv.org/pdf/1603.09

[jira] [Commented] (LUCENE-10569) Think again about the floor segment size?

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539116#comment-17539116 ] Robert Muir commented on LUCENE-10569: -- I agree. same with the stored fields stuff

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539096#comment-17539096 ] ASF subversion and git services commented on LUCENE-10574: -- Co

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539095#comment-17539095 ] ASF subversion and git services commented on LUCENE-10574: -- Co

[jira] [Commented] (LUCENE-10312) Add PersianStemmer

2022-05-18 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539092#comment-17539092 ] Alan Woodward commented on LUCENE-10312: Hi, it looks like this adds the new Pe

[jira] [Updated] (LUCENE-10569) Think again about the floor segment size?

2022-05-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-10569: -- Description: TieredMergePolicy has a floor segment size that it uses to prevent indexes from

[jira] [Reopened] (LUCENE-10569) Think again about the floor segment size?

2022-05-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand reopened LUCENE-10569: --- Reopening: O(n^2) behavior went away (LUCENE-10574), but we still need to think about this flo

[jira] [Resolved] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10574. --- Fix Version/s: 9.3 Resolution: Fixed > Remove O(n^2) from TieredMergePolicy or chang

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539080#comment-17539080 ] ASF subversion and git services commented on LUCENE-10574: -- Co

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539079#comment-17539079 ] ASF subversion and git services commented on LUCENE-10574: -- Co

[GitHub] [lucene] jpountz merged pull request #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
jpountz merged PR #900: URL: https://github.com/apache/lucene/pull/900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[GitHub] [lucene] rmuir opened a new pull request, #903: LUCENE-10579: fix smoketester backwards-check to not parse stdout

2022-05-18 Thread GitBox
rmuir opened a new pull request, #903: URL: https://github.com/apache/lucene/pull/903 This is very noisy, can contain gradle status updates, various other `tests.verbose` prints from other threads, you name it. It causes the check to be flaky, and randomly "miss" seeing a test that e

[jira] [Updated] (LUCENE-10579) fix smoketester backwards-check to not parse stdout

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10579: - Fix Version/s: 9.3 > fix smoketester backwards-check to not parse stdout >

[GitHub] [lucene] dweiss commented on pull request #901: remove commented-out/obselete AwaitsFix

2022-05-18 Thread GitBox
dweiss commented on PR #901: URL: https://github.com/apache/lucene/pull/901#issuecomment-1130485931 I'll take a look at TestMatchRegionRetriever tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-05-18 Thread GitBox
mdmarshmallow commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r876142339 ## lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/HyperRectangleFacetCounts.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-05-18 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r876315286 ## lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/HyperRectangle.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Commented] (LUCENE-10579) fix smoketester backwards-check to not parse stdout

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539050#comment-17539050 ] Robert Muir commented on LUCENE-10579: -- or even maybe a gradle status update with

[jira] [Commented] (LUCENE-10579) fix smoketester backwards-check to not parse stdout

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539042#comment-17539042 ] Robert Muir commented on LUCENE-10579: -- There's all kinds of stuff being printed,

[jira] [Commented] (LUCENE-10579) fix smoketester backwards-check to not parse stdout

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539040#comment-17539040 ] Robert Muir commented on LUCENE-10579: -- I attached compressed file of what the smo

[jira] [Updated] (LUCENE-10579) fix smoketester backwards-check to not parse stdout

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10579: - Attachment: backwards.log.gz > fix smoketester backwards-check to not parse stdout > --

[jira] [Created] (LUCENE-10579) fix smoketester backwards-check to not parse stdout

2022-05-18 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10579: Summary: fix smoketester backwards-check to not parse stdout Key: LUCENE-10579 URL: https://issues.apache.org/jira/browse/LUCENE-10579 Project: Lucene - Core

[GitHub] [lucene] jtibshirani commented on pull request #873: LUCENE-10397: KnnVectorQuery doesn't tie break by doc ID

2022-05-18 Thread GitBox
jtibshirani commented on PR #873: URL: https://github.com/apache/lucene/pull/873#issuecomment-1130368325 > I feel less strongly about this part so I'm happy to follow the re-sorting approach if tie-breaking by doc ID as part of the HNSW search proves controversial. I also don't feel

[GitHub] [lucene-solr] madrob merged pull request #2655: SOLR-16143 SolrConfig ResourceProvider can miss updates from ZooKeeper

2022-05-18 Thread GitBox
madrob merged PR #2655: URL: https://github.com/apache/lucene-solr/pull/2655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[jira] [Comment Edited] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?

2022-05-18 Thread Deepika Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538981#comment-17538981 ] Deepika Sharma edited comment on LUCENE-10544 at 5/18/22 5:36 PM: ---

[jira] [Commented] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?

2022-05-18 Thread Deepika Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538981#comment-17538981 ] Deepika Sharma commented on LUCENE-10544: - Thanks [~jpountz] for sharing this a

[jira] [Comment Edited] (LUCENE-10544) Should ExitableTermsEnum wrap postings and impacts?

2022-05-18 Thread Deepika Sharma (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529965#comment-17529965 ] Deepika Sharma edited comment on LUCENE-10544 at 5/18/22 5:34 PM: ---

[GitHub] [lucene] shahrs87 commented on a diff in pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-18 Thread GitBox
shahrs87 commented on code in PR #898: URL: https://github.com/apache/lucene/pull/898#discussion_r876161864 ## lucene/CHANGES.txt: ## @@ -40,7 +40,7 @@ Improvements Optimizations - -(No changes) +* LUCENE-8519 MultiDocValues.getNormValues should not call

[GitHub] [lucene] dsmiley commented on a diff in pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-18 Thread GitBox
dsmiley commented on code in PR #898: URL: https://github.com/apache/lucene/pull/898#discussion_r876148753 ## lucene/CHANGES.txt: ## @@ -40,7 +40,7 @@ Improvements Optimizations - -(No changes) +* LUCENE-8519 MultiDocValues.getNormValues should not call g

[GitHub] [lucene] LuXugang commented on pull request #873: LUCENE-10397: KnnVectorQuery doesn't tie break by doc ID

2022-05-18 Thread GitBox
LuXugang commented on PR #873: URL: https://github.com/apache/lucene/pull/873#issuecomment-1130265413 > `Integer.MAX_VALUE - node` Thanks @jpountz , this idea is really great, it is a good way to keep high 32 bit always 0 so that it made node will not affect the sort logic by score.

[GitHub] [lucene] shahrs87 commented on a diff in pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-18 Thread GitBox
shahrs87 commented on code in PR #898: URL: https://github.com/apache/lucene/pull/898#discussion_r876089065 ## lucene/CHANGES.txt: ## @@ -38,6 +38,8 @@ Improvements * LUCENE-10416: Update Korean Dictionary to mecab-ko-dic-2.1.1-20180720 for Nori. (Uihyun Kim) +* LUCENE-85

[GitHub] [lucene] shahrs87 opened a new pull request, #902: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-18 Thread GitBox
shahrs87 opened a new pull request, #902: URL: https://github.com/apache/lucene/pull/902 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach ta

[GitHub] [lucene] shahrs87 commented on a diff in pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-18 Thread GitBox
shahrs87 commented on code in PR #898: URL: https://github.com/apache/lucene/pull/898#discussion_r876075120 ## lucene/CHANGES.txt: ## @@ -40,7 +40,7 @@ Improvements Optimizations - -(No changes) +* LUCENE-8519 MultiDocValues.getNormValues should not call

[jira] [Updated] (LUCENE-9409) TestAllFilesDetectTruncation failures

2022-05-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9409: - Fix Version/s: 9.3 (was: 9.2) > TestAllFilesDetectTruncation failures > -

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-18 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538904#comment-17538904 ] Mike Drob commented on LUCENE-10481: The relevant results are part of https://githu

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538891#comment-17538891 ] Michael McCandless commented on LUCENE-10481: - {quote}Hmm... some slightly

[jira] [Commented] (LUCENE-10481) FacetsCollector does not need scores when not keeping them

2022-05-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538889#comment-17538889 ] Michael McCandless commented on LUCENE-10481: - I think the reason why it ma

[GitHub] [lucene] rmuir commented on pull request #901: remove commented-out/obselete AwaitsFix

2022-05-18 Thread GitBox
rmuir commented on PR #901: URL: https://github.com/apache/lucene/pull/901#issuecomment-1130101538 FYI there are only 6 `@AwaitsFix` tests left: * `TestICUTokenizerCJK`: we are really actually waiting on a third-party fix, i checked ICU bugtracker and adrien's bug is still open. we just h

[jira] [Comment Edited] (LUCENE-10578) Make minimum required Java version for build more specific

2022-05-18 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538867#comment-17538867 ] Tomoko Uchida edited comment on LUCENE-10578 at 5/18/22 2:14 PM:

[GitHub] [lucene] mikemccand commented on a diff in pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-18 Thread GitBox
mikemccand commented on code in PR #898: URL: https://github.com/apache/lucene/pull/898#discussion_r875952557 ## lucene/core/src/java/org/apache/lucene/index/MultiDocValues.java: ## @@ -53,8 +53,18 @@ public static NumericDocValues getNormValues(final IndexReader r, final Strin

[jira] [Commented] (LUCENE-10578) Make minimum required Java version for build more specific

2022-05-18 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538867#comment-17538867 ] Tomoko Uchida commented on LUCENE-10578: Thanks [~rcmuir] for your comments, an

[GitHub] [lucene] mikemccand commented on a diff in pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-18 Thread GitBox
mikemccand commented on code in PR #898: URL: https://github.com/apache/lucene/pull/898#discussion_r875951319 ## lucene/CHANGES.txt: ## @@ -40,7 +40,7 @@ Improvements Optimizations - -(No changes) +* LUCENE-8519 MultiDocValues.getNormValues should not cal

[GitHub] [lucene] rmuir opened a new pull request, #901: remove commented-out/obselete AwaitsFix

2022-05-18 Thread GitBox
rmuir opened a new pull request, #901: URL: https://github.com/apache/lucene/pull/901 All of these issues are fixed, but the AwaitsFix annotation is still there, just commented out. This causes confusion and makes it harder to keep an eye/review the AwaitsFix tests, e.g. false posit

[jira] [Commented] (LUCENE-9409) TestAllFilesDetectTruncation failures

2022-05-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538851#comment-17538851 ] ASF subversion and git services commented on LUCENE-9409: - Commi

[jira] [Resolved] (LUCENE-9409) TestAllFilesDetectTruncation failures

2022-05-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-9409. -- Fix Version/s: 9.2 Resolution: Fixed > TestAllFilesDetectTruncation failures >

[jira] [Commented] (LUCENE-9409) TestAllFilesDetectTruncation failures

2022-05-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538849#comment-17538849 ] ASF subversion and git services commented on LUCENE-9409: - Commi

[GitHub] [lucene] jpountz merged pull request #896: LUCENE-9409: Reenable TestAllFilesDetectTruncation.

2022-05-18 Thread GitBox
jpountz merged PR #896: URL: https://github.com/apache/lucene/pull/896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[GitHub] [lucene] mikemccand commented on a diff in pull request #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
mikemccand commented on code in PR #900: URL: https://github.com/apache/lucene/pull/900#discussion_r875924090 ## lucene/core/src/java/org/apache/lucene/index/LogMergePolicy.java: ## @@ -582,23 +589,29 @@ public MergeSpecification findMerges( if (anyMerging) {

[GitHub] [lucene] mikemccand commented on a diff in pull request #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
mikemccand commented on code in PR #900: URL: https://github.com/apache/lucene/pull/900#discussion_r875923145 ## lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java: ## @@ -532,13 +532,21 @@ private MergeSpecification doFindMerges( // segments, and alrea

[GitHub] [lucene] dweiss commented on a diff in pull request #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
dweiss commented on code in PR #900: URL: https://github.com/apache/lucene/pull/900#discussion_r875895539 ## lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMergePolicy.java: ## @@ -310,22 +365,18 @@ private void checkInvariants(IndexWriter writer) throws IOExceptio

[GitHub] [lucene] dweiss commented on a diff in pull request #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
dweiss commented on code in PR #900: URL: https://github.com/apache/lucene/pull/900#discussion_r875894329 ## lucene/core/src/java/org/apache/lucene/index/LogMergePolicy.java: ## @@ -582,23 +589,29 @@ public MergeSpecification findMerges( if (anyMerging) { //

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538835#comment-17538835 ] Dawid Weiss commented on LUCENE-10574: -- I like [~jpountz]'s solution... even if it

[GitHub] [lucene] jpountz commented on a diff in pull request #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
jpountz commented on code in PR #900: URL: https://github.com/apache/lucene/pull/900#discussion_r875876270 ## lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java: ## @@ -532,13 +532,21 @@ private MergeSpecification doFindMerges( // segments, and already

[GitHub] [lucene-solr] gus-asf merged pull request #2658: SOLR-16194 Backport from solr project main, excluding new method that throws, per discussion.

2022-05-18 Thread GitBox
gus-asf merged PR #2658: URL: https://github.com/apache/lucene-solr/pull/2658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] jpountz commented on a diff in pull request #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
jpountz commented on code in PR #900: URL: https://github.com/apache/lucene/pull/900#discussion_r875848606 ## lucene/core/src/java/org/apache/lucene/index/LogMergePolicy.java: ## @@ -582,23 +589,29 @@ public MergeSpecification findMerges( if (anyMerging) { //

[GitHub] [lucene] mikemccand commented on a diff in pull request #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
mikemccand commented on code in PR #900: URL: https://github.com/apache/lucene/pull/900#discussion_r875839832 ## lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java: ## @@ -532,13 +532,21 @@ private MergeSpecification doFindMerges( // segments, and alrea

[GitHub] [lucene] jpountz commented on pull request #873: LUCENE-10397: KnnVectorQuery doesn't tie break by doc ID

2022-05-18 Thread GitBox
jpountz commented on PR #873: URL: https://github.com/apache/lucene/pull/873#issuecomment-1129949546 Good question. In my opinion, the part that is important is that the TopDocs returned by `KnnVectorsReader#search` are ordered by score then doc ID. Otherwise logic like `TopDocs#merge` woul

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538797#comment-17538797 ] Michael McCandless commented on LUCENE-10574: - If any one finally gives a t

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538787#comment-17538787 ] Michael McCandless commented on LUCENE-10574: - I like [~jpountz]'s approach

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538780#comment-17538780 ] Robert Muir commented on LUCENE-10574: -- Yes, that's awesome. I think if we go with

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538778#comment-17538778 ] Adrien Grand commented on LUCENE-10574: --- Correct: 3 docs at a time with a 50% con

[GitHub] [lucene] rmuir commented on a diff in pull request #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
rmuir commented on code in PR #900: URL: https://github.com/apache/lucene/pull/900#discussion_r875797459 ## lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java: ## @@ -1009,69 +1007,6 @@ protected synchronized boolean maybeStall(MergeSource mergeSour

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538767#comment-17538767 ] Robert Muir commented on LUCENE-10574: -- what is "flushed 3 by 3". flushing 3 docs

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538760#comment-17538760 ] Adrien Grand commented on LUCENE-10574: --- It might not be the best approach, but t

[GitHub] [lucene] jpountz opened a new pull request, #900: LUCENE-10574: Prevent pathological merging.

2022-05-18 Thread GitBox
jpountz opened a new pull request, #900: URL: https://github.com/apache/lucene/pull/900 This updates TieredMergePolicy and Log(Doc|Size)MergePolicy to only ever consider merges where the resulting segment would be at least 50% bigger than the biggest input segment. While a merge that on

[GitHub] [lucene-solr] janhoy closed pull request #103: SOLR-6994: Implement Windows version of bin/post

2022-05-18 Thread GitBox
janhoy closed pull request #103: SOLR-6994: Implement Windows version of bin/post URL: https://github.com/apache/lucene-solr/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [lucene-solr] janhoy commented on pull request #103: SOLR-6994: Implement Windows version of bin/post

2022-05-18 Thread GitBox
janhoy commented on PR #103: URL: https://github.com/apache/lucene-solr/pull/103#issuecomment-1129891623 I'l not work more on this, at least not for 8x line. Closing PR. If anyone wants to pick up the work on 9x then I'll leave the branch around for some while. -- This is an automated me

[GitHub] [lucene-solr] janhoy closed pull request #351: SOLR-9640 Support PKI authentication in standalone mode

2022-05-18 Thread GitBox
janhoy closed pull request #351: SOLR-9640 Support PKI authentication in standalone mode URL: https://github.com/apache/lucene-solr/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [lucene-solr] janhoy commented on pull request #351: SOLR-9640 Support PKI authentication in standalone mode

2022-05-18 Thread GitBox
janhoy commented on PR #351: URL: https://github.com/apache/lucene-solr/pull/351#issuecomment-1129889594 I won't work on this, at least not on the 8.x branch, closing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [lucene-solr] janhoy merged pull request #2642: SOLR-16019 Query parsing exception return HTTP 400 instead of 500

2022-05-18 Thread GitBox
janhoy merged PR #2642: URL: https://github.com/apache/lucene-solr/pull/2642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[jira] [Commented] (LUCENE-10578) Make minimum required Java version for build more specific

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538749#comment-17538749 ] Robert Muir commented on LUCENE-10578: -- 1. fail, there is only fail. warnings are

[jira] [Comment Edited] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538746#comment-17538746 ] Adrien Grand edited comment on LUCENE-10574 at 5/18/22 11:10 AM:

[jira] [Commented] (LUCENE-10574) Remove O(n^2) from TieredMergePolicy or change defaults to one that doesn't do this

2022-05-18 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538746#comment-17538746 ] Adrien Grand commented on LUCENE-10574: --- I used BaseMergePolicyTestCase's simulat

[jira] [Commented] (LUCENE-10572) Can we optimize BytesRefHash?

2022-05-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538742#comment-17538742 ] Robert Muir commented on LUCENE-10572: -- I don't think we should recommend the user

[jira] [Resolved] (LUCENE-10477) SpanBoostQuery.rewrite was incomplete for boost==1 factor

2022-05-18 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved LUCENE-10477. -- Fix Version/s: 8.11.2 Resolution: Fixed > SpanBoostQuery.rewrite was i

[jira] [Updated] (LUCENE-10464) unnecessary for-loop in WeightedSpanTermExtractor.extractWeightedSpanTerms

2022-05-18 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated LUCENE-10464: - Fix Version/s: 8.11.2 > unnecessary for-loop in WeightedSpanTermExtractor.extra

[jira] [Commented] (LUCENE-10464) unnecessary for-loop in WeightedSpanTermExtractor.extractWeightedSpanTerms

2022-05-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538733#comment-17538733 ] ASF subversion and git services commented on LUCENE-10464: -- Co

[jira] [Commented] (LUCENE-10477) SpanBoostQuery.rewrite was incomplete for boost==1 factor

2022-05-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538734#comment-17538734 ] ASF subversion and git services commented on LUCENE-10477: -- Co

[GitHub] [lucene-solr] cpoerschke merged pull request #2656: LUCENE-10464, LUCENE-10477: WeightedSpanTermExtractor.extractWeightedSpanTerms to rewrite sufficiently

2022-05-18 Thread GitBox
cpoerschke merged PR #2656: URL: https://github.com/apache/lucene-solr/pull/2656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@luce

[jira] [Created] (LUCENE-10578) Make minimum required Java version for build more specific

2022-05-18 Thread Tomoko Uchida (Jira)
Tomoko Uchida created LUCENE-10578: -- Summary: Make minimum required Java version for build more specific Key: LUCENE-10578 URL: https://issues.apache.org/jira/browse/LUCENE-10578 Project: Lucene - Cor

[GitHub] [lucene] romseygeek commented on a diff in pull request #898: LUCENE-8519 MultiDocValues.getNormValues should not call getMergedFieldInfos

2022-05-18 Thread GitBox
romseygeek commented on code in PR #898: URL: https://github.com/apache/lucene/pull/898#discussion_r875631623 ## lucene/CHANGES.txt: ## @@ -38,6 +38,8 @@ Improvements * LUCENE-10416: Update Korean Dictionary to mecab-ko-dic-2.1.1-20180720 for Nori. (Uihyun Kim) +* LUCENE-

[jira] [Commented] (LUCENE-10531) Mark testLukeCanBeLaunched @Nightly test and make a dedicated Github CI workflow for it

2022-05-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538655#comment-17538655 ] ASF subversion and git services commented on LUCENE-10531: -- Co