Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

github-actions[bot] commented on PR #13165: URL: https://github.com/apache/lucene/pull/13165#issuecomment-2276934277 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

vletard commented on PR #13165: URL: https://github.com/apache/lucene/pull/13165#issuecomment-2250172786 @romseygeek, could you write what you would like to see added more precisely? See the three options I listed in my earlier comment. Thank you! -- This is an automated message from t

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

github-actions[bot] commented on PR #13165: URL: https://github.com/apache/lucene/pull/13165#issuecomment-2050752122 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

vletard commented on PR #13165: URL: https://github.com/apache/lucene/pull/13165#issuecomment-2025143936 I added a test in TestUnifiedHighlighterExtensibility, probably too simple for what you asked though. From my understanding, performing a more realistic test with adequate UH and quer

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

romseygeek commented on PR #13165: URL: https://github.com/apache/lucene/pull/13165#issuecomment-2021674549 Thanks @vletard! This looks great, I'd just like to add one more test to ensure that inheritance works in the way we expect. -- This is an automated message from the Apache Git Se

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

romseygeek commented on code in PR #13165: URL: https://github.com/apache/lucene/pull/13165#discussion_r1540259892 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -1130,7 +1137,7 @@ public boolean acceptField(String field) {

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

vletard commented on code in PR #13165: URL: https://github.com/apache/lucene/pull/13165#discussion_r1538165525 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -1130,7 +1134,16 @@ public boolean acceptField(String field) {

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

romseygeek commented on code in PR #13165: URL: https://github.com/apache/lucene/pull/13165#discussion_r1537485874 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -1130,7 +1134,16 @@ public boolean acceptField(String field) {

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

github-actions[bot] commented on PR #13165: URL: https://github.com/apache/lucene/pull/13165#issuecomment-2016641610 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

vletard commented on code in PR #13165: URL: https://github.com/apache/lucene/pull/13165#discussion_r1518583204 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -1130,7 +1134,16 @@ public boolean acceptField(String field) {

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

romseygeek commented on code in PR #13165: URL: https://github.com/apache/lucene/pull/13165#discussion_r1518350668 ## lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java: ## @@ -1130,7 +1134,16 @@ public boolean acceptField(String field) {

[PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

vletard opened a new pull request, #13165: URL: https://github.com/apache/lucene/pull/13165 ### Description This pull request is a follow up to #12938. I took on the task of complying with @romseygeek's comment on behalf of [Lexum](https://lexum.com/en/). I also rebased to the late

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

github-actions[bot] commented on PR #12938: URL: https://github.com/apache/lucene/pull/12938#issuecomment-1922531062 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

romseygeek commented on PR #12938: URL: https://github.com/apache/lucene/pull/12938#issuecomment-1898672394 This seems reasonable - FunctionQuery doesn't actually match things, it just scores, so it shouldn't be used for highlighting in any case. Could you add a test to the highlighti

Re: [PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

github-actions[bot] commented on PR #12938: URL: https://github.com/apache/lucene/pull/12938#issuecomment-1880898750 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. [lucene]

ljak opened a new pull request, #12938: URL: https://github.com/apache/lucene/pull/12938 ### Description At [Lexum](https://lexum.com/en/), we deploy Solr with a slightly modified version of the UnifiedHighlighter: the `FunctionQuery` type is added as a knownLeaf to the `QueryVisitor