[jira] [Resolved] (LUCENE-9948) Automatically detect multi- vs. single-valued cases in LongValueFacetCounts

2021-05-03 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9948. - Fix Version/s: main (9.0) Resolution: Fixed > Automatically detect multi- vs. single-valu

[jira] [Commented] (LUCENE-9948) Automatically detect multi- vs. single-valued cases in LongValueFacetCounts

2021-05-03 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338443#comment-17338443 ] Robert Muir commented on LUCENE-9948: - Thanks [~gsmiller] for taking care of this!

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-05-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339084#comment-17339084 ] Robert Muir commented on LUCENE-9843: - +1 let's simplify and have better test covera

[jira] [Updated] (LUCENE-9843) Remove compression option on doc values

2021-05-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9843: Attachment: LUCENE-9843.patch mods.patch Status: Open (was: Open) [~jdcon

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-05-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339374#comment-17339374 ] Robert Muir commented on LUCENE-9843: - looks like we can do the same trick for binar

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-05-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339863#comment-17339863 ] Robert Muir commented on LUCENE-9843: - +1 to your latest patch [~jdconradson]. I ran

[jira] [Commented] (LUCENE-9950) Support both single- and multi-value string fields in facet counting (non-taxonomy based approaches)

2021-05-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340242#comment-17340242 ] Robert Muir commented on LUCENE-9950: - +1 to add a "normal" facet method here, and d

[jira] [Resolved] (LUCENE-9843) Remove compression option on doc values

2021-05-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9843. - Fix Version/s: main (9.0) Resolution: Fixed Thanks [~jdconradson]! > Remove compression

[jira] [Updated] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

2021-05-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9827: Fix Version/s: 8.9 > Small segments are slower to merge due to stored fields since 8.7 > -

[jira] [Created] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-28 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9981: --- Summary: CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit Key: LUCENE-9981 URL: https://issues.apache.org/jira/browse/LUC

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9981: Attachment: LUCENE-9981_test.patch > CompiledAutomaton.getCommonSuffix can be extraordinarily slow

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353637#comment-17353637 ] Robert Muir commented on LUCENE-9981: - Before we {{det(reverse())}} this automaton t

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353644#comment-17353644 ] Robert Muir commented on LUCENE-9379: - Sorry, the above comment is really wrong. Ple

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353645#comment-17353645 ] Robert Muir commented on LUCENE-9379: - As always, you can count on arch to have some

[jira] [Commented] (LUCENE-9379) Directory based approach for index encryption

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353696#comment-17353696 ] Robert Muir commented on LUCENE-9379: - Your argument is even more uneducated, the "i

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353742#comment-17353742 ] Robert Muir commented on LUCENE-9981: - Hi [~oridool]. This issue isn't a security is

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353762#comment-17353762 ] Robert Muir commented on LUCENE-9981: - Nope, but exposing very slow queries (via DSL

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9981: Attachment: LUCENE-9981_nfaprefix.patch > CompiledAutomaton.getCommonSuffix can be extraordinarily

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353830#comment-17353830 ] Robert Muir commented on LUCENE-9981: - I attached LUCENE-9981_nfa_prefix.patch, whic

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353852#comment-17353852 ] Robert Muir commented on LUCENE-9981: - Patch looks great! I really like how it is cl

[jira] [Updated] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9981: Attachment: LUCENE-9981.patch > CompiledAutomaton.getCommonSuffix can be extraordinarily slow, eve

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353861#comment-17353861 ] Robert Muir commented on LUCENE-9981: - I updated the patch, changes: * Add simple un

[jira] [Commented] (LUCENE-9867) CorruptIndexException after failed segment merge caused by No space left on device

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353906#comment-17353906 ] Robert Muir commented on LUCENE-9867: - Sorry for the dyslexic commit > CorruptIndex

[jira] [Commented] (LUCENE-9687) Hunspell support improvements

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353907#comment-17353907 ] Robert Muir commented on LUCENE-9687: - I think we should be good now. The only other

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353908#comment-17353908 ] Robert Muir commented on LUCENE-9981: - cc: [~dweiss] in case you have thoughts. Quic

[jira] [Comment Edited] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353908#comment-17353908 ] Robert Muir edited comment on LUCENE-9981 at 5/30/21, 12:01 AM: --

[jira] [Comment Edited] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353908#comment-17353908 ] Robert Muir edited comment on LUCENE-9981 at 5/30/21, 12:10 AM: --

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353910#comment-17353910 ] Robert Muir commented on LUCENE-9981: - Another tweak: its great that we give a compi

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353956#comment-17353956 ] Robert Muir commented on LUCENE-9981: - There's no reason to rush fixes/backports for

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353972#comment-17353972 ] Robert Muir commented on LUCENE-9981: - It is probably enough bits? I originally like

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-05-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17353994#comment-17353994 ] Robert Muir commented on LUCENE-9981: - Even with no API break, I don't want these ch

[jira] [Commented] (LUCENE-9987) JVM 11.0.6 crash while trying to read term vectors in CheckIndex?

2021-06-02 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355694#comment-17355694 ] Robert Muir commented on LUCENE-9987: - ZAC though. Workaround: don't use ZGC > JVM

[jira] [Commented] (LUCENE-9981) CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit

2021-06-04 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357410#comment-17357410 ] Robert Muir commented on LUCENE-9981: - +1. glad this test is happy! > CompiledAutom

[jira] [Created] (LUCENE-9997) Revisit smoketester for 9.0 build

2021-06-10 Thread Robert Muir (Jira)
Robert Muir created LUCENE-9997: --- Summary: Revisit smoketester for 9.0 build Key: LUCENE-9997 URL: https://issues.apache.org/jira/browse/LUCENE-9997 Project: Lucene - Core Issue Type: Task

[jira] [Reopened] (LUCENE-9935) Bulk merges for stored fields when index sorting is enabled

2021-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir reopened LUCENE-9935: - Reopening as the term vectors support was reverted from main (but not 8.x?). cc: [~dnhatn] > Bulk

[jira] [Commented] (LUCENE-9935) Bulk merges for stored fields when index sorting is enabled

2021-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363019#comment-17363019 ] Robert Muir commented on LUCENE-9935: - ah ok, sorry, i read the linked issues wrong.

[jira] [Commented] (LUCENE-10003) Disallow C-style array declarations

2021-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363218#comment-17363218 ] Robert Muir commented on LUCENE-10003: -- What is the bug caused by this? It is 100%

[jira] [Commented] (LUCENE-10003) Disallow C-style array declarations

2021-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363221#comment-17363221 ] Robert Muir commented on LUCENE-10003: -- In this particular case, i'm specifically

[jira] [Commented] (LUCENE-10003) Disallow C-style array declarations

2021-06-15 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363644#comment-17363644 ] Robert Muir commented on LUCENE-10003: -- My concern is really beyond when the tool

[jira] [Resolved] (LUCENE-10004) Delete unnecessary flush in Lucene90CompressingStoredFieldsWriter.copyChunks() to reduce dirty chunks

2021-06-18 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10004. -- Resolution: Not A Problem We absolutely need to flush pending docs before we start copying by

[jira] [Commented] (LUCENE-10010) Should we have a NFA Query?

2021-06-22 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367524#comment-17367524 ] Robert Muir commented on LUCENE-10010: -- I think the main difference between the ar

[jira] [Commented] (LUCENE-9855) Reconsider names for ANN related format and APIs

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372001#comment-17372001 ] Robert Muir commented on LUCENE-9855: - I really do think this is correctly a blocker

[jira] [Created] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-06-30 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10015: Summary: Remove VectorValues.SimilarityFunction, remove NONE Key: LUCENE-10015 URL: https://issues.apache.org/jira/browse/LUCENE-10015 Project: Lucene - Core

[jira] [Created] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-06-30 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10016: Summary: VectorReader.search needs rethought, o.a.l.search integration? Key: LUCENE-10016 URL: https://issues.apache.org/jira/browse/LUCENE-10016 Project: Lucene - Co

[jira] [Updated] (LUCENE-10015) Remove VectorValues.SimilarityFunction, remove NONE

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10015: - Fix Version/s: 9.0 > Remove VectorValues.SimilarityFunction, remove NONE >

[jira] [Updated] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-10016: - Fix Version/s: 9.0 > VectorReader.search needs rethought, o.a.l.search integration? > -

[jira] [Commented] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372057#comment-17372057 ] Robert Muir commented on LUCENE-10016: -- [~sokolov] let's not make these assumption

[jira] [Commented] (LUCENE-8638) Remove deprecated code in master

2021-06-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372278#comment-17372278 ] Robert Muir commented on LUCENE-8638: - What are these {{lucene-deprecations.txt}} fi

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377541#comment-17377541 ] Robert Muir commented on LUCENE-10023: -- I actually think it is useful for the user

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377636#comment-17377636 ] Robert Muir commented on LUCENE-10023: -- {quote} In contrast, the current PR only r

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377639#comment-17377639 ] Robert Muir commented on LUCENE-10023: -- {quote} In contrast, the current PR only r

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-08 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377769#comment-17377769 ] Robert Muir commented on LUCENE-10023: -- {quote} I guess the essence of the questio

[jira] [Commented] (LUCENE-10023) Multi-token post-analysis DocValues

2021-07-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17378142#comment-17378142 ] Robert Muir commented on LUCENE-10023: -- A big part of my concern is adding this co

[jira] [Commented] (LUCENE-9177) ICUNormalizer2CharFilter worst case is very slow

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380111#comment-17380111 ] Robert Muir commented on LUCENE-9177: - i haven't had a chance to test it out, I didn

[jira] [Commented] (LUCENE-9177) ICUNormalizer2CharFilter worst case is very slow

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380178#comment-17380178 ] Robert Muir commented on LUCENE-9177: - it may be the case. it shouldn't hold up your

[jira] [Commented] (LUCENE-9177) ICUNormalizer2CharFilter worst case is very slow

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380238#comment-17380238 ] Robert Muir commented on LUCENE-9177: - I re-enabled this test on top of your branch.

[jira] [Commented] (LUCENE-5595) TestICUNormalizer2CharFilter test failure

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380239#comment-17380239 ] Robert Muir commented on LUCENE-5595: - I'd like to re-enable this test. I will open

[jira] [Updated] (LUCENE-9177) ICUNormalizer2CharFilter worst case is very slow

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9177: Fix Version/s: 8.10 main (9.0) > ICUNormalizer2CharFilter worst case is very sl

[jira] [Commented] (LUCENE-9177) ICUNormalizer2CharFilter worst case is very slow

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380243#comment-17380243 ] Robert Muir commented on LUCENE-9177: - Thanks [~mgibney] a lot for taking care of th

[jira] [Resolved] (LUCENE-9177) ICUNormalizer2CharFilter worst case is very slow

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9177. - Resolution: Fixed > ICUNormalizer2CharFilter worst case is very slow > -

[jira] [Commented] (LUCENE-5595) TestICUNormalizer2CharFilter test failure

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380256#comment-17380256 ] Robert Muir commented on LUCENE-5595: - One thing bogus about the existing test is th

[jira] [Commented] (LUCENE-5595) TestICUNormalizer2CharFilter test failure

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380259#comment-17380259 ] Robert Muir commented on LUCENE-5595: - sorry, the previous NFKD test is fine. I thou

[jira] [Resolved] (LUCENE-5595) TestICUNormalizer2CharFilter test failure

2021-07-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-5595. - Fix Version/s: main (9.0) Resolution: Fixed Marking as fixed. Actually all we did is cran

[jira] [Commented] (LUCENE-9959) Can we remove threadlocals of stored fields and term vectors

2021-07-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17383126#comment-17383126 ] Robert Muir commented on LUCENE-9959: - I don't think we should do this anymore. Some

[jira] [Resolved] (LUCENE-9959) Can we remove threadlocals of stored fields and term vectors

2021-07-19 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9959. - Resolution: Won't Fix was a terrible idea that just made APIs worse: I tried having some sympath

[jira] [Commented] (LUCENE-10016) VectorReader.search needs rethought, o.a.l.search integration?

2021-07-28 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388868#comment-17388868 ] Robert Muir commented on LUCENE-10016: -- Even if it isn't in the o.a.l.demo module,

[jira] [Commented] (LUCENE-10033) Encode doc values in smaller blocks of values, like postings

2021-07-29 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389841#comment-17389841 ] Robert Muir commented on LUCENE-10033: -- {quote} Queries that consume most values l

[jira] [Commented] (LUCENE-10048) Bypass total frequency check if field uses custom term frequency

2021-08-10 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17396981#comment-17396981 ] Robert Muir commented on LUCENE-10048: -- It has been brought up before, I don't thi

[jira] [Commented] (LUCENE-9937) ann-benchmarks results for HNSW search

2021-08-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397555#comment-17397555 ] Robert Muir commented on LUCENE-9937: - we can help some of those hotspots with vecto

[jira] [Commented] (LUCENE-10048) Bypass total frequency check if field uses custom term frequency

2021-08-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397774#comment-17397774 ] Robert Muir commented on LUCENE-10048: -- Whether or not you use the similarity or s

[jira] [Commented] (LUCENE-10048) Bypass total frequency check if field uses custom term frequency

2021-08-11 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397782#comment-17397782 ] Robert Muir commented on LUCENE-10048: -- btw, there are a lot of alternatives you c

[jira] [Commented] (LUCENE-10048) Bypass total frequency check if field uses custom term frequency

2021-08-12 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398358#comment-17398358 ] Robert Muir commented on LUCENE-10048: -- this doesn't explain any use case to me. i

[jira] [Commented] (LUCENE-10048) Bypass total frequency check if field uses custom term frequency

2021-08-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398896#comment-17398896 ] Robert Muir commented on LUCENE-10048: -- no, you still dont get it. please read the

[jira] [Resolved] (LUCENE-10048) Bypass total frequency check if field uses custom term frequency

2021-08-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10048. -- Resolution: Won't Fix > Bypass total frequency check if field uses custom term frequency > --

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-23 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464531#comment-17464531 ] Robert Muir commented on LUCENE-10334: -- I think you took a good approach: small st

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17465062#comment-17465062 ] Robert Muir commented on LUCENE-10334: -- so it speeds up ordinals (SSDV) but maybe

[jira] [Commented] (LUCENE-10334) Introduce a BlockReader based on ForUtil and use it for NumericDocValues

2021-12-30 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466832#comment-17466832 ] Robert Muir commented on LUCENE-10334: -- I really prefer the first patch for simpli

[jira] [Created] (LUCENE-10345) remove non-NRT replication support

2021-12-30 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10345: Summary: remove non-NRT replication support Key: LUCENE-10345 URL: https://issues.apache.org/jira/browse/LUCENE-10345 Project: Lucene - Core Issue Type: Task

[jira] [Created] (LUCENE-10353) Add null injection to analyzer integration tests (e.g. TestRandomChains)

2022-01-04 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10353: Summary: Add null injection to analyzer integration tests (e.g. TestRandomChains) Key: LUCENE-10353 URL: https://issues.apache.org/jira/browse/LUCENE-10353 Project: L

[jira] [Commented] (LUCENE-10353) Add null injection to analyzer integration tests (e.g. TestRandomChains)

2022-01-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469220#comment-17469220 ] Robert Muir commented on LUCENE-10353: -- +1, this sounds good to me. Then we can ad

[jira] [Commented] (LUCENE-10359) KoreanTokenizer: TestRandomChains fails with incorrect offsets

2022-01-05 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17469269#comment-17469269 ] Robert Muir commented on LUCENE-10359: -- This one may be KoreanNumberFilter in the

[jira] [Created] (LUCENE-10361) KoreanNumberFilter messes up offsets

2022-01-05 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10361: Summary: KoreanNumberFilter messes up offsets Key: LUCENE-10361 URL: https://issues.apache.org/jira/browse/LUCENE-10361 Project: Lucene - Core Issue Type: Bu

[jira] [Created] (LUCENE-10362) JapaneseNumberFilter messes up offsets

2022-01-05 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10362: Summary: JapaneseNumberFilter messes up offsets Key: LUCENE-10362 URL: https://issues.apache.org/jira/browse/LUCENE-10362 Project: Lucene - Core Issue Type:

[jira] [Created] (LUCENE-10363) JapaneseCompletionFilter messes up offsets

2022-01-05 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10363: Summary: JapaneseCompletionFilter messes up offsets Key: LUCENE-10363 URL: https://issues.apache.org/jira/browse/LUCENE-10363 Project: Lucene - Core Issue Ty

[jira] [Commented] (LUCENE-10364) Prepare and update errorprone plugin for Java 17

2022-01-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470558#comment-17470558 ] Robert Muir commented on LUCENE-10364: -- > It was complaining about Character#getNu

[jira] [Commented] (LUCENE-10364) Prepare and update errorprone plugin for Java 17

2022-01-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470568#comment-17470568 ] Robert Muir commented on LUCENE-10364: -- Sorry, I don't want to "ban" this method.

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2022-01-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470624#comment-17470624 ] Robert Muir commented on LUCENE-8739: - > +1 ZSTD is quite great. I wouldn't use it i

[jira] [Commented] (LUCENE-8739) ZSTD Compressor support in Lucene

2022-01-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471315#comment-17471315 ] Robert Muir commented on LUCENE-8739: - We already have a compression abstraction in

[jira] [Commented] (LUCENE-10374) Track down the "browse" taxonomy faceting qps regression

2022-01-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475381#comment-17475381 ] Robert Muir commented on LUCENE-10374: -- Looks like that did the trick! http://peo

[jira] [Commented] (LUCENE-10374) Track down the "browse" taxonomy faceting qps regression

2022-01-13 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475435#comment-17475435 ] Robert Muir commented on LUCENE-10374: -- [~gsmiller] I agree, looking at the commit

[jira] [Commented] (LUCENE-10396) Automatically create sparse indexes for sort fields

2022-02-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485178#comment-17485178 ] Robert Muir commented on LUCENE-10396: -- an entire new file format abstraction for

[jira] [Commented] (LUCENE-10396) Automatically create sparse indexes for sort fields

2022-02-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485292#comment-17485292 ] Robert Muir commented on LUCENE-10396: -- thanks [~jpountz]. I like that there is a

[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17492034#comment-17492034 ] Robert Muir commented on LUCENE-10421: -- Can we just make this default seed a const

[jira] [Commented] (LUCENE-10391) Reuse data structures across HnswGraph invocations

2022-02-16 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493146#comment-17493146 ] Robert Muir commented on LUCENE-10391: -- Actually these nightly benchmarks have not

[jira] [Created] (LUCENE-10423) Remove uses of wall-clock time in codebase

2022-02-16 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10423: Summary: Remove uses of wall-clock time in codebase Key: LUCENE-10423 URL: https://issues.apache.org/jira/browse/LUCENE-10423 Project: Lucene - Core Issue Ty

[jira] [Commented] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-16 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493320#comment-17493320 ] Robert Muir commented on LUCENE-10421: -- 42 patch is here: https://github.com/apach

[jira] [Resolved] (LUCENE-10421) Non-deterministic results from KnnVectorQuery?

2022-02-24 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10421. -- Fix Version/s: 9.1 Resolution: Fixed > Non-deterministic results from KnnVectorQuery?

[jira] [Created] (LUCENE-10443) Remove one of SparseFixedBitSet/DocIdSetBuilder.Buffer

2022-02-25 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10443: Summary: Remove one of SparseFixedBitSet/DocIdSetBuilder.Buffer Key: LUCENE-10443 URL: https://issues.apache.org/jira/browse/LUCENE-10443 Project: Lucene - Core

[jira] [Resolved] (LUCENE-10430) Literal double quotes cause exception in class RegExp

2022-02-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10430. -- Resolution: Not A Problem You aren't escaping the quote. You're sending a java string of leng

[jira] [Commented] (LUCENE-10449) Performance regression due to decompressBlock method introduced with compression on binary doc values

2022-03-01 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499629#comment-17499629 ] Robert Muir commented on LUCENE-10449: -- Looks like you aren't using BinaryDocValue

<    6   7   8   9   10   11   12   13   14   15   >