[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298073#comment-17298073 ] Ignacio Vera commented on LUCENE-8626: -- Thanks Dawid! > standardise test class naming >

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297911#comment-17297911 ] Dawid Weiss commented on LUCENE-8626: - I've fixed it already. > standardise test class naming >

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297897#comment-17297897 ] ASF subversion and git services commented on LUCENE-8626: - Commit

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297899#comment-17297899 ] Ignacio Vera commented on LUCENE-8626: -- It seems the last test introduced is making nightly test

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297815#comment-17297815 ] Marcus Eagan commented on LUCENE-8626: -- Thank you Christine for wrapping this up. Looks like it

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297457#comment-17297457 ] ASF subversion and git services commented on LUCENE-8626: - Commit

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297375#comment-17297375 ] Christine Poerschke commented on LUCENE-8626: -

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297341#comment-17297341 ] ASF subversion and git services commented on LUCENE-8626: - Commit

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291821#comment-17291821 ] Christine Poerschke commented on LUCENE-8626: - I don't know if we've already got naming

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270317#comment-17270317 ] ASF subversion and git services commented on LUCENE-8626: - Commit

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268864#comment-17268864 ] Marcus Eagan commented on LUCENE-8626: -- I've added the final batch of standardized tests. No more

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17233574#comment-17233574 ] ASF subversion and git services commented on LUCENE-8626: - Commit

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224885#comment-17224885 ] Dawid Weiss commented on LUCENE-8626: - I don't mind at all, Christine. Thank you for picking this

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224800#comment-17224800 ] Christine Poerschke commented on LUCENE-8626: - bq. ... the PR which makes it easier to do it

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224792#comment-17224792 ] Christine Poerschke commented on LUCENE-8626: - bq. Looking for tests where we currently have

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224350#comment-17224350 ] Marcus Eagan commented on LUCENE-8626: -- [I added another 36 tests to this

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223444#comment-17223444 ] ASF subversion and git services commented on LUCENE-8626: - Commit

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176607#comment-17176607 ] Michael McCandless commented on LUCENE-8626: Ahh thanks [~dweiss], yeah +1 for this approach 

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176578#comment-17176578 ] Dawid Weiss commented on LUCENE-8626: - bq. 1) do the renaming at once I pushed the PR which makes

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176557#comment-17176557 ] Michael McCandless commented on LUCENE-8626: {quote}I'm myself more of a suffix-style kind

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176393#comment-17176393 ] Christine Poerschke commented on LUCENE-8626: - Looking for tests where we currently have

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176323#comment-17176323 ] Erick Erickson commented on LUCENE-8626: +100 to David's comment. We should refrain from

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176113#comment-17176113 ] Dawid Weiss commented on LUCENE-8626: - As for the convention itself, I'm myself more of a

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176109#comment-17176109 ] Dawid Weiss commented on LUCENE-8626: - Pushed a PR for consideration on how this can be done

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176068#comment-17176068 ] Marcus Eagan commented on LUCENE-8626: -- Great ideas [~dweiss] and [~dsmiley]! > standardise test

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176013#comment-17176013 ] David Smiley commented on LUCENE-8626: -- I request that the Solr side be delayed some, and maybe get

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174997#comment-17174997 ] Dawid Weiss commented on LUCENE-8626: - bq. Still, without automated enforcement For LuceneTestCase

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173271#comment-17173271 ] Erick Erickson commented on LUCENE-8626: Both should be the same IMO. > standardise test class

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173239#comment-17173239 ] Christine Poerschke commented on LUCENE-8626: - bq. Within the lucene test suite, it is

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173238#comment-17173238 ] Christine Poerschke commented on LUCENE-8626: - {quote}Thank you very much for kicking this

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172712#comment-17172712 ] Marcus Eagan commented on LUCENE-8626: -- There are many many areas where I am looking to improve the

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172709#comment-17172709 ] Marcus Eagan commented on LUCENE-8626: -- [~cpoerschke] Thank you very much for kicking this effort

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172666#comment-17172666 ] Erick Erickson commented on LUCENE-8626: Hmmm, one other random thought. While I'd prefer some

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172545#comment-17172545 ] Erick Erickson commented on LUCENE-8626: Contrariwise, I prefer suffixing on the theory that

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172538#comment-17172538 ] Michael Sokolov commented on LUCENE-8626: - Personally, I prefer prefixing, but more than that,

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172101#comment-17172101 ] Christine Poerschke commented on LUCENE-8626: - bq. This was mentioned and proposed on the

[jira] [Commented] (LUCENE-8626) standardise test class naming

[ https://issues.apache.org/jira/browse/LUCENE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172050#comment-17172050 ] Robert Muir commented on LUCENE-8626: - I'm gonna reiterate my numbers: 2/3 of all tests use the