[jira] [Commented] (MNG-6806) Provide Maven BOM

2020-12-27 Thread Andrey Fadeev (Jira)
[ https://issues.apache.org/jira/browse/MNG-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255396#comment-17255396 ] Andrey Fadeev commented on MNG-6806: By Maven libraries you mean maven-shared? http://m

[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request #33: Bump maven-artifact-transfer from 0.11.0 to 0.13.1

2020-12-27 Thread GitBox
dependabot[bot] opened a new pull request #33: URL: https://github.com/apache/maven-invoker-plugin/pull/33 Bumps [maven-artifact-transfer](https://github.com/apache/maven-artifact-transfer) from 0.11.0 to 0.13.1. Commits https://github.com/apache/maven-artifact-transfer/commi

[GitHub] [maven-shade-plugin] dependabot[bot] opened a new pull request #82: Bump maven-artifact-transfer from 0.12.0 to 0.13.1

2020-12-27 Thread GitBox
dependabot[bot] opened a new pull request #82: URL: https://github.com/apache/maven-shade-plugin/pull/82 Bumps [maven-artifact-transfer](https://github.com/apache/maven-artifact-transfer) from 0.12.0 to 0.13.1. Commits https://github.com/apache/maven-artifact-transfer/commit/

[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request #28: Bump maven-scm-publish-plugin from 3.0.0 to 3.1.0

2020-12-27 Thread GitBox
dependabot[bot] opened a new pull request #28: URL: https://github.com/apache/maven-apache-parent/pull/28 Bumps [maven-scm-publish-plugin](https://github.com/apache/maven-scm-publish-plugin) from 3.0.0 to 3.1.0. Commits https://github.com/apache/maven-scm-publish-plugin/commi

[GitHub] [maven] michael-o edited a comment on pull request #177: [MNG-6471] during parallel build, ensure to set the thread name to the artifactId

2020-12-27 Thread GitBox
michael-o edited a comment on pull request #177: URL: https://github.com/apache/maven/pull/177#issuecomment-751530508 Here is a very simple counter proposal: ``` $ git diff diff --git a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java b/mav

[GitHub] [maven-project-info-reports-plugin] slawekjaranowski commented on a change in pull request #27: [MPIR-391] Continuous Integration support for GitHub Action

2020-12-27 Thread GitBox
slawekjaranowski commented on a change in pull request #27: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/27#discussion_r549178027 ## File path: src/main/java/org/apache/maven/report/projectinfo/CiManagementReport.java ## @@ -225,23 +199,29 @@ else if

[GitHub] [maven-resolver] michael-o commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-27 Thread GitBox
michael-o commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751531066 Very nice, I will happily go through. This is an automated message from the Apache Git Service. To respond

[GitHub] [maven] michael-o edited a comment on pull request #177: [MNG-6471] during parallel build, ensure to set the thread name to the artifactId

2020-12-27 Thread GitBox
michael-o edited a comment on pull request #177: URL: https://github.com/apache/maven/pull/177#issuecomment-751530508 Here is a very simple counter proposal: ``` $ git diff diff --git a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java b/mav

[GitHub] [maven] michael-o edited a comment on pull request #177: [MNG-6471] during parallel build, ensure to set the thread name to the artifactId

2020-12-27 Thread GitBox
michael-o edited a comment on pull request #177: URL: https://github.com/apache/maven/pull/177#issuecomment-751530508 Here is a very simple counter proposal: ``` $ git diff diff --git a/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java b/mav

[GitHub] [maven] michael-o commented on pull request #177: [MNG-6471] during parallel build, ensure to set the thread name to the artifactId

2020-12-27 Thread GitBox
michael-o commented on pull request #177: URL: https://github.com/apache/maven/pull/177#issuecomment-751530508 Here is a very simple counter proposal: ``` $ git diff

[GitHub] [maven-resolver] michael-o commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549166502 ## File path: maven-resolver-synccontext-named/pom.xml ## @@ -59,7 +59,13 @@ org.apache.maven.resolver - maven-resolver-impl

[jira] [Commented] (MRESOLVER-154) Move SyncContextFactory interface to SPI module

2020-12-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255325#comment-17255325 ] Hudson commented on MRESOLVER-154: -- Build succeeded in Jenkins: Maven » Maven TLP » m

[GitHub] [maven-resolver] cstamas opened a new pull request #85: Make TrackingFileManager member of DefUpdateCheckManager

2020-12-27 Thread GitBox
cstamas opened a new pull request #85: URL: https://github.com/apache/maven-resolver/pull/85 And do not use it funky way. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Resolved] (MDEP-698) FileWriter and FileReader should be replaced

2020-12-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MDEP-698. Resolution: Fixed > FileWriter and FileReader should be replaced > --

[jira] [Closed] (MDEP-698) FileWriter and FileReader should be replaced

2020-12-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MDEP-698. -- > FileWriter and FileReader should be replaced >

[jira] [Assigned] (MDEP-698) FileWriter and FileReader should be replaced

2020-12-27 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MDEP-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MDEP-698: -- Assignee: Elliotte Rusty Harold > FileWriter and FileReader should be replaced >

[jira] [Closed] (MRESOLVER-154) Move SyncContextFactory interface to SPI module

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRESOLVER-154. Resolution: Fixed Fixed with [8779eedd8825f811069c79ad3c850dffa6ad6838|https://gitbox.a

[GitHub] [maven-resolver] asfgit closed pull request #84: [MRESOLVER-154] Move SyncContextFactory to SPI module

2020-12-27 Thread GitBox
asfgit closed pull request #84: URL: https://github.com/apache/maven-resolver/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (MRESOLVER-154) Move SyncContextFactory interface to SPI module

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-154: - Summary: Move SyncContextFactory interface to SPI module (was: Move SyncContextFactor

[jira] [Assigned] (MRESOLVER-154) Move SyncContextFactory iface to SPI module

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRESOLVER-154: Assignee: Michael Osipov > Move SyncContextFactory iface to SPI module > --

[jira] [Updated] (MRESOLVER-154) Move SyncContextFactory iface to SPI module

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRESOLVER-154: - Fix Version/s: 1.7.0 > Move SyncContextFactory iface to SPI module > -

[jira] [Commented] (MDEP-698) FileWriter and FileReader should be replaced

2020-12-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MDEP-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255320#comment-17255320 ] Hudson commented on MDEP-698: - Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency

[jira] [Created] (MRESOLVER-154) Move SyncContextFactory iface to SPI module

2020-12-27 Thread Jira
Tamás Cservenák created MRESOLVER-154: - Summary: Move SyncContextFactory iface to SPI module Key: MRESOLVER-154 URL: https://issues.apache.org/jira/browse/MRESOLVER-154 Project: Maven Resolver

[GitHub] [maven-resolver] cstamas opened a new pull request #84: Move SyncContextFactory to SPI module

2020-12-27 Thread GitBox
cstamas opened a new pull request #84: URL: https://github.com/apache/maven-resolver/pull/84 Move out this iface from impl to spi module. This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (MNG-5689) Checksum policy for mirrors

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255317#comment-17255317 ] Michael Osipov commented on MNG-5689: - > > This is not correct. The mirror is still nec

[GitHub] [maven-dependency-plugin] elharo merged pull request #119: [MDEP-698] replace code that relies on default encoding

2020-12-27 Thread GitBox
elharo merged pull request #119: URL: https://github.com/apache/maven-dependency-plugin/pull/119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #119: [MDEP-698] replace code that relies on default encoding

2020-12-27 Thread GitBox
elharo commented on a change in pull request #119: URL: https://github.com/apache/maven-dependency-plugin/pull/119#discussion_r549157882 ## File path: src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java ## @@ -286,7 +286,8 @@ public void execute()

[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull request #119: [MDEP-698] replace code that relies on default encoding

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #119: URL: https://github.com/apache/maven-dependency-plugin/pull/119#discussion_r549154720 ## File path: src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java ## @@ -286,7 +286,8 @@ public void execute()

[GitHub] [maven-project-info-reports-plugin] michael-o commented on a change in pull request #27: [MPIR-391] Continuous Integration support for GitHub Action

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #27: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/27#discussion_r549153452 ## File path: src/main/java/org/apache/maven/report/projectinfo/CiManagementReport.java ## @@ -225,23 +199,29 @@ else if ( isCiM

[jira] [Commented] (MNG-6801) MavenXpp3Writer doesn't retain structure

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255309#comment-17255309 ] Michael Osipov commented on MNG-6801: - Looking closing into this, we use {{java.util.Pr

[jira] [Issue Comment Deleted] (MNG-6801) MavenXpp3Writer doesn't retain structure

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6801: Comment: was deleted (was: I think this needs to be solved in Modello.) > MavenXpp3Writer doesn't re

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549152683 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +tru

[jira] [Commented] (MNG-6830) Warn on missing namespace

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255307#comment-17255307 ] Michael Osipov commented on MNG-6830: - All of our POMs and Settings must be in the prop

[jira] [Commented] (MNG-6830) Warn on missing namespace

2020-12-27 Thread Brian E Fox (Jira)
[ https://issues.apache.org/jira/browse/MNG-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255304#comment-17255304 ] Brian E Fox commented on MNG-6830: -- I'm not able to decipher the pom above, what do you me

[jira] [Commented] (MNG-6801) MavenXpp3Writer doesn't retain structure

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255303#comment-17255303 ] Michael Osipov commented on MNG-6801: - I think this needs to be solved in Modello. > M

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549150845 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comm

[jira] [Created] (MNG-7059) Add repository support in Maven Settings model

2020-12-27 Thread Michael Osipov (Jira)
Michael Osipov created MNG-7059: --- Summary: Add repository support in Maven Settings model Key: MNG-7059 URL: https://issues.apache.org/jira/browse/MNG-7059 Project: Maven Issue Type: New Featur

[jira] [Commented] (MNG-7058) Dependency Version Requirement Specification conflicts with SemVer pre-release specification

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255294#comment-17255294 ] Michael Osipov commented on MNG-7058: - We need to rework our version handling. It is pr

[jira] [Commented] (MNG-7058) Dependency Version Requirement Specification conflicts with SemVer pre-release specification

2020-12-27 Thread Marcono1234 (Jira)
[ https://issues.apache.org/jira/browse/MNG-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255286#comment-17255286 ] Marcono1234 commented on MNG-7058: -- The "Version Order Specification" section starts with:

[jira] [Commented] (MNG-7058) Dependency Version Requirement Specification conflicts with SemVer pre-release specification

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255284#comment-17255284 ] Michael Osipov commented on MNG-7058: - That's not a bug. Maven does not closely follow

[jira] [Comment Edited] (MNG-7058) Dependency Version Requirement Specification conflicts with SemVer pre-release specification

2020-12-27 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255284#comment-17255284 ] Michael Osipov edited comment on MNG-7058 at 12/27/20, 5:25 PM: -

[jira] [Commented] (MPLUGIN-302) Dependencies Annotation

2020-12-27 Thread Christofer Dutz (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255263#comment-17255263 ] Christofer Dutz commented on MPLUGIN-302: - I still think this would be super use

[jira] [Created] (MPMD-313) Improve parameter description

2020-12-27 Thread Marcono1234 (Jira)
Marcono1234 created MPMD-313: Summary: Improve parameter description Key: MPMD-313 URL: https://issues.apache.org/jira/browse/MPMD-313 Project: Maven PMD Plugin Issue Type: Improvement

[jira] [Created] (MCOMPILER-449) Improve parameter description

2020-12-27 Thread Marcono1234 (Jira)
Marcono1234 created MCOMPILER-449: - Summary: Improve parameter description Key: MCOMPILER-449 URL: https://issues.apache.org/jira/browse/MCOMPILER-449 Project: Maven Compiler Plugin Issue Ty

[jira] [Updated] (MJAVADOC-668) Improve parameter description

2020-12-27 Thread Marcono1234 (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcono1234 updated MJAVADOC-668: - Description: As pointed out in [this comment|https://issues.apache.org/jira/browse/MJAVADOC-50

[jira] [Updated] (MJAVADOC-668) Improve parameter description

2020-12-27 Thread Marcono1234 (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcono1234 updated MJAVADOC-668: - Description: As pointed out in [this comment|https://issues.apache.org/jira/browse/MJAVADOC-50

[jira] [Updated] (MPLUGIN-302) Dependencies Annotation

2020-12-27 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPLUGIN-302: - Labels: Maven5 (was: ) > Dependencies Annotation > --- > >

[jira] [Commented] (MJAVADOC-500) Add support for explicit toolchain reference

2020-12-27 Thread Marcono1234 (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255259#comment-17255259 ] Marcono1234 commented on MJAVADOC-500: -- [~britter] I have created MJAVADOC-668 req

[jira] [Updated] (MJAVADOC-668) Improve option description

2020-12-27 Thread Marcono1234 (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcono1234 updated MJAVADOC-668: - Description: As pointed out in [this comment|https://issues.apache.org/jira/browse/MJAVADOC-50

[jira] [Created] (MJAVADOC-668) Improve option description

2020-12-27 Thread Marcono1234 (Jira)
Marcono1234 created MJAVADOC-668: Summary: Improve option description Key: MJAVADOC-668 URL: https://issues.apache.org/jira/browse/MJAVADOC-668 Project: Maven Javadoc Plugin Issue Type: Impr

[jira] [Created] (MCLEAN-92) Require Maven 3.1.1 (drop dependency to Maven 3.0)

2020-12-27 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MCLEAN-92: -- Summary: Require Maven 3.1.1 (drop dependency to Maven 3.0) Key: MCLEAN-92 URL: https://issues.apache.org/jira/browse/MCLEAN-92 Project: Maven Clean Plugin

[jira] [Closed] (MCLEAN-79) Partial Clean + Configurable Selectors

2020-12-27 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MCLEAN-79?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MCLEAN-79. -- Resolution: Auto Closed > Partial Clean + Configurable Selectors > -

[jira] [Closed] (MCLEAN-78) Ability to retry longer if clean fails

2020-12-27 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MCLEAN-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MCLEAN-78. -- Resolution: Auto Closed > Ability to retry longer if clean fails > -

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549123187 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comm

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549123105 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +tru

[GitHub] [maven-archetypes] JurrianFahner commented on pull request #3: Enabled generating Java 9+ projects as well as using JUnit 5.x

2020-12-27 Thread GitBox
JurrianFahner commented on pull request #3: URL: https://github.com/apache/maven-archetypes/pull/3#issuecomment-751472644 Duplicate of #5 This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Commented] (MDEP-686) Upgrade maven-artifact-transfer from 0.11.0 to 0.13.1

2020-12-27 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MDEP-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255225#comment-17255225 ] Hudson commented on MDEP-686: - Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency

[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549111039 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +tru

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549110998 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comm

[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549110820 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comm

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549110606 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +tru

[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549110466 ## File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java ## @@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals(

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549108923 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comm

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549108923 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comm

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549108816 ## File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java ## @@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals(

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549108800 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +tru

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #34: update ejb plugin

2020-12-27 Thread GitBox
mabrarov commented on a change in pull request #34: URL: https://github.com/apache/maven-ear-plugin/pull/34#discussion_r549092998 ## File path: pom.xml ## @@ -88,7 +88,7 @@ 2020-09-26T20:10:30Z 3.3.1 2.5.1 -2.3 +3.1.0 Review comment: Refer to [`

[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549108105 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comm

[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549107773 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +tru

[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549107685 ## File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java ## @@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals(

[GitHub] [maven] rfscholte commented on a change in pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #415: URL: https://github.com/apache/maven/pull/415#discussion_r549107198 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -569,6 +570,20 @@ else if ( cliRequest.commandLine.hasOption( CLIManage

[GitHub] [maven] rfscholte commented on a change in pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #415: URL: https://github.com/apache/maven/pull/415#discussion_r549106876 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -433,6 +433,8 @@ void cli( CliRequest cliRequest ) if ( cliRe

[GitHub] [maven] rfscholte commented on a change in pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #415: URL: https://github.com/apache/maven/pull/415#discussion_r549106686 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -433,6 +433,8 @@ void cli( CliRequest cliRequest ) if ( cliRe

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549106505 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + +tru

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549106196 ## File path: maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java ## @@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals(

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549105819 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comm

[GitHub] [maven-project-info-reports-plugin] michael-o commented on a change in pull request #27: [MPIR-391] Continuous Integration support for GitHub Action

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #27: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/27#discussion_r549105428 ## File path: src/main/java/org/apache/maven/report/projectinfo/CiManagementReport.java ## @@ -88,6 +91,21 @@ protected String g

[GitHub] [maven] michael-o commented on a change in pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-27 Thread GitBox
michael-o commented on a change in pull request #415: URL: https://github.com/apache/maven/pull/415#discussion_r549103918 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -433,6 +433,8 @@ void cli( CliRequest cliRequest ) if ( cliRe

[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-27 Thread GitBox
rfscholte commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549099926 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,6 +244,35 @@ under the License. --> + + Review comm

[GitHub] [maven-project-info-reports-plugin] slawekjaranowski commented on pull request #27: [MPIR-391] Continuous Integration support for GitHub Action

2020-12-27 Thread GitBox
slawekjaranowski commented on pull request #27: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/27#issuecomment-751455090 I splitted change for two commit - one for code refactor and one for new feature. I think that, creating separate PR will be more complica

[jira] [Commented] (MSCMPUB-37) Upgrade to SCM 1.11.2

2020-12-27 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSCMPUB-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255202#comment-17255202 ] Sylwester Lachiewicz commented on MSCMPUB-37: - Update to 1.11.2 in MSCPUB-42

[jira] [Created] (MPOM-259) Upgrade maven-scm-plugin from 3.0.0 to 3.1.0

2020-12-27 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MPOM-259: - Summary: Upgrade maven-scm-plugin from 3.0.0 to 3.1.0 Key: MPOM-259 URL: https://issues.apache.org/jira/browse/MPOM-259 Project: Maven POMs Issue T

[jira] [Updated] (MSCMPUB-37) Upgrade to SCM 1.11.2

2020-12-27 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MSCMPUB-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSCMPUB-37: Summary: Upgrade to SCM 1.11.2 (was: Upgrade to SCM 1.10.0) > Upgrade to SCM 1.11.

[jira] [Updated] (MPOM-259) Upgrade maven-scm-plugin from 3.0.0 to 3.1.0

2020-12-27 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPOM-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPOM-259: -- Issue Type: Dependency upgrade (was: Improvement) > Upgrade maven-scm-plugin from 3.0.0

[GitHub] [maven] bmarwell commented on a change in pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-27 Thread GitBox
bmarwell commented on a change in pull request #415: URL: https://github.com/apache/maven/pull/415#discussion_r549097062 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -433,6 +433,8 @@ void cli( CliRequest cliRequest ) if ( cliReq

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #34: update ejb plugin

2020-12-27 Thread GitBox
mabrarov commented on a change in pull request #34: URL: https://github.com/apache/maven-ear-plugin/pull/34#discussion_r549092998 ## File path: pom.xml ## @@ -88,7 +88,7 @@ 2020-09-26T20:10:30Z 3.3.1 2.5.1 -2.3 +3.1.0 Review comment: Refer to [`

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #34: update ejb plugin

2020-12-27 Thread GitBox
mabrarov commented on a change in pull request #34: URL: https://github.com/apache/maven-ear-plugin/pull/34#discussion_r549092998 ## File path: pom.xml ## @@ -88,7 +88,7 @@ 2020-09-26T20:10:30Z 3.3.1 2.5.1 -2.3 +3.1.0 Review comment: Refer to [`

[jira] [Commented] (MNG-5689) Checksum policy for mirrors

2020-12-27 Thread Christopher Tubbs (Jira)
[ https://issues.apache.org/jira/browse/MNG-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255192#comment-17255192 ] Christopher Tubbs commented on MNG-5689: > This is not correct. The mirror is still