[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #221: Upgrade Groovy in one of the ITs to support JDK 19

2023-01-03 Thread GitBox
slawekjaranowski merged PR #221: URL: https://github.com/apache/maven-integration-testing/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[jira] [Closed] (SUREFIRE-2109) User cannot write temporary file to surefire/ temp directory

2023-01-03 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed SUREFIRE-2109. - Fix Version/s: 3.0.0-M8 Assignee: Slawomir Jaranowski Resolutio

[GitHub] [maven-surefire] slawekjaranowski merged pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name

2023-01-03 Thread GitBox
slawekjaranowski merged PR #554: URL: https://github.com/apache/maven-surefire/pull/554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (MNG-7596) Upgrade to plexus-utils 3.5.0

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654328#comment-17654328 ] ASF GitHub Bot commented on MNG-7596: - hboutemy commented on code in PR #866: URL: http

[GitHub] [maven] hboutemy commented on a diff in pull request #866: [MNG-7596] Upgrade to plexus 3.5.0

2023-01-03 Thread GitBox
hboutemy commented on code in PR #866: URL: https://github.com/apache/maven/pull/866#discussion_r1061205771 ## maven-xml-impl/src/main/java/org/apache/maven/internal/xml/Xpp3Dom.java: ## @@ -180,8 +181,6 @@ public void writeToSerializer(String namespace, XmlSerializer serialize

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654317#comment-17654317 ] ASF GitHub Bot commented on DOXIA-617: -- hboutemy commented on PR #132: URL: https://g

[GitHub] [maven-doxia] hboutemy commented on pull request #132: [DOXIA-617] support yaml metadata

2023-01-03 Thread GitBox
hboutemy commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1370556912 I don't get what benefit you get from this complex regexp to add the markers vs the simple marker removal code that keeps all existing code in place without needing to reimplement the

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654315#comment-17654315 ] ASF GitHub Bot commented on DOXIA-617: -- hboutemy commented on code in PR #132: URL: h

[GitHub] [maven-doxia] hboutemy commented on a diff in pull request #132: [DOXIA-617] support yaml metadata

2023-01-03 Thread GitBox
hboutemy commented on code in PR #132: URL: https://github.com/apache/maven-doxia/pull/132#discussion_r1061185557 ## doxia-modules/doxia-module-markdown/src/test/resources/metadata-yaml.md: ## @@ -0,0 +1,14 @@ +--- +title: A Title & a 'Test' +author: Somebody 'Nickname' Great +

[jira] [Commented] (MNG-6806) Provide Maven BOM

2023-01-03 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654314#comment-17654314 ] Herve Boutemy commented on MNG-6806: notice that due to a typo, the Git commit refers t

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name

2023-01-03 Thread GitBox
slawekjaranowski commented on PR #554: URL: https://github.com/apache/maven-surefire/pull/554#issuecomment-1370318893 Looks good enough ... I see one another issue - what when JVM not exit immediately ... like in mvnd - classes are loaded once and can be reused. But it can be next issue

[jira] [Closed] (SUREFIRE-1962) Unit test for ProviderInfo#isApplicable

2023-01-03 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed SUREFIRE-1962. - Fix Version/s: 3.0.0-M8 Resolution: Fixed > Unit test for ProviderInfo#

[GitHub] [maven-surefire] slawekjaranowski merged pull request #445: [SUREFIRE-1962] Unit test for ProviderInfo#isApplicable

2023-01-03 Thread GitBox
slawekjaranowski merged PR #445: URL: https://github.com/apache/maven-surefire/pull/445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (MWRAPPER-67) mvnw script does not download jar if used in git bash in windows

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654191#comment-17654191 ] ASF GitHub Bot commented on MWRAPPER-67: hazendaz commented on PR #44: URL: http

[GitHub] [maven-wrapper] hazendaz commented on pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

2023-01-03 Thread GitBox
hazendaz commented on PR #44: URL: https://github.com/apache/maven-wrapper/pull/44#issuecomment-1370262620 @michael-o Ping, any possibility of this being merged before next release happens? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [maven-integration-testing] psiroky commented on pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky commented on PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#issuecomment-1370261138 Once I had these changes done I noticed @slawekjaranowski solved this a bit differently in `maven-enforcer` (https://github.com/apache/maven-enforcer/commit/74228deccd43e

[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky commented on code in PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#discussion_r1060979574 ## core-it-support/maven-it-plugin-bootstrap/src/main/java/org/apache/maven/its/bootstrap/DownloadMojo.java: ## @@ -132,7 +131,7 @@ static Dependency t

[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky commented on code in PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#discussion_r1060979196 ## core-it-support/core-it-plugins/maven-it-plugin-site/pom.xml: ## @@ -67,6 +68,40 @@ under the License. org.apache.maven.reporting mave

[GitHub] [maven-integration-testing] psiroky commented on a diff in pull request #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky commented on code in PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#discussion_r1060978463 ## core-it-support/core-it-plugins/maven-it-plugin-settings/src/main/java/org/apache/maven/plugin/coreit/SettingsReadItMojo.java: ## @@ -59,22 +58,14 @

[GitHub] [maven-integration-testing] psiroky opened a new pull request, #223: [MNG-7661] Use provided scope for Maven deps in IT plugins

2023-01-03 Thread GitBox
psiroky opened a new pull request, #223: URL: https://github.com/apache/maven-integration-testing/pull/223 This fixes these kinds of warnings: ``` [INFO] --- maven-plugin-plugin:3.6.4:descriptor (default-descriptor) @ maven-it-plugin-bootstrap --- [ERROR] Some dependencies of Maven

[jira] [Updated] (MNG-7661) Fix IT build / compiler warnings

2023-01-03 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petr Široký updated MNG-7661: - Description: I noticed there is a quite a few build (from Maven) and also compiler warnings (e.g. using de

[jira] [Created] (MNG-7661) Fix IT build / compiler warnings

2023-01-03 Thread Jira
Petr Široký created MNG-7661: Summary: Fix IT build / compiler warnings Key: MNG-7661 URL: https://issues.apache.org/jira/browse/MNG-7661 Project: Maven Issue Type: Task Components: Int

[jira] [Closed] (MNG-7652) switch to Modello Velocity Maven plugin

2023-01-03 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MNG-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MNG-7652. -- Fix Version/s: 4.0.0-alpha-4 Resolution: Fixed merged in https://github.com/apache/maven/commit/a

[jira] [Commented] (MNG-7652) switch to Modello Velocity Maven plugin

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654186#comment-17654186 ] ASF GitHub Bot commented on MNG-7652: - hboutemy merged PR #944: URL: https://github.com

[GitHub] [maven] hboutemy merged pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
hboutemy merged PR #944: URL: https://github.com/apache/maven/pull/944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[jira] [Created] (MWRAPPER-87) Provide a switch to use default repository URL

2023-01-03 Thread Jira
Björn Michael created MWRAPPER-87: - Summary: Provide a switch to use default repository URL Key: MWRAPPER-87 URL: https://issues.apache.org/jira/browse/MWRAPPER-87 Project: Maven Wrapper Issu

[jira] [Comment Edited] (MNG-7659) ComparableVersion cache

2023-01-03 Thread Andrzej Jarmoniuk (Jira)
[ https://issues.apache.org/jira/browse/MNG-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653824#comment-17653824 ] Andrzej Jarmoniuk edited comment on MNG-7659 at 1/3/23 7:55 PM: -

[jira] [Comment Edited] (MNG-7659) ComparableVersion cache

2023-01-03 Thread Andrzej Jarmoniuk (Jira)
[ https://issues.apache.org/jira/browse/MNG-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653824#comment-17653824 ] Andrzej Jarmoniuk edited comment on MNG-7659 at 1/3/23 7:55 PM: -

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060884704 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/internal/EnforcerRuleManager.java: ## @@ -25,33 +25,52 @@ import java.util.Arr

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060884107 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/internal/EnforcerRuleManager.java: ## @@ -93,6 +112,16 @@ public List createRule

[jira] [Commented] (MWRAPPER-86) Trim trailing slash in Repo URL

2023-01-03 Thread Jira
[ https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654146#comment-17654146 ] Björn Michael commented on MWRAPPER-86: --- The URLs were corrected manually after th

[jira] [Closed] (SUREFIRE-2138) Update JUnit versions used in docs/ITs

2023-01-03 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed SUREFIRE-2138. - Fix Version/s: 3.0.0-M8 Assignee: Slawomir Jaranowski Resolutio

[GitHub] [maven-surefire] slawekjaranowski merged pull request #590: [SUREFIRE-2138] Update Junit4/5 version in docs and ITs

2023-01-03 Thread GitBox
slawekjaranowski merged PR #590: URL: https://github.com/apache/maven-surefire/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Closed] (MNG-7660) Rename Dom to XmlNode in the v4 api

2023-01-03 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7660. Assignee: Guillaume Nodet Resolution: Fixed > Rename Dom to XmlNode in the v4 api > ---

[jira] [Commented] (MNG-7660) Rename Dom to XmlNode in the v4 api

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654076#comment-17654076 ] ASF GitHub Bot commented on MNG-7660: - gnodet merged PR #946: URL: https://github.com/a

[GitHub] [maven] gnodet merged pull request #946: [MNG-7660] Rename Dom to XmlNode in the v4 api

2023-01-03 Thread GitBox
gnodet merged PR #946: URL: https://github.com/apache/maven/pull/946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

[jira] [Commented] (MNG-7652) switch to Modello Velocity Maven plugin

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654075#comment-17654075 ] ASF GitHub Bot commented on MNG-7652: - michael-o commented on code in PR #944: URL: htt

[GitHub] [maven] michael-o commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
michael-o commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060715950 ## api/maven-api-model/pom.xml: ## @@ -63,26 +63,26 @@ under the License. -org.apache.maven -modello-plugin-velocity - -

[jira] [Commented] (MNG-7652) switch to Modello Velocity Maven plugin

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654065#comment-17654065 ] ASF GitHub Bot commented on MNG-7652: - hboutemy commented on code in PR #944: URL: http

[GitHub] [maven] hboutemy commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
hboutemy commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060691858 ## api/maven-api-model/pom.xml: ## @@ -63,26 +63,26 @@ under the License. -org.apache.maven -modello-plugin-velocity - -

[jira] [Commented] (MNG-7652) switch to Modello Velocity Maven plugin

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654062#comment-17654062 ] ASF GitHub Bot commented on MNG-7652: - hboutemy commented on code in PR #944: URL: http

[GitHub] [maven] hboutemy commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
hboutemy commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060691858 ## api/maven-api-model/pom.xml: ## @@ -63,26 +63,26 @@ under the License. -org.apache.maven -modello-plugin-velocity - -

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060686023 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (MWRAPPER-86) Trim trailing slash in Repo URL

2023-01-03 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654023#comment-17654023 ] Michael Osipov commented on MWRAPPER-86: Which problem do you experience, accord

[jira] [Comment Edited] (MWRAPPER-86) Trim trailing slash in Repo URL

2023-01-03 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654023#comment-17654023 ] Michael Osipov edited comment on MWRAPPER-86 at 1/3/23 2:17 PM: --

[GitHub] [maven-enforcer] kwin commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
kwin commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060575511 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (AS

[jira] [Created] (MWRAPPER-86) Trim trailing slash in Repo URL

2023-01-03 Thread Jira
Björn Michael created MWRAPPER-86: - Summary: Trim trailing slash in Repo URL Key: MWRAPPER-86 URL: https://issues.apache.org/jira/browse/MWRAPPER-86 Project: Maven Wrapper Issue Type: Bug

[jira] [Updated] (SUREFIRE-2137) Run junit jupiter platform ITs with latest 5.8.x and 5.9.x as well

2023-01-03 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated SUREFIRE-2137: -- Issue Type: Task (was: Improvement) > Run junit jupiter platform ITs with l

[jira] [Closed] (SUREFIRE-2137) Run junit jupiter platform ITs with latest 5.8.x and 5.9.x as well

2023-01-03 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed SUREFIRE-2137. - Fix Version/s: 3.0.0-M8 Assignee: Slawomir Jaranowski Resolutio

[GitHub] [maven-surefire] slawekjaranowski merged pull request #588: [SUREFIRE-2137] Run JUnitPlatform ITs with latest 5.8.x/5.9.x as well

2023-01-03 Thread GitBox
slawekjaranowski merged PR #588: URL: https://github.com/apache/maven-surefire/pull/588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060550808 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
slawekjaranowski commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060542315 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [maven-artifact-transfer] dependabot[bot] commented on pull request #85: Bump apiMaven.version from 3.0 to 3.8.7

2023-01-03 Thread GitBox
dependabot[bot] commented on PR #85: URL: https://github.com/apache/maven-artifact-transfer/pull/85#issuecomment-1369705092 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a

[GitHub] [maven-artifact-transfer] slawekjaranowski closed pull request #85: Bump apiMaven.version from 3.0 to 3.8.7

2023-01-03 Thread GitBox
slawekjaranowski closed pull request #85: Bump apiMaven.version from 3.0 to 3.8.7 URL: https://github.com/apache/maven-artifact-transfer/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request, #85: Bump apiMaven.version from 3.0 to 3.8.7

2023-01-03 Thread GitBox
dependabot[bot] opened a new pull request, #85: URL: https://github.com/apache/maven-artifact-transfer/pull/85 Bumps `apiMaven.version` from 3.0 to 3.8.7. Updates `maven-core` from 3.0 to 3.8.7 Release notes Sourced from https://github.com/apache/maven/releases";>maven-core's re

[GitHub] [maven-enforcer] kwin commented on a diff in pull request #216: [MENFORCER-455] New Enforcer API

2023-01-03 Thread GitBox
kwin commented on code in PR #216: URL: https://github.com/apache/maven-enforcer/pull/216#discussion_r1060512105 ## enforcer-api/src/main/java/org/apache/maven/enforcer/rule/api/AbstractEnforcerRule.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [maven-surefire] andpab commented on pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name

2023-01-03 Thread GitBox
andpab commented on PR #554: URL: https://github.com/apache/maven-surefire/pull/554#issuecomment-1369670644 @olamy Can you merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-surefire] sman-81 commented on pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name

2023-01-03 Thread GitBox
sman-81 commented on PR #554: URL: https://github.com/apache/maven-surefire/pull/554#issuecomment-1369647504 This is ready to ship now. Who can merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request, #110: Bump release-drafter/release-drafter from 5.21.1 to 5.22.0

2023-01-03 Thread GitBox
dependabot[bot] opened a new pull request, #110: URL: https://github.com/apache/maven-pmd-plugin/pull/110 Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.21.1 to 5.22.0. Release notes Sourced from https://github.com/release-drafte

[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-03 Thread GitBox
timtebeek commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060445903 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import java.util.Properties

[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-03 Thread GitBox
timtebeek commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060443396 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/WrapperExecutorTest.java: ## @@ -222,27 +226,27 @@ public void testEnvironmentVariableOverwrite_mvnwRepoUrl

[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter

2023-01-03 Thread GitBox
bmarwell commented on code in PR #61: URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060406639 ## maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java: ## @@ -31,23 +31,23 @@ import java.util.Map; import java.util.Properties;

[GitHub] [maven-gh-actions-shared] slawekjaranowski merged pull request #64: Bump release-drafter/release-drafter from 5.21.1 to 5.22.0

2023-01-03 Thread GitBox
slawekjaranowski merged PR #64: URL: https://github.com/apache/maven-gh-actions-shared/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [maven-gh-actions-shared] slawekjaranowski merged pull request #65: Bump release-drafter/release-drafter from 5.21.1 to 5.22.0

2023-01-03 Thread GitBox
slawekjaranowski merged PR #65: URL: https://github.com/apache/maven-gh-actions-shared/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [maven-surefire] andpab commented on a diff in pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4

2023-01-03 Thread GitBox
andpab commented on code in PR #516: URL: https://github.com/apache/maven-surefire/pull/516#discussion_r1060357685 ## surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java: ## @@ -314,28 +313,26 @@ private String

[jira] [Commented] (MNG-7652) switch to Modello Velocity Maven plugin

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653859#comment-17653859 ] ASF GitHub Bot commented on MNG-7652: - gnodet commented on code in PR #944: URL: https:

[jira] [Commented] (MNG-7652) switch to Modello Velocity Maven plugin

2023-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653858#comment-17653858 ] ASF GitHub Bot commented on MNG-7652: - gnodet commented on code in PR #944: URL: https:

[GitHub] [maven] gnodet commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
gnodet commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060357689 ## api/pom.xml: ## @@ -45,6 +44,27 @@ api + + + + + org.codehaus.modello + modello-maven-plugin + + +

[GitHub] [maven] gnodet commented on a diff in pull request #944: [MNG-7652] switch to Modello Velocity

2023-01-03 Thread GitBox
gnodet commented on code in PR #944: URL: https://github.com/apache/maven/pull/944#discussion_r1060357689 ## api/pom.xml: ## @@ -45,6 +44,27 @@ api + + + + + org.codehaus.modello + modello-maven-plugin + + +

[jira] [Commented] (MNG-7536) Mojo execution locking in Maven 3.8.5 deadlocks my plugin

2023-01-03 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653857#comment-17653857 ] Michael Osipov commented on MNG-7536: - bq. It's disappointing for a potential deadlock