[GitHub] [maven-site] slachiewicz commented on pull request #402: Bump plantuml from 1.2023.4 to 1.2023.5

2023-03-29 Thread via GitHub
slachiewicz commented on PR #402: URL: https://github.com/apache/maven-site/pull/402#issuecomment-1489779359 V1.2023.5 (24 Mar, 2023) [Error in generating State Diagram](https://github.com/plantuml/plantuml/issues/1357) [Bug - Crowfoot notation on ERD rendering buggy](https://github.c

[GitHub] [maven-site] slachiewicz commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
slachiewicz commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489762593 i've added change to bump to fluido-2.0.0-M5 to easier test and help with release vote -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [maven-site] hboutemy commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
hboutemy commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489761388 IIUC, not highlighted is less broken than table :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MRESOLVER-347) Transport http should be able to not reuse or maximize TTL of connections

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706699#comment-17706699 ] ASF GitHub Bot commented on MRESOLVER-347: -- ok2c commented on code in PR #274

[GitHub] [maven-resolver] ok2c commented on a diff in pull request #274: [MRESOLVER-347] Ability to control conn reuse

2023-03-29 Thread via GitHub
ok2c commented on code in PR #274: URL: https://github.com/apache/maven-resolver/pull/274#discussion_r1152756305 ## maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java: ## @@ -159,6 +159,37 @@ public final class ConfigurationProperties { */

[jira] [Updated] (MSKINS-216) Fix issue with missing dependency to plexus-utils in minify-maven-plugin and Maven 3.9.x

2023-03-29 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MSKINS-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MSKINS-216: - Description: {noformat}[ERROR] Failed to execute goal com.samaxes.maven:minify-maven-plugin:1.7.

[jira] [Commented] (MRESOLVER-347) Transport http should be able to not reuse or maximize TTL of connections

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706668#comment-17706668 ] ASF GitHub Bot commented on MRESOLVER-347: -- kwin commented on code in PR #274

[GitHub] [maven-resolver] kwin commented on a diff in pull request #274: [MRESOLVER-347] Ability to control conn reuse

2023-03-29 Thread via GitHub
kwin commented on code in PR #274: URL: https://github.com/apache/maven-resolver/pull/274#discussion_r1152684480 ## maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java: ## @@ -159,6 +159,37 @@ public final class ConfigurationProperties { */

[jira] [Commented] (MBUILDCACHE-45) Compiled classes are not copied/restored to target, causing higher phase builds to fail

2023-03-29 Thread Jira
[ https://issues.apache.org/jira/browse/MBUILDCACHE-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706667#comment-17706667 ] Tomáš Mrázek commented on MBUILDCACHE-45: -   You have to for some reason exp

[GitHub] [maven-stage-plugin] elharo commented on pull request #7: [MSTAGE-26] - Fix and un-ignore RepositoryCopierTest

2023-03-29 Thread via GitHub
elharo commented on PR #7: URL: https://github.com/apache/maven-stage-plugin/pull/7#issuecomment-1489502511 Looks like a credential problem in the CI unrelated to this PR. Unsure how to fix this: Recording test results [GitHub Checks] Causes for no suitable publisher found:

[GitHub] [maven-stage-plugin] elharo opened a new pull request, #11: Pullrequest

2023-03-29 Thread via GitHub
elharo opened a new pull request, #11: URL: https://github.com/apache/maven-stage-plugin/pull/11 fire ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[jira] [Created] (MDEP-848) Dependency Analysis does not work under Java 20

2023-03-29 Thread Mark Derricutt (Jira)
Mark Derricutt created MDEP-848: --- Summary: Dependency Analysis does not work under Java 20 Key: MDEP-848 URL: https://issues.apache.org/jira/browse/MDEP-848 Project: Maven Dependency Plugin Iss

[jira] [Created] (MINVOKER-334) incorrect basedir on windows

2023-03-29 Thread James Nord (Jira)
James Nord created MINVOKER-334: --- Summary: incorrect basedir on windows Key: MINVOKER-334 URL: https://issues.apache.org/jira/browse/MINVOKER-334 Project: Maven Invoker Plugin Issue Type: Bug

[GitHub] [maven-site] michael-o commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
michael-o commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489224344 > I simply built a site with this change and tables looks more better. Yes, but the source code blocks are broken, not highlighted. -- This is an automated message from the Apa

[GitHub] [maven-site] slawekjaranowski commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
slawekjaranowski commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489193991 I simply built a site with this change and tables looks more better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [maven-stage-plugin] michaelboyles commented on pull request #7: [MSTAGE-26] - Fix and un-ignore RepositoryCopierTest

2023-03-29 Thread via GitHub
michaelboyles commented on PR #7: URL: https://github.com/apache/maven-stage-plugin/pull/7#issuecomment-1489192555 @elharo Done, please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Comment Edited] (MBUILDCACHE-47) Extension computes a new check sum for a project with multiple modules without any changes

2023-03-29 Thread Venelin Koulaxazov (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706576#comment-17706576 ] Venelin Koulaxazov edited comment on MBUILDCACHE-47 at 3/29/23 7:27 PM: ---

[jira] [Commented] (MBUILDCACHE-47) Extension computes a new check sum for a project with multiple modules without any changes

2023-03-29 Thread Venelin Koulaxazov (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706576#comment-17706576 ] Venelin Koulaxazov commented on MBUILDCACHE-47: --- Wonderful thank you ve

[jira] [Commented] (MNG-5659) Project specific settings.xml

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706575#comment-17706575 ] ASF GitHub Bot commented on MNG-5659: - rmannibucau commented on PR #1059: URL: https://

[GitHub] [maven] rmannibucau commented on pull request #1059: [MNG-5659] Provide project-specific settings located in [root]/.mvn/settings.xml by default

2023-03-29 Thread via GitHub
rmannibucau commented on PR #1059: URL: https://github.com/apache/maven/pull/1059#issuecomment-1489173930 Can `${maven.multiModuleProjectDirectory}/.mvn/settings.xml` become `${maven.multiModuleProjectDirectory}/.mvn/project.settings.xml` or something like that since `.mvn/settings.xml` is

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706574#comment-17706574 ] ASF GitHub Bot commented on MNG-7038: - rmannibucau commented on PR #1061: URL: https://

[GitHub] [maven] rmannibucau commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
rmannibucau commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1489172763 > Imho, we need this definition before parsing any project POM , else use cases such as https://github.com/apache/maven/pull/1059 or https://github.com/apache/maven/pull/1062 cannot be

[jira] [Created] (MNG-7752) can't download transitive dependencies if there is an expression in the pom

2023-03-29 Thread Jim Sellers (Jira)
Jim Sellers created MNG-7752: Summary: can't download transitive dependencies if there is an expression in the pom Key: MNG-7752 URL: https://issues.apache.org/jira/browse/MNG-7752 Project: Maven

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706568#comment-17706568 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on PR #1061: URL: https://githu

[GitHub] [maven] gnodet commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1489148686 > > But the parent/child relationship has to be done later in the process, so can't be used for early interpolation. > > Interpolation does not really works there anyway so no, but yes

[jira] [Commented] (MBUILDCACHE-47) Extension computes a new check sum for a project with multiple modules without any changes

2023-03-29 Thread Maximilian Novikov (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706565#comment-17706565 ] Maximilian Novikov commented on MBUILDCACHE-47: --- At the moment the buil

[GitHub] [maven-site] michael-o commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
michael-o commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489137504 > We are still on Doxia 2.0.0-M3 ( > > https://github.com/apache/maven-site/blob/4624b5cb3301670c7faac8d838844f0ba35bdfc9/pom.xml#L78 > ) therefore probably not affected by h

[jira] [Commented] (MSITE-933) mvn site fails when contains &

2023-03-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706563#comment-17706563 ] Michael Osipov commented on MSITE-933: -- Funny, found this in the code: {code:java}

[GitHub] [maven-site] kwin commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
kwin commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489122877 We are still on Doxia 2.0.0-M3 (https://github.com/apache/maven-site/blob/4624b5cb3301670c7faac8d838844f0ba35bdfc9/pom.xml#L78) therefore probably not affected by https://issues.apache.org

[jira] [Assigned] (MSITE-933) mvn site fails when contains &

2023-03-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MSITE-933: Assignee: Michael Osipov > mvn site fails when contains & > --

[jira] [Commented] (MSITE-933) mvn site fails when contains &

2023-03-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706557#comment-17706557 ] Michael Osipov commented on MSITE-933: -- Your request is totally valid. What needs to

[jira] [Commented] (MSITE-933) mvn site fails when contains &

2023-03-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706556#comment-17706556 ] Michael Osipov commented on MSITE-933: -- Well, yes I can confirm that the entire inter

[jira] [Commented] (MNG-7656) Dependencies copied to target have stricter permissions

2023-03-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706553#comment-17706553 ] Michael Osipov commented on MNG-7656: - [~cstamas], I think this is resolved. Please add

[GitHub] [maven-enforcer] kwin merged pull request #265: improve documentation of banDynamicVersions

2023-03-29 Thread via GitHub
kwin merged PR #265: URL: https://github.com/apache/maven-enforcer/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706547#comment-17706547 ] ASF GitHub Bot commented on MNG-7038: - rmannibucau commented on PR #1061: URL: https://

[GitHub] [maven] rmannibucau commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
rmannibucau commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1489105642 > But the parent/child relationship has to be done later in the process, so can't be used for early interpolation. Interpolation does not really works there anyway so no, but yes

[GitHub] [maven-site] michael-o commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
michael-o commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489093701 > It is broken currently! Is it worse with m3 or better? At least the table in https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html looks correct wit

[GitHub] [maven-site] kwin commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
kwin commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489081339 It is broken currently! Is it worse with m3 or better? At least the table in https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html looks correct with m3 (an

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706535#comment-17706535 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on PR #1061: URL: https://githu

[GitHub] [maven] gnodet commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1489078230 > So this PR just duplicates the properties we have without solving any new feature but does it differently from before. Git is different because the bubbling is cleaner whereas .mvn is an u

[GitHub] [maven-site] michael-o commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
michael-o commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489069675 > m-site-p is already on version 4.0.0-M6, > > https://github.com/apache/maven-site/blob/4624b5cb3301670c7faac8d838844f0ba35bdfc9/pom.xml#L116 Then you should wit for M5 o

[GitHub] [maven-site] kwin commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
kwin commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489067849 m-site-p is already on version 4.0.0-M6, https://github.com/apache/maven-site/blob/4624b5cb3301670c7faac8d838844f0ba35bdfc9/pom.xml#L116 -- This is an automated message from the Apache Gi

[GitHub] [maven-site] michael-o commented on pull request #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
michael-o commented on PR #404: URL: https://github.com/apache/maven-site/pull/404#issuecomment-1489065395 This needs to go hand in hand with Maven Site Plugin, but consider that there might be plugins which aren't compatible anymore. They won't fail, but they might produce garbage output.

[jira] [Comment Edited] (MBUILDCACHE-47) Extension computes a new check sum for a project with multiple modules without any changes

2023-03-29 Thread Venelin Koulaxazov (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706524#comment-17706524 ] Venelin Koulaxazov edited comment on MBUILDCACHE-47 at 3/29/23 5:51 PM: ---

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706527#comment-17706527 ] ASF GitHub Bot commented on MNG-7038: - rmannibucau commented on PR #1061: URL: https://

[GitHub] [maven] rmannibucau commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
rmannibucau commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1489045762 So this PR just duplicates the properties we have without solving any new feature but does it differently from before. Git is different because the bubbling is cleaner whereas .mvn is

[jira] [Commented] (MBUILDCACHE-47) Extension computes a new check sum for a project with multiple modules without any changes

2023-03-29 Thread Venelin Koulaxazov (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706524#comment-17706524 ] Venelin Koulaxazov commented on MBUILDCACHE-47: --- Adding the property in

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706523#comment-17706523 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on PR #1061: URL: https://githu

[GitHub] [maven] gnodet commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1489027939 > > well the parent-child relation, and I often build setups where there are not really parent/child > > as much as the `.mvn` thing actually, we are used to get it in the root dir bu

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706521#comment-17706521 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on PR #1061: URL: https://githu

[GitHub] [maven] gnodet commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1489020126 > I'm very confused by this PR, what I see: > > 1. we had 2 dir properties and they are deprecated in favor of 2 dir properties, can't we fix the previous ones? My option was to

[GitHub] [maven-site] kwin opened a new pull request, #404: Update to m-fluido 2.0.0-M3 due to

2023-03-29 Thread via GitHub
kwin opened a new pull request, #404: URL: https://github.com/apache/maven-site/pull/404 https://issues.apache.org/jira/browse/MSKINS-207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706519#comment-17706519 ] ASF GitHub Bot commented on MNG-7038: - rmannibucau commented on PR #1061: URL: https://

[GitHub] [maven] rmannibucau commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
rmannibucau commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1489011010 > well the parent-child relation, and I often build setups where there are not really parent/child as much as the `.mvn` thing actually, we are used to get it in the root dir but

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706517#comment-17706517 ] ASF GitHub Bot commented on MNG-7038: - laeubi commented on PR #1061: URL: https://githu

[GitHub] [maven] laeubi commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
laeubi commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1488999749 I only can add that I always have a `.mvn` dir in any setup, so "still not mainstream so will likely always fail " is probably depending on personal use-cases and experience. Also I l

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706509#comment-17706509 ] ASF GitHub Bot commented on MNG-7038: - rmannibucau commented on PR #1061: URL: https://

[GitHub] [maven] rmannibucau commented on pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
rmannibucau commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1488942008 I'm very confused by this PR, what I see: 1. we had 2 dir properties and they are deprecated in favor of 2 dir properties, can't we fix the previous ones? 2. the root dir is de

[GitHub] [maven-enforcer] kwin opened a new pull request, #265: improve documentation of banDynamicVersions

2023-03-29 Thread via GitHub
kwin opened a new pull request, #265: URL: https://github.com/apache/maven-enforcer/pull/265 fix wrong description of allowRanges add JIRA link for allowRangesWithIdenticalBounds clarify excludedScopes Following this checklist to help us incorporate your contribution quickly

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706497#comment-17706497 ] ASF GitHub Bot commented on MNG-7038: - michael-o commented on code in PR #1061: URL: ht

[GitHub] [maven] michael-o commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
michael-o commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152181028 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type) thr

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706438#comment-17706438 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152107242 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type) throws

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706424#comment-17706424 ] ASF GitHub Bot commented on MNG-7038: - michael-o commented on code in PR #1061: URL: ht

[GitHub] [maven] michael-o commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
michael-o commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152079980 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type) thr

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706423#comment-17706423 ] ASF GitHub Bot commented on MNG-7038: - michael-o commented on code in PR #1061: URL: ht

[GitHub] [maven] michael-o commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
michael-o commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152077350 ## maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java: ## @@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map> too

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706410#comment-17706410 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152028179 ## maven-model-builder/src/main/java/org/apache/maven/model/interpolation/AbstractStringBasedModelInterpolator.java: ## @@ -133,6 +134,21 @@ public Object getValue(String

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706408#comment-17706408 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706409#comment-17706409 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152023745 ## maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java: ## @@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map> too

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152023745 ## maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java: ## @@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map> too

[GitHub] [maven] michael-o commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
michael-o commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152018222 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type) thr

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706403#comment-17706403 ] ASF GitHub Bot commented on MNG-7038: - michael-o commented on code in PR #1061: URL: ht

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706402#comment-17706402 ] ASF GitHub Bot commented on MNG-7038: - michael-o commented on code in PR #1061: URL: ht

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706401#comment-17706401 ] ASF GitHub Bot commented on MNG-7038: - michael-o commented on code in PR #1061: URL: ht

[GitHub] [maven] michael-o commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
michael-o commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152016383 ## maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java: ## @@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map> too

[GitHub] [maven] michael-o commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
michael-o commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152000103 ## maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java: ## @@ -494,14 +504,50 @@ public interface MavenExecutionRequest { /** *

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706399#comment-17706399 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152011959 ## maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java: ## @@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map> too

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706398#comment-17706398 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152003319 ## maven-model-builder/src/site/apt/index.apt: ## @@ -192,6 +192,10 @@ Maven Model Builder *+--+--+ | <<>> | The path to the current Maven home. | <<<$\{mav

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706395#comment-17706395 ] ASF GitHub Bot commented on MNG-7038: - michael-o commented on code in PR #1061: URL: ht

[GitHub] [maven] michael-o commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
michael-o commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151997995 ## maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java: ## @@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map> too

[GitHub] [maven-project-info-reports-plugin] elharo commented on pull request #46: [MPIR-432] upgrade to parent POM 39

2023-03-29 Thread via GitHub
elharo commented on PR #46: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/46#issuecomment-1488648543 https://github.com/google/google-java-format/issues/697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [maven-project-info-reports-plugin] elharo commented on pull request #46: [MPIR-432] upgrade to parent POM 39

2023-03-29 Thread via GitHub
elharo commented on PR #46: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/46#issuecomment-1488644198 Fixed the duplicate licenses. The Modifier.SEALED problem remains. I am really not happy with the palantir-java-format. It seems quite buggy and unreliable. I wonder

[GitHub] [maven-mvnd] ppalaga commented on issue #828: Failed to load native library:jansi-2.4.0-b00c64e8b23a020c-jansi.dll. osinfo: Windows/x86_64

2023-03-29 Thread via GitHub
ppalaga commented on issue #828: URL: https://github.com/apache/maven-mvnd/issues/828#issuecomment-1488609917 Perhaps a duplicate of https://github.com/apache/maven-mvnd/issues/571? - that one suggests to upgrade to a newer Java 11 version. You say you have openjdk 20. Does it work with an

[GitHub] [maven-mvnd] ppalaga commented on pull request #810: Add configuration to send build scans to https://ge.apache.org

2023-03-29 Thread via GitHub
ppalaga commented on PR #810: URL: https://github.com/apache/maven-mvnd/pull/810#issuecomment-1488602421 Sorry gentlemen, no time at all for mvnd this month. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Created] (MSITE-933) mvn site fails when contains &

2023-03-29 Thread Heiko Selber (Jira)
Heiko Selber created MSITE-933: -- Summary: mvn site fails when contains & Key: MSITE-933 URL: https://issues.apache.org/jira/browse/MSITE-933 Project: Maven Site Plugin Issue Type: Bug Affec

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706355#comment-17706355 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151777611 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type) throws

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706352#comment-17706352 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151777611 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type) throws

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706308#comment-17706308 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151708471 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -86,8 +86,34 @@ default String getId() { return getModel().getId(); } +/**

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706306#comment-17706306 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151706480 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type) throws

[jira] [Commented] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706305#comment-17706305 ] ASF GitHub Bot commented on MNG-7038: - gnodet commented on code in PR #1061: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-03-29 Thread via GitHub
gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151704300 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -321,6 +323,46 @@ void initialize(CliRequest cliRequest) throws ExitException { }

  1   2   >