[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1171886117 ## maven-model-builder/src/main/java/org/apache/maven/model/root/DefaultRootLocator.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1171642600 ## maven-model-builder/src/main/java/org/apache/maven/model/root/DefaultRootLocator.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1171542519 ## maven-model-builder/src/main/java/org/apache/maven/model/root/DefaultRootLocator.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1171534446 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -320,6 +324,49 @@ void initialize(CliRequest cliRequest) throws ExitException { }

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1171526547 ## maven-model-builder/src/main/java/org/apache/maven/model/root/DefaultRootLocator.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1171483867 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -320,6 +324,49 @@ void initialize(CliRequest cliRequest) throws ExitException { }

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1171253490 ## maven-model-builder/src/site/apt/index.apt: ## @@ -183,13 +183,17 @@ Maven Model Builder | <<>>\ <<>> () | the directory containing the <<>> file as URI |

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1166567100 ## maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java: ## @@ -494,14 +504,49 @@ public interface MavenExecutionRequest { /** *

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1163893091 ## maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -1679,4 +1681,13 @@ public ProjectBuildingRequest getProjectBuildingRequest() { public

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1160912659 ## maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java: ## @@ -494,14 +504,51 @@ public interface MavenExecutionRequest { /** *

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1160797325 ## maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java: ## @@ -494,14 +504,51 @@ public interface MavenExecutionRequest { /** *

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152107242 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type)

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152028179 ## maven-model-builder/src/main/java/org/apache/maven/model/interpolation/AbstractStringBasedModelInterpolator.java: ## @@ -133,6 +134,21 @@ public Object getValue(String

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152023745 ## maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java: ## @@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map> too

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152023745 ## maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java: ## @@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map> too

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152011959 ## maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java: ## @@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map> too

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1152003319 ## maven-model-builder/src/site/apt/index.apt: ## @@ -192,6 +192,10 @@ Maven Model Builder *+--+--+ | <<>> | The path to the current Maven home. |

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151777611 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type)

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151777611 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type)

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151708471 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -86,8 +86,34 @@ default String getId() { return getModel().getId(); } +

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151706480 ## maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java: ## @@ -165,7 +165,11 @@ public Object evaluate(String expr, Class type)

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151704300 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -321,6 +323,46 @@ void initialize(CliRequest cliRequest) throws ExitException { }

[GitHub] [maven] gnodet commented on a diff in pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

gnodet commented on code in PR #1061: URL: https://github.com/apache/maven/pull/1061#discussion_r1151702341 ## maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java: ## @@ -494,14 +504,49 @@ public interface MavenExecutionRequest { /** *