[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064151253 > @gnodet Does this apply to 3.8.x? I guess we need a new JIRA issue to clearly document this problem/regression. @michael-o It does apply to 3.8.x, and yes, I'll create a JIR

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064126265 > But why/how does it breaks them? As described in the PR this currently leaks the CCL of the _last_ project in the chain, and even if it makes extensions work somehow it is clearly

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064120857 > This looks like another issue that is only similar to the other fix, but why should anything be reverted? It's not another issue. The https://github.com/apache/maven/commi

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064115889 > > > What is a build extension is declared in a submodule only? > > > > > > You mean "what if" ? That's my point, I don't think there are solid expectations wrt to the re

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064107249 > What is a build extension is declared in a submodule only? You mean "what if" ? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [maven] gnodet commented on pull request #690: [MNG-7402] Make sure the top level project classloader is used throughout the build

2022-03-10 Thread GitBox
gnodet commented on pull request #690: URL: https://github.com/apache/maven/pull/690#issuecomment-1064078828 > This does not supersede [e327be3](https://github.com/apache/maven/commit/e327be3d85918a23a5ba48d752143a6dbf8b83f7) but complements it? Yes, I actually don't think the first