slawekjaranowski commented on PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#issuecomment-2283484428
Ok I will do it 😄 in a few days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
VirtualTim commented on PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#issuecomment-2283009222
@elharo @slachiewicz @hboutemy
Sorry to bother you guys, but is there any plan on releasing a new version
of this plugin?
--
This is an automated message from the Apac
schedin commented on PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#issuecomment-2017361559
@elharo and @slachiewicz: Is there any plan on making a new release for
maven-jarsigner-plugin? I think the features I have implemented would be
beneficial for others as well.
schedin commented on PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#issuecomment-1943279373
I also think it would be good to release a new version of the plugin. For
what it is worth I have been running a custom build from the state of master
branch the 19th of Decem
VirtualTim commented on PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#issuecomment-1942937955
@elharo would it be possible to release a new version of this plugin
containing this?
My signing seems to be pretty flaky, and this would really help me out. Plus
#18 so
elharo merged PR #13:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@m
elharo commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1421831151
##
src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java:
##
@@ -126,4 +155,62 @@ protected JarSignerRequest createRequest(File archive)
t
schedin commented on PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#issuecomment-1849564284
I have fixed JUnit version.
I don't agree there is any problem `JarsignerSignMojo.waitAfterFailure()`
because it had test cases to test limit behaviors in addition to a
elharo commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1421830206
##
pom.xml:
##
@@ -128,6 +129,25 @@ under the License.
maven-jarsigner
3.0.0
+
+ junit
+ junit
+ 4.13
Review Comment:
schedin commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1421718112
##
src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java:
##
@@ -126,4 +155,62 @@ protected JarSignerRequest createRequest(File archive)
schedin commented on PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#issuecomment-1848914046
I have resolved/fixed all code review comments (at least from my
perspective) and have now set pull request back to "ready for review".
--
This is an automated message from
schedin commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1421718112
##
src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java:
##
@@ -126,4 +155,62 @@ protected JarSignerRequest createRequest(File archive)
schedin commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1421717905
##
src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java:
##
@@ -90,6 +94,30 @@ public class JarsignerSignMojo extends AbstractJarsignerMo
schedin commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1420602906
##
src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java:
##
@@ -251,78 +250,80 @@ public abstract class AbstractJarsignerMojo extends
schedin commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1420597254
##
src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java:
##
@@ -126,4 +155,62 @@ protected JarSignerRequest createRequest(File archive)
schedin commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1420595655
##
src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java:
##
@@ -126,4 +155,62 @@ protected JarSignerRequest createRequest(File archive)
schedin commented on code in PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#discussion_r1420595140
##
src/main/java/org/apache/maven/plugins/jarsigner/JarsignerSignMojo.java:
##
@@ -90,6 +94,30 @@ public class JarsignerSignMojo extends AbstractJarsignerMo
slachiewicz commented on PR #13:
URL:
https://github.com/apache/maven-jarsigner-plugin/pull/13#issuecomment-1842677968
Amazing work, thank you.
let's see what CI will say
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
schedin opened a new pull request, #13:
URL: https://github.com/apache/maven-jarsigner-plugin/pull/13
This pull request implements
https://issues.apache.org/jira/projects/MJARSIGNER/issues/MJARSIGNER-41 that
introduces a retry feature for when jar signing fails (typically for network
issue
19 matches
Mail list logo
