sebastien-doyon commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1772775302
@gnodet a new PR was created for that
[1296](https://github.com/apache/maven/pull/1296)
--
This is an automated message from the Apache Git Service.
To respond to the message,
sebastien-doyon commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1772754240
@gnodet
> There are still a couple of things to clean in this package
> `FileSizeFormat` should be moved to top level
Done in the last commit
> it
sebastien-doyon commented on code in PR #1269:
URL: https://github.com/apache/maven/pull/1269#discussion_r1366969590
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -64,20 +65,36 @@ public synchronized void
gnodet merged PR #1269:
URL: https://github.com/apache/maven/pull/1269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gnodet commented on code in PR #1269:
URL: https://github.com/apache/maven/pull/1269#discussion_r1366713989
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -64,20 +65,36 @@ public synchronized void
sebastien-doyon commented on code in PR #1269:
URL: https://github.com/apache/maven/pull/1269#discussion_r1365441412
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -135,7 +136,7 @@ public synchronized void
gnodet commented on code in PR #1269:
URL: https://github.com/apache/maven/pull/1269#discussion_r1365371612
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -135,7 +136,7 @@ public synchronized void
sebastien-doyon commented on code in PR #1269:
URL: https://github.com/apache/maven/pull/1269#discussion_r1365248238
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -135,7 +136,7 @@ public synchronized void
gnodet commented on code in PR #1269:
URL: https://github.com/apache/maven/pull/1269#discussion_r1365000724
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -135,7 +136,7 @@ public synchronized void
sebastien-doyon commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1768511456
@gnodet the last commit fixes the unit test that was broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sebastien-doyon commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1766473890
> @sebastien-doyon unit tests seem broken.
@gnodet yes, I am trying to find the problem, but without access to the
surefire report files, it is hard to find the problem. Do
gnodet commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1762920120
> @sebastien-doyon unit tests seem broken. Also and fwiw, this looks like
all this work may be broken if we somehow integrate #1279... we may want to
investigate on that branch then...
gnodet commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1762918806
@sebastien-doyon unit tests seem broken.
Also and fwiw, this looks like all this work may be broken if we somehow
integrate https://github.com/apache/maven/pull/1279... we may want to
sebastien-doyon commented on PR #1269:
URL: https://github.com/apache/maven/pull/1269#issuecomment-1760038298
Memory allocation profiling using
14 matches
Mail list logo
