[jira] [Commented] (METRON-1801) Allow Customization of Elasticsearch Document ID

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642753#comment-16642753 ] ASF GitHub Bot commented on METRON-1801: Github user mraliagha commented on the issue:

[GitHub] metron issue #1218: METRON-1801 Allow Customization of Elasticsearch Documen...

2018-10-08 Thread mraliagha
Github user mraliagha commented on the issue: https://github.com/apache/metron/pull/1218 @nickwallen in the case of event logs and the fact that retrieval segmentation would be mostly based on timestamp, it is recommended to use timestamp as a prefix of the id. For example, something

[jira] [Commented] (METRON-1806) Upgrade Maven Shade Plugin version

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642736#comment-16642736 ] ASF GitHub Bot commented on METRON-1806: Github user mmiklavc closed the pull request at:

[jira] [Commented] (METRON-1806) Upgrade Maven Shade Plugin version

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642738#comment-16642738 ] ASF GitHub Bot commented on METRON-1806: GitHub user mmiklavc reopened a pull request:

[GitHub] metron issue #1224: METRON-1806: Upgrade Maven Shade Plugin version

2018-10-08 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1224 Kick travis ---

[GitHub] metron pull request #1224: METRON-1806: Upgrade Maven Shade Plugin version

2018-10-08 Thread mmiklavc
Github user mmiklavc closed the pull request at: https://github.com/apache/metron/pull/1224 ---

[GitHub] metron pull request #1224: METRON-1806: Upgrade Maven Shade Plugin version

2018-10-08 Thread mmiklavc
GitHub user mmiklavc reopened a pull request: https://github.com/apache/metron/pull/1224 METRON-1806: Upgrade Maven Shade Plugin version ## Contributor Comments https://issues.apache.org/jira/browse/METRON-1806 Update the maven shade plugin version. There is a bug

[jira] [Commented] (METRON-1792) Simplify Profile Definitions in Integration Tests

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642566#comment-16642566 ] ASF GitHub Bot commented on METRON-1792: Github user asfgit closed the pull request at:

[GitHub] metron pull request #1211: METRON-1792 Simplify Profile Definitions in Integ...

2018-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1211 ---

[jira] [Commented] (METRON-1801) Allow Customization of Elasticsearch Document ID

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642561#comment-16642561 ] ASF GitHub Bot commented on METRON-1801: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1218: METRON-1801 Allow Customization of Elasticsearch ...

2018-10-08 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1218#discussion_r223514656 --- Diff: metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/writer/ElasticsearchWriterConfig.java --- @@ -0,0 +1,134

[jira] [Commented] (METRON-1801) Allow Customization of Elasticsearch Document ID

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642559#comment-16642559 ] ASF GitHub Bot commented on METRON-1801: Github user nickwallen commented on a diff in the pull

[jira] [Commented] (METRON-1801) Allow Customization of Elasticsearch Document ID

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642556#comment-16642556 ] ASF GitHub Bot commented on METRON-1801: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1218: METRON-1801 Allow Customization of Elasticsearch ...

2018-10-08 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1218#discussion_r223513848 --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchSearchIntegrationTest.java --- @@

[jira] [Commented] (METRON-1801) Allow Customization of Elasticsearch Document ID

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642554#comment-16642554 ] ASF GitHub Bot commented on METRON-1801: Github user nickwallen commented on the issue:

[GitHub] metron issue #1218: METRON-1801 Allow Customization of Elasticsearch Documen...

2018-10-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1218 @mraliagha I updated the README to (hopefully) better explain your options in using `es.document.id`. I sensed by your question that what I had originally was not very clear. ---

[jira] [Commented] (METRON-1813) Stellar REPL Not Initialized with Client JAAS

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642536#comment-16642536 ] ASF GitHub Bot commented on METRON-1813: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1232: METRON-1813 Stellar REPL Not Initialized with Cli...

2018-10-08 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1232#discussion_r223507156 --- Diff: metron-platform/metron-common/src/main/scripts/stellar --- @@ -28,10 +28,15 @@ elif [ -e /usr/lib/bigtop-utils/bigtop-detect-javahome ]; then

[jira] [Commented] (METRON-1813) Stellar REPL Not Initialized with Client JAAS

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642532#comment-16642532 ] ASF GitHub Bot commented on METRON-1813: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1232: METRON-1813 Stellar REPL Not Initialized with Cli...

2018-10-08 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1232#discussion_r223506784 --- Diff: metron-platform/metron-common/src/main/scripts/stellar --- @@ -28,10 +28,15 @@ elif [ -e /usr/lib/bigtop-utils/bigtop-detect-javahome ]; then

[jira] [Commented] (METRON-1813) Stellar REPL Not Initialized with Client JAAS

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642529#comment-16642529 ] ASF GitHub Bot commented on METRON-1813: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1232: METRON-1813 Stellar REPL Not Initialized with Cli...

2018-10-08 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1232#discussion_r223506424 --- Diff: metron-platform/metron-common/src/main/scripts/stellar --- @@ -28,10 +28,15 @@ elif [ -e /usr/lib/bigtop-utils/bigtop-detect-javahome ]; then

[jira] [Commented] (METRON-1792) Simplify Profile Definitions in Integration Tests

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642520#comment-16642520 ] ASF GitHub Bot commented on METRON-1792: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1211: METRON-1792 Simplify Profile Definitions in Integration ...

2018-10-08 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1211 Love it @nickwallen. +1 via inspection from me. Much improved readability and very easy to see the full context of the test from this change without needing to open up separate files. ---

[jira] [Commented] (METRON-1796) [UI] Migrate off moment.js

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642513#comment-16642513 ] ASF GitHub Bot commented on METRON-1796: Github user mmiklavc commented on a diff in the pull

[GitHub] metron pull request #1219: METRON-1796: [UI] Migrate off moment.js

2018-10-08 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1219#discussion_r223502181 --- Diff: metron-interface/metron-alerts/package.json --- @@ -22,17 +22,17 @@ "@angular/platform-browser": "^6.1.6",

[jira] [Commented] (METRON-1792) Simplify Profile Definitions in Integration Tests

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642511#comment-16642511 ] ASF GitHub Bot commented on METRON-1792: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1211: METRON-1792 Simplify Profile Definitions in Integ...

2018-10-08 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1211#discussion_r223501886 --- Diff: metron-analytics/metron-profiler-storm/src/test/java/org/apache/metron/profiler/storm/integration/ConfigUploadComponent.java --- @@ -117,8

[jira] [Commented] (METRON-1792) Simplify Profile Definitions in Integration Tests

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642507#comment-16642507 ] ASF GitHub Bot commented on METRON-1792: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1211: METRON-1792 Simplify Profile Definitions in Integ...

2018-10-08 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1211#discussion_r223501784 --- Diff: metron-analytics/metron-profiler-storm/src/test/java/org/apache/metron/profiler/storm/integration/ConfigUploadComponent.java --- @@ -86,11

[jira] [Commented] (METRON-1796) [UI] Migrate off moment.js

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642497#comment-16642497 ] ASF GitHub Bot commented on METRON-1796: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1219: METRON-1796: [UI] Migrate off moment.js

2018-10-08 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1219#discussion_r223498638 --- Diff: metron-interface/metron-alerts/package.json --- @@ -22,17 +22,17 @@ "@angular/platform-browser": "^6.1.6",

[jira] [Commented] (METRON-1811) Alert Search Fails When Sorting by Alert Status

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642482#comment-16642482 ] ASF GitHub Bot commented on METRON-1811: Github user nickwallen commented on the issue:

[GitHub] metron issue #1231: METRON-1811: Alert Search Fails When Sorting by Alert St...

2018-10-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1231 @merrimanr Are there any automated tests that could have caught this bug? Is it possible to add a test for this? ---

[jira] [Commented] (METRON-1813) Stellar REPL Not Initialized with Client JAAS

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642467#comment-16642467 ] ASF GitHub Bot commented on METRON-1813: GitHub user nickwallen opened a pull request:

[GitHub] metron pull request #1232: METRON-1813 Stellar REPL Not Initialized with Cli...

2018-10-08 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1232 METRON-1813 Stellar REPL Not Initialized with Client JAAS Running a function like `KAFKA_GET` in the Stellar REPL does not work in a kerberized environment. * When the Stellar REPL

[jira] [Commented] (METRON-1811) Alert Search Fails When Sorting by Alert Status

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642458#comment-16642458 ] ASF GitHub Bot commented on METRON-1811: Github user merrimanr closed the pull request at:

[jira] [Commented] (METRON-1811) Alert Search Fails When Sorting by Alert Status

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642459#comment-16642459 ] ASF GitHub Bot commented on METRON-1811: GitHub user merrimanr reopened a pull request:

[GitHub] metron pull request #1231: METRON-1811: Alert Search Fails When Sorting by A...

2018-10-08 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/1231 METRON-1811: Alert Search Fails When Sorting by Alert Status ## Contributor Comments This PR fixes sorting on the `alert_status` field in the Alerts UI by defining the field in ES

[jira] [Created] (METRON-1813) Stellar REPL Not Initialized with Client JAAS

2018-10-08 Thread Nick Allen (JIRA)
Nick Allen created METRON-1813: -- Summary: Stellar REPL Not Initialized with Client JAAS Key: METRON-1813 URL: https://issues.apache.org/jira/browse/METRON-1813 Project: Metron Issue Type: Bug

[GitHub] metron pull request #1231: METRON-1811: Alert Search Fails When Sorting by A...

2018-10-08 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1231 ---

[jira] [Commented] (METRON-1812) Fix dependencies_with_url.csv

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642368#comment-16642368 ] ASF GitHub Bot commented on METRON-1812: Github user merrimanr commented on the issue:

[GitHub] metron issue #1230: METRON-1812: Fix dependencies_with_url.csv

2018-10-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1230 +1 for the clever history reference and this PR. ---

[jira] [Commented] (METRON-1811) Alert Search Fails When Sorting by Alert Status

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642365#comment-16642365 ] ASF GitHub Bot commented on METRON-1811: GitHub user merrimanr opened a pull request:

[GitHub] metron pull request #1231: METRON-1811: Alert Search Fails When Sorting by A...

2018-10-08 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1231 METRON-1811: Alert Search Fails When Sorting by Alert Status ## Contributor Comments This PR fixes sorting on the `alert_status` field in the Alerts UI by defining the field in ES templates

[jira] [Commented] (METRON-1769) Script creation of a release candidate

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642324#comment-16642324 ] ASF GitHub Bot commented on METRON-1769: Github user justinleet commented on the issue:

[GitHub] metron issue #1188: METRON-1769: Script creation of a release candidate

2018-10-08 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1188 @nickwallen Updated the script. I did a few things in the latest commits. * reorganized slightly the order of prompts * Fixed the last (non-KEYS file) TODO * Uncommented out

[jira] [Commented] (METRON-1812) Fix dependencies_with_url.csv

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642302#comment-16642302 ] ASF GitHub Bot commented on METRON-1812: GitHub user mmiklavc opened a pull request:

[GitHub] metron pull request #1230: METRON-1812: Fix dependencies_with_url.csv

2018-10-08 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/1230 METRON-1812: Fix dependencies_with_url.csv ## Contributor Comments The war of https://issues.apache.org/jira/browse/METRON-1812 The dependencies_with_url.csv is used for our

[jira] [Created] (METRON-1812) Fix dependencies_with_url.csv

2018-10-08 Thread Michael Miklavcic (JIRA)
Michael Miklavcic created METRON-1812: - Summary: Fix dependencies_with_url.csv Key: METRON-1812 URL: https://issues.apache.org/jira/browse/METRON-1812 Project: Metron Issue Type: Bug

[jira] [Assigned] (METRON-930) UI - Threat triage rules configuration is missing the comment and reason fields

2018-10-08 Thread Michael Miklavcic (JIRA)
[ https://issues.apache.org/jira/browse/METRON-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic reassigned METRON-930: Assignee: (was: Michael Miklavcic) > UI - Threat triage rules configuration

[jira] [Assigned] (METRON-930) UI - Threat triage rules configuration is missing the comment and reason fields

2018-10-08 Thread Michael Miklavcic (JIRA)
[ https://issues.apache.org/jira/browse/METRON-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miklavcic reassigned METRON-930: Assignee: Michael Miklavcic > UI - Threat triage rules configuration is missing

[jira] [Commented] (METRON-1809) Support Column Oriented Input with Batch Profiler

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642144#comment-16642144 ] ASF GitHub Bot commented on METRON-1809: Github user nickwallen commented on the issue:

[GitHub] metron issue #1229: METRON-1809 Support Column Oriented Input with Batch Pro...

2018-10-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1229 I validated the test instructions in the dev environments. This is looking good to me. ---

[jira] [Commented] (METRON-1807) Auto populate the recommended values to some of the metron config parameters

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642088#comment-16642088 ] ASF GitHub Bot commented on METRON-1807: Github user asfgit closed the pull request at:

[GitHub] metron pull request #1227: METRON-1807: Auto populate the recommended values...

2018-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1227 ---

[jira] [Commented] (METRON-1807) Auto populate the recommended values to some of the metron config parameters

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642086#comment-16642086 ] ASF GitHub Bot commented on METRON-1807: Github user merrimanr commented on the issue:

[GitHub] metron issue #1227: METRON-1807: Auto populate the recommended values to som...

2018-10-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1227 +1 by inspection. Thanks @MohanDV. ---

[jira] [Commented] (METRON-1801) Allow Customization of Elasticsearch Document ID

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641863#comment-16641863 ] ASF GitHub Bot commented on METRON-1801: Github user nickwallen commented on the issue:

[GitHub] metron issue #1218: METRON-1801 Allow Customization of Elasticsearch Documen...

2018-10-08 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1218 > @mraliagha: So if es.document.id is not provided, as the default, doc id won't be send to ES indexing, right? Yes, exactly. > @mraliagha: I guess it would be also nice to

[jira] [Commented] (METRON-1796) [UI] Migrate off moment.js

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16641473#comment-16641473 ] ASF GitHub Bot commented on METRON-1796: Github user ruffle1986 commented on a diff in the pull

[GitHub] metron pull request #1219: METRON-1796: [UI] Migrate off moment.js

2018-10-08 Thread ruffle1986
Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1219#discussion_r223269377 --- Diff: metron-interface/metron-alerts/package.json --- @@ -22,17 +22,17 @@ "@angular/platform-browser": "^6.1.6",