[GitHub] [metron] tiborm closed pull request #1480: METRON-2209: [UI] Showing loading indicator when querying alerts

2019-08-13 Thread GitBox
tiborm closed pull request #1480: METRON-2209: [UI] Showing loading indicator when querying alerts URL: https://github.com/apache/metron/pull/1480 This is an automated message from the Apache Git Service. To respond to the m

[jira] [Created] (METRON-2211) [UI] Alerts UI should optionally render timestamp in local time

2019-08-13 Thread Shane Ardell (JIRA)
Shane Ardell created METRON-2211: Summary: [UI] Alerts UI should optionally render timestamp in local time Key: METRON-2211 URL: https://issues.apache.org/jira/browse/METRON-2211 Project: Metron

[jira] [Created] (METRON-2212) Add debugging developer docs to hbase-server README

2019-08-13 Thread Michael Miklavcic (JIRA)
Michael Miklavcic created METRON-2212: - Summary: Add debugging developer docs to hbase-server README Key: METRON-2212 URL: https://issues.apache.org/jira/browse/METRON-2212 Project: Metron

[GitHub] [metron] mmiklavc opened a new pull request #1481: METRON-2212 Add debugging developer docs to hbase-server README

2019-08-13 Thread GitBox
mmiklavc opened a new pull request #1481: METRON-2212 Add debugging developer docs to hbase-server README URL: https://github.com/apache/metron/pull/1481 ## Contributor Comments https://issues.apache.org/jira/browse/METRON-2212 Adds some detail to assist developers/devops in d

[GitHub] [metron] justinleet commented on a change in pull request #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
justinleet commented on a change in pull request #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#discussion_r313517446 ## File path: metron-platform/metron-parsing/metron-parsers-common/src/main/java/org/apache/metron/parsers/

[GitHub] [metron] justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-520927745 The PR from @mmiklavc (https://github.com/justinleet/metron/pull/22) got merged to address the couple `readCharset` issues.

[GitHub] [metron] ottobackwards commented on issue #1481: METRON-2212 Add debugging developer docs to hbase-server README

2019-08-13 Thread GitBox
ottobackwards commented on issue #1481: METRON-2212 Add debugging developer docs to hbase-server README URL: https://github.com/apache/metron/pull/1481#issuecomment-520927977 +1 This is an automated message from the Apache Gi

[GitHub] [metron] mmiklavc commented on issue #1474: METRON-2201: The description for the IS_IP method default behavior needs to corrected as per implementation

2019-08-13 Thread GitBox
mmiklavc commented on issue #1474: METRON-2201: The description for the IS_IP method default behavior needs to corrected as per implementation URL: https://github.com/apache/metron/pull/1474#issuecomment-520930529 For reference, the underlying implementation of this validator https://commo

[GitHub] [metron] mmiklavc commented on issue #1474: METRON-2201: The description for the IS_IP method default behavior needs to corrected as per implementation

2019-08-13 Thread GitBox
mmiklavc commented on issue #1474: METRON-2201: The description for the IS_IP method default behavior needs to corrected as per implementation URL: https://github.com/apache/metron/pull/1474#issuecomment-520930649 +1, thanks @MohanDV ---

[GitHub] [metron] justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-520965262 @mmiklavc Unit test looks like it fails because a mocked parser NPEs on the `getReadCharset`. Could just do a `when(broParser.getRea

[GitHub] [metron] mmiklavc commented on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
mmiklavc commented on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-520998393 Well that's odd - apparently our version of Mockito doesn't call the provided concrete method for default interface methods. Submitting

[GitHub] [metron] mmiklavc commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
mmiklavc commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#discussion_r313612975 ## File path: metron-deployment/ansible/roles/metron-builder/tasks/build.yml ## @@ -20,7 +20,7 @@

[GitHub] [metron] mmiklavc commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
mmiklavc commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#discussion_r313615221 ## File path: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/bulk/LeastRecen

[GitHub] [metron] justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-521011869 Merged. Adds some docs and the test fix. @mmiklavc Assuming the build succeeds, are we good for @nickwallen + @ottobackwards t

[GitHub] [metron] cstella-stripe commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
cstella-stripe commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#discussion_r313616983 ## File path: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/bulk/Leas

[GitHub] [metron] cstella-stripe commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
cstella-stripe commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#discussion_r313616983 ## File path: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/bulk/Leas

[GitHub] [metron] cestella commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
cestella commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#discussion_r313617975 ## File path: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/bulk/LeastRecen

[GitHub] [metron] ottobackwards commented on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
ottobackwards commented on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-521019388 Ran this up in full-dev, everything seems to be working. Ship it. +1 -

[GitHub] [metron] nickwallen commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
nickwallen commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#discussion_r313626182 ## File path: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/bulk/LeastRec

[GitHub] [metron] nickwallen commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
nickwallen commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#discussion_r313630051 ## File path: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/bulk/LeastRec

[GitHub] [metron] ottobackwards commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
ottobackwards commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#discussion_r313635130 ## File path: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/bulk/Least

[GitHub] [metron] justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-521029586 @mmiklavc We should probably add a note to the Upgrading.md. There is a backwards compatibility concern when upgrading: When

[GitHub] [metron] cestella commented on issue #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
cestella commented on issue #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#issuecomment-521033037 This PR piqued my interest. :) First off, I'm glad to see we're fixing the use of the deprecated `HTables` and HBase APIs, so tha

[GitHub] [metron] mmiklavc commented on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
mmiklavc commented on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-521034747 I assume you mean if they were using the system default, which is Java's default when a charset is not provided when converting from by

[GitHub] [metron] cestella commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
cestella commented on a change in pull request #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#discussion_r313643143 ## File path: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/bulk/LeastRecen

[GitHub] [metron] justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
justinleet commented on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-521040026 @mmiklavc If they're using a system default that isn't UTF-8 (say ISO_8859_1), all the parsers that currently work would silently sta

[GitHub] [metron] justinleet edited a comment on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
justinleet edited a comment on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-521040026 @mmiklavc If they're using a system default that isn't UTF-8 (say ISO_8859_1), all the parsers that currently work would silen

[GitHub] [metron] nickwallen commented on issue #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
nickwallen commented on issue #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#issuecomment-521041113 > I will say, however, that I was surprised at the size of a single PR until I looked... Conflating so many things inside of a PR whic

[GitHub] [metron] nickwallen commented on issue #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
nickwallen commented on issue #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#issuecomment-521045619 > Replacing deprecated API calls against master Many of the changes here are not backwards compatible which prevents me from in

[GitHub] [metron] mmiklavc commented on issue #1341: METRON-614: Eliminate use of the default Charset

2019-08-13 Thread GitBox
mmiklavc commented on issue #1341: METRON-614: Eliminate use of the default Charset URL: https://github.com/apache/metron/pull/1341#issuecomment-521062716 That is correct @justinleet This is an automated message from the Apac

[GitHub] [metron] mmiklavc commented on issue #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2

2019-08-13 Thread GitBox
mmiklavc commented on issue #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#issuecomment-521073596 Still trying to wrap my head around this PR and the scope of changes. > Many of the changes here are not backwards compatible whic

[jira] [Created] (METRON-2213) Documentation not deployed

2019-08-13 Thread Dale Richardson (JIRA)
Dale Richardson created METRON-2213: --- Summary: Documentation not deployed Key: METRON-2213 URL: https://issues.apache.org/jira/browse/METRON-2213 Project: Metron Issue Type: Bug