[GitHub] metron pull request #1161: METRON-1708 Run the Batch Profiler in Spark [Feat...

2018-08-27 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1161 ---

[GitHub] metron pull request #1175: METRON-1750 Metron Parser for valid RFC 5424 Sysl...

2018-08-27 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1175#discussion_r213051917 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] metron pull request #1177: METRON-1752: Prevent package.lock from changing d...

2018-08-27 Thread sardell
GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1177 METRON-1752: Prevent package.lock from changing during build ## Contributor Comments This PR updates the build script to use `npm ci` instead of `npm install`. The former command installs

[GitHub] metron pull request #1175: METRON-1750 Metron Parser for valid RFC 5424 Sysl...

2018-08-27 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1175#discussion_r213048634 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] metron pull request #1175: METRON-1750 Metron Parser for valid RFC 5424 Sysl...

2018-08-27 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1175#discussion_r213048275 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] metron pull request #1175: METRON-1750 Metron Parser for valid RFC 5424 Sysl...

2018-08-27 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1175#discussion_r213039514 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] metron pull request #1175: METRON-1750 Metron Parser for valid RFC 5424 Sysl...

2018-08-27 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1175#discussion_r213027440 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] metron pull request #1175: METRON-1750 Metron Parser for valid RFC 5424 Sysl...

2018-08-27 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/1175#discussion_r213016887 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] metron pull request #1175: METRON-1750 Metron Parser for valid RFC 5424 Sysl...

2018-08-27 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1175#discussion_r212985523 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/syslog/Syslog5424Parser.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] metron pull request #1176: METRON-1751 Storm Profiler dies when consuming nu...

2018-08-27 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1176 METRON-1751 Storm Profiler dies when consuming null message The Storm Profiler dies if a null message is consumed from the input Kafka topic. The Profiler should skip past any null messages

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1172 ---

[GitHub] metron pull request #1175: METRON-1453 Metron Parser for valid RFC 5424 Sysl...

2018-08-25 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/metron/pull/1175 METRON-1453 Metron Parser for valid RFC 5424 Syslog messages This is a simple parser for *valid* [RFC 5424](http://www.rfc-base.org/txt/rfc-5424.txt) messages. It produces JSON for the

[GitHub] metron pull request #1174: METRON-1748 Improve Storm Profiler Integration Te...

2018-08-24 Thread nickwallen
GitHub user nickwallen reopened a pull request: https://github.com/apache/metron/pull/1174 METRON-1748 Improve Storm Profiler Integration Test Improved the Storm Profiler integration tests based on improvements I made for the Spark Profiler feature branch. * Validate the

[GitHub] metron pull request #1174: METRON-1748 Improve Storm Profiler Integration Te...

2018-08-24 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1174 ---

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-24 Thread tiborm
Github user tiborm closed the pull request at: https://github.com/apache/metron/pull/1172 ---

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-24 Thread tiborm
GitHub user tiborm reopened a pull request: https://github.com/apache/metron/pull/1172 METRON-1724: Date/time validation missing in PCAP query ## Contributor Comments This PR contains date range validation. We added validation messages with hints also, to help the user correct

[GitHub] metron pull request #1150: METRON-1707 Port Profiler to Spark [Feature Branc...

2018-08-23 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1150 ---

[GitHub] metron pull request #1174: METRON-1748 Improve Storm Profiler Integration Te...

2018-08-23 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1174 METRON-1748 Improve Storm Profiler Integration Test Improved the Storm Profiler integration tests based on improvements I made for the Spark Profiler feature branch. * Validate the

[GitHub] metron pull request #1173: METRON-1743: CEF test confusing URL

2018-08-23 Thread JonZeolla
GitHub user JonZeolla opened a pull request: https://github.com/apache/metron/pull/1173 METRON-1743: CEF test confusing URL ## Contributor Comments Trivial variable rename. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron.

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-23 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r212383664 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts --- @@ -179,19 +172,6 @@ describe('PcapFiltersComponent',

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-23 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r212369764 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.spec.ts --- @@ -143,38 +132,4 @@

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-23 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r212342518 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.spec.ts --- @@ -143,38 +132,4 @@

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-23 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r212341861 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts --- @@ -179,19 +172,6 @@

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-23 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212275406 --- Diff: metron-interface/metron-alerts-host/src/main/scripts/metron-alerts.sh --- @@ -0,0 +1,55 @@ +#!/usr/bin/env bash +# +#

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-23 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212270804 --- Diff: metron-interface/metron-rest-client/bin/pom.xml --- @@ -0,0 +1,52 @@ + --- End diff -- Yes. Will remove. ---

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-23 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212225176 --- Diff: metron-interface/metron-ui-host/pom.xml --- @@ -0,0 +1,142 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-23 Thread ruffle1986
Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r212205588 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -15,63 +15,116 @@ * See the License for the

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-23 Thread ruffle1986
Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r212205052 --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts --- @@ -17,13 +17,13 @@ */ export class PcapRequest { -

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-23 Thread ruffle1986
Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r212204263 --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts --- @@ -17,13 +17,13 @@ */ export class PcapRequest { -

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-23 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r212196734 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -15,63 +15,116 @@ * See the License for the

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-22 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212108451 --- Diff: metron-interface/metron-ui-host/pom.xml --- @@ -0,0 +1,142 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-22 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212107810 --- Diff: metron-interface/metron-rest-client/bin/pom.xml --- @@ -0,0 +1,52 @@ + --- End diff -- Is adding this file a mistake? ---

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-22 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212107439 --- Diff: metron-interface/metron-alerts-host/src/main/scripts/metron-alerts.sh --- @@ -0,0 +1,55 @@ +#!/usr/bin/env bash +# +# Licensed to

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-22 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212106486 --- Diff: metron-interface/metron-alerts-host/pom.xml --- @@ -0,0 +1,143 @@ + --- End diff -- I'm not even sure this is accurate

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-22 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212106080 --- Diff: metron-interface/metron-alerts-host/src/main/java/org/apache/metron/ui/AlertsApplication.java --- @@ -0,0 +1,31 @@ +/** --- End diff

[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...

2018-08-22 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212104536 --- Diff: metron-interface/metron-alerts-host/pom.xml --- @@ -0,0 +1,143 @@ + --- End diff -- Our xml files generally follow the

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r212012726 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -15,63 +15,116 @@ * See the License for the

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r211990573 --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts --- @@ -17,13 +17,13 @@ */ export class PcapRequest { -

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r211989622 --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts --- @@ -17,13 +17,13 @@ */ export class PcapRequest { -

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r211979831 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -15,63 +15,116 @@ * See the License for the

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread ruffle1986
Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r211972645 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -15,63 +15,116 @@ * See the License for the

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread ruffle1986
Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r211970078 --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts --- @@ -17,13 +17,13 @@ */ export class PcapRequest { -

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r211964997 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -15,63 +15,116 @@ * See the License

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread ruffle1986
Github user ruffle1986 commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r211960374 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -15,63 +15,116 @@ * See the License for the

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1172#discussion_r211945169 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -15,63 +15,116 @@ * See the License for the

[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...

2018-08-22 Thread tiborm
GitHub user tiborm opened a pull request: https://github.com/apache/metron/pull/1172 METRON-1724: Date/time validation missing in PCAP query ## Contributor Comments This PR contains date range validation. We added validation messages with hints also, to help the user correct a

[GitHub] metron pull request #1171: METRON-1740 make parser support CONFIG and SYSTEM...

2018-08-21 Thread liuy-tnz
GitHub user liuy-tnz opened a pull request: https://github.com/apache/metron/pull/1171 METRON-1740 make parser support CONFIG and SYSTEM log types ## Contributor Comments The current PaloAlto parser (BasicPaloAltoFirewallParser) doesn't support PanOS Config and System syslog.

[GitHub] metron pull request #1170: METRON-1741 Move REPL Port of Profiler to Separat...

2018-08-21 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1170 METRON-1741 Move REPL Port of Profiler to Separate Project This separates out the Profiler code specific to the port which runs in the Stellar REPL into its own project. This also creates a

[GitHub] metron pull request #1150: METRON-1707 Port Profiler to Spark [Feature Branc...

2018-08-21 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1150#discussion_r211659471 --- Diff: metron-analytics/metron-profiler-spark/src/main/java/org/apache/metron/profiler/spark/BatchProfiler.java --- @@ -0,0 +1,102 @@ +/* +

[GitHub] metron pull request #1148: METRON-1705 Create ProfilePeriod Using Period ID ...

2018-08-20 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1148 ---

[GitHub] metron pull request #1147: METRON-1706: HbaseClient.mutate should return the...

2018-08-20 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1147 ---

[GitHub] metron pull request #1168: METRON-1739: UDP packets are not handled

2018-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1168 ---

[GitHub] metron pull request #1169: METRON-1554: Pcap Query Panel

2018-08-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1169 ---

[GitHub] metron pull request #1169: METRON-1554: Pcap Query Panel

2018-08-17 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1169 METRON-1554: Pcap Query Panel ## Contributor Comments Per the discussion

[GitHub] metron pull request #1168: METRON-1739: UDP packets are not handled

2018-08-16 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1168 METRON-1739: UDP packets are not handled ## Contributor Comments Currently only TCP packets are included in query results when fixed field filters are applied. In the case where no filters

[GitHub] metron pull request #1146: METRON-1704 Message Timestamp Logic Should be Sha...

2018-08-16 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1146 ---

[GitHub] metron pull request #1166: METRON-1738: Pcap directories should have correct...

2018-08-15 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1166 ---

[GitHub] metron pull request #1164: METRON-1737: Document Job cleanup

2018-08-15 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1164 ---

[GitHub] metron pull request #1141: Metron-1727: metron-rest service needs to be rest...

2018-08-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1141 ---

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread tiborm
Github user tiborm closed the pull request at: https://github.com/apache/metron/pull/1165 ---

[GitHub] metron pull request #1167: METRON-1715 Create DEB Packaging for Batch Profil...

2018-08-15 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1167 METRON-1715 Create DEB Packaging for Batch Profiler This creates a DEB package that makes it simple to install the Batch Profiler. There are now two separate packages created for the Profiler;

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread tiborm
Github user tiborm commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210379924 --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts --- @@ -17,13 +17,13 @@ */ export class PcapRequest { -

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-15 Thread mmiklavc
Github user mmiklavc closed the pull request at: https://github.com/apache/metron/pull/1157 ---

[GitHub] metron pull request #1166: METRON-1738: Pcap directories should have correct...

2018-08-15 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1166 METRON-1738: Pcap directories should have correct permissions ## Contributor Comments This PR corrects the Pcap HDFS directory permissions. When a cluster is not Kerberized, the Pcap

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210306465 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts --- @@ -263,10 +230,10 @@

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210285682 --- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts --- @@ -17,13 +17,13 @@ */ export class PcapRequest { -

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210284527 --- Diff: metron-platform/metron-pcap-backend/src/test/java/org/apache/metron/pcap/query/PcapCliTest.java --- @@ -172,7 +172,8 @@ public void

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1165#discussion_r210284388 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java --- @@ -494,6 +494,10 @@ protected void setMrJob(Job mrJob) {

[GitHub] metron pull request #1165: METRON-1724: Date/time validation missing in PCAP...

2018-08-15 Thread tiborm
GitHub user tiborm opened a pull request: https://github.com/apache/metron/pull/1165 METRON-1724: Date/time validation missing in PCAP query ## Contributor Comments This PR contains date range validation. We also added validation messages with hints for the user how to correct

[GitHub] metron pull request #1145: METRON-1703 Make Core Profiler Components Seriali...

2018-08-15 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/1145 ---

[GitHub] metron pull request #1164: METRON-1737: Document Job cleanup

2018-08-14 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1164 METRON-1737: Document Job cleanup ## Contributor Comments This PR adds documentation around the directory structure of Pcap query results and recommendations for managing their growth. It

[GitHub] metron pull request #1163: METRON-1714 Create RPM Packaging for the Batch Pr...

2018-08-14 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1163 METRON-1714 Create RPM Packaging for the Batch Profiler This creates an RPM that makes it simple to install the Batch Profiler. There are now two separate RPM packages created for the

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-14 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r210059160 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java --- @@ -307,8 +307,11 @@ public void

[GitHub] metron pull request #1160: METRON-1735: Empty print status option causes NPE

2018-08-14 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1160 ---

[GitHub] metron pull request #1150: METRON-1707 Port Profiler to Spark [Feature Branc...

2018-08-14 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1150#discussion_r210030412 --- Diff: metron-analytics/metron-profiler-spark/src/main/java/org/apache/metron/profiler/spark/function/ProfileBuilderFunction.java --- @@ -0,0 +1,107

[GitHub] metron pull request #1158: METRON-1733: PCAP UI - PCAP queries don't work on...

2018-08-14 Thread sardell
Github user sardell closed the pull request at: https://github.com/apache/metron/pull/1158 ---

[GitHub] metron pull request #1150: METRON-1707 Port Profiler to Spark [Feature Branc...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1150#discussion_r209771180 --- Diff: metron-analytics/metron-profiler-spark/src/main/java/org/apache/metron/profiler/spark/function/ProfileBuilderFunction.java --- @@ -0,0 +1,107

[GitHub] metron pull request #1150: METRON-1707 Port Profiler to Spark [Feature Branc...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1150#discussion_r209764724 --- Diff: metron-analytics/metron-profiler-spark/src/main/java/org/apache/metron/profiler/spark/function/ProfileBuilderFunction.java --- @@ -0,0 +1,107

[GitHub] metron pull request #1159: METRON-1734: Src and Dst port filters are incorre...

2018-08-13 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1159 ---

[GitHub] metron pull request #1162: METRON-1736 Enhance Batch Profiler Integration Te...

2018-08-13 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1162 METRON-1736 Enhance Batch Profiler Integration Test The integration test for the Batch Profiler should use the Profiler Client API and `PROFILE_GET` to validate the values that are produced.

[GitHub] metron pull request #1161: METRON-1708 Run the Batch Profiler in Spark

2018-08-13 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1161 METRON-1708 Run the Batch Profiler in Spark This adds the ability to run the Batch Profiler from the command line. This also packages up the Batch Profiler into a tarball. This is a

[GitHub] metron pull request #1158: METRON-1733: PCAP UI - PCAP queries don't work on...

2018-08-13 Thread sardell
GitHub user sardell reopened a pull request: https://github.com/apache/metron/pull/1158 METRON-1733: PCAP UI - PCAP queries don't work on Safari ## Contributor Comments This PR fixes a bug where Safari cannot read the format of the date we are passing to the startTimeMs and

[GitHub] metron pull request #1158: METRON-1733: PCAP UI - PCAP queries don't work on...

2018-08-13 Thread sardell
Github user sardell closed the pull request at: https://github.com/apache/metron/pull/1158 ---

[GitHub] metron pull request #1160: METRON-1735: Empty print status option causes NPE

2018-08-13 Thread merrimanr
GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/1160 METRON-1735: Empty print status option causes NPE ## Contributor Comments This is a regression in the feature branch introduced by https://github.com/apache/metron/pull/1138. The default

[GitHub] metron pull request #1160: METRON-1735: Empty print status option causes NPE

2018-08-13 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1160 ---

[GitHub] metron pull request #1159: METRON-1734: Src and Dst port filters are incorre...

2018-08-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1159#discussion_r209698673 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -63,9 +63,13 @@ export class PcapFiltersComponent

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209689930 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java --- @@ -307,8 +307,11 @@ public void

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209687780 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapFinalizer.java --- @@ -99,10 +104,55 @@ protected

[GitHub] metron pull request #1159: METRON-1734: Src and Dst port filters are incorre...

2018-08-13 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/1159#discussion_r209683673 --- Diff: metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts --- @@ -63,9 +63,13 @@ export class PcapFiltersComponent

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209674410 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapFinalizer.java --- @@ -99,10 +104,55 @@ protected

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209650724 --- Diff: metron-interface/metron-rest/README.md --- @@ -223,6 +223,9 @@ REST will supply the script with raw pcap data through standard in and expects

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209671313 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapFinalizer.java --- @@ -99,10 +104,55 @@ protected

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209665613 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java --- @@ -307,8 +307,11 @@ public void

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209655011 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapFinalizer.java --- @@ -99,10 +104,55 @@ protected

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209651293 --- Diff: metron-interface/metron-rest/README.md --- @@ -223,6 +223,9 @@ REST will supply the script with raw pcap data through standard in and expects

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209649851 --- Diff: metron-interface/metron-rest/README.md --- @@ -223,6 +223,9 @@ REST will supply the script with raw pcap data through standard in and expects

[GitHub] metron pull request #1157: METRON-1732: Fix job status liveness bug and para...

2018-08-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1157#discussion_r209649720 --- Diff: metron-interface/metron-rest/README.md --- @@ -223,6 +223,9 @@ REST will supply the script with raw pcap data through standard in and expects

[GitHub] metron pull request #1160: METRON-1735: Empty print status option causes NPE

2018-08-10 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1160 METRON-1735: Empty print status option causes NPE ## Contributor Comments This is a regression in the feature branch introduced by https://github.com/apache/metron/pull/1138. The default

[GitHub] metron pull request #1159: METRON-1734: Src and Dst port filters are incorre...

2018-08-10 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/1159 METRON-1734: Src and Dst port filters are incorrect after changing to empty ## Contributor Comments This PR removes the src and dst port filters when the input forms are cleared. Before the

[GitHub] metron pull request #1153: METRON-1725: Add ability to specify YARN queue fo...

2018-08-10 Thread merrimanr
Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/1153 ---

<    3   4   5   6   7   8   9   10   11   12   >