[jira] [Commented] (NIFIREG-279) Upgrade to use latest NIFI-FDS, angular, etc.

2019-07-26 Thread Scott Aslan (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894170#comment-16894170 ] Scott Aslan commented on NIFIREG-279: - [https://github.com/apache/nifi-registry/pull/209] > Upgrade

[GitHub] [nifi-registry] scottyaslan opened a new pull request #209: Nifireg 279

2019-07-26 Thread GitBox
scottyaslan opened a new pull request #209: Nifireg 279 URL: https://github.com/apache/nifi-registry/pull/209 https://issues.apache.org/jira/browse/NIFIREG-279 This is an automated message from the Apache Git Service. To

[jira] [Created] (NIFI-6495) Drop down menu's have a min-height css rule

2019-07-26 Thread Scott Aslan (JIRA)
Scott Aslan created NIFI-6495: - Summary: Drop down menu's have a min-height css rule Key: NIFI-6495 URL: https://issues.apache.org/jira/browse/NIFI-6495 Project: Apache NiFi Issue Type: Bug

[GitHub] [nifi-registry] thenatog opened a new pull request #208: NIFIREG-296 - Upgrade version of Jetty

2019-07-26 Thread GitBox
thenatog opened a new pull request #208: NIFIREG-296 - Upgrade version of Jetty URL: https://github.com/apache/nifi-registry/pull/208 Upgraded Jetty version to 9.4.19.v20190610. Required some changes to integration tests. Minor JettyServer change.

[jira] [Resolved] (NIFI-6469) NiFi FDS 0.2.0 Release process

2019-07-26 Thread Scott Aslan (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan resolved NIFI-6469. --- Resolution: Fixed > NiFi FDS 0.2.0 Release process > -- > >

[GitHub] [nifi-minifi-cpp] achristianson commented on issue #603: MINIFICPP-929 mmap

2019-07-26 Thread GitBox
achristianson commented on issue #603: MINIFICPP-929 mmap URL: https://github.com/apache/nifi-minifi-cpp/pull/603#issuecomment-515593699 Switched to mio library for cross-platform (windows) compatibility. Fixed the broken test. The benchmarks need some work, but should be close now.

[GitHub] [nifi] AxelSync commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
AxelSync commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607#discussion_r307890403 ## File path:

[jira] [Created] (NIFIREG-297) Upgrade to latest LTS release of Node (and npm)

2019-07-26 Thread Robert Fellows (JIRA)
Robert Fellows created NIFIREG-297: -- Summary: Upgrade to latest LTS release of Node (and npm) Key: NIFIREG-297 URL: https://issues.apache.org/jira/browse/NIFIREG-297 Project: NiFi Registry

[jira] [Created] (NIFI-6494) Upgrade to latest LTS release of Node (and npm)

2019-07-26 Thread Robert Fellows (JIRA)
Robert Fellows created NIFI-6494: Summary: Upgrade to latest LTS release of Node (and npm) Key: NIFI-6494 URL: https://issues.apache.org/jira/browse/NIFI-6494 Project: Apache NiFi Issue

[jira] [Commented] (NIFI-5749) NiFi requirements include "Java 8 or later", but doesn't compile with Java 9

2019-07-26 Thread Andrew Lim (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894050#comment-16894050 ] Andrew Lim commented on NIFI-5749: -- In nifi-assembly/README.md it says: JDK 1.8 or higher Will change

[jira] [Resolved] (NIFIREG-294) Include difference in Processors' Scheduled State as a Flow Difference

2019-07-26 Thread Bryan Bende (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende resolved NIFIREG-294. - Resolution: Fixed > Include difference in Processors' Scheduled State as a Flow Difference >

[GitHub] [nifi-registry] bbende commented on issue #206: NIFIREG-294: Added Scheduled State Changed as a difference type and u…

2019-07-26 Thread GitBox
bbende commented on issue #206: NIFIREG-294: Added Scheduled State Changed as a difference type and u… URL: https://github.com/apache/nifi-registry/pull/206#issuecomment-515550147 +1 Looks good This is an automated message

[GitHub] [nifi-registry] bbende merged pull request #206: NIFIREG-294: Added Scheduled State Changed as a difference type and u…

2019-07-26 Thread GitBox
bbende merged pull request #206: NIFIREG-294: Added Scheduled State Changed as a difference type and u… URL: https://github.com/apache/nifi-registry/pull/206 This is an automated message from the Apache Git Service. To

[jira] [Commented] (NIFI-5749) NiFi requirements include "Java 8 or later", but doesn't compile with Java 9

2019-07-26 Thread Andrew Lim (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894029#comment-16894029 ] Andrew Lim commented on NIFI-5749: -- In [https://github.com/apache/nifi/blob/master/README.md] it says:

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on issue #617: Minificpp 897

2019-07-26 Thread GitBox
am-c-p-p commented on issue #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#issuecomment-515541674 @phrocker Yes, it will be separate PR. This is an automated message from the Apache Git Service.

[jira] [Comment Edited] (MINIFICPP-947) Fix all -Wall warnings, gradually fix or disable warnings from -Weverything

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894006#comment-16894006 ] Mr TheSegfault edited comment on MINIFICPP-947 at 7/26/19 5:41 PM: ---

[GitHub] [nifi] markap14 commented on issue #3606: [WIP] Nifi 6282

2019-07-26 Thread GitBox
markap14 commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-515540138 @scottyaslan thanks for posting this PR! It actually will make testing my PR quite a bit easier, I think. I started playing around with it and noticed one minor thing so

[jira] [Created] (NIFI-6493) Allow components access to the VariableRegistry

2019-07-26 Thread Jon Kessler (JIRA)
Jon Kessler created NIFI-6493: - Summary: Allow components access to the VariableRegistry Key: NIFI-6493 URL: https://issues.apache.org/jira/browse/NIFI-6493 Project: Apache NiFi Issue Type:

[jira] [Commented] (MINIFICPP-947) Fix all -Wall warnings, gradually fix or disable warnings from -Weverything

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894006#comment-16894006 ] Mr TheSegfault commented on MINIFICPP-947: -- Definitely another long lived task I think.

[GitHub] [nifi] patricker opened a new pull request #3609: NIFI-6492 Paste Location should match Right-Click location

2019-07-26 Thread GitBox
patricker opened a new pull request #3609: NIFI-6492 Paste Location should match Right-Click location URL: https://github.com/apache/nifi/pull/3609 Description of PR This moves the paste location to wherever the user right-clicked on the canvas, and not wherever the menu-item

[jira] [Comment Edited] (MINIFICPP-953) Review the code for proper integral type usage

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894000#comment-16894000 ] Mr TheSegfault edited comment on MINIFICPP-953 at 7/26/19 5:18 PM: ---

[jira] [Created] (NIFI-6492) Paste Location should match Right-Click location

2019-07-26 Thread Peter Wicks (JIRA)
Peter Wicks created NIFI-6492: - Summary: Paste Location should match Right-Click location Key: NIFI-6492 URL: https://issues.apache.org/jira/browse/NIFI-6492 Project: Apache NiFi Issue Type:

[jira] [Commented] (MINIFICPP-953) Review the code for proper integral type usage

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894000#comment-16894000 ] Mr TheSegfault commented on MINIFICPP-953: -- This particular ticket seems like one which will

[jira] [Comment Edited] (MINIFICPP-941) Ideas for code quality, architectural or process improvements

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893992#comment-16893992 ] Mr TheSegfault edited comment on MINIFICPP-941 at 7/26/19 5:15 PM: ---

[jira] [Commented] (MINIFICPP-944) Run with Valgrind

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893998#comment-16893998 ] Mr TheSegfault commented on MINIFICPP-944: -- yes yes yes! > Run with Valgrind >

[jira] [Commented] (MINIFICPP-956) Support compiling and linking our own libc++ and depend on libc only as a dynamic dependency.

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893996#comment-16893996 ] Mr TheSegfault commented on MINIFICPP-956: -- We can and should support doing this. I have a

[jira] [Comment Edited] (MINIFICPP-941) Ideas for code quality, architectural or process improvements

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893992#comment-16893992 ] Mr TheSegfault edited comment on MINIFICPP-941 at 7/26/19 5:15 PM: ---

[jira] [Commented] (MINIFICPP-950) Create a strongly-typed file system util

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893991#comment-16893991 ] Mr TheSegfault commented on MINIFICPP-950: -- Forgive me but if we moved to statically linking

[jira] [Comment Edited] (MINIFICPP-954) Consider moving the C2 line protocol to Google Protobuf

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893988#comment-16893988 ] Mr TheSegfault edited comment on MINIFICPP-954 at 7/26/19 5:04 PM: ---

[jira] [Commented] (MINIFICPP-954) Consider moving the C2 line protocol to Google Protobuf

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893988#comment-16893988 ] Mr TheSegfault commented on MINIFICPP-954: -- [~bakaid]  I like some of the concepts you

[jira] [Comment Edited] (MINIFICPP-954) Consider moving the C2 line protocol to Google Protobuf

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893988#comment-16893988 ] Mr TheSegfault edited comment on MINIFICPP-954 at 7/26/19 5:04 PM: ---

[jira] [Commented] (MINIFICPP-941) Ideas for code quality, architectural or process improvements

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893992#comment-16893992 ] Mr TheSegfault commented on MINIFICPP-941: -- [~bakaid] Thanks for making the effort to compile

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #617: Minificpp 897

2019-07-26 Thread GitBox
am-c-p-p commented on a change in pull request #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307828769 ## File path: extensions/libmodbus/Libmodbus.vcxproj ## @@ -0,0 +1,188 @@ + Review comment: It is not a derivative, I

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #617: Minificpp 897

2019-07-26 Thread GitBox
phrocker commented on issue #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#issuecomment-515529548 @am-c-p-p with your last comment I'm good with this; however, I don't see any thing being compiled with this. I also appreciate @arpadboda 's comment. Can you

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #617: Minificpp 897

2019-07-26 Thread GitBox
am-c-p-p commented on a change in pull request #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307828769 ## File path: extensions/libmodbus/Libmodbus.vcxproj ## @@ -0,0 +1,188 @@ + Review comment: It is not a derivative, I

[GitHub] [nifi] jtstorck edited a comment on issue #3404: NIFI-5176 Java 11 Build Compatibilty

2019-07-26 Thread GitBox
jtstorck edited a comment on issue #3404: NIFI-5176 Java 11 Build Compatibilty URL: https://github.com/apache/nifi/pull/3404#issuecomment-515516986 > Manual build locally gave me this > > ``` > [INFO] --- > [INFO] T E S T S

[jira] [Updated] (NIFI-5478) PutS3Object support for new Storage Classes for Infrequent Access

2019-07-26 Thread Peter Turcsanyi (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-5478: -- Status: Patch Available (was: In Progress) > PutS3Object support for new Storage Classes for

[GitHub] [nifi] jtstorck commented on issue #3404: NIFI-5176 Java 11 Build Compatibilty

2019-07-26 Thread GitBox
jtstorck commented on issue #3404: NIFI-5176 Java 11 Build Compatibilty URL: https://github.com/apache/nifi/pull/3404#issuecomment-515516986 > Manual build locally gave me this > > ``` > [INFO] --- > [INFO] T E S T S >

[GitHub] [nifi-minifi-cpp] phrocker removed a comment on issue #612: MINIFICPP-854: Capture RTSP Frame

2019-07-26 Thread GitBox
phrocker removed a comment on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-515513655 @arpadboda I don't think that's a valid interpretation of what I wrote. I would appreciate @nghiaxlee 's interpretation of my

[GitHub] [nifi-minifi-cpp] phrocker removed a comment on issue #612: MINIFICPP-854: Capture RTSP Frame

2019-07-26 Thread GitBox
phrocker removed a comment on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-515515837 "honestly I'm against placing the env var to the minifi.sh script. First I don't think we highlight that the script is the only

[GitHub] [nifi] turcsanyip opened a new pull request #3608: NIFI-5478: PutS3Object support for new Storage Classes

2019-07-26 Thread GitBox
turcsanyip opened a new pull request #3608: NIFI-5478: PutS3Object support for new Storage Classes URL: https://github.com/apache/nifi/pull/3608 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #612: MINIFICPP-854: Capture RTSP Frame

2019-07-26 Thread GitBox
phrocker commented on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-515515837 "honestly I'm against placing the env var to the minifi.sh script. First I don't think we highlight that the script is the only supported way

[GitHub] [nifi-minifi-cpp] phrocker edited a comment on issue #612: MINIFICPP-854: Capture RTSP Frame

2019-07-26 Thread GitBox
phrocker edited a comment on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-515513655 @arpadboda I don't think that's a valid interpretation of what I wrote. I would appreciate @nghiaxlee 's interpretation of my questions.

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #612: MINIFICPP-854: Capture RTSP Frame

2019-07-26 Thread GitBox
phrocker commented on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-515513655 @arpadboda I don't think that's a valid interpretation of what I wrote. I would appreciate @nghiaxlee 's interpretation of my comments.

[GitHub] [nifi] mgaido91 commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
mgaido91 commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607#discussion_r307804574 ## File path:

[GitHub] [nifi] cherrera2001 closed pull request #1997: NIFI-4164 Adding a realistic time simulator processor to NiFi

2019-07-26 Thread GitBox
cherrera2001 closed pull request #1997: NIFI-4164 Adding a realistic time simulator processor to NiFi URL: https://github.com/apache/nifi/pull/1997 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] AxelSync commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
AxelSync commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607#discussion_r307803671 ## File path:

[GitHub] [nifi] AxelSync edited a comment on issue #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
AxelSync edited a comment on issue #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607#issuecomment-515503709 (I closed and re-opened the PR because I suspect something went wrong with the ci)

[GitHub] [nifi] mgaido91 commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
mgaido91 commented on a change in pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607#discussion_r307802104 ## File path:

[GitHub] [nifi] AxelSync commented on issue #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
AxelSync commented on issue #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607#issuecomment-515503709 (I Closed and re-opened because I suspect something went wrong with the ci)

[GitHub] [nifi] AxelSync closed pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
AxelSync closed pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607 This is an automated message from the Apache Git Service. To

[GitHub] [nifi] AxelSync opened a new pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
AxelSync opened a new pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here:

[jira] [Updated] (NIFI-6490) MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language

2019-07-26 Thread Alessandro D'Armiento (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro D'Armiento updated NIFI-6490: Component/s: Core Framework > MergeRecord properties MIN_RECORDS and MAX_RECORDS

[GitHub] [nifi-minifi-cpp] arpadboda commented on issue #612: MINIFICPP-854: Capture RTSP Frame

2019-07-26 Thread GitBox
arpadboda commented on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-515504140 @phrocker : 1) env vars are inherited from the parent process, but can be overwritten. The overwrite we do doesn't effect the parent

[jira] [Resolved] (NIFI-6433) Update getStatusHistory to honor filter parameters

2019-07-26 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-6433. -- Resolution: Fixed > Update getStatusHistory to honor filter parameters >

[jira] [Commented] (NIFI-6433) Update getStatusHistory to honor filter parameters

2019-07-26 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893910#comment-16893910 ] Mark Payne commented on NIFI-6433: -- [~jmark99] thanks for the PR. I reviewed the code and all looked

[GitHub] [nifi] asfgit closed pull request #3579: NIFI-6433 Update getStatusHistory to honor filter values.

2019-07-26 Thread GitBox
asfgit closed pull request #3579: NIFI-6433 Update getStatusHistory to honor filter values. URL: https://github.com/apache/nifi/pull/3579 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (NIFI-6433) Update getStatusHistory to honor filter parameters

2019-07-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893905#comment-16893905 ] ASF subversion and git services commented on NIFI-6433: --- Commit

[GitHub] [nifi] AxelSync commented on issue #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
AxelSync commented on issue #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607#issuecomment-515494045 cc @mgaido91 could you please take a look at my PR?

[GitHub] [nifi] AxelSync opened a new pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS

2019-07-26 Thread GitBox
AxelSync opened a new pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here:

[GitHub] [nifi-minifi-cpp] phrocker commented on issue #612: MINIFICPP-854: Capture RTSP Frame

2019-07-26 Thread GitBox
phrocker commented on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-515492387 @nghiaxlee Sorry i missed the notifications. Allow me to answer the questions in reverse order. I presented my chief concern, which is the

[GitHub] [nifi] MikeThomsen commented on issue #3404: NIFI-5176 Java 11 Build Compatibilty

2019-07-26 Thread GitBox
MikeThomsen commented on issue #3404: NIFI-5176 Java 11 Build Compatibilty URL: https://github.com/apache/nifi/pull/3404#issuecomment-515491590 Manual build locally gave me this ``` [INFO] --- [INFO] T E S T S [INFO]

[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #617: Minificpp 897

2019-07-26 Thread GitBox
phrocker commented on a change in pull request #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307783519 ## File path: extensions/libmodbus/Libmodbus.vcxproj ## @@ -0,0 +1,188 @@ + Review comment: is this a derivative of what

[GitHub] [nifi] bbende commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts…

2019-07-26 Thread GitBox
bbende commented on issue #3536: NIFI-6380: Introduced the notion of Parameters and Parameter Contexts… URL: https://github.com/apache/nifi/pull/3536#issuecomment-515483536 The parameter references look good with the latest commit, also tested all the standard operations in a secure

[jira] [Commented] (MINIFICPP-876) Changes to Socket code may have broken Raw Site to Site

2019-07-26 Thread Arpad Boda (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893865#comment-16893865 ] Arpad Boda commented on MINIFICPP-876: -- [~phrocker] thanks, agreed! > Changes to Socket code may

[jira] [Comment Edited] (MINIFICPP-876) Changes to Socket code may have broken Raw Site to Site

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893839#comment-16893839 ] Mr TheSegfault edited comment on MINIFICPP-876 at 7/26/19 2:39 PM: ---

[jira] [Commented] (NIFI-5749) NiFi requirements include "Java 8 or later", but doesn't compile with Java 9

2019-07-26 Thread Andrew Lim (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893860#comment-16893860 ] Andrew Lim commented on NIFI-5749: -- In the short term, will change from "Java 8 or later" to "Java 8". 

[jira] [Assigned] (NIFI-6491) Improve installation documentation

2019-07-26 Thread Andrew Lim (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim reassigned NIFI-6491: Assignee: Andrew Lim > Improve installation documentation > -- > >

[jira] [Created] (NIFI-6491) Improve installation documentation

2019-07-26 Thread Andrew Lim (JIRA)
Andrew Lim created NIFI-6491: Summary: Improve installation documentation Key: NIFI-6491 URL: https://issues.apache.org/jira/browse/NIFI-6491 Project: Apache NiFi Issue Type: Improvement

[jira] [Assigned] (NIFI-5749) NiFi requirements include "Java 8 or later", but doesn't compile with Java 9

2019-07-26 Thread Andrew Lim (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim reassigned NIFI-5749: Assignee: Andrew Lim > NiFi requirements include "Java 8 or later", but doesn't compile with Java

[jira] [Updated] (NIFI-5749) NiFi requirements include "Java 8 or later", but doesn't compile with Java 9

2019-07-26 Thread Andrew Lim (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lim updated NIFI-5749: - Component/s: Documentation & Website > NiFi requirements include "Java 8 or later", but doesn't compile

[GitHub] [nifi] mcgilman commented on issue #3606: [WIP] Nifi 6282

2019-07-26 Thread GitBox
mcgilman commented on issue #3606: [WIP] Nifi 6282 URL: https://github.com/apache/nifi/pull/3606#issuecomment-515465639 Will review... This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (MINIFICPP-876) Changes to Socket code may have broken Raw Site to Site

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault resolved MINIFICPP-876. -- Resolution: Duplicate [~aboda] I'm closing this as a duplicate since I think this

[jira] [Created] (NIFIREG-296) Upgrade version of Jetty

2019-07-26 Thread Nathan Gough (JIRA)
Nathan Gough created NIFIREG-296: Summary: Upgrade version of Jetty Key: NIFIREG-296 URL: https://issues.apache.org/jira/browse/NIFIREG-296 Project: NiFi Registry Issue Type: Improvement

[jira] [Created] (MINIFICPP-988) Evaluate Allowable values for Kafka options

2019-07-26 Thread Mr TheSegfault (JIRA)
Mr TheSegfault created MINIFICPP-988: Summary: Evaluate Allowable values for Kafka options Key: MINIFICPP-988 URL: https://issues.apache.org/jira/browse/MINIFICPP-988 Project: Apache NiFi MiNiFi

[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #614: MINIFICPP-732 - Add property to expose librdkafka "debug" values for …

2019-07-26 Thread GitBox
phrocker commented on a change in pull request #614: MINIFICPP-732 - Add property to expose librdkafka "debug" values for … URL: https://github.com/apache/nifi-minifi-cpp/pull/614#discussion_r307729933 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -79,6 +79,7

[jira] [Comment Edited] (MINIFICPP-985) Implement listvalidators

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893799#comment-16893799 ] Mr TheSegfault edited comment on MINIFICPP-985 at 7/26/19 12:52 PM:

[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #617: Minificpp 897

2019-07-26 Thread GitBox
phrocker commented on a change in pull request #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307725472 ## File path: CMakeSettings.json ## @@ -104,6 +104,10 @@ "cmakeCommandArgs": "", "buildCommandArgs": "-v -j8",

[jira] [Updated] (MINIFICPP-985) Implement listvalidators

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-985: - Fix Version/s: (was: 0.7.0) > Implement listvalidators >

[jira] [Commented] (MINIFICPP-985) Implement listvalidators

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893797#comment-16893797 ] Mr TheSegfault commented on MINIFICPP-985: -- "What you mentioned (4 and 3.3) is something I

[jira] [Commented] (MINIFICPP-985) Implement listvalidators

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893799#comment-16893799 ] Mr TheSegfault commented on MINIFICPP-985: -- Maybe this will help me resolve my confusion. It

[jira] [Comment Edited] (MINIFICPP-985) Implement listvalidators

2019-07-26 Thread Mr TheSegfault (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893799#comment-16893799 ] Mr TheSegfault edited comment on MINIFICPP-985 at 7/26/19 12:39 PM:

[jira] [Created] (NIFI-6490) MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language

2019-07-26 Thread Alessandro D'Armiento (JIRA)
Alessandro D'Armiento created NIFI-6490: --- Summary: MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language Key: NIFI-6490 URL:

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #617: Minificpp 897

2019-07-26 Thread GitBox
arpadboda commented on a change in pull request #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307691430 ## File path: CMakeSettings.json ## @@ -104,6 +104,10 @@ "cmakeCommandArgs": "", "buildCommandArgs": "-v -j8",

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #617: Minificpp 897

2019-07-26 Thread GitBox
arpadboda commented on a change in pull request #617: Minificpp 897 URL: https://github.com/apache/nifi-minifi-cpp/pull/617#discussion_r307691664 ## File path: extensions/libmodbus/CMakeLists.txt ## @@ -0,0 +1,13 @@

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #618: POC: MINIFICPP-985 - Implement listvalidators

2019-07-26 Thread GitBox
arpadboda commented on a change in pull request #618: POC: MINIFICPP-985 - Implement listvalidators URL: https://github.com/apache/nifi-minifi-cpp/pull/618#discussion_r307690730 ## File path: libminifi/include/core/PropertyValidation.h ## @@ -308,6 +288,66 @@ class

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #618: POC: MINIFICPP-985 - Implement listvalidators

2019-07-26 Thread GitBox
arpadboda commented on a change in pull request #618: POC: MINIFICPP-985 - Implement listvalidators URL: https://github.com/apache/nifi-minifi-cpp/pull/618#discussion_r307690730 ## File path: libminifi/include/core/PropertyValidation.h ## @@ -308,6 +288,66 @@ class

[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #618: POC: MINIFICPP-985 - Implement listvalidators

2019-07-26 Thread GitBox
arpadboda opened a new pull request #618: POC: MINIFICPP-985 - Implement listvalidators URL: https://github.com/apache/nifi-minifi-cpp/pull/618 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to

[GitHub] [nifi] ijokarumawak commented on issue #3592: NIFI-6407 - added support for useAvroLogicalTypes in PutBigQueryBatch

2019-07-26 Thread GitBox
ijokarumawak commented on issue #3592: NIFI-6407 - added support for useAvroLogicalTypes in PutBigQueryBatch URL: https://github.com/apache/nifi/pull/3592#issuecomment-515363298 Hi @pvillard31 This is my first time to use BigQuery but I tried reviewing the improvement since I know