exceptionfactory commented on pull request #5390:
URL: https://github.com/apache/nifi/pull/5390#issuecomment-919647220
> @greyp9 thanks for the fix! I looked at the code and did some testing. All
looks good to me. I'm a +1 on these changes. Given that @exceptionfactory had
made some commen
mtien-apache commented on pull request #5371:
URL: https://github.com/apache/nifi/pull/5371#issuecomment-919621384
Reviewing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
greyp9 commented on a change in pull request #5386:
URL: https://github.com/apache/nifi/pull/5386#discussion_r708730096
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/netty/NettyEventSender.java
##
@@ -25,
greyp9 commented on pull request #5390:
URL: https://github.com/apache/nifi/pull/5390#issuecomment-919581272
Thanks all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Lehel44 removed a comment on pull request #5356:
URL: https://github.com/apache/nifi/pull/5356#issuecomment-919495011
There's a strange compilation error in the pipeline. I will rebase it to
main later to save the comments from force pushing.
--
This is an automated message from the Apac
Lehel44 commented on pull request #5356:
URL: https://github.com/apache/nifi/pull/5356#issuecomment-919495011
There's a strange compilation error in the pipeline. I will rebase it to
main later to save the comments from force pushing.
--
This is an automated message from the Apache Git S
exceptionfactory commented on a change in pull request #5390:
URL: https://github.com/apache/nifi/pull/5390#discussion_r708613114
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/leader/election/CuratorLea
markap14 commented on pull request #5390:
URL: https://github.com/apache/nifi/pull/5390#issuecomment-919493443
@greyp9 thanks for the fix! I looked at the code and did some testing. All
looks good to me. I'm a +1 on these changes. Given that @exceptionfactory had
made some comments, though
markap14 commented on a change in pull request #5390:
URL: https://github.com/apache/nifi/pull/5390#discussion_r708611876
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/leader/election/CuratorLeaderElect
exceptionfactory commented on a change in pull request #5390:
URL: https://github.com/apache/nifi/pull/5390#discussion_r708608680
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/leader/election/CuratorLea
exceptionfactory commented on a change in pull request #5386:
URL: https://github.com/apache/nifi/pull/5386#discussion_r708600644
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/netty/NettyEventServer.java
[
https://issues.apache.org/jira/browse/NIFI-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Thomsen updated NIFI-9216:
---
Fix Version/s: 1.15.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> U
[
https://issues.apache.org/jira/browse/NIFI-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415116#comment-17415116
]
ASF subversion and git services commented on NIFI-9216:
---
Commit bb63
asfgit closed pull request #5385:
URL: https://github.com/apache/nifi/pull/5385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
[
https://issues.apache.org/jira/browse/NIFI-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415091#comment-17415091
]
Paul Grey commented on NIFI-9217:
-
https://github.com/apache/nifi/pull/5390
> Possible de
[
https://issues.apache.org/jira/browse/NIFI-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Grey updated NIFI-9217:
Status: Patch Available (was: In Progress)
> Possible deadlock when node is disconnected
>
greyp9 opened a new pull request #5390:
URL: https://github.com/apache/nifi/pull/5390
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Prevent deadlock caused by interaction between Lead
[
https://issues.apache.org/jira/browse/NIFI-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415049#comment-17415049
]
Paul Grey commented on NIFI-9217:
-
I've changed the LeaderElectionManager maps to use Conc
szaszm commented on pull request #1171:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1171#issuecomment-919284849
I did some more measurements in the same environment, but this time I was
building with `-j12` and using your cmake command line.
My environment:
- Gentoo amd64
[
https://issues.apache.org/jira/browse/NIFI-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Grey updated NIFI-9212:
Status: Patch Available (was: In Progress)
> Tweak Netty Config to Improve JUnit Run Time
> ---
[
https://issues.apache.org/jira/browse/NIFI-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-9216:
---
Status: Patch Available (was: Open)
> Upgrade Apache Derby in Hive Components
> -
[
https://issues.apache.org/jira/browse/NIFI-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-9179:
---
Status: Patch Available (was: Open)
> Run System Tests for any PR that updates framework or A
exceptionfactory opened a new pull request #5389:
URL: https://github.com/apache/nifi/pull/5389
Description of PR
NIFI-9179 Enables the GitHub `system-tests` workflow for Pull Requests that
include changes to the following modules:
- nifi-api
- nifi-framework-api
-
pgyori commented on a change in pull request #5365:
URL: https://github.com/apache/nifi/pull/5365#discussion_r708358951
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##
@@ -297,7 +271,54 @@ private DataType ge
pgyori opened a new pull request #5388:
URL: https://github.com/apache/nifi/pull/5388
… when determining the object's schema.
Signed-off-by: Peter Gyori
https://issues.apache.org/jira/browse/NIFI-9192
Description of PR
Introduces the useLogicalTypes
pgyori closed pull request #5365:
URL: https://github.com/apache/nifi/pull/5365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
MikeThomsen opened a new pull request #5387:
URL: https://github.com/apache/nifi/pull/5387
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-.
[
https://issues.apache.org/jira/browse/NIFI-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414963#comment-17414963
]
Mark Payne commented on NIFI-9217:
--
It appears that given this call stack:
ElectionListe
[
https://issues.apache.org/jira/browse/MINIFICPP-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1488:
--
Summary: Improve tests for features lacking coverage (was: Improve tests
for featu
[
https://issues.apache.org/jira/browse/MINIFICPP-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1488:
--
Epic Name: Test Coverage Expansion (was: 2021 Summer Internship Test
Coverage Expa
fgerlits commented on a change in pull request #1165:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1165#discussion_r708288140
##
File path: libminifi/src/utils/crypto/EncryptionManager.cpp
##
@@ -32,11 +32,7 @@ namespace minifi {
namespace utils {
namespace crypto {
fgerlits commented on a change in pull request #1165:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1165#discussion_r708288140
##
File path: libminifi/src/utils/crypto/EncryptionManager.cpp
##
@@ -32,11 +32,7 @@ namespace minifi {
namespace utils {
namespace crypto {
fgerlits commented on a change in pull request #1165:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1165#discussion_r708288140
##
File path: libminifi/src/utils/crypto/EncryptionManager.cpp
##
@@ -32,11 +32,7 @@ namespace minifi {
namespace utils {
namespace crypto {
[
https://issues.apache.org/jira/browse/MINIFICPP-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi resolved MINIFICPP-1518.
--
Fix Version/s: 0.11.0
Resolution: Fixed
> Migrate integration tests (without
[
https://issues.apache.org/jira/browse/MINIFICPP-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-1516:
-
Fix Version/s: 0.11.0
Resolution: Fixed
Status: Resolved (was: Patc
[
https://issues.apache.org/jira/browse/MINIFICPP-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-1374:
-
Fix Version/s: 0.11.0
Resolution: Fixed
Status: Resolved (was: Patc
szaszm commented on a change in pull request #1165:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1165#discussion_r708276932
##
File path: libminifi/src/utils/crypto/EncryptionManager.cpp
##
@@ -32,11 +32,7 @@ namespace minifi {
namespace utils {
namespace crypto {
-#
szaszm commented on a change in pull request #1165:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1165#discussion_r708274224
##
File path: libminifi/src/utils/crypto/EncryptionManager.cpp
##
@@ -32,11 +32,7 @@ namespace minifi {
namespace utils {
namespace crypto {
-#
greyp9 opened a new pull request #5386:
URL: https://github.com/apache/nifi/pull/5386
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Provide ability to adjust the shutdown configuratio
szaszm closed pull request #1120:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
fgerlits commented on a change in pull request #1165:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1165#discussion_r708193348
##
File path: extensions/standard-processors/processors/RouteOnAttribute.h
##
@@ -39,9 +39,8 @@ namespace processors {
class RouteOnAttribute
[
https://issues.apache.org/jira/browse/MINIFICPP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ádám Markovics updated MINIFICPP-1640:
--
Summary: Run docker tests with debugger (was: Run docker tests from
debugger)
> R
Ádám Markovics created MINIFICPP-1641:
-
Summary: Parallel running of docker tests
Key: MINIFICPP-1641
URL: https://issues.apache.org/jira/browse/MINIFICPP-1641
Project: Apache NiFi MiNiFi C++
Ádám Markovics created MINIFICPP-1640:
-
Summary: Run docker tests from debugger
Key: MINIFICPP-1640
URL: https://issues.apache.org/jira/browse/MINIFICPP-1640
Project: Apache NiFi MiNiFi C++
[
https://issues.apache.org/jira/browse/NIFI-8954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
DEOM Damien resolved NIFI-8954.
---
Resolution: Fixed
The default configuration for DNS Azure should be 168.63.129.16 which is able
to re
MikeThomsen commented on pull request #5350:
URL: https://github.com/apache/nifi/pull/5350#issuecomment-919074592
@exceptionfactory good catches. I'll clear them out. I think when I was
going through the other PRs more thoroughly this is one I forgot to hit.
--
This is an automated messa
[
https://issues.apache.org/jira/browse/NIFI-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eduardo Mota Fontes updated NIFI-9211:
--
Fix Version/s: 1.15.0
> DBCPConnectionPool import error when using variable in "Database
fgerlits commented on pull request #1171:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1171#issuecomment-918963581
I have tried building this, and on my computer (Intel i7-8850H CPU @
2.60GHz, 6 cores x2 hyperthreading), the new code takes longer to compile. I
have no idea why.
fgerlits commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r708016377
##
File path: extensions/standard-processors/processors/RouteText.cpp
##
@@ -0,0 +1,488 @@
+/**
+ * @file RouteText.cpp
+ * TailFile class declar
adamdebreceni commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r707996215
##
File path: extensions/standard-processors/tests/unit/RouteTextTests.cpp
##
@@ -0,0 +1,488 @@
+/**
+ *
+ * Licensed to the Apache Software
adamdebreceni commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r707992037
##
File path: extensions/standard-processors/tests/unit/RouteTextTests.cpp
##
@@ -0,0 +1,488 @@
+/**
+ *
+ * Licensed to the Apache Software
adamdebreceni commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r707991674
##
File path: extensions/standard-processors/processors/RouteText.cpp
##
@@ -0,0 +1,488 @@
+/**
+ * @file RouteText.cpp
+ * TailFile class d
adamdebreceni commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r707988685
##
File path: extensions/standard-processors/processors/RouteText.cpp
##
@@ -0,0 +1,488 @@
+/**
+ * @file RouteText.cpp
+ * TailFile class d
adamdebreceni commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r707988352
##
File path: extensions/standard-processors/processors/RouteText.cpp
##
@@ -0,0 +1,488 @@
+/**
+ * @file RouteText.cpp
+ * TailFile class d
adamdebreceni commented on a change in pull request #1168:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1168#discussion_r707986304
##
File path: extensions/standard-processors/processors/RouteText.cpp
##
@@ -0,0 +1,488 @@
+/**
+ * @file RouteText.cpp
+ * TailFile class d
55 matches
Mail list logo
