[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2018-04-26 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 @mattyb149 Looks like a lot has changed in the last 9 months. The code I added here leveraged classes related to Schema registries, but those classes have been moved into a more Avro

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2018-04-26 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 While I think @markap14 and I agree on the correct long-term solution of adding a new "String Column Names" schema registry, I've never got around to taking on that task. Shifting

[GitHub] nifi issue #2088: NIFI-4242 Allow quote and escape chars for CSV to be 'unde...

2017-09-12 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2088 @markap14 Alright, should be all fixed up now. I made sure to test out a live Flow this time, and make sure the functionality worked outside of just unit tests. ---

[GitHub] nifi pull request #2088: NIFI-4242 Allow quote and escape chars for CSV to b...

2017-09-11 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on a diff in the pull request: https://github.com/apache/nifi/pull/2088#discussion_r138191348 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2088: NIFI-4242 Allow quote and escape chars for CSV to b...

2017-09-11 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on a diff in the pull request: https://github.com/apache/nifi/pull/2088#discussion_r138190101 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi issue #2088: NIFI-4242 Allow quote and escape chars for CSV to be 'unde...

2017-09-11 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2088 @markap14 Thanks for the feedback, and my apologies for the delayed response. Hopefully this latest commit address your feedback. Thanks so much for taking the time to review

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2017-08-17 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 Yea, I think we're on the same page. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #2090: NIFI-4258 Corrected a bug with the 'Informix Unload...

2017-08-15 Thread Wesley-Lawrence
GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/2090 NIFI-4258 Corrected a bug with the 'Informix Unload Escape Disabled' CSV format. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #2088: NIFI-4242 Allow quote and escape chars for CSV to b...

2017-08-15 Thread Wesley-Lawrence
GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/2088 NIFI-4242 Allow quote and escape chars for CSV to be 'undefined'. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi pull request #2052: NIFI-4215 NiFi can now parse an Avro schema of a re...

2017-08-03 Thread Wesley-Lawrence
GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/2052 NIFI-4215 NiFi can now parse an Avro schema of a record that referenc… …es an already defined record, including itself. Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #2034: NIFI-4215 Fixed stackoverflow error when NiFi tries to par...

2017-07-30 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2034 Alright, changes made, and contrib-check still passing for me. Thanks for the review @jvwing! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #2034: NIFI-4215 Fixed stackoverflow error when NiFi tries to par...

2017-07-26 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2034 @pvillard31 Yup, you're right, that solves the issue for me 😃. I got so caught up in the second `RightCurly` definitons saying `}` should be alone, and other `if`s being that way

[GitHub] nifi issue #2034: NIFI-4215 Fixed stackoverflow error when NiFi tries to par...

2017-07-26 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2034 Thanks for taking a look @jvwing! I didn't want to change it, but I keep getting the following error with it; ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2017-07-25 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 @markap14 @mattyb149 Is there any other feedback you'd two like me to address? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #2034: NIFI-4215 NiFi can now parse an Avro schema of a re...

2017-07-23 Thread Wesley-Lawrence
GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/2034 NIFI-4215 NiFi can now parse an Avro schema of a record that references an already defined record, including itself. Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi pull request #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be u...

2017-07-13 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on a diff in the pull request: https://github.com/apache/nifi/pull/2003#discussion_r127294937 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be u...

2017-07-13 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on a diff in the pull request: https://github.com/apache/nifi/pull/2003#discussion_r127294734 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be u...

2017-07-13 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on a diff in the pull request: https://github.com/apache/nifi/pull/2003#discussion_r127265959 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be u...

2017-07-13 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on a diff in the pull request: https://github.com/apache/nifi/pull/2003#discussion_r127263693 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be u...

2017-07-13 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on a diff in the pull request: https://github.com/apache/nifi/pull/2003#discussion_r127263093 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be u...

2017-07-13 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on a diff in the pull request: https://github.com/apache/nifi/pull/2003#discussion_r127262710 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi issue #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be used by ...

2017-07-13 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/2003 @markap14 Good points. I actually considered adding a schema registry at first, but thought it might be too much for just making CSV in/out easier. I think using schemas falls

[GitHub] nifi pull request #2003: NIFI-4181 CSVReader and CSVRecordSetWriter can be u...

2017-07-12 Thread Wesley-Lawrence
GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/2003 NIFI-4181 CSVReader and CSVRecordSetWriter can be used by just explictly declaring their columns. Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #1914: NIFI-4064 Make sure that Funnels with queued incoming Flow...

2017-06-14 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/1914 Fixed and re-squashed the license issue travis found. I suspect the appveyor issues isn't an issue? `mvn -Pcontrib-check clean install` worked fine locally (after a couple of restarts

[GitHub] nifi pull request #1914: NIFI-4064 Make sure that Funnels with queued incomi...

2017-06-13 Thread Wesley-Lawrence
GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/1914 NIFI-4064 Make sure that Funnels with queued incoming FlowFiles, but no outgoing connections yield rather than continually check to run. Thank you for submitting a contribution to Apache

[GitHub] nifi issue #1311: NIFI-3175 Fix a bug in the ValidateCSV processor to handle...

2016-12-08 Thread Wesley-Lawrence
Github user Wesley-Lawrence commented on the issue: https://github.com/apache/nifi/pull/1311 I think the appveyor fail is unrelated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1311: NIFI-3175 Fix a bug in the ValidateCSV processor to...

2016-12-08 Thread Wesley-Lawrence
GitHub user Wesley-Lawrence opened a pull request: https://github.com/apache/nifi/pull/1311 NIFI-3175 Fix a bug in the ValidateCSV processor to handle empty CSV columns Thank you for submitting a contribution to Apache NiFi. In order to streamline the review