Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/460#discussion_r241051202
--- Diff: libminifi/src/processors/LogAttribute.cpp ---
@@ -38,13 +38,23 @@ namespace apache {
namespace nifi {
namespace minifi
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/460#discussion_r241048908
--- Diff: libminifi/include/core/state/Value.h ---
@@ -74,94 +157,215 @@ class BoolValue : public Value {
explicit BoolValue(bool value
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/460#discussion_r241052650
--- Diff: libminifi/include/core/PropertyValidation.h ---
@@ -0,0 +1,347 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/460#discussion_r241048231
--- Diff: libminifi/include/core/state/Value.h ---
@@ -74,94 +157,215 @@ class BoolValue : public Value {
explicit BoolValue(bool value
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/459#discussion_r240994771
--- Diff: nanofi/examples/CMakeLists.txt ---
@@ -50,11 +50,11 @@ if (WIN32)
set(LINK_FLAGS "/WHOLEARCHIVE")
set(LINK
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/459#discussion_r240643845
--- Diff: nanofi/examples/CMakeLists.txt ---
@@ -50,11 +50,11 @@ if (WIN32)
set(LINK_FLAGS "/WHOLEARCHIVE")
set(LINK
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/459
MINIFICPP-695 - NanoFi Examples appear to be broken
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we
Github user arpadboda commented on the pull request:
https://github.com/apache/nifi-minifi-cpp/commit/6ae05fdb5a0068777be7bda80e1105a3b0b1359a#commitcomment-31597872
Thanks, looks good!
---
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239815939
--- Diff: extensions/mqtt/processors/PublishMQTT.h ---
@@ -137,7 +137,7 @@ class PublishMQTT : public
processors::AbstractMQTTProcessor
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/458
MINIFICPP-693 - getProperty should rely on user provided allocated buâ¦
â¦ffers.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239780670
--- Diff: libminifi/include/processors/GetFile.h ---
@@ -194,7 +194,7 @@ class GetFile : public core::Processor, public
state::response
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239778574
--- Diff: extensions/mqtt/processors/PublishMQTT.h ---
@@ -137,7 +137,7 @@ class PublishMQTT : public
processors::AbstractMQTTProcessor
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239776939
--- Diff: extensions/mqtt/processors/AbstractMQTTProcessor.h ---
@@ -157,7 +157,6 @@ class AbstractMQTTProcessor : public core::Processor
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239771411
--- Diff: extensions/libarchive/MergeContent.h ---
@@ -334,7 +334,9 @@ class MergeContent : public processors::BinFiles {
std::string
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239145213
--- Diff: libminifi/include/Exception.h ---
@@ -60,16 +60,17 @@ class Exception : public std::exception {
public:
// Constructor
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239140370
--- Diff: libminifi/include/Exception.h ---
@@ -60,16 +60,17 @@ class Exception : public std::exception {
public:
// Constructor
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239140994
--- Diff: libminifi/include/Exception.h ---
@@ -60,16 +60,17 @@ class Exception : public std::exception {
public:
// Constructor
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239125843
--- Diff: nanofi/include/api/nanofi.h ---
@@ -68,60 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239123478
--- Diff: nanofi/include/api/nanofi.h ---
@@ -68,60 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239116973
--- Diff: nanofi/include/api/nanofi.h ---
@@ -68,60 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239115752
--- Diff: nanofi/include/api/nanofi.h ---
@@ -71,62 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239113983
--- Diff: nanofi/include/api/nanofi.h ---
@@ -135,16 +274,62 @@ flow_file_record* create_ff_object(const char *file,
const size_t len, const uin
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239111667
--- Diff: nanofi/include/api/nanofi.h ---
@@ -165,6 +355,31 @@ uint8_t remove_attribute(flow_file_record*, char *key);
int
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239106406
--- Diff: nanofi/include/api/nanofi.h ---
@@ -68,60 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239105384
--- Diff: nanofi/include/api/nanofi.h ---
@@ -68,60 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/455
MINIFICPP-689 - Make minifi::Exception constructible with string param
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/454#discussion_r238631364
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -325,6 +325,12 @@ void
YamlConfiguration::parseRemoteProcessGroupYaml(YAML::Node
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r238330333
--- Diff: nanofi/include/api/nanofi.h ---
@@ -71,62 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r238329859
--- Diff: nanofi/include/api/nanofi.h ---
@@ -71,62 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r238329139
--- Diff: nanofi/include/api/nanofi.h ---
@@ -71,62 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/448
> I just skimmed the latest commit. Really good stuff. This will go a long
way toward helping consumers of this API. Very excited!
>
> Is this ready for review? If so I&
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/453
Overview:
-Please read tests first. They should give an idea of the motivation of the
change
-This is POF, some parts of the code might leave space for improvement,
some are not
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/453
POF: static property improvements
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/452
MINIFICPP-681 - Minor fixes and improvements of HashContent proc. andâ¦
⦠related docs
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r237412934
--- Diff: libminifi/src/processors/HashContent.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file HashContent.cpp
+ * HashContent class
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r237412844
--- Diff: libminifi/include/processors/HashContent.h ---
@@ -0,0 +1,196 @@
+/**
+ * @file HashContent.h
+ * HashContent class
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/449#discussion_r236665802
--- Diff: libminifi/include/core/ConfigurableComponent.h ---
@@ -153,14 +153,14 @@ class ConfigurableComponent {
*
* @return
Github user arpadboda closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/450
---
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/450
MINIFICPP-686 - Move static property reads to onSchedule function of â¦
â¦processors.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/449
MINIFICPP-685 - Improve const correctness of property getters
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r236150567
--- Diff: nanofi/include/cxx/CallbackProcessor.h ---
@@ -65,24 +67,19 @@ class CallbackProcessor : public core::Processor {
public
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r236149200
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -223,13 +226,15 @@ void free_flowfile(flow_file_record *ff) {
return;
}
auto
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448
MINIFICPP-682 - C API: provide functions to create custom processors
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235734644
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235734574
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235710954
--- Diff: libminifi/include/processors/ContentHash.h ---
@@ -0,0 +1,186 @@
+/**
+ * @file ContentHash.h
+ * ContentHash class
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235710768
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235709568
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235707469
--- Diff: PROCESSORS.md ---
@@ -130,6 +131,31 @@ default values, and whether a property supports the
NiFi Expression Language.
| success
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235707338
--- Diff: libminifi/include/processors/ContentHash.h ---
@@ -0,0 +1,186 @@
+/**
+ * @file ContentHash.h
+ * ContentHash class
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235707060
--- Diff: libminifi/include/processors/ContentHash.h ---
@@ -0,0 +1,186 @@
+/**
+ * @file ContentHash.h
+ * ContentHash class
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235706224
--- Diff: libminifi/include/processors/ContentHash.h ---
@@ -0,0 +1,186 @@
+/**
+ * @file ContentHash.h
+ * ContentHash class
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/446
> @arpadboda I'll update the commit on merge to what was intended if you
don't have a chance to in the next few minutes.
Done.
---
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/446
MINIFICPP-684 - ExtractText processor doesn't handle \
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contrib
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445
MINIFICPP-681 - Add content hash processor
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/440#discussion_r234176325
--- Diff: libminifi/include/io/Serializable.h ---
@@ -22,11 +22,36 @@
#include
#include "EndianCheck.h"
#include &qu
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/439
There is no delete, it was wrong before:
```
void free_flowfile(flow_file_record *ff) {
if (ff == nullptr) {
return;
}
auto content_repo_ptr =
static_cast
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233942801
--- Diff: extensions/coap/controllerservice/CoapConnector.cpp ---
@@ -0,0 +1,189 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233941448
--- Diff: extensions/coap/controllerservice/CoapConnector.cpp ---
@@ -0,0 +1,189 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r233919866
--- Diff: nanofi/include/core/utlist.h ---
@@ -0,0 +1,1073 @@
+/*
--- End diff --
Okay, fine for me. ð Happy to approve as it
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r233913935
--- Diff: nanofi/include/core/utlist.h ---
@@ -0,0 +1,1073 @@
+/*
--- End diff --
Not yet in nanofi :)
Guess this library is
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r233910986
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -72,19 +41,17 @@ class DirectoryConfiguration {
* nifi_instance *create_instance(nifi_port const
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r233910142
--- Diff: nanofi/include/core/cstructs.h ---
@@ -76,6 +80,12 @@ typedef struct
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/436#discussion_r233909297
--- Diff: nanofi/include/core/utlist.h ---
@@ -0,0 +1,1073 @@
+/*
--- End diff --
I would prefer to place this file somewhere
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/440
A step forward, there is improvement left (a lot of code duplication exists
in stream hierarchy), although this is enough for one PR.
---
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/440
MINIFICPP-676 - Cleanup and fix serializable interface implementation
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/439#discussion_r233815698
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -205,7 +205,7 @@ flow_file_record* create_ff_object(const char *file,
const size_t len, const uin
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/439
MINIFICPP-645 - Move from new to malloc in CAPI to facilitate eventuaâ¦
â¦l change from C++ to C
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233507600
--- Diff: extensions/coap/protocols/CoapC2Protocol.cpp ---
@@ -0,0 +1,353 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233504886
--- Diff: extensions/coap/protocols/CoapC2Protocol.cpp ---
@@ -0,0 +1,353 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233501997
--- Diff: extensions/coap/nanofi/coap_functions.c ---
@@ -0,0 +1,175 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233500950
--- Diff: extensions/coap/nanofi/coap_functions.c ---
@@ -0,0 +1,175 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233500619
--- Diff: extensions/coap/nanofi/coap_functions.c ---
@@ -0,0 +1,175 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233500462
--- Diff: extensions/coap/nanofi/coap_functions.c ---
@@ -0,0 +1,175 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233499744
--- Diff: extensions/coap/controllerservice/CoapConnector.h ---
@@ -0,0 +1,207 @@
+/**
+ *
+ * Licensed to the Apache Software
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/437#discussion_r233497401
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -42,6 +42,8 @@ def __init__(self, output_validator
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/435#discussion_r232960242
--- Diff: libminifi/src/io/BaseStream.cpp ---
@@ -143,15 +147,19 @@ int BaseStream::read(uint8_t *value, int len) {
* @param buflen
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/435
The implementation is fine, I wonder if:
-This all could be done using template member functions
-We could add some more details to commit msg
---
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231889164
--- Diff: nanofi/include/cxx/Plan.h ---
@@ -133,8 +133,29 @@ class ExecutionPlan {
next_ff_ = ptr;
}
+ bool
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231886702
--- Diff: nanofi/src/cxx/Plan.cpp ---
@@ -162,6 +153,21 @@ bool
ExecutionPlan::runNextProcessor(std::function current_session =
std::make_shared
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231886506
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -323,55 +360,45 @@ int transmit_flowfile(flow_file_record *ff,
nifi_instance *instance
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231884707
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -323,55 +360,45 @@ int transmit_flowfile(flow_file_record *ff,
nifi_instance *instance
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231880575
--- Diff: nanofi/include/cxx/Plan.h ---
@@ -44,7 +44,7 @@
#include "core/ProcessSession.h"
#include "core/ProcessorNode.h
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231879717
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -89,6 +93,39 @@ nifi_instance *create_instance(const char *url,
nifi_port *port) {
return
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231878067
--- Diff: nanofi/include/core/cxxstructs.h ---
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231876679
--- Diff: nanofi/include/cxx/CallbackProcessor.h ---
@@ -65,7 +65,7 @@ class CallbackProcessor : public core::Processor {
public
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/432
>
>
> @arpadboda is this good? I'm good with this otherwise.
Now it is.
---
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r231202899
--- Diff: nanofi/src/cxx/Plan.cpp ---
@@ -162,6 +153,21 @@ bool
ExecutionPlan::runNextProcessor(std::function current_session =
std::make_shared
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/432
> @arpadboda is this good? I'm good with this otherwise.
Good, but not complete, I will amend some stuff soon. (today)
---
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r230801807
--- Diff: libminifi/CMakeLists.txt ---
@@ -141,11 +141,14 @@ endif()
SET (LIBMINIFI core-minifi PARENT_SCOPE)
if (ENABLE_PYTHON
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r230800455
--- Diff: libminifi/CMakeLists.txt ---
@@ -141,11 +141,14 @@ endif()
SET (LIBMINIFI core-minifi PARENT_SCOPE)
if (ENABLE_PYTHON
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229595113
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -142,7 +147,7 @@ def check_output(self, timeout=5
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/427#discussion_r229593381
--- Diff: docker/test/integration/minifi/test/__init__.py ---
@@ -117,12 +119,15 @@ def log_nifi_output(self):
for container in
Github user arpadboda closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/431
---
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/431
> @arpadboda this was merged but I used the wrong commit hook to close it.
I closed the wrong PR. So can you close this when you have a chance? Sorry
about that.
Sure, done
---
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/432
Incomplete as the functionality to use a standalone processor with existing
data is not yet implemented, however the already done part is not planned to be
changed, so happy to receive
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432#discussion_r229379233
--- Diff: libminifi/src/capi/Plan.cpp ---
@@ -23,19 +23,8 @@
#include
#include
-bool intToFailureStragey(int in
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/432
MINIFICPP-648 - add processor and add processor with linkage nomenclaâ¦
â¦ture is confusing
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/431
MINIFICPP-640 - C API: how to support dynamic properties?
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/429#discussion_r229266790
--- Diff: libminifi/include/capi/Plan.h ---
@@ -16,6 +16,8 @@
* limitations under the License.
*/
+#pragma once
--- End
1 - 100 of 169 matches
Mail list logo
