[GitHub] nifi issue #2794: NIFI-4579: Fix ValidateRecord type coercing

2018-12-13 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2794 +1 LGTM, verified the unit test illustrates the behavior and the patch fixes it. Thanks for the fix! Merging to master ---

[GitHub] nifi pull request #3217: NIFI-3988: Add fragment attributes to SplitRecord

2018-12-13 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3217 NIFI-3988: Add fragment attributes to SplitRecord Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #3216: NIFI-5891 fix handling of null logical types in Hive3Strea...

2018-12-13 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3216 +1 LGTM, verified the unit tests illustrate the problem and the patch fixes it. There are 2 CheckStyle violations but I will fix them on merge. Thanks for the fix! Merging to master ---

[GitHub] nifi pull request #2521: NIFI-4946 nifi-spark-bundle : Adding support for py...

2018-12-05 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2521#discussion_r239241291 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/main/java/org/apache/nifi/processors/livy/ExecuteSparkInteractive.java

[GitHub] nifi pull request #3191: NIFI-5855: Remove unnecessary ORDER BY clause in Ge...

2018-11-29 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3191 NIFI-5855: Remove unnecessary ORDER BY clause in GenerateTableFetch when Partition Size is zero Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #3188: NIFI-5829 Create Lookup Controller Services for Rec...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3188#discussion_r237218520 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi pull request #3188: NIFI-5829 Create Lookup Controller Services for Rec...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3188#discussion_r237218092 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi issue #3186: NIFI-5843 added subjects to the error message to make it c...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3186 +1 LGTM, thanks for the improvement! Merging to master ---

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r237138338 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/AbstractCassandraProcessor.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r237138928 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/AbstractCassandraProcessor.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r237141917 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r237152109 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r237138678 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/AbstractCassandraProcessor.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r237147586 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi pull request #3184: NIFI-5845: Add support for OTHER and SQLXML JDBC ty...

2018-11-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3184#discussion_r237101820 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/util/hive/HiveJdbcCommon.java --- @@ -402,6 +409,9

[GitHub] nifi pull request #3184: NIFI-5845: Add support for OTHER and SQLXML JDBC ty...

2018-11-27 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3184 NIFI-5845: Add support for OTHER and SQLXML JDBC types to SQL/Hive processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution

[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...

2018-11-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3179#discussion_r236410267 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3QL.java --- @@ -148,7 +148,23

[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...

2018-11-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3179#discussion_r236410289 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/PutHive3QL.java --- @@ -148,7 +148,23

[GitHub] nifi issue #3167: NIFI-5812: Marked Database processors as 'PrimaryNodeOnly'

2018-11-21 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3167 Removing the PrimaryNodeOnly annotation from GTF causes a Checkstyle violation due to the unused import. Can you remove the import statement as well? Wouldn't hurt to rebase (not merge) as well

[GitHub] nifi pull request #3179: NIFI-5834: Restore default PutHiveQL error handling...

2018-11-20 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3179 NIFI-5834: Restore default PutHiveQL error handling behavior Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #3177: NIFI-5828: Documents behavior of ExecuteSQL attrs when Max...

2018-11-19 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3177 @colindean mind closing this PR? Doesn't look like the comment in the commit caused it to auto-close (maybe the period after the PR number?) Please and thanks! Also I updated the Fix Version

[GitHub] nifi issue #3128: NIFI-5788: Introduce batch size limit in PutDatabaseRecord...

2018-11-15 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3128 +1 LGTM, tested with various batch sizes and ran unit tests. Thanks for this improvment! Merged to master ---

[GitHub] nifi pull request #3075: NIFI-5604: Added property to allow empty FlowFile w...

2018-11-14 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3075#discussion_r233598457 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java

[GitHub] nifi pull request #3170: NIFI-5652: Fixed LogMessage when logging level is d...

2018-11-14 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3170 NIFI-5652: Fixed LogMessage when logging level is disabled I couldn't write a unit test as I can't change the log level in between unit tests. I reproduced the issue and verified it is no longer

[GitHub] nifi issue #1953: NIFI-4130 Add lookup controller service in TransformXML to...

2018-11-14 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1953 +1 LGTM, thanks for the review @bdesert and the improvement @pvillard31 ! Merging to master ---

[GitHub] nifi pull request #3075: NIFI-5604: Added property to allow empty FlowFile w...

2018-11-13 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3075#discussion_r233142376 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java

[GitHub] nifi issue #3130: NIFI-5791: Add Apache Daffodil (incubating) bundle

2018-11-12 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3130 This is interesting stuff, I need to read more up on DFDL, might make a good schema definition language as an alternative to Avro schemas. Also at first glance it seems the Daffodil infoset

[GitHub] nifi issue #3167: NIFI-5812: Marked Database processors as 'PrimaryNodeOnly'

2018-11-12 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3167 I did something like that for the Hive 1 version of PutHiveStreaming, the underlying library wasn't thread-safe if you were working on the same table, so I put in a "table lock" wher

[GitHub] nifi pull request #3167: NIFI-5812: Marked Database processors as 'PrimaryNo...

2018-11-12 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3167#discussion_r232697514 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java

[GitHub] nifi pull request #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPCo...

2018-11-08 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3133#discussion_r232011596 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java

[GitHub] nifi pull request #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPCo...

2018-11-07 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3133#discussion_r231582876 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java

[GitHub] nifi pull request #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPCo...

2018-11-07 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3133#discussion_r231582349 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java

[GitHub] nifi pull request #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPCo...

2018-11-07 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3133#discussion_r231580669 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java

[GitHub] nifi pull request #3133: NIFI-5790: Exposes 6 commons-dbcp options in DBCPCo...

2018-11-07 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3133#discussion_r231580368 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java

[GitHub] nifi issue #2287: NIFI-4625 - Added External Version to the PutElastic5 Proc...

2018-11-06 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2287 There has been some recent interest in this feature, do you think you'll be able to continue with this? Seems like a good feature to add. ---

[GitHub] nifi pull request #3128: NIFI-5788: Introduce batch size limit in PutDatabas...

2018-11-05 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3128#discussion_r230812123 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java

[GitHub] nifi pull request #3128: NIFI-5788: Introduce batch size limit in PutDatabas...

2018-11-05 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3128#discussion_r230811717 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java

[GitHub] nifi issue #3117: NIFI-5770 Fix Memory Leak in ExecuteScript on Jython

2018-11-01 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3117 +1 LGTM, ran unit tests and tried a Jython script in a live NiFi instance. Thanks for the improvement! Merging to master ---

[GitHub] nifi issue #3123: NIFI-5781 - Incorrect schema for provenance events in Site...

2018-11-01 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3123 +1 LGTM, verified the documentation looks correct, and used the output S2S Prov Reporting Task in various record-based processors with the updated schema. Thanks for the improvement! Merging

[GitHub] nifi issue #3041: NIFI-5224 Added SolrClientService.

2018-10-29 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3041 Mind updating the versions to 1.9.0-SNAPSHOT? Please and thanks! ---

[GitHub] nifi issue #3105: NIFI-5621: Added Cassandra connection provider service

2018-10-29 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3105 Mind rebasing this and setting all 1.8.0-SNAPSHOT versions to 1.9.0-SNAPSHOT? Please and thanks! ---

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-10-25 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3107 Just to connect the dots here, there is some dissent from the PMC about this approach, so we should do our best to reach consensus on the mailing list before this PR is merged, in case

[GitHub] nifi issue #3020: NIFI-5625: support the variables for the properties of HTT...

2018-10-25 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3020 Mind rebasing this against the latest master? Please and thanks! ---

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-10-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r228325897 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-10-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r228325643 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/AbstractCassandraProcessor.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-10-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r228332165 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-10-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r228331847 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-10-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r228328178 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-10-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r228327507 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi issue #3086: NIFI-5714 - Hive[3]ConnectionPool - Kerberos Authenticatio...

2018-10-24 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3086 +1 LGTM, tested successfully. Thanks for the fix! Merging to master ---

[GitHub] nifi issue #3107: NIFI-5744: Put exception message to attribute while Execut...

2018-10-24 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3107 Reviewing... ---

[GitHub] nifi issue #3104: NIFI-5740 Ensuring permissions are restored after test com...

2018-10-23 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3104 +1 LGTM, verified I couldn't delete the directories manually without this change, and I can afterwards. Thanks for the fix! Merging to master ---

[GitHub] nifi issue #3094: NIFI-5727 - Optimize GenerateTableFetch to remove unnecess...

2018-10-23 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3094 +1 LGTM, ran regression tests and tried on a NiFi instance. Thanks for the improvement! Merging to master ---

[GitHub] nifi issue #3086: NIFI-5714 - Hive[3]ConnectionPool - Kerberos Authenticatio...

2018-10-23 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3086 Not sure if you want to try another rebase to see if the repo problem is gone (and the realm problem is fixed), or just Ignore the test. I'm fine with either, let me know when you're happy

[GitHub] nifi issue #3092: NIFI-5525 - CSVRecordReader fails with StringIndexOutOfBou...

2018-10-22 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3092 Pierre made the change Peter recommended (I verified). I think we need it in now as the current Jira is only partially complete for 1.8.0 without it. Peter, I'm going to go ahead and merge

[GitHub] nifi issue #3101: NIFI-5736: Removed 'synchronized' keyword from SwappablePr...

2018-10-22 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3101 +1 LGTM, ran full build with tests and tried a live NiFi instance. Thanks for the fix! Merging to master ---

[GitHub] nifi pull request #3092: NIFI-5525 - CSVRecordReader fails with StringIndexO...

2018-10-22 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3092#discussion_r227045025 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi

[GitHub] nifi issue #3079: NIFI-5706 : Added ConvertAvroToParquet processor

2018-10-18 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3079 What is the use case for having Parquet files flow through NiFi? I wrote ConvertAvroToORC and every time I saw it used, it was immediately followed by PutHDFS. So I followed the PutParquet lead

[GitHub] nifi issue #3086: NIFI-5714 - Hive[3]ConnectionPool - Kerberos Authenticatio...

2018-10-18 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3086 Doesn't look like the tests were run due to a bad artifact. Maybe rebase the PR (squashing just the commits where you tried individual things?) and force push, hopefully it'll go through this time

[GitHub] nifi issue #3086: NIFI-5714 - Hive[3]ConnectionPool - Kerberos Authenticatio...

2018-10-18 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3086 The krb5.conf from the TestRangerNiFiAuthorizer looks like this: ``` [libdefaults] default_realm = EXAMPLE.COM dns_lookup_kdc = false

[GitHub] nifi issue #3086: NIFI-5714 - Hive[3]ConnectionPool - Kerberos Authenticatio...

2018-10-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3086 First one didn't work :( ---

[GitHub] nifi issue #3086: NIFI-5714 - Hive[3]ConnectionPool - Kerberos Authenticatio...

2018-10-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3086 Same here, the relevant error in the Travis log is "Cannot locate default realm". Looking at other tests that load krb5.conf, one (TestHBase_1_1_2_ClientSe

[GitHub] nifi issue #3086: NIFI-5714 - Hive[3]ConnectionPool - Kerberos Authenticatio...

2018-10-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3086 Looks like the unit test is throwing the wrong exception, IllegalArgumentException instead of InitializationException ---

[GitHub] nifi issue #3081: NIFI-5708 Fixing the creation of ValidationContextFactory ...

2018-10-16 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3081 +1 LGTM, thanks for the fix! Merging to master ---

[GitHub] nifi pull request #3076: NIFI-5705: Added Hive 3 attribution to nifi-assembl...

2018-10-15 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3076 NIFI-5705: Added Hive 3 attribution to nifi-assembly and top-level NOTICEs Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we

[GitHub] nifi pull request #3075: NIFI-5604: Added property to allow empty FlowFile w...

2018-10-15 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3075 NIFI-5604: Added property to allow empty FlowFile when no SQL generated by GenerateTableFetch Note that this should work with NIFI-5601 (#3074) such that the fragment attributes would be written

[GitHub] nifi pull request #3074: NIFI-5601: Add fragment.* attributes to GenerateTab...

2018-10-15 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3074 NIFI-5601: Add fragment.* attributes to GenerateTableFetch Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #3062: NIFI-5686: Updated StandardProcessScheduler so that if it ...

2018-10-15 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3062 +1 LGTM, ran full build with unit tests, tried on a live instance with reporting tasks and various other flows. Thanks for the improvement! Merging to master ---

[GitHub] nifi pull request #2861: NIFI-5248 Added new Elasticsearch json and record p...

2018-10-15 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2861#discussion_r225216435 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2861: NIFI-5248 Added new Elasticsearch json and record p...

2018-10-15 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2861#discussion_r225215375 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/pom.xml --- @@ -107,6 +146,38 @@ language governing permissions

[GitHub] nifi pull request #2861: NIFI-5248 Added new Elasticsearch json and record p...

2018-10-15 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2861#discussion_r225215710 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2861: NIFI-5248 Added new Elasticsearch json and record p...

2018-10-15 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2861#discussion_r225208197 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2861: NIFI-5248 Added new Elasticsearch json and record p...

2018-10-15 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2861#discussion_r225208562 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi issue #3057: NIFI-5667: Add nested record support for PutORC

2018-10-12 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3057 Updated the rest of the backticks, thanks @VikingK and @bbende for your reviews! ---

[GitHub] nifi issue #3057: NIFI-5667: Add nested record support for PutORC

2018-10-11 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3057 I found the issue and pushed a new commit with the fix. Also your test data exercised another part of the code I hadn't thought of, your "as" field is a keyword in Hive so when I used the

[GitHub] nifi pull request #3060: NIFI-5678: Fixed MAP type support of MapRecord obje...

2018-10-10 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3060 NIFI-5678: Fixed MAP type support of MapRecord objects in StandardSchemaValidator Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #3057: NIFI-5667: Add nested record support for PutORC

2018-10-10 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3057#discussion_r224126176 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/orc/PutORC.java --- @@ -157,19 +155,17

[GitHub] nifi issue #3057: NIFI-5667: Add nested record support for PutORC

2018-10-10 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3057 Can you share the schema of the data, and possibly a JSON export of your Avro file? I couldn't reproduce this with an array of ints, and @bbende ran successfully with an array of records. ---

[GitHub] nifi pull request #3057: NIFI-5667: Add nested record support for PutORC

2018-10-09 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3057#discussion_r223893228 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/orc/PutORC.java --- @@ -157,19 +155,17

[GitHub] nifi pull request #3057: NIFI-5667: Add nested record support for PutORC

2018-10-09 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3057#discussion_r223892664 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/hadoop/hive/ql/io/orc/NiFiOrcUtils.java --- @@ -163,19 +161,30

[GitHub] nifi pull request #3057: NIFI-5667: Add nested record support for PutORC

2018-10-09 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3057#discussion_r223892405 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-mock-record-utils/src/main/java/org/apache/nifi/serialization/record

[GitHub] nifi pull request #3057: NIFI-5667: Add nested record support for PutORC

2018-10-09 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/3057 NIFI-5667: Add nested record support for PutORC The basic approach here is that I removed all references to Avro schemas/fields and replaced them with NiFi Record API concepts. This allows us

[GitHub] nifi issue #2966: NIFI-5552 - Add option to normalize header column names in...

2018-10-09 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2966 I'm a little leery of automatically normalizing the names. In [NIFI-4612](https://issues.apache.org/jira/browse/NIFI-4612) we added the ability to disable name validation for the AvroSchemaRegistry

[GitHub] nifi issue #2997: NIFI-5583: Add cdc processor for MySQL referring to GTID.

2018-10-09 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2997 Do we need a separate processor for this, or can we just add GTID support to the existing one (perhaps with a property such as "Include GTID" or whatever, defaulting to false but if s

[GitHub] nifi issue #3025: NIFI-5605 Added UpdateCassandra.

2018-10-09 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3025 Can PutCassandraRecord also be improved to allow inserts, updates, deletes? I'm thinking PutCassandraRecord could be like PutDatabaseRecord. Doesn't PutCassandraQL already support updates since

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-10-09 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r223701761 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi pull request #3051: NIFI-5642: QueryCassandra processor : output FlowFi...

2018-10-09 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3051#discussion_r223700156 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/QueryCassandra.java

[GitHub] nifi issue #2974: NIFI-5533: Be more efficient with heap utilization

2018-10-09 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2974 +1 LGTM, ran full build with unit tests and tried many different scenarios with record processors, attributes, etc. Thanks for the improvements! Merging to master ---

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-04 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r222757166 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-04 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r222753864 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/Neo4JCypherExecutor.java --- @@ -0,0

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-04 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r222758854 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-04 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r222758485 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-04 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r222756058 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-04 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r222756361 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-04 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r222760950 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi issue #2945: NIFI-4517: Added ExecuteSQLRecord and QueryDatabaseTableRe...

2018-10-04 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2945 @pvillard31 @MikeThomsen Think we can get the final review done in time for 1.8.0? Folks have been asking for these processors for a long time :) ---

[GitHub] nifi issue #3025: NIFI-5605 Added UpdateCassandra.

2018-10-01 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3025 Is there a reason we can't have delete/update capabilities in PutCassandraQL and/or PutCassandraRecord? Wondering why the need for a separate processor. If it does need to be separate, maybe

[GitHub] nifi issue #3015: NIFI-5254 [WIP] Updated to Groovy 2.5.2

2018-10-01 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3015 Unfortunately I believe you need to enumerate all the transitive dependencies in the L You should have been able to copy that from the Groovy NOTICE, but it does not have its own dependencies

[GitHub] nifi issue #2861: NIFI-5248 Added new Elasticsearch json and record processo...

2018-10-01 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2861 Mind rebasing this one? I think you were waiting on the ES LookupService PR anyway, and now it's in :) ---

[GitHub] nifi issue #3042: NIFI-5650: Added Xerces to scripting bundle for Jython 2.7...

2018-10-01 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3042 Thanks! Might need to update your master before pushing, I brought in your ES Lookup Service PR (finally :P) ---

  1   2   3   4   5   6   7   8   9   10   >