szaszm closed pull request #1756: MINIFICPP-2326 Link lua statically
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
szaszm commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1566008345
##
libminifi/test/unit/CronTests.cpp:
##
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA_DIR
martinzink commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1565982904
##
libminifi/test/unit/CronTests.cpp:
##
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA
szaszm commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1565961703
##
libminifi/test/unit/CronTests.cpp:
##
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA_DIR
fgerlits commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1565902422
##
libminifi/test/unit/CronTests.cpp:
##
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA_D
fgerlits commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1565902422
##
libminifi/test/unit/CronTests.cpp:
##
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA_D
fgerlits commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1565902422
##
libminifi/test/unit/CronTests.cpp:
##
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA_D
fgerlits commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1565902422
##
libminifi/test/unit/CronTests.cpp:
##
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA_D
szaszm commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1565727195
##
libminifi/test/unit/CronTests.cpp:
##
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA_DIR
fgerlits commented on PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#issuecomment-2049275853
> I think some other files need to be updated as well
Yes, good point, thanks! Fixed in 450f397604263c1faafdfffdd3aab7158556720e.
--
This is an automated message from th
lordgamez commented on PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#issuecomment-2047939844
I think some other files need to be updated as well:
- Remove Lua from build time dependencies in README.md
- Remove lua package installation from bootstrap shell files if l
fgerlits opened a new pull request, #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756
Link liblua statically into the lua script extension instead of using the
lua library installed on the system.
https://issues.apache.org/jira/browse/MINIFICPP-2326
---
Tha
12 matches
Mail list logo
