ravinarayansingh commented on code in PR #8995:
URL: https://github.com/apache/nifi/pull/8995#discussion_r1670915680
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java:
##
@@ -0,0
mattyb149 commented on code in PR #8995:
URL: https://github.com/apache/nifi/pull/8995#discussion_r1653289944
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java:
##
@@ -0,0 +1,53
mattyb149 closed pull request #7544: NIFI-11858 Configurable Column Name
Normalization in PutDatabaseRecord and UpdateDatabaseTable
URL: https://github.com/apache/nifi/pull/7544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mattyb149 commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2185613576
Closing this in favor of the new PR, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ravinarayansingh commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2184174000
> Looks like there are some merge and/or rebase issues here, might be worth
a new PR applying the desired commits to a feature branch based off the latest
main branch.
Hi
ravinarayansingh commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1644904710
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##
@@ -270,6
jrsteinebrey commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2163395200
Thanks, @ravinarayansingh. My comments that are automatically marked as
Outdated are all resolved.
I still have some open existing comments that I recommend changing property
names.
mattyb149 commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1636607648
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/ColumnDescription.java:
##
@@ -84,9 +84,6
jrsteinebrey commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1635355735
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/ColumnDescription.java:
##
@@ -84,9
jrsteinebrey commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1635355735
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/ColumnDescription.java:
##
@@ -84,9
jrsteinebrey commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1631317574
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##
@@ -278,6
mattyb149 commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2130235297
The checkstyle rules were recently made more stringent, looks like this
needs another rebase and please run your Maven build with the `contrib-check`
profile activated.
--
This is an
jrsteinebrey commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2127792570
Thanks for the changes you made. Some other files in this PR now have
checkstyle violations:
Warning:
ravinarayansingh commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2125166378
Hi @jrsteinebrey
I have updated the code as per you suggestion, have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please
jrsteinebrey commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1603296706
##
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java:
##
@@ -0,0
ravinarayansingh commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2076490348
Hi @mattyb149
Build is failing but i think that is not related to this PR
please let me know if i have change anything form myside
--
This is an automated message from
mattyb149 commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2061707094
This needs a rebase against the latest main, then I will take a look also,
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
exceptionfactory commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2041215127
Thanks for the updates @ravinarayansingh, the `ColumnNameNormalizer` with
individual implementations matches what I had in mind. I appreciate your
efforts, I will take a closer
ravinarayansingh commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2039271408
> @ravinarayansingh Thanks for your work and patience on this pull request.
>
> Unfortunately I may not have been clear in previous comments regarding the
ravinarayansingh commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2038164793
> @ravinarayansingh Thanks for your work and patience on this pull request.
>
> Unfortunately I may not have been clear in previous comments regarding the
interface-based
ravinarayansingh commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-2007277327
Hi @dan-s1 and @exceptionfactory
please have look and let me know if any change required
--
This is an automated message from the Apache Git Service.
To respond to the
dan-s1 commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1476145113
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/ColumnNameNormalizerUtility.java:
##
@@ -0,0 +1,56
dan-s1 commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-1873402173
@exceptionfactory Can you please restart the 'ci-workflow / Windows Zulu JDK
21 FR` build again? The error does not seem to relate to the changes in the PR.
Thanks!
--
This is an
ravinarayansingh commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1438454454
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/db/ColumnNameNormalizerUtilityTest.java:
##
dan-s1 commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1438276400
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/db/ColumnNameNormalizerUtilityTest.java:
##
@@ -0,0
ravinarayansingh commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1437177360
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java:
##
@@ -460,15
dan-s1 commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1437164753
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java:
##
@@ -460,15 +488,18 @@
ravinarayansingh commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-1839974560
Hi @exceptionfactory
i have made the required changes please have a look
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message,
exceptionfactory commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1412711140
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java:
##
@@ -1276,8
ravinarayansingh commented on PR #7544:
URL: https://github.com/apache/nifi/pull/7544#issuecomment-1825274326
Hi @exceptionfactory ,
I have made the required changes, please have a look
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the
30 matches
Mail list logo
