Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239108187
--- Diff: nanofi/include/api/nanofi.h ---
@@ -135,16 +274,62 @@ flow_file_record* create_ff_object(const char *file,
const size_t len, const uin
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239107724
--- Diff: nanofi/include/api/nanofi.h ---
@@ -135,16 +274,62 @@ flow_file_record* create_ff_object(const char *file,
const size_t len, const uin
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/454#discussion_r239092725
--- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp ---
@@ -325,6 +325,12 @@ void
YamlConfiguration::parseRemoteProcessGroupYaml(YAML::Node
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/448
taking a look
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239103770
--- Diff: nanofi/include/api/nanofi.h ---
@@ -68,60 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2(nifi_instance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239105138
--- Diff: nanofi/include/api/nanofi.h ---
@@ -71,62 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2(nifi_instance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239110104
--- Diff: nanofi/include/core/cstructs.h ---
@@ -114,4 +126,6 @@ typedef enum FS {
ROLLBACK
} FailureStrategy;
+typedef void
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239109360
--- Diff: nanofi/include/api/nanofi.h ---
@@ -165,6 +355,31 @@ uint8_t remove_attribute(flow_file_record*, char *key);
int
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239106621
--- Diff: nanofi/include/api/nanofi.h ---
@@ -68,60 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2(nifi_instance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239117109
--- Diff: libminifi/include/Exception.h ---
@@ -60,16 +60,17 @@ class Exception : public std::exception {
public:
// Constructor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239117254
--- Diff: libminifi/include/Exception.h ---
@@ -60,16 +60,17 @@ class Exception : public std::exception {
public:
// Constructor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239144107
--- Diff: libminifi/include/Exception.h ---
@@ -60,16 +60,17 @@ class Exception : public std::exception {
public:
// Constructor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/455#discussion_r239144665
--- Diff: libminifi/include/Exception.h ---
@@ -60,16 +60,17 @@ class Exception : public std::exception {
public:
// Constructor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239819770
--- Diff: extensions/mqtt/processors/PublishMQTT.h ---
@@ -137,7 +137,7 @@ class PublishMQTT : public
processors::AbstractMQTTProcessor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239815379
--- Diff: extensions/mqtt/processors/PublishMQTT.h ---
@@ -137,7 +137,7 @@ class PublishMQTT : public
processors::AbstractMQTTProcessor
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239815707
--- Diff: libminifi/include/processors/GetFile.h ---
@@ -194,7 +194,7 @@ class GetFile : public core::Processor, public
state::response
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239792102
--- Diff: libminifi/include/processors/GetFile.h ---
@@ -194,7 +194,7 @@ class GetFile : public core::Processor, public
state::response
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239814559
--- Diff: extensions/libarchive/MergeContent.h ---
@@ -334,7 +334,9 @@ class MergeContent : public processors::BinFiles {
std::string
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457#discussion_r239792561
--- Diff: extensions/mqtt/processors/AbstractMQTTProcessor.h ---
@@ -157,7 +157,6 @@ class AbstractMQTTProcessor : public core::Processor
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/454
MINIFICPP-404: Correct invalid assumption and protect against invalidâ¦
⦠protocols
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order
Github user phrocker commented on the pull request:
https://github.com/apache/nifi-minifi-cpp/commit/4cc6702a9841ca7441a9553080f81b148daac2fc#commitcomment-31523402
I just skimmed the latest commit. Really good stuff. This will go a long
way toward helping consumers of this API. Very
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239481840
--- Diff: nanofi/include/api/nanofi.h ---
@@ -165,6 +355,31 @@ uint8_t remove_attribute(flow_file_record*, char *key);
int
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/448
Also added https://issues.apache.org/jira/browse/MINIFICPP-695 since
examples don't appear to work in testing. Merging anyway so we can fix that as
a follow on
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/456
MINIFICPP-690: Correct log statement and regenerate docs
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/457
MINIFICPP-691: Add method for getting processor description. Internalâ¦
⦠API change, but is strictly voluntary for contributors
Based on work from September -- enables us
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/453
Thanks for submitting this. I think there is definite overlap between work
I previously had with MINIFICPP-479
(https://github.com/apache/nifi-minifi-cpp/compare/master
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239477701
--- Diff: nanofi/include/api/nanofi.h ---
@@ -68,60 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2(nifi_instance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239477181
--- Diff: nanofi/include/api/nanofi.h ---
@@ -71,62 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2(nifi_instance
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r239479166
--- Diff: nanofi/include/api/nanofi.h ---
@@ -68,60 +94,173 @@ typedef int c2_start_callback(char *);
void enable_async_c2(nifi_instance
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/444
MINIFICPP-679: Revert changes. We can make them const but we should wâ¦
â¦ait after additional testing before pushing these changes
Thank you for submitting a contribution
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/444
@apiri Master is broken. We need to revert these two changes. Not sure how
I missed it...but the goal was to limit changes to avoid breaking changes.
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235461700
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235477945
--- Diff: libminifi/include/processors/ContentHash.h ---
@@ -0,0 +1,186 @@
+/**
+ * @file ContentHash.h
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235459513
--- Diff: libminifi/include/processors/ContentHash.h ---
@@ -0,0 +1,186 @@
+/**
+ * @file ContentHash.h
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235474428
--- Diff: libminifi/include/processors/ContentHash.h ---
@@ -0,0 +1,186 @@
+/**
+ * @file ContentHash.h
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235461430
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235472601
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235461991
--- Diff: libminifi/include/processors/ContentHash.h ---
@@ -0,0 +1,186 @@
+/**
+ * @file ContentHash.h
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235476969
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235471397
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r235458978
--- Diff: PROCESSORS.md ---
@@ -130,6 +131,31 @@ default values, and whether a property supports the
NiFi Expression Language.
| success
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/447
Since this is pretty large I'm doing a self review of this now.
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/447#discussion_r235480882
--- Diff: extensions/coap/COAPLoader.h ---
@@ -0,0 +1,81 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/447#discussion_r235480740
--- Diff: extensions/coap/CMakeLists.txt ---
@@ -0,0 +1,93 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/447#discussion_r235487951
--- Diff: extensions/coap/controllerservice/CoapConnector.cpp ---
@@ -0,0 +1,97 @@
+/**
+ *
+ * Licensed to the Apache Software
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/447
MINIFICPP-558: initial provisioning for CoAP still a wip
test framework still under dev
MINIFICPP-683: Remove extraneous std::move
MINIFICPP-558: Add some test
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/446
@arpadboda I'll update the commit on merge to what was intended if you
don't have a chance to in the next few minutes.
---
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/445
taking a look.
---
Github user phrocker closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/437
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/449#discussion_r236664502
--- Diff: libminifi/include/core/ConfigurableComponent.h ---
@@ -153,14 +153,14 @@ class ConfigurableComponent {
*
* @return vector
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/446
> > @arpadboda I'll update the commit on merge to what was intended if you
don't have a chance to in the next few minutes.
>
> Done.
I had some issues
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/448#discussion_r237139770
--- Diff: nanofi/src/api/nanofi.cpp ---
@@ -223,13 +226,15 @@ void free_flowfile(flow_file_record *ff) {
return;
}
auto
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r237058367
--- Diff: libminifi/src/processors/ContentHash.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ContentHash.cpp
+ * ContentHash class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r237056704
--- Diff: libminifi/include/processors/HashContent.h ---
@@ -0,0 +1,196 @@
+/**
+ * @file HashContent.h
+ * HashContent class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r237057728
--- Diff: libminifi/src/processors/HashContent.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file HashContent.cpp
+ * HashContent class
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/445#discussion_r237057613
--- Diff: libminifi/src/processors/HashContent.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file HashContent.cpp
+ * HashContent class
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/398
@alopresto no prob. The first iteration had some template metaprogramming
so this would only compile for unit tests, but the virtue of it being removed
is a sign that it's easy to remove
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/398
MINIFICPP-607: Remove host/peer bypass
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/394
@apiri it is not anticipated that OpenSSL be installed for this release.
Will check. Thanks!
---
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/399
MINIFICPP-610: Add description to types
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/397
MINIFICPP-606: Use centos bootstrap config for AWS Linux
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r218532216
--- Diff: LICENSE ---
@@ -1427,3 +1451,183 @@ This product bundles 'bsdiff' which is available
under a "2-clause BSD" license.
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/394#discussion_r218535623
--- Diff: LICENSE ---
@@ -1427,3 +1451,183 @@ This product bundles 'bsdiff' which is available
under a "2-clause BSD" license.
1001 - 1063 of 1063 matches
Mail list logo
