[GitHub] ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127135290 ## File path: ansible/group_vars/all ## @@ -166,10 +166,12 @@ nginx: adminportal: 8

[GitHub] ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127131356 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,6 +71,8 @@ import whisk.ut

[GitHub] ningyougang commented on issue #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
ningyougang commented on issue #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#issuecomment-314975269 @rabbah @markusthoemmes @jeremiaswerner I have modifid the codes as your suggestions. please review again. --

[GitHub] rabbah commented on issue #2463: Correct unable to set apihost issue.

2017-07-12 Thread git
rabbah commented on issue #2463: Correct unable to set apihost issue. URL: https://github.com/apache/incubator-openwhisk/pull/2463#issuecomment-314962689 The cli must support both - there's a test for http as well as https which is the nginx path. ---

[GitHub] lzbj commented on a change in pull request #2463: Correct unable to set apihost issue.

2017-07-12 Thread git
lzbj commented on a change in pull request #2463: Correct unable to set apihost issue. URL: https://github.com/apache/incubator-openwhisk/pull/2463#discussion_r127121659 ## File path: tools/cli/go-whisk-cli/commands/util.go ## @@ -856,6 +856,10 @@ func getURLBase(host str

[GitHub] dubeejw commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
dubeejw commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127118883 ## File path: common/scala/build.gradle ## @@ -21,7 +21,7 @@ dependencies { Review comment: L

[GitHub] DDuTCH commented on issue #35: Invoker is not deployed

2017-07-12 Thread git
DDuTCH commented on issue #35: Invoker is not deployed URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/35#issuecomment-314951098 Ran into the same issue. Posting easy to follow instructions here: Download [invoker.yml](https://raw.githubusercontent.com/DanLa

[GitHub] rabbah commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
rabbah commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127113784 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,6 +71,8 @@ import whisk.utils.r

[GitHub] ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127111207 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,6 +71,8 @@ import whisk.ut

[GitHub] ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127110241 ## File path: ansible/group_vars/all ## @@ -166,10 +166,12 @@ nginx: adminportal: 8

[GitHub] ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127109985 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,6 +71,8 @@ import whisk.ut

[GitHub] houshengbo opened a new pull request #2480: WIP: Implement REST for test cases to replace wsk binary

2017-07-12 Thread git
houshengbo opened a new pull request #2480: WIP: Implement REST for test cases to replace wsk binary URL: https://github.com/apache/incubator-openwhisk/pull/2480 This is an automated message from the Apache Git Service. To

[GitHub] dubeejw commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
dubeejw commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127104928 ## File path: common/scala/build.gradle ## @@ -21,7 +21,7 @@ dependencies { Review comment: F

[GitHub] dubeejw commented on issue #2279: Return Nicer Errors when Non-Integer Values are Passed as Integer Arguments (CLI)

2017-07-12 Thread git
dubeejw commented on issue #2279: Return Nicer Errors when Non-Integer Values are Passed as Integer Arguments (CLI) URL: https://github.com/apache/incubator-openwhisk/issues/2279#issuecomment-314913198 If the problem is with Cobra we should open an issue with them. --

[GitHub] dubeejw commented on issue #2279: Return Nicer Errors when Non-Integer Values are Passed as Integer Arguments (CLI)

2017-07-12 Thread git
dubeejw commented on issue #2279: Return Nicer Errors when Non-Integer Values are Passed as Integer Arguments (CLI) URL: https://github.com/apache/incubator-openwhisk/issues/2279#issuecomment-314913198 If the issue is with Cobra we should open an issue with them.

[GitHub] dubeejw commented on issue #2279: Return Nicer Errors when Non-Integer Values are Passed as Integer Arguments (CLI)

2017-07-12 Thread git
dubeejw commented on issue #2279: Return Nicer Errors when Non-Integer Values are Passed as Integer Arguments (CLI) URL: https://github.com/apache/incubator-openwhisk/issues/2279#issuecomment-314913198 If the problem is with Cobra we should open an issue with them. --

[GitHub] dubeejw commented on issue #2279: Return Nicer Errors when Non-Integer Values are Passed as Integer Arguments (CLI)

2017-07-12 Thread git
dubeejw commented on issue #2279: Return Nicer Errors when Non-Integer Values are Passed as Integer Arguments (CLI) URL: https://github.com/apache/incubator-openwhisk/issues/2279#issuecomment-314658021 I believe we can control the error message if we surround the `strconv.ParseInt` method

[GitHub] dubeejw closed pull request #2479: Ensure Proper Order of CLI Build Tasks

2017-07-12 Thread git
dubeejw closed pull request #2479: Ensure Proper Order of CLI Build Tasks URL: https://github.com/apache/incubator-openwhisk/pull/2479 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] dubeejw opened a new pull request #2479: Ensure Proper Order of CLI Build Tasks

2017-07-12 Thread git
dubeejw opened a new pull request #2479: Ensure Proper Order of CLI Build Tasks URL: https://github.com/apache/incubator-openwhisk/pull/2479 @bpoole16 is experiencing CLI build issues. Attempting to resolve those issues. Thi

[GitHub] glikson commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
glikson commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314906144 I am fine with either option On Jul 12, 2017 12:24 PM, "Matt Rutkowski" wrote: > @bjus

[GitHub] markusthoemmes commented on issue #2476: Stabilize loadbalancer under on/off conditions

2017-07-12 Thread git
markusthoemmes commented on issue #2476: Stabilize loadbalancer under on/off conditions URL: https://github.com/apache/incubator-openwhisk/pull/2476#issuecomment-314905442 PG2 1802 ? This is an automated message from the A

[GitHub] houshengbo closed pull request #288: Update the version of openwhisk client go

2017-07-12 Thread git
houshengbo closed pull request #288: Update the version of openwhisk client go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/288 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dubeejw commented on issue #2326: (Review) Alphabetize

2017-07-12 Thread git
dubeejw commented on issue #2326: (Review) Alphabetize URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-314895174 Please fix conflicts with upstream, @underwoodb-sd. No need for another PG. Will give it a spin after that, so we can merge. Might want to squash first

[GitHub] dubeejw commented on issue #2326: (Review) Alphabetize

2017-07-12 Thread git
dubeejw commented on issue #2326: (Review) Alphabetize URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-314895174 Please fix conflicts with upstream, @underwoodb-sd. No need for another PG. Will give it a spin after that, so we can merge.

[GitHub] dubeejw commented on issue #2326: (Review) Alphabetize

2017-07-12 Thread git
dubeejw commented on issue #2326: (Review) Alphabetize URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-314895174 Please fix conflicts with upstream, @underwoodb-sd. This is an automated message

[GitHub] dubeejw commented on issue #2326: (Review) Alphabetize

2017-07-12 Thread git
dubeejw commented on issue #2326: (Review) Alphabetize URL: https://github.com/apache/incubator-openwhisk/pull/2326#issuecomment-314895174 Please fix conflicts, @underwoodb-sd. This is an automated message from the Apach

[GitHub] dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag

2017-07-12 Thread git
dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag URL: https://github.com/apache/incubator-openwhisk/pull/2334#discussion_r127069401 ## File path: tools/cli/build.gradle ## @@ -38,9 +38,12 @@ task copyCLIShortcut(type: Copy, depen

[GitHub] dubeejw commented on issue #2479: Ensure Proper Order of CLI Build Tasks

2017-07-12 Thread git
dubeejw commented on issue #2479: Ensure Proper Order of CLI Build Tasks URL: https://github.com/apache/incubator-openwhisk/pull/2479#issuecomment-314893273 @bpoole16, please test this out and see if the CLI builds and gets copied properly. ---

[GitHub] dubeejw commented on issue #2479: Ensure Proper Order of CLI Build Tasks

2017-07-12 Thread git
dubeejw commented on issue #2479: Ensure Proper Order of CLI Build Tasks URL: https://github.com/apache/incubator-openwhisk/pull/2479#issuecomment-314893273 bpoole16, please test this out and see if the CLI builds and gets copied properly.

[GitHub] dubeejw opened a new pull request #2479: Ensure Proper Order of CLI Build Tasks

2017-07-12 Thread git
dubeejw opened a new pull request #2479: Ensure Proper Order of CLI Build Tasks URL: https://github.com/apache/incubator-openwhisk/pull/2479 @bpoole16 is experiencing CLI build issues. Attempting to resolve those issues. Thi

[GitHub] dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag

2017-07-12 Thread git
dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag URL: https://github.com/apache/incubator-openwhisk/pull/2334#discussion_r127062722 ## File path: tools/cli/build.gradle ## @@ -38,9 +38,12 @@ task copyCLIShortcut(type: Copy, depen

[GitHub] dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag

2017-07-12 Thread git
dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag URL: https://github.com/apache/incubator-openwhisk/pull/2334#discussion_r127062722 ## File path: tools/cli/build.gradle ## @@ -38,9 +38,12 @@ task copyCLIShortcut(type: Copy, depen

[GitHub] dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag

2017-07-12 Thread git
dubeejw commented on a change in pull request #2334: (Review) Added --last Activation Flag URL: https://github.com/apache/incubator-openwhisk/pull/2334#discussion_r127062722 ## File path: tools/cli/build.gradle ## @@ -38,9 +38,12 @@ task copyCLIShortcut(type: Copy, depen

[GitHub] markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127054156 ## File path: tests/build.gradle ## @@ -57,6 +57,8 @@ dependencies { compile project(':co

[GitHub] markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127051652 ## File path: core/controller/src/main/scala/whisk/core/controller/Activations.scala ## @@ -2

[GitHub] bjustin-ibm closed pull request #5: Update README with badges and source files with ASF license headers.

2017-07-12 Thread git
bjustin-ibm closed pull request #5: Update README with badges and source files with ASF license headers. URL: https://github.com/apache/incubator-openwhisk-playground/pull/5 This is an automated message from the Apache Git

[GitHub] mrutkows commented on issue #5: Update README with badges and source files with ASF license headers.

2017-07-12 Thread git
mrutkows commented on issue #5: Update README with badges and source files with ASF license headers. URL: https://github.com/apache/incubator-openwhisk-playground/pull/5#issuecomment-314873076 @bjustin-ibm same approach as other repos. where it is not yet enabled; that is, comment it out

[GitHub] markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127049509 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +94,5

[GitHub] markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127049207 ## File path: common/scala/build.gradle ## @@ -21,7 +21,7 @@ dependencies { Review commen

[GitHub] berndtj opened a new issue #74: Cannot create alarms trigger

2017-07-12 Thread git
berndtj opened a new issue #74: Cannot create alarms trigger URL: https://github.com/apache/incubator-openwhisk-package-alarms/issues/74 I get an openssl error when trying to create an alarms trigger. I installed the alarms package as follows (this is on a new vagrant openwhisk install):

[GitHub] markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127040698 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +94,5

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127038883 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -19,56 +19,64 @@ pac

[GitHub] markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127038393 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -19,56 +19,6

[GitHub] markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127038196 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -19,56 +19,6

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127030713 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -173,16 +174,2

[GitHub] jonpspri commented on issue #243: Adding provisions for building s390x (Linux on Z) images of openwhisk-apigateway

2017-07-12 Thread git
jonpspri commented on issue #243: Adding provisions for building s390x (Linux on Z) images of openwhisk-apigateway URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/243#issuecomment-314839726 Okay, huge changes over the last 1-2 days: 1. All profiling logic is now

[GitHub] markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127017037 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -173,1

[GitHub] bjustin-ibm closed pull request #2461: Get Action URL from CLI (Review)

2017-07-12 Thread git
bjustin-ibm closed pull request #2461: Get Action URL from CLI (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2461 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] bjustin-ibm closed pull request #2436: API GW V2 updates

2017-07-12 Thread git
bjustin-ibm closed pull request #2436: API GW V2 updates URL: https://github.com/apache/incubator-openwhisk/pull/2436 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] dubeejw commented on a change in pull request #116: Return Expected JSON Response from Web Action

2017-07-12 Thread git
dubeejw commented on a change in pull request #116: Return Expected JSON Response from Web Action URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/116#discussion_r127008795 ## File path: actions/changesWebAction.js ## @@ -79,7 +79,13 @@ function ma

[GitHub] bjustin-ibm closed issue #2318: API management web actions incorrectly assume __ow_user will always be set

2017-07-12 Thread git
bjustin-ibm closed issue #2318: API management web actions incorrectly assume __ow_user will always be set URL: https://github.com/apache/incubator-openwhisk/issues/2318 This is an automated message from the Apache Git Serv

[GitHub] bjustin-ibm closed pull request #2: Add Apache 2 license badge and travis badge.

2017-07-12 Thread git
bjustin-ibm closed pull request #2: Add Apache 2 license badge and travis badge. URL: https://github.com/apache/incubator-openwhisk-podspecs/pull/2 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mrutkows commented on issue #2: Add Apache 2 license badge and travis badge.

2017-07-12 Thread git
mrutkows commented on issue #2: Add Apache 2 license badge and travis badge. URL: https://github.com/apache/incubator-openwhisk-podspecs/pull/2#issuecomment-314825547 @bjustin-ibm correctly commented out line (for now) in a manner GitHub accepts. -

[GitHub] mrutkows commented on a change in pull request #2: Add Apache 2 license badge and travis badge.

2017-07-12 Thread git
mrutkows commented on a change in pull request #2: Add Apache 2 license badge and travis badge. URL: https://github.com/apache/incubator-openwhisk-podspecs/pull/2#discussion_r127003900 ## File path: README.md ## @@ -0,0 +1,6 @@ +# CocoaPods Podspecs for openwhisk-client-s

[GitHub] dubeejw commented on issue #2218: Port Controller from Spray to Akka (Review)

2017-07-12 Thread git
dubeejw commented on issue #2218: Port Controller from Spray to Akka (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2218#issuecomment-314822873 BasicHttpService.scala is a little different since HTTPService is not offered by Akka. Might be able to move `bindAndHandle` cal

[GitHub] mrutkows commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
mrutkows commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314821934 @bjustin-ibm I am willing and have customized the tool to allow leading indents for GoLang; however

[GitHub] mrutkows commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
mrutkows commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314821934 @bjustin-ibm I am willing and have customized the tool to allow leading indents for GoLang; however

[GitHub] mrutkows commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
mrutkows commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314821934 @bjustin-ibm I am willing abd have customized the tool to allow leading indents for GoLang; however

[GitHub] dubeejw commented on issue #2218: Port Controller from Spray to Akka (Review)

2017-07-12 Thread git
dubeejw commented on issue #2218: Port Controller from Spray to Akka (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2218#issuecomment-314821663 @rabbah, please review. All tests are passing. This is an auto

[GitHub] jthomas commented on issue #57: removed the experimental from API Url.

2017-07-12 Thread git
jthomas commented on issue #57: removed the experimental from API Url. URL: https://github.com/apache/incubator-openwhisk-client-js/pull/57#issuecomment-314818200 Hello. Thanks for contributing this, I do have an open ticket to remove the experimental API gateway. https://github.com/apa

[GitHub] DanLavine commented on issue #35: Invoker is not deployed

2017-07-12 Thread git
DanLavine commented on issue #35: Invoker is not deployed URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/35#issuecomment-314807563 hi @Ra1nmaker . This is a problem with the configuration image. There is a [PR](https://github.com/apache/incubator-openwhisk-deploy-kub

[GitHub] DanLavine commented on issue #21: issue about couchdb

2017-07-12 Thread git
DanLavine commented on issue #21: issue about couchdb URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/21#issuecomment-314807327 @zhy989 ?. Glad you have everything deployed. If all your issues have been resolved, could you please close this issue. Thanks! -

[GitHub] bjustin-ibm commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
bjustin-ibm commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314800401 Additionally, it seems that `git blame -w` will also ignore whitespace changes. This makes massi

[GitHub] bjustin-ibm commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
bjustin-ibm commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314800401 Additionally, it seems that `git blame -w` will ignore whitespace changes. This makes massive ch

[GitHub] bjustin-ibm commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
bjustin-ibm commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314797878 > Ignoring white space via w=1 the changes are to the headers primarily. Thanks, this is h

[GitHub] rabbah commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
rabbah commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314786015 FWIW I run scan code as a precommit hook. So it will fail locally before I can push any changes. This

[GitHub] houshengbo opened a new pull request #288: Update the version of openwhisk client go

2017-07-12 Thread git
houshengbo opened a new pull request #288: Update the version of openwhisk client go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/288 This is an automated message from the Apache Git Service. To respond

[GitHub] bjustin-ibm commented on a change in pull request #116: Return Expected JSON Response from Web Action

2017-07-12 Thread git
bjustin-ibm commented on a change in pull request #116: Return Expected JSON Response from Web Action URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/116#discussion_r126955245 ## File path: actions/changesWebAction.js ## @@ -79,7 +79,13 @@ functio

[GitHub] bjustin-ibm commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
bjustin-ibm commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314769188 As stated in other repos, I am all for having coding standards to bring some agreed-upon uniform

[GitHub] mrutkows commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README.

2017-07-12 Thread git
mrutkows commented on issue #1: Update source files with ASF Licenses; Add ASF badge to README. URL: https://github.com/apache/incubator-openwhisk-sample-matos/pull/1#issuecomment-314764673 @rabbah @bjustin-ibm please allow this tab to space conversion as it allows us to use scancode unch

[GitHub] l2fprod opened a new issue #2478: If a web action emits CORS header but does not specify the "web-custom-options" annotation, it results in duplicate headers

2017-07-12 Thread git
l2fprod opened a new issue #2478: If a web action emits CORS header but does not specify the "web-custom-options" annotation, it results in duplicate headers URL: https://github.com/apache/incubator-openwhisk/issues/2478 I have one action that I expose as a web action. The action ret

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126940960 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126939639 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126939429 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126938687 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126938355 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126938010 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126937707 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126937269 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126936930 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126935807 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126935973 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2282: Distributed tracing support #2192 URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r126935807 ## File path: common/scala/src/main/scala/whisk/common/tracing/TraceUtil.scala ## @@ -0,0 +1,14

[GitHub] mdeuser commented on issue #2436: API GW V2 updates

2017-07-12 Thread git
mdeuser commented on issue #2436: API GW V2 updates URL: https://github.com/apache/incubator-openwhisk/pull/2436#issuecomment-314749236 @dubeejw - comment updates made. if there are no other comments would you please approve your review. thanks!

[GitHub] vvraskin opened a new pull request #2477: Move load balancer data into a separate class

2017-07-12 Thread git
vvraskin opened a new pull request #2477: Move load balancer data into a separate class URL: https://github.com/apache/incubator-openwhisk/pull/2477 Hello, this PR contains a companion commit that separates the the load balancer data from its main logic. This change will si

[GitHub] Ra1nmaker opened a new issue #35: Invoker is not deployed

2017-07-12 Thread git
Ra1nmaker opened a new issue #35: Invoker is not deployed URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/35 Hi, I want to deploy OpenWhisk on Kubernetes (v1.5.6) by using this code. I found that when I used default setting (danlavine's whisk_config:v1.5.6 image)

[GitHub] ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r126905802 ## File path: ansible/group_vars/all ## @@ -166,10 +166,12 @@ nginx: adminportal: 8

[GitHub] markusthoemmes opened a new pull request #2476: Stabilize loadbalancer under on/off conditions

2017-07-12 Thread git
markusthoemmes opened a new pull request #2476: Stabilize loadbalancer under on/off conditions URL: https://github.com/apache/incubator-openwhisk/pull/2476 If invokers are coming online/offline frequently today, the list of available invokers changes frequently which causes the hash-based

[GitHub] rabbah commented on issue #2415: Add PHP 7.1 as a kind

2017-07-12 Thread git
rabbah commented on issue #2415: Add PHP 7.1 as a kind URL: https://github.com/apache/incubator-openwhisk/pull/2415#issuecomment-314716101 The built in packages are convenient - less zip files for the initial ramp up. But it creates a maintenance issue: when do you pick up updates to the

[GitHub] rabbah commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
rabbah commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r126912975 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,6 +71,8 @@ import whisk.utils.r

[GitHub] rabbah commented on issue #2475: Fix error string duplicate issue.

2017-07-12 Thread git
rabbah commented on issue #2475: Fix error string duplicate issue. URL: https://github.com/apache/incubator-openwhisk/pull/2475#issuecomment-314714806 I'm not sure I follow. Can you show me an example of how to save one of three message identifiers? @dubeejw I assume it's possible

[GitHub] markusthoemmes commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r126906122 ## File path: ansible/group_vars/all ## @@ -166,10 +166,12 @@ nginx: adminportal

[GitHub] ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r126905802 ## File path: ansible/group_vars/all ## @@ -166,10 +166,12 @@ nginx: adminportal: 8

[GitHub] daisy-ycguo closed pull request #271: Bump go to 1.8 and gradle to 3.5 as Openwhisk core repo.

2017-07-12 Thread git
daisy-ycguo closed pull request #271: Bump go to 1.8 and gradle to 3.5 as Openwhisk core repo. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/271 This is an automated message from the Apache Git Service.

[GitHub] lzbj commented on issue #2113: CLI error messages are replicated three times

2017-07-12 Thread git
lzbj commented on issue #2113: CLI error messages are replicated three times URL: https://github.com/apache/incubator-openwhisk/issues/2113#issuecomment-314706292 thanks for your clarification, I submitted one pr https://github.com/apache/incubator-openwhisk/pull/2475, please help review

[GitHub] lzbj opened a new pull request #2475: Fix error string duplicate issue.

2017-07-12 Thread git
lzbj opened a new pull request #2475: Fix error string duplicate issue. URL: https://github.com/apache/incubator-openwhisk/pull/2475 Try to fix the error message duplicate issue, make some change to the MakeWskErrorFromWskError function which could save one copy. -

[GitHub] ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx

2017-07-12 Thread git
ningyougang commented on a change in pull request #2427: Support client certificate on cli and nginx URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r126899281 ## File path: tests/src/test/scala/common/Wsk.scala ## @@ -71,6 +71,8 @@ import whisk.ut

[GitHub] mabels opened a new pull request #57: removed the experimental from API Url.

2017-07-12 Thread git
mabels opened a new pull request #57: removed the experimental from API Url. URL: https://github.com/apache/incubator-openwhisk-client-js/pull/57 During my tests with the serverless framework i discovered that an experimental marked url. was not working anymore. So i looked at the wsk

[GitHub] markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations

2017-07-12 Thread git
markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations URL: https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r126884861 ## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStoreProvider.scala

[GitHub] darrenmothersele commented on issue #2415: Add PHP 7.1 as a kind

2017-07-12 Thread git
darrenmothersele commented on issue #2415: Add PHP 7.1 as a kind URL: https://github.com/apache/incubator-openwhisk/pull/2415#issuecomment-314673077 Re: extensions, this set would be good: - mysqli - xml - gd - openssl - json - curl - mbstring - PDO - pdo_mysq

  1   2   >