[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225242#comment-17225242 ] Richard Antal commented on PHOENIX-6091: I have created a [pull request|https:/

[GitHub] [phoenix] virajjasani opened a new pull request #952: PHOENIX-6086 : Take snapshot of all SYSTEM tables before attempting to upgrade them

virajjasani opened a new pull request #952: URL: https://github.com/apache/phoenix/pull/952 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [phoenix] richardantal opened a new pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

richardantal opened a new pull request #953: URL: https://github.com/apache/phoenix/pull/953 …p gives version as 4.15.x This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Commented] (PHOENIX-6086) Take a snapshot of all SYSTEM tables before attempting to upgrade them

[ https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225360#comment-17225360 ] ASF GitHub Bot commented on PHOENIX-6086: - virajjasani opened a new pull reques

[GitHub] [phoenix] ChinmaySKulkarni commented on pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

ChinmaySKulkarni commented on pull request #949: URL: https://github.com/apache/phoenix/pull/949#issuecomment-720785864 Thanks for your reviews @virajjasani @gjacoby126 I have addressed all your review comments. Can I get a +1? -

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #944: PHOENIX-6127 Prevent unnecessary HBase admin API calls in ViewUtil.ge…

gjacoby126 commented on a change in pull request #944: URL: https://github.com/apache/phoenix/pull/944#discussion_r516342109 ## File path: phoenix-core/src/main/java/org/apache/phoenix/util/ServerUtil.java ## @@ -225,6 +227,21 @@ public static Table getHTableForCoprocessorScan

[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225361#comment-17225361 ] ASF GitHub Bot commented on PHOENIX-6091: - richardantal opened a new pull reque

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225363#comment-17225363 ] ASF GitHub Bot commented on PHOENIX-6032: - ChinmaySKulkarni commented on pull r

[jira] [Commented] (PHOENIX-6127) Prevent unnecessary HBase admin API calls in ViewUtil.getSystemTableForChildLinks() and act lazily instead

[ https://issues.apache.org/jira/browse/PHOENIX-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225364#comment-17225364 ] ASF GitHub Bot commented on PHOENIX-6127: - gjacoby126 commented on a change in

[jira] [Commented] (PHOENIX-5895) Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

[ https://issues.apache.org/jira/browse/PHOENIX-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225371#comment-17225371 ] ASF GitHub Bot commented on PHOENIX-5895: - sandeepvinayak commented on pull req

[GitHub] [phoenix] sandeepvinayak opened a new pull request #951: PHOENIX-5895: Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

sandeepvinayak opened a new pull request #951: URL: https://github.com/apache/phoenix/pull/951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [phoenix] sandeepvinayak commented on pull request #951: PHOENIX-5895: Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

sandeepvinayak commented on pull request #951: URL: https://github.com/apache/phoenix/pull/951#issuecomment-720270639 @gjacoby126 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [phoenix] richardantal commented on pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

richardantal commented on pull request #953: URL: https://github.com/apache/phoenix/pull/953#issuecomment-720985224 Thanks @gjacoby126 for the review. I wrote a test but we will have to update this version after releases. I also checked the failing tests and the were successful locall

[GitHub] [phoenix] gjacoby126 commented on pull request #916: PHOENIX-6171 Child views should not be allowed to override the parent view PHOENIX_TTL attribute.

gjacoby126 commented on pull request #916: URL: https://github.com/apache/phoenix/pull/916#issuecomment-720788103 JIRA appears to be closed as fixed. Closing PR. This is an automated message from the Apache Git Service. To r

[jira] [Commented] (PHOENIX-5895) Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

[ https://issues.apache.org/jira/browse/PHOENIX-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225372#comment-17225372 ] ASF GitHub Bot commented on PHOENIX-5895: - sandeepvinayak opened a new pull req

[jira] [Commented] (PHOENIX-6171) Child views should not be allowed to override the parent view PHOENIX_TTL attribute.

[ https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225377#comment-17225377 ] ASF GitHub Bot commented on PHOENIX-6171: - gjacoby126 commented on pull request

[GitHub] [phoenix] stoty commented on pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

stoty commented on pull request #953: URL: https://github.com/apache/phoenix/pull/953#issuecomment-720680092 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Doc

[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225374#comment-17225374 ] ASF GitHub Bot commented on PHOENIX-6091: - richardantal commented on pull reque

[GitHub] [phoenix] stoty commented on pull request #929: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

stoty commented on pull request #929: URL: https://github.com/apache/phoenix/pull/929#issuecomment-720631843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225384#comment-17225384 ] ASF GitHub Bot commented on PHOENIX-6083: - stoty commented on pull request #929

[GitHub] [phoenix] richardantal commented on pull request #944: PHOENIX-6127 Prevent unnecessary HBase admin API calls in ViewUtil.ge…

richardantal commented on pull request #944: URL: https://github.com/apache/phoenix/pull/944#issuecomment-720999062 I ran the tests locally, all of them were successful, but let's wait the test result on the new version. Thi

[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225380#comment-17225380 ] ASF GitHub Bot commented on PHOENIX-6091: - stoty commented on pull request #953

[jira] [Commented] (PHOENIX-6127) Prevent unnecessary HBase admin API calls in ViewUtil.getSystemTableForChildLinks() and act lazily instead

[ https://issues.apache.org/jira/browse/PHOENIX-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225388#comment-17225388 ] ASF GitHub Bot commented on PHOENIX-6127: - richardantal commented on pull reque

[GitHub] [phoenix] richardantal commented on a change in pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

richardantal commented on a change in pull request #953: URL: https://github.com/apache/phoenix/pull/953#discussion_r516604261 ## File path: phoenix-core/src/test/java/org/apache/phoenix/schema/MetaDataClientTest.java ## @@ -83,4 +85,13 @@ public void testHandleCreateTableMuta

[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225393#comment-17225393 ] ASF GitHub Bot commented on PHOENIX-6091: - richardantal commented on a change i

[GitHub] [phoenix] stoty commented on pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

stoty commented on pull request #949: URL: https://github.com/apache/phoenix/pull/949#issuecomment-720826602 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

ChinmaySKulkarni commented on a change in pull request #949: URL: https://github.com/apache/phoenix/pull/949#discussion_r516230051 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogRollbackEnabledIT.java ## @@ -0,0 +1,273 @@ +/* + * Licensed to the

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225395#comment-17225395 ] ASF GitHub Bot commented on PHOENIX-6032: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225394#comment-17225394 ] ASF GitHub Bot commented on PHOENIX-6032: - stoty commented on pull request #949

[GitHub] [phoenix] virajjasani commented on a change in pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

virajjasani commented on a change in pull request #953: URL: https://github.com/apache/phoenix/pull/953#discussion_r516581750 ## File path: phoenix-core/src/test/java/org/apache/phoenix/schema/MetaDataClientTest.java ## @@ -83,4 +85,13 @@ public void testHandleCreateTableMutat

[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225402#comment-17225402 ] ASF GitHub Bot commented on PHOENIX-6091: - virajjasani commented on a change in

[jira] [Commented] (PHOENIX-5895) Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

[ https://issues.apache.org/jira/browse/PHOENIX-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225407#comment-17225407 ] ASF GitHub Bot commented on PHOENIX-5895: - sandeepvinayak edited a comment on p

[GitHub] [phoenix] sandeepvinayak edited a comment on pull request #951: PHOENIX-5895: Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

sandeepvinayak edited a comment on pull request #951: URL: https://github.com/apache/phoenix/pull/951#issuecomment-720270639 @gjacoby126 can you please review this? This is an automated message from the Apache Git Service. To

[GitHub] [phoenix] virajjasani commented on pull request #952: PHOENIX-6086 : Take snapshot of all SYSTEM tables before attempting to upgrade them

virajjasani commented on pull request #952: URL: https://github.com/apache/phoenix/pull/952#issuecomment-720521681 spotbug warning `passes a nonconstant String to an execute or addBatch method on an SQL statement` almost seem quite difficult to avoid (also not related to main code changes,

[GitHub] [phoenix] gjacoby126 closed pull request #916: PHOENIX-6171 Child views should not be allowed to override the parent view PHOENIX_TTL attribute.

gjacoby126 closed pull request #916: URL: https://github.com/apache/phoenix/pull/916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-6171) Child views should not be allowed to override the parent view PHOENIX_TTL attribute.

[ https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225421#comment-17225421 ] ASF GitHub Bot commented on PHOENIX-6171: - gjacoby126 closed pull request #916:

[jira] [Commented] (PHOENIX-6086) Take a snapshot of all SYSTEM tables before attempting to upgrade them

[ https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225418#comment-17225418 ] ASF GitHub Bot commented on PHOENIX-6086: - virajjasani commented on pull reques

[GitHub] [phoenix] richardantal commented on pull request #929: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

richardantal commented on pull request #929: URL: https://github.com/apache/phoenix/pull/929#issuecomment-720605438 Sure, thank you @ChinmaySKulkarni I have squashed the commits into one and back ported this change to [4.x.](https://github.com/apache/phoenix/pull/954/commits)

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #951: PHOENIX-5895: Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

gjacoby126 commented on a change in pull request #951: URL: https://github.com/apache/phoenix/pull/951#discussion_r516334881 ## File path: phoenix-core/src/it/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilterIT.java ## @@ -134,11 +135,16 @@ public void testSystem

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225426#comment-17225426 ] ASF GitHub Bot commented on PHOENIX-6083: - richardantal commented on pull reque

[GitHub] [phoenix] richardantal commented on a change in pull request #944: PHOENIX-6127 Prevent unnecessary HBase admin API calls in ViewUtil.ge…

richardantal commented on a change in pull request #944: URL: https://github.com/apache/phoenix/pull/944#discussion_r516520567 ## File path: phoenix-core/src/main/java/org/apache/phoenix/util/ServerUtil.java ## @@ -225,6 +227,21 @@ public static Table getHTableForCoprocessorSca

[jira] [Commented] (PHOENIX-6127) Prevent unnecessary HBase admin API calls in ViewUtil.getSystemTableForChildLinks() and act lazily instead

[ https://issues.apache.org/jira/browse/PHOENIX-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225428#comment-17225428 ] ASF GitHub Bot commented on PHOENIX-6127: - richardantal commented on a change i

[jira] [Commented] (PHOENIX-5895) Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

[ https://issues.apache.org/jira/browse/PHOENIX-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225430#comment-17225430 ] ASF GitHub Bot commented on PHOENIX-5895: - gjacoby126 commented on a change in

[GitHub] [phoenix] stoty commented on pull request #951: PHOENIX-5895: Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

stoty commented on pull request #951: URL: https://github.com/apache/phoenix/pull/951#issuecomment-720373974 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s | Doc

[GitHub] [phoenix] richardantal opened a new pull request #954: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

richardantal opened a new pull request #954: URL: https://github.com/apache/phoenix/pull/954 …ow key This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [phoenix] stoty commented on pull request #944: PHOENIX-6127 Prevent unnecessary HBase admin API calls in ViewUtil.ge…

stoty commented on pull request #944: URL: https://github.com/apache/phoenix/pull/944#issuecomment-721027327 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 17s | Doc

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225438#comment-17225438 ] ASF GitHub Bot commented on PHOENIX-6083: - richardantal opened a new pull reque

[jira] [Commented] (PHOENIX-5895) Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

[ https://issues.apache.org/jira/browse/PHOENIX-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225437#comment-17225437 ] ASF GitHub Bot commented on PHOENIX-5895: - stoty commented on pull request #951

[jira] [Commented] (PHOENIX-6127) Prevent unnecessary HBase admin API calls in ViewUtil.getSystemTableForChildLinks() and act lazily instead

[ https://issues.apache.org/jira/browse/PHOENIX-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225441#comment-17225441 ] ASF GitHub Bot commented on PHOENIX-6127: - stoty commented on pull request #944

[GitHub] [phoenix] gjacoby126 commented on pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

gjacoby126 commented on pull request #953: URL: https://github.com/apache/phoenix/pull/953#issuecomment-720753361 Change itself looks good, @richardantal , but could we please have a simple test? This is an automated message

[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225443#comment-17225443 ] ASF GitHub Bot commented on PHOENIX-6091: - gjacoby126 commented on pull request

[GitHub] [phoenix] virajjasani commented on a change in pull request #951: PHOENIX-5895: Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

virajjasani commented on a change in pull request #951: URL: https://github.com/apache/phoenix/pull/951#discussion_r515785773 ## File path: phoenix-core/src/it/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilterIT.java ## @@ -134,11 +135,16 @@ public void testSyste

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

gjacoby126 commented on a change in pull request #949: URL: https://github.com/apache/phoenix/pull/949#discussion_r516276781 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogRollbackEnabledIT.java ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apach

[jira] [Commented] (PHOENIX-5895) Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

[ https://issues.apache.org/jira/browse/PHOENIX-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225445#comment-17225445 ] ASF GitHub Bot commented on PHOENIX-5895: - virajjasani commented on a change in

[jira] [Commented] (PHOENIX-6086) Take a snapshot of all SYSTEM tables before attempting to upgrade them

[ https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225447#comment-17225447 ] ASF GitHub Bot commented on PHOENIX-6086: - stoty commented on pull request #952

[GitHub] [phoenix] stoty commented on pull request #952: PHOENIX-6086 : Take snapshot of all SYSTEM tables before attempting to upgrade them

stoty commented on pull request #952: URL: https://github.com/apache/phoenix/pull/952#issuecomment-720378075 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Doc

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225446#comment-17225446 ] ASF GitHub Bot commented on PHOENIX-6032: - gjacoby126 commented on a change in

[GitHub] [phoenix] virajjasani commented on pull request #952: PHOENIX-6086 : Take snapshot of all SYSTEM tables before attempting to upgrade them

virajjasani commented on pull request #952: URL: https://github.com/apache/phoenix/pull/952#issuecomment-721174388 `NamespaceEnabledStatsCollectorIT` seems flaky, the failure is not relevant to the changes. This is an automa

[jira] [Commented] (PHOENIX-6086) Take a snapshot of all SYSTEM tables before attempting to upgrade them

[ https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225471#comment-17225471 ] ASF GitHub Bot commented on PHOENIX-6086: - virajjasani commented on pull reques

[jira] [Commented] (PHOENIX-5669) Remove hack for PHOENIX-3121

[ https://issues.apache.org/jira/browse/PHOENIX-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225478#comment-17225478 ] Hadoop QA commented on PHOENIX-5669: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (PHOENIX-5669) Remove hack for PHOENIX-3121

[ https://issues.apache.org/jira/browse/PHOENIX-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225492#comment-17225492 ] Hadoop QA commented on PHOENIX-5669: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (PHOENIX-5669) Remove hack for PHOENIX-3121

[ https://issues.apache.org/jira/browse/PHOENIX-5669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225496#comment-17225496 ] Hadoop QA commented on PHOENIX-5669: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225529#comment-17225529 ] ASF GitHub Bot commented on PHOENIX-6083: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #929: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

virajjasani commented on a change in pull request #929: URL: https://github.com/apache/phoenix/pull/929#discussion_r516787757 ## File path: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ## @@ -1685,12 +1685,16 @@ public MutationState createIndex(Crea

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225547#comment-17225547 ] ASF GitHub Bot commented on PHOENIX-6083: - richardantal commented on a change i

[GitHub] [phoenix] richardantal commented on a change in pull request #929: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

richardantal commented on a change in pull request #929: URL: https://github.com/apache/phoenix/pull/929#discussion_r516811982 ## File path: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ## @@ -1685,12 +1685,16 @@ public MutationState createIndex(Cre

[GitHub] [phoenix] richardantal commented on a change in pull request #929: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

richardantal commented on a change in pull request #929: URL: https://github.com/apache/phoenix/pull/929#discussion_r516815108 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java ## @@ -280,6 +282,64 @@ public void testCoprocsOnGlobalNonMTI

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225550#comment-17225550 ] ASF GitHub Bot commented on PHOENIX-6083: - richardantal commented on a change i

[GitHub] [phoenix] virajjasani commented on a change in pull request #929: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

virajjasani commented on a change in pull request #929: URL: https://github.com/apache/phoenix/pull/929#discussion_r516840959 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java ## @@ -280,6 +282,64 @@ public void testCoprocsOnGlobalNonMTIm

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225575#comment-17225575 ] ASF GitHub Bot commented on PHOENIX-6083: - virajjasani commented on a change in

[GitHub] [phoenix] richardantal commented on a change in pull request #929: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

richardantal commented on a change in pull request #929: URL: https://github.com/apache/phoenix/pull/929#discussion_r516853365 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java ## @@ -280,6 +282,64 @@ public void testCoprocsOnGlobalNonMTI

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225578#comment-17225578 ] ASF GitHub Bot commented on PHOENIX-6083: - richardantal commented on a change i

[GitHub] [phoenix] stoty commented on pull request #929: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

stoty commented on pull request #929: URL: https://github.com/apache/phoenix/pull/929#issuecomment-721317223 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Doc

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225616#comment-17225616 ] ASF GitHub Bot commented on PHOENIX-6083: - stoty commented on pull request #929

[GitHub] [phoenix] stoty commented on pull request #953: PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

stoty commented on pull request #953: URL: https://github.com/apache/phoenix/pull/953#issuecomment-721359001 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Doc

[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225654#comment-17225654 ] ASF GitHub Bot commented on PHOENIX-6091: - stoty commented on pull request #953

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225659#comment-17225659 ] ASF GitHub Bot commented on PHOENIX-6083: - stoty commented on pull request #954

[GitHub] [phoenix] stoty commented on pull request #954: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

stoty commented on pull request #954: URL: https://github.com/apache/phoenix/pull/954#issuecomment-721360920 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 58s | Doc

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225684#comment-17225684 ] ASF GitHub Bot commented on PHOENIX-6083: - stoty commented on pull request #929

[GitHub] [phoenix] stoty commented on pull request #929: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

stoty commented on pull request #929: URL: https://github.com/apache/phoenix/pull/929#issuecomment-721378786 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Doc

[GitHub] [phoenix] yanxinyi commented on a change in pull request #952: PHOENIX-6086 : Take snapshot of all SYSTEM tables before attempting to upgrade them

yanxinyi commented on a change in pull request #952: URL: https://github.com/apache/phoenix/pull/952#discussion_r517022108 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -3821,17 +3823,37 @@ public void upgradeSystemTab

[jira] [Commented] (PHOENIX-6086) Take a snapshot of all SYSTEM tables before attempting to upgrade them

[ https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225731#comment-17225731 ] ASF GitHub Bot commented on PHOENIX-6086: - yanxinyi commented on a change in pu

[jira] [Commented] (PHOENIX-5281) 95%+ of request time spent in Phoenix driver

[ https://issues.apache.org/jira/browse/PHOENIX-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225738#comment-17225738 ] Elias Adhanom commented on PHOENIX-5281: We are experiencing similar issue. Any

[GitHub] [phoenix] stoty commented on pull request #954: PHOENIX-6083 View index creation does a checkAndPut on an incorrect r…

stoty commented on pull request #954: URL: https://github.com/apache/phoenix/pull/954#issuecomment-721442556 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Doc

[jira] [Commented] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

[ https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225743#comment-17225743 ] ASF GitHub Bot commented on PHOENIX-6083: - stoty commented on pull request #954

[GitHub] [phoenix] ChinmaySKulkarni merged pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

ChinmaySKulkarni merged pull request #949: URL: https://github.com/apache/phoenix/pull/949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225781#comment-17225781 ] ASF GitHub Bot commented on PHOENIX-6032: - ChinmaySKulkarni merged pull request

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225800#comment-17225800 ] Chinmay Kulkarni commented on PHOENIX-6032: --- Committed to master and 4.x. Tha

[jira] [Commented] (PHOENIX-6209) Remove unused estimateParallelLevel()

[ https://issues.apache.org/jira/browse/PHOENIX-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225832#comment-17225832 ] Xinyi Yan commented on PHOENIX-6209: can you submit the patch and run the Hadoop QA

[GitHub] [phoenix] sandeepvinayak commented on a change in pull request #951: PHOENIX-5895: Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

sandeepvinayak commented on a change in pull request #951: URL: https://github.com/apache/phoenix/pull/951#discussion_r517140962 ## File path: phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java ## @@ -35,30 +36,30 @@ * be copied. This

[jira] [Commented] (PHOENIX-5895) Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

[ https://issues.apache.org/jira/browse/PHOENIX-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225906#comment-17225906 ] ASF GitHub Bot commented on PHOENIX-5895: - sandeepvinayak commented on a change

[GitHub] [phoenix] stoty commented on pull request #952: PHOENIX-6086 : Take snapshot of all SYSTEM tables before attempting to upgrade them

stoty commented on pull request #952: URL: https://github.com/apache/phoenix/pull/952#issuecomment-721562503 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Doc

[jira] [Commented] (PHOENIX-6086) Take a snapshot of all SYSTEM tables before attempting to upgrade them

[ https://issues.apache.org/jira/browse/PHOENIX-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225907#comment-17225907 ] ASF GitHub Bot commented on PHOENIX-6086: - stoty commented on pull request #952