[jira] [Commented] (PHOENIX-6342) RoundRobinResultIterator doesn't close itself when result size = fetchsize-1

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272642#comment-17272642 ] ASF GitHub Bot commented on PHOENIX-6342: - virajjasani commented on a change in pull request

[GitHub] [phoenix] virajjasani commented on a change in pull request #1114: PHOENIX-6342 RoundRobinResultIterator doesn't close itself when resul…

2021-01-26 Thread GitBox
virajjasani commented on a change in pull request #1114: URL: https://github.com/apache/phoenix/pull/1114#discussion_r565095342 ## File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/RoundRobinResultIterator.java ## @@ -114,6 +114,7 @@ public Tuple next() throws

[jira] [Commented] (PHOENIX-6342) RoundRobinResultIterator doesn't close itself when result size = fetchsize-1

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272638#comment-17272638 ] ASF GitHub Bot commented on PHOENIX-6342: - virajjasani commented on a change in pull request

[GitHub] [phoenix] virajjasani commented on a change in pull request #1114: PHOENIX-6342 RoundRobinResultIterator doesn't close itself when resul…

2021-01-26 Thread GitBox
virajjasani commented on a change in pull request #1114: URL: https://github.com/apache/phoenix/pull/1114#discussion_r565092144 ## File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/RoundRobinResultIterator.java ## @@ -114,6 +114,7 @@ public Tuple next() throws

[jira] [Commented] (PHOENIX-6340) Infinitely looping ResultSet.next()

2021-01-26 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272632#comment-17272632 ] Istvan Toth commented on PHOENIX-6340: -- I've lowered the priority, as only the PHOENIX-6342 part

[jira] [Commented] (PHOENIX-6340) Infinitely looping ResultSet.next()

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272622#comment-17272622 ] ASF GitHub Bot commented on PHOENIX-6340: - stoty commented on pull request #1112: URL:

[GitHub] [phoenix] stoty commented on pull request #1112: PHOENIX-6340 Infinitely looping ResultSet.next()

2021-01-26 Thread GitBox
stoty commented on pull request #1112: URL: https://github.com/apache/phoenix/pull/1112#issuecomment-768083565 Closing this. I am still not convinced that the threshold logic is correct, but that's only a performance issue. I've opened PHOENIX-6342 for a focused fix on the close()

[jira] [Commented] (PHOENIX-6342) RoundRobinResultIterator doesn't close itself when result size = fetchsize-1

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272619#comment-17272619 ] ASF GitHub Bot commented on PHOENIX-6342: - stoty opened a new pull request #1114: URL:

[GitHub] [phoenix] stoty opened a new pull request #1114: PHOENIX-6342 RoundRobinResultIterator doesn't close itself when resul…

2021-01-26 Thread GitBox
stoty opened a new pull request #1114: URL: https://github.com/apache/phoenix/pull/1114 …t size = fetchsize-1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (PHOENIX-6336) Scan filter is incorrectly set to null for index rebuilds

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272582#comment-17272582 ] ASF GitHub Bot commented on PHOENIX-6336: - abhishek-chouhan opened a new pull request #1113:

[GitHub] [phoenix] abhishek-chouhan opened a new pull request #1113: PHOENIX-6336 Scan filter is incorrectly set to null for index rebuilds

2021-01-26 Thread GitBox
abhishek-chouhan opened a new pull request #1113: URL: https://github.com/apache/phoenix/pull/1113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (PHOENIX-6118) Multi Tenant Workloads using PHERF

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272517#comment-17272517 ] ASF GitHub Bot commented on PHOENIX-6118: - yanxinyi commented on pull request #878: URL:

[GitHub] [phoenix] yanxinyi commented on pull request #878: PHOENIX-6118: Multi Tenant Workloads using PHERF

2021-01-26 Thread GitBox
yanxinyi commented on pull request #878: URL: https://github.com/apache/phoenix/pull/878#issuecomment-767962186 @jpisaac can you handle the above comments and solve the conflicts? This is an automated message from the Apache

[jira] [Commented] (PHOENIX-6339) Older client using aggregate queries shows incorrect results.

2021-01-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272511#comment-17272511 ] Hadoop QA commented on PHOENIX-6339: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (PHOENIX-6339) Older client using aggregate queries shows incorrect results.

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272454#comment-17272454 ] ASF GitHub Bot commented on PHOENIX-6339: - kadirozde commented on a change in pull request

[GitHub] [phoenix] kadirozde commented on a change in pull request #1111: PHOENIX-6339 Older client using aggregate queries shows incorrect res…

2021-01-26 Thread GitBox
kadirozde commented on a change in pull request #: URL: https://github.com/apache/phoenix/pull/#discussion_r564860842 ## File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java ## @@ -1304,21 +1304,20 @@ public static PagedFilter

[jira] [Commented] (PHOENIX-6339) Older client using aggregate queries shows incorrect results.

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272427#comment-17272427 ] ASF GitHub Bot commented on PHOENIX-6339: - jpisaac commented on a change in pull request #:

[GitHub] [phoenix] jpisaac commented on a change in pull request #1111: PHOENIX-6339 Older client using aggregate queries shows incorrect res…

2021-01-26 Thread GitBox
jpisaac commented on a change in pull request #: URL: https://github.com/apache/phoenix/pull/#discussion_r564843145 ## File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java ## @@ -1304,21 +1304,20 @@ public static PagedFilter

[jira] [Commented] (PHOENIX-6340) Infinitely looping ResultSet.next()

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272370#comment-17272370 ] ASF GitHub Bot commented on PHOENIX-6340: - stoty commented on a change in pull request #1112:

[GitHub] [phoenix] stoty commented on a change in pull request #1112: PHOENIX-6340 Infinitely looping ResultSet.next()

2021-01-26 Thread GitBox
stoty commented on a change in pull request #1112: URL: https://github.com/apache/phoenix/pull/1112#discussion_r564791378 ## File path: phoenix-core/src/main/java/org/apache/phoenix/iterate/RoundRobinResultIterator.java ## @@ -114,12 +114,15 @@ public Tuple next() throws

[jira] [Commented] (PHOENIX-6340) Infinitely looping ResultSet.next()

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272367#comment-17272367 ] ASF GitHub Bot commented on PHOENIX-6340: - stoty commented on pull request #1112: URL:

[GitHub] [phoenix] stoty commented on pull request #1112: PHOENIX-6340 Infinitely looping ResultSet.next()

2021-01-26 Thread GitBox
stoty commented on pull request #1112: URL: https://github.com/apache/phoenix/pull/1112#issuecomment-767788988 There are two issues here. The one that I am fixing is that RoundRobinResultIterator doesn't close itself when every iterator 's last element is the last cached one, and

[jira] [Commented] (PHOENIX-6340) Infinitely looping ResultSet.next()

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272361#comment-17272361 ] ASF GitHub Bot commented on PHOENIX-6340: - dbwong commented on pull request #1112: URL:

[GitHub] [phoenix] dbwong commented on pull request #1112: PHOENIX-6340 Infinitely looping ResultSet.next()

2021-01-26 Thread GitBox
dbwong commented on pull request #1112: URL: https://github.com/apache/phoenix/pull/1112#issuecomment-767778944 This should be integration testable; however, I saw in the JIRA that you were having issues recreating this. What area according to was giving you issues making an IT for this?

[jira] [Commented] (PHOENIX-6341) Enable running IT tests from PHERF module during builds and patch checkins

2021-01-26 Thread Jacob Isaac (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272338#comment-17272338 ] Jacob Isaac commented on PHOENIX-6341: -- [~yanxinyi] [~ChinmayKulkarni] > Enable running IT tests

[jira] [Commented] (PHOENIX-6340) Infinitely looping ResultSet.next()

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272249#comment-17272249 ] ASF GitHub Bot commented on PHOENIX-6340: - stoty opened a new pull request #1112: URL:

[GitHub] [phoenix] stoty opened a new pull request #1112: PHOENIX-6340 Infinitely looping ResultSet.next()

2021-01-26 Thread GitBox
stoty opened a new pull request #1112: URL: https://github.com/apache/phoenix/pull/1112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272140#comment-17272140 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on pull request #1097: URL:

[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-26 Thread GitBox
stoty commented on pull request #1097: URL: https://github.com/apache/phoenix/pull/1097#issuecomment-767597455 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s |

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272085#comment-17272085 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on pull request #1096: URL:

[GitHub] [phoenix] stoty commented on pull request #1096: PHOENIX-5296 : Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-26 Thread GitBox
stoty commented on pull request #1096: URL: https://github.com/apache/phoenix/pull/1096#issuecomment-767522020 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s |

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272029#comment-17272029 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on pull request #1097: URL:

[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks

2021-01-26 Thread GitBox
stoty commented on pull request #1097: URL: https://github.com/apache/phoenix/pull/1097#issuecomment-767464453 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s |

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272023#comment-17272023 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on pull request #1096: URL:

[GitHub] [phoenix] stoty commented on pull request #1096: PHOENIX-5296 : refCount leak checks

2021-01-26 Thread GitBox
stoty commented on pull request #1096: URL: https://github.com/apache/phoenix/pull/1096#issuecomment-767449453 One more nit: Please update the commit message to match the JIRA description. This is an automated message from

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272010#comment-17272010 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on pull request #1096: URL:

[GitHub] [phoenix] stoty commented on pull request #1096: PHOENIX-5296 : refCount leak checks

2021-01-26 Thread GitBox
stoty commented on pull request #1096: URL: https://github.com/apache/phoenix/pull/1096#issuecomment-767428915 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s |

[jira] [Commented] (PHOENIX-6339) Older client using aggregate queries shows incorrect results.

2021-01-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272000#comment-17272000 ] ASF GitHub Bot commented on PHOENIX-6339: - stoty commented on pull request #: URL:

[GitHub] [phoenix] stoty commented on pull request #1111: PHOENIX-6339 Older client using aggregate queries shows incorrect res…

2021-01-26 Thread GitBox
stoty commented on pull request #: URL: https://github.com/apache/phoenix/pull/#issuecomment-767414314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |