Re: [PR] [FEATURE REQUEST #32] On-Premises S3 / S3 Compatible... [polaris]

2025-04-05 Thread via GitHub
flyrain commented on PR #389: URL: https://github.com/apache/polaris/pull/389#issuecomment-2781233548 > There are unaddressed concerns with this PR (as commented on specific changes). I believe they need to be resolved before merging. Agreed. I meant merge it after comments are addres

Re: [PR] main: Update docker.io/jaegertracing/all-in-one Docker tag to v1.68.0 [polaris]

2025-04-05 Thread via GitHub
jbonofre merged PR #1317: URL: https://github.com/apache/polaris/pull/1317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.ap

Re: [PR] [Spec] Add 'inherited' and 'namespace-path' Fields to GetApplicablePolicies API Response [polaris]

2025-04-05 Thread via GitHub
HonahX commented on code in PR #1277: URL: https://github.com/apache/polaris/pull/1277#discussion_r2030005944 ## spec/generated/bundled-polaris-catalog-service.yaml: ## @@ -4005,6 +4005,26 @@ components: properties: target: $ref: '#/components/schemas/

Re: [PR] [Spec] Add 'inherited' and 'namespace-path' Fields to GetApplicablePolicies API Response [polaris]

2025-04-05 Thread via GitHub
HonahX commented on code in PR #1277: URL: https://github.com/apache/polaris/pull/1277#discussion_r2030005541 ## spec/polaris-catalog-apis/policy-apis.yaml: ## @@ -529,6 +529,28 @@ components: version: type: integer +ApplicablePolicy: + allOf: +

Re: [PR] Upgrade Iceberg REST Spec to match Iceberg 1.8 [polaris]

2025-04-05 Thread via GitHub
eric-maynard closed pull request #1283: Upgrade Iceberg REST Spec to match Iceberg 1.8 URL: https://github.com/apache/polaris/pull/1283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Update gradle format [polaris]

2025-04-05 Thread via GitHub
eric-maynard closed pull request #1319: Update gradle format URL: https://github.com/apache/polaris/pull/1319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Use config-file to define errorprone rule, with some new rules [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on PR #1233: URL: https://github.com/apache/polaris/pull/1233#issuecomment-2781051828 It compiled fine on main for sure after @HonahX's fix. However, check [this failed CI run on a dummy PR](https://github.com/apache/polaris/actions/runs/14285035248/job/40039071

[PR] gradle format test [polaris]

2025-04-05 Thread via GitHub
eric-maynard opened a new pull request, #1319: URL: https://github.com/apache/polaris/pull/1319 _do not merge_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Implement GenericTableCatalogAdapter; admin-related fixes [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1298: URL: https://github.com/apache/polaris/pull/1298#discussion_r2029949193 ## service/common/src/main/java/org/apache/polaris/service/catalog/common/CatalogHandler.java: ## @@ -366,4 +349,24 @@ protected void authorizeRenameTableLikeOpera

Re: [PR] Generalize bootstrapping in servers [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1313: URL: https://github.com/apache/polaris/pull/1313#discussion_r2029948842 ## service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java: ## @@ -100,10 +96,22 @@ public synchronized Sup

Re: [PR] add refresh credentials property to loadTableResult [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #1164: URL: https://github.com/apache/polaris/pull/1164#discussion_r2005798659 ## polaris-core/src/main/java/org/apache/polaris/core/context/CallContext.java: ## @@ -134,6 +173,8 @@ public Map contextVariables() { Map contextVariables(); +

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-05 Thread via GitHub
singhpk234 commented on PR #1287: URL: https://github.com/apache/polaris/pull/1287#issuecomment-2773464973 Sure thing, removed the dependencies not required for the current java code, added DBCP2 helper also in this. -- This is an automated message from the Apache Git Service. To respond

[I] jakarta.persistence.OptimisticLockException [polaris]

2025-04-05 Thread via GitHub
lkindere opened a new issue, #1306: URL: https://github.com/apache/polaris/issues/1306 ### Describe the bug During the execution of our maintenance operations (RewriteManifestsSparkAction) we noticed this exception: ``` CommitStateUnknownException: Service failed: 500: jaka

Re: [PR] Implement GenericTableCatalogAdapter [polaris]

2025-04-05 Thread via GitHub
flyrain commented on code in PR #1264: URL: https://github.com/apache/polaris/pull/1264#discussion_r2025263913 ## service/common/src/main/java/org/apache/polaris/service/catalog/common/CatalogHandlerWrapper.java: ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Policy Store: PolicyMappingRecord with Persistence Impl [polaris]

2025-04-05 Thread via GitHub
flyrain commented on code in PR #1104: URL: https://github.com/apache/polaris/pull/1104#discussion_r2015143484 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/AtomicOperationMetaStoreManager.java: ## @@ -1821,4 +1826,155 @@ public Map getInternalPropertyMap(

Re: [PR] API Spec: Add ConnectionConfigInfo to ExternalCatalog [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #1026: URL: https://github.com/apache/polaris/pull/1026#discussion_r2004305938 ## spec/polaris-management-service.yml: ## @@ -850,9 +850,92 @@ components: - $ref: "#/components/schemas/Catalog" - type: object propertie

Re: [PR] Merge polaris-quarkus-service into polaris-quarkus-server [polaris]

2025-04-05 Thread via GitHub
adutra commented on PR #1223: URL: https://github.com/apache/polaris/pull/1223#issuecomment-2741007949 @jbonofre and @snazy imo the idea was appealing initially, but it doesn't live up to its promises. Are you OK to close this? -- This is an automated message from the Apache Git Service.

Re: [PR] Added freshness aware table loading using metadata file location for ETag [polaris]

2025-04-05 Thread via GitHub
mansehajsingh commented on PR #1037: URL: https://github.com/apache/polaris/pull/1037#issuecomment-2755425875 I moved the ETag generation to a utility class for now. This is because we need it internal to the `IcebergCatalogHandlerWrapper` since we need to compare ETags using the `IcebergTa

Re: [PR] Add CreateTable and LoadTable implementation for SparkCatalog [polaris]

2025-04-05 Thread via GitHub
gh-yzou commented on code in PR #1303: URL: https://github.com/apache/polaris/pull/1303#discussion_r2027916309 ## plugins/spark/v3.5/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Refactor EntityCache into an interface [polaris]

2025-04-05 Thread via GitHub
andrew4699 commented on code in PR #1193: URL: https://github.com/apache/polaris/pull/1193#discussion_r108108 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCacheInterface.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] main: Update dependency org.apache.iceberg:iceberg-bom to v1.8.1 - autoclosed [polaris]

2025-04-05 Thread via GitHub
renovate-bot closed pull request #997: main: Update dependency org.apache.iceberg:iceberg-bom to v1.8.1 - autoclosed URL: https://github.com/apache/polaris/pull/997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Initial commit for Iceberg catalog migrator [polaris-tools]

2025-04-05 Thread via GitHub
ajantha-bhat commented on PR #1: URL: https://github.com/apache/polaris-tools/pull/1#issuecomment-2766154814 And regarding this > I also think, that the migrator should actually live in its own directory, as this repository is rather generic ("tools"). I propose to either move everyt

Re: [PR] Implement GenericTableCatalogAdapter [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1264: URL: https://github.com/apache/polaris/pull/1264#discussion_r2023769350 ## polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java: ## @@ -183,4 +183,11 @@ protected FeatureConfiguration( "How

Re: [PR] Clarify the atomicity of BasePersistence methods [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #1274: URL: https://github.com/apache/polaris/pull/1274#discussion_r2021976026 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java: ## @@ -37,6 +37,11 @@ * defining the internal data model for Polaris, and whic

Re: [PR] Clarify the atomicity of BasePersistence methods [polaris]

2025-04-05 Thread via GitHub
flyrain commented on PR #1274: URL: https://github.com/apache/polaris/pull/1274#issuecomment-2773253588 Thanks a lot for the feedback, @dimas-b @eric-maynard @singhpk234! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] IcebergCatalogAdapter: close underlying catalog consistently [polaris]

2025-04-05 Thread via GitHub
adutra opened a new pull request, #1224: URL: https://github.com/apache/polaris/pull/1224 With the revert of b84f4624db8d0bd5b8920b0df719bcc15666008f by ccf25df7b055e9d232b88a3f6fe8b4e0a2ab035a, we lost an extra benefit that was included in the reverted commit: a fix for the fact that `Ice

Re: [PR] Implement GenericTableCatalogAdapter; admin-related fixes [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1298: URL: https://github.com/apache/polaris/pull/1298#discussion_r2028090363 ## service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java: ## @@ -472,11 +471,7 @@ private void authorizeGrantOnTableLikeOperationO

[PR] Exclude generated files in client/python/polaris [polaris]

2025-04-05 Thread via GitHub
rakesh-das08 opened a new pull request, #1248: URL: https://github.com/apache/polaris/pull/1248 This tries to address - https://github.com/apache/polaris/issues/755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Add Polaris benchmarks [polaris-tools]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #2: URL: https://github.com/apache/polaris-tools/pull/2#discussion_r2023513356 ## benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/util/CircularIterator.scala: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Policy Store: PolicyMappingRecord with Persistence Impl [polaris]

2025-04-05 Thread via GitHub
flyrain closed pull request #1104: Policy Store: PolicyMappingRecord with Persistence Impl URL: https://github.com/apache/polaris/pull/1104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Clarify the atomicity of BasePersistence methods [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1274: URL: https://github.com/apache/polaris/pull/1274#discussion_r2021947904 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java: ## @@ -37,6 +37,11 @@ * defining the internal data model for Polaris, and

Re: [PR] Scala build infra [polaris]

2025-04-05 Thread via GitHub
gh-yzou commented on PR #1211: URL: https://github.com/apache/polaris/pull/1211#issuecomment-2741094630 @snazy but those are libraries already compiled, i do not need to recompile those libraries anymore, right? I am not sure if i get how scala build infra will be used if we are not bui

Re: [PR] Implement GenericTableCatalogAdapter [polaris]

2025-04-05 Thread via GitHub
gh-yzou commented on code in PR #1264: URL: https://github.com/apache/polaris/pull/1264#discussion_r2019461862 ## service/common/src/main/java/org/apache/polaris/service/catalog/common/CatalogHandlerWrapper.java: ## @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache Software Found

[PR] PySpark Reg Test Updates [polaris]

2025-04-05 Thread via GitHub
travis-bowen opened a new pull request, #1262: URL: https://github.com/apache/polaris/pull/1262 Minor Updates to PySpark Reg Tests Each test directly cleans the artifacts it created. Optional bucket prefix location has a UUID appended to allow for multiple runs against the same

Re: [PR] Implement PolicyCatalog Stage 1: CRUD + LisPolicies [polaris]

2025-04-05 Thread via GitHub
HonahX commented on code in PR #1294: URL: https://github.com/apache/polaris/pull/1294#discussion_r2025416072 ## service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalog.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [JDBC] Part1 : ADD SQL script for Polaris setup [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1276: URL: https://github.com/apache/polaris/pull/1276#discussion_r2021528703 ## scripts/postgres/schema-v1-postgresql.sql: ## @@ -0,0 +1,91 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor licens

Re: [PR] Fix updating the storage config [polaris]

2025-04-05 Thread via GitHub
XJDKC commented on code in PR #1191: URL: https://github.com/apache/polaris/pull/1191#discussion_r2006144562 ## service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java: ## @@ -664,6 +665,15 @@ private void validateUpdateCatalogDiffOrThrow(

Re: [PR] [JDBC] Part1 : ADD SQL script for Polaris setup [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1276: URL: https://github.com/apache/polaris/pull/1276#discussion_r2021528703 ## scripts/postgres/schema-v1-postgresql.sql: ## @@ -0,0 +1,91 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor licens

Re: [PR] Simplify `polaris` client script [polaris]

2025-04-05 Thread via GitHub
MonkeyCanCode commented on PR #1220: URL: https://github.com/apache/polaris/pull/1220#issuecomment-2741652173 > cc @MonkeyCanCode Will check tonight. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [JDBC] Part1 : ADD SQL script for Polaris setup [polaris]

2025-04-05 Thread via GitHub
flyrain commented on code in PR #1276: URL: https://github.com/apache/polaris/pull/1276#discussion_r2021818312 ## scripts/postgres/schema-v1-postgresql.sql: ## @@ -0,0 +1,91 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor license agr

[PR] main: Update dependency com.azure:azure-sdk-bom to v1.2.33 [polaris]

2025-04-05 Thread via GitHub
renovate-bot opened a new pull request, #1275: URL: https://github.com/apache/polaris/pull/1275 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.azure:azure-sdk-bom](https://redirect.github.com/

Re: [PR] Add type and converters for `MemorySize` [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #1230: URL: https://github.com/apache/polaris/pull/1230#discussion_r2006602310 ## tools/misc-types/src/main/java/org/apache/polaris/misc/types/memorysize/MemorySize.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[PR] main: Update dependency com.google.guava:guava to v33.4.6-jre [polaris]

2025-04-05 Thread via GitHub
renovate-bot opened a new pull request, #1251: URL: https://github.com/apache/polaris/pull/1251 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.guava:guava](https://redirect.github.com/go

Re: [I] Build instructions from quickstart do not work [polaris]

2025-04-05 Thread via GitHub
adnanhemani commented on issue #1254: URL: https://github.com/apache/polaris/issues/1254#issuecomment-2753159859 This just caught my eye: https://github.com/apache/polaris/pull/1082 Seems that this commit may have broken the existing build instructions. Investigating. -- This is an

Re: [PR] Implement pagination for list APIs [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #273: URL: https://github.com/apache/polaris/pull/273#discussion_r2023223318 ## service/common/src/test/java/org/apache/polaris/service/persistence/pagination/PageTokenTest.java: ## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] Add type and converters for `MemorySize` [polaris]

2025-04-05 Thread via GitHub
snazy commented on PR #1230: URL: https://github.com/apache/polaris/pull/1230#issuecomment-2741533151 For context: this is a per-requisite for #1189. It's quite isolated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add Polaris benchmarks that use the REST APIs [polaris]

2025-04-05 Thread via GitHub
pingtimeout closed pull request #1208: Add Polaris benchmarks that use the REST APIs URL: https://github.com/apache/polaris/pull/1208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [JDBC] Part1 : ADD SQL script for Polaris setup [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #1276: URL: https://github.com/apache/polaris/pull/1276#discussion_r2021997518 ## scripts/postgres/schema-v1-postgresql.sql: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license ag

Re: [PR] Implement GenericTableCatalog [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1231: URL: https://github.com/apache/polaris/pull/1231#discussion_r2010698315 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1189,6 +1189,20 @@ private class BasePolarisTableOperations

Re: [PR] Initial commit for Iceberg catalog migrator [polaris-tools]

2025-04-05 Thread via GitHub
ajantha-bhat commented on code in PR #1: URL: https://github.com/apache/polaris-tools/pull/1#discussion_r2021026432 ## CODE_OF_CONDUCT.md: ## @@ -0,0 +1,3 @@ +This is a project of the [Apache Software Foundation](https://apache.org/) and follows the [ASF Code of Conduct](https

Re: [PR] IcebergCatalogAdapter: close underlying catalog consistently [polaris]

2025-04-05 Thread via GitHub
snazy commented on PR #1224: URL: https://github.com/apache/polaris/pull/1224#issuecomment-2740713289 Related to #563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Scala build infra [polaris]

2025-04-05 Thread via GitHub
snazy commented on PR #1211: URL: https://github.com/apache/polaris/pull/1211#issuecomment-2741619839 Well, the Scala language implications are implicitly introduced with the Spark plugin. I don't mind removing the Scala _compilation_ here, but the dependency stuff needs to happen. --

Re: [PR] PySpark Reg Test Updates [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1262: URL: https://github.com/apache/polaris/pull/1262#discussion_r2015786603 ## regtests/t_pyspark/src/test_spark_sql_s3_with_privileges.py: ## @@ -359,6 +359,14 @@ def test_spark_creates_table_in_custom_namespace_dir(root_client, snowflak

Re: [PR] Rename the Snapshot Retention policy [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1284: URL: https://github.com/apache/polaris/pull/1284#discussion_r2023186360 ## polaris-core/src/main/resources/schemas/policies/system/snapshot-expiry/2025-02-03.json: ## @@ -1,8 +1,8 @@ { "license": "Licensed under the Apache License,

Re: [PR] Implement PolicyCatalog Stage 1: CRUD + ListPolicies [polaris]

2025-04-05 Thread via GitHub
HonahX commented on code in PR #1294: URL: https://github.com/apache/polaris/pull/1294#discussion_r2028162344 ## service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalog.java: ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Implement pagination for list APIs [polaris]

2025-04-05 Thread via GitHub
singhpk234 commented on code in PR #273: URL: https://github.com/apache/polaris/pull/273#discussion_r2021563710 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java: ## @@ -278,21 +281,40 @@ lon

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-05 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2023648845 ## quarkus/server/build.gradle.kts: ## @@ -51,6 +51,10 @@ dependencies { runtimeOnly(project(":polaris-eclipselink")) } + if (project.hasProperty("relatio

Re: [PR] Implement GenericTableCatalogAdapter [polaris]

2025-04-05 Thread via GitHub
eric-maynard merged PR #1264: URL: https://github.com/apache/polaris/pull/1264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polari

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-04-05 Thread via GitHub
RussellSpitzer commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2021188866 ## plugins/spark/v3.5/src/test/java/org/apache/polaris/spark/SparkCatalogTest.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Add annotation @BehaviorChangeSince for behavior-change flags [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on PR #1170: URL: https://github.com/apache/polaris/pull/1170#issuecomment-2769983202 Good idea @dimas-b, I will try to do just that. Putting the PR in draft for now -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[PR] main: Update Quarkus Platform and Group [polaris]

2025-04-05 Thread via GitHub
renovate-bot opened a new pull request, #1291: URL: https://github.com/apache/polaris/pull/1291 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | io.quarkus | `3.19.4` -> `3.21.1` | [![age](https://de

[PR] main: Update dependency io.opentelemetry.semconv:opentelemetry-semconv to v1.31.0 [polaris]

2025-04-05 Thread via GitHub
renovate-bot opened a new pull request, #1288: URL: https://github.com/apache/polaris/pull/1288 This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.opentelemetry.semconv:opentelemetry-semconv](https

Re: [PR] Fix updating the storage config [polaris]

2025-04-05 Thread via GitHub
XJDKC commented on code in PR #1191: URL: https://github.com/apache/polaris/pull/1191#discussion_r2006144562 ## service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java: ## @@ -664,6 +665,15 @@ private void validateUpdateCatalogDiffOrThrow(

Re: [PR] Update `LICENSE` and `NOTICE` in the distributions (admin and server) [polaris]

2025-04-05 Thread via GitHub
jbonofre commented on code in PR #1258: URL: https://github.com/apache/polaris/pull/1258#discussion_r2021416180 ## quarkus/admin/build.gradle.kts: ## @@ -87,8 +87,8 @@ distributions { contents { from(runScript) from(project.layout.buildDirectory.dir("quarkus-a

Re: [PR] Update usage of polaris.io to apache.polaris.org [polaris]

2025-04-05 Thread via GitHub
eric-maynard closed pull request #1235: Update usage of polaris.io to apache.polaris.org URL: https://github.com/apache/polaris/pull/1235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Story, design and implementation for secrets management [polaris]

2025-04-05 Thread via GitHub
dennishuo commented on issue #776: URL: https://github.com/apache/polaris/issues/776#issuecomment-235084 Here's a document with a focus on internal secrets management machinery for Catalog Federation, but which proposes a generalizable model that could accommodate either external secret

Re: [PR] Non-breaking code updates for new errorprone version [polaris]

2025-04-05 Thread via GitHub
snazy commented on code in PR #1215: URL: https://github.com/apache/polaris/pull/1215#discussion_r2007457473 ## service/common/src/main/java/org/apache/polaris/service/catalog/PolarisCatalogHandlerWrapper.java: ## @@ -1019,88 +1016,86 @@ public void commitTransaction(CommitTrans

Re: [PR] Add resource path for Generic Table Endpoints and add the endpoints as supported endpoints when generic table enabled [polaris]

2025-04-05 Thread via GitHub
gh-yzou commented on code in PR #1286: URL: https://github.com/apache/polaris/pull/1286#discussion_r2021958153 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java: ## @@ -652,6 +663,13 @@ public Response getConfig( Pola

Re: [PR] Initial commit for Iceberg catalog migrator [polaris-tools]

2025-04-05 Thread via GitHub
ajantha-bhat commented on PR #1: URL: https://github.com/apache/polaris-tools/pull/1#issuecomment-2774204689 I squashed the commit to add co-author by in the commit message. ( I have a backup. If people want to still review it individually again). -- This is an automated message from

Re: [PR] Fix behavior change config VALIDATE_VIEW_LOCATION_OVERLAP [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on PR #1201: URL: https://github.com/apache/polaris/pull/1201#issuecomment-2737525471 I'm not sure why the commit message wasn't derived from the PR details, sorry about that. We can revert and fix the commit message if need be -- This is an automated message from t

Re: [PR] Add data compaction policy validator [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1238: URL: https://github.com/apache/polaris/pull/1238#discussion_r2012621912 ## polaris-core/src/main/java/org/apache/polaris/core/policy/validator/GenericPolicyValidator.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Fou

[PR] Make PolarisConfiguration values optional [polaris]

2025-04-05 Thread via GitHub
eric-maynard opened a new pull request, #1295: URL: https://github.com/apache/polaris/pull/1295 Created this PR to get feedback on an idea I had while trying to add a new configuration where we'd like to distinguish between "set" and "not set" without just setting the default value to `null

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-05 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2025858108 ## extension/persistence/relational-jdbc/src/main/resources/db.properties: ## @@ -0,0 +1,31 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

Re: [PR] API Spec: Add ConnectionConfigInfo to ExternalCatalog [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #1026: URL: https://github.com/apache/polaris/pull/1026#discussion_r2004321903 ## spec/polaris-management-service.yml: ## @@ -850,9 +850,92 @@ components: - $ref: "#/components/schemas/Catalog" - type: object propertie

Re: [PR] Implement PolicyCatalog Stage 1: CRUD + LisPolicies [polaris]

2025-04-05 Thread via GitHub
gh-yzou commented on code in PR #1294: URL: https://github.com/apache/polaris/pull/1294#discussion_r2027589160 ## service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalog.java: ## @@ -0,0 +1,300 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [I] Remove and ban usage of `[Inheritable]ThreadLocal` [polaris]

2025-04-05 Thread via GitHub
snazy commented on issue #463: URL: https://github.com/apache/polaris/issues/463#issuecomment-2743126453 This is a serious 1.0-blocker, see [reason explained here](https://errorprone.info/bugpattern/ThreadLocalUsage) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Add BOM (Bill of Materials) [polaris]

2025-04-05 Thread via GitHub
snazy merged PR #1216: URL: https://github.com/apache/polaris/pull/1216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apach

Re: [PR] Add type and converters for `MemorySize` [polaris]

2025-04-05 Thread via GitHub
eric-maynard commented on code in PR #1230: URL: https://github.com/apache/polaris/pull/1230#discussion_r2006789031 ## tools/misc-types/src/main/java/org/apache/polaris/misc/types/memorysize/MemorySize.java: ## @@ -0,0 +1,233 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Initial commit for Iceberg catalog migrator [polaris-tools]

2025-04-05 Thread via GitHub
ajantha-bhat commented on code in PR #1: URL: https://github.com/apache/polaris-tools/pull/1#discussion_r2021027739 ## LICENSE: ## @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 +

Re: [PR] Upgrade Iceberg to 1.8 [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #1126: URL: https://github.com/apache/polaris/pull/1126#discussion_r2006791577 ## quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java: ## @@ -153,6 +153,8 @@ public Map getConfigOverrides() {

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-04-05 Thread via GitHub
RussellSpitzer commented on code in PR #1190: URL: https://github.com/apache/polaris/pull/1190#discussion_r2021179153 ## plugins/spark/spark-scala.properties: ## @@ -0,0 +1,22 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agre

Re: [PR] Add a weigher to the EntityCache based on approximate entity size [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #490: URL: https://github.com/apache/polaris/pull/490#discussion_r2006435060 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityWeigher.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Add Polaris benchmarks [polaris-tools]

2025-04-05 Thread via GitHub
RussellSpitzer commented on code in PR #2: URL: https://github.com/apache/polaris-tools/pull/2#discussion_r2023407691 ## benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/actions/AuthenticationActions.scala: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software F

Re: [PR] [JDBC] Part1 : ADD SQL script for Polaris setup [polaris]

2025-04-05 Thread via GitHub
flyrain merged PR #1276: URL: https://github.com/apache/polaris/pull/1276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2023639832 ## extension/persistence/relational-jdbc/build.gradle.kts: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

Re: [PR] Improve code-containment and efficiency of etag-aware loading [polaris]

2025-04-05 Thread via GitHub
dennishuo commented on code in PR #1296: URL: https://github.com/apache/polaris/pull/1296#discussion_r2026181665 ## service/common/src/main/java/org/apache/polaris/service/http/IcebergHttpUtil.java: ## @@ -32,6 +32,10 @@ private IcebergHttpUtil() {} * @return the generated E

Re: [PR] Add resource path for Generic Table Endpoints and add the endpoints as supported endpoints when generic table enabled [polaris]

2025-04-05 Thread via GitHub
flyrain commented on code in PR #1286: URL: https://github.com/apache/polaris/pull/1286#discussion_r2024140766 ## polaris-core/src/main/java/org/apache/polaris/core/rest/PolarisEndpoint.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Implement pagination for list APIs [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #273: URL: https://github.com/apache/polaris/pull/273#discussion_r2021982919 ## extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java: ## @@ -278,21 +281,40 @@ long c

Re: [PR] API Spec: Add ConnectionConfigInfo to ExternalCatalog [polaris]

2025-04-05 Thread via GitHub
gh-yzou commented on code in PR #1026: URL: https://github.com/apache/polaris/pull/1026#discussion_r2006122993 ## spec/polaris-management-service.yml: ## @@ -850,9 +850,92 @@ components: - $ref: "#/components/schemas/Catalog" - type: object propertie

Re: [PR] API Spec: Add ConnectionConfigInfo to ExternalCatalog [polaris]

2025-04-05 Thread via GitHub
dimas-b commented on code in PR #1026: URL: https://github.com/apache/polaris/pull/1026#discussion_r2005855560 ## spec/polaris-management-service.yml: ## @@ -850,9 +850,92 @@ components: - $ref: "#/components/schemas/Catalog" - type: object propertie

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-04-05 Thread via GitHub
gh-yzou commented on PR #1190: URL: https://github.com/apache/polaris/pull/1190#issuecomment-2741336662 We clarified in the other pr https://github.com/apache/polaris/pull/1211 that the Spark Plugin have no strict requirement for the Scala build. -- This is an automated message from the A

Re: [PR] Initial commit for Iceberg catalog migrator [polaris-tools]

2025-04-05 Thread via GitHub
ajantha-bhat commented on PR #1: URL: https://github.com/apache/polaris-tools/pull/1#issuecomment-2766142851 @snazy: thanks for the review. I have updated the gradle stuff to be similar to polaris main repo and verified `./gradlew clean build` and handled other comments. -- This is an a

Re: [I] Fix annoying "split package" build warnings [polaris]

2025-04-05 Thread via GitHub
snazy closed issue #849: Fix annoying "split package" build warnings URL: https://github.com/apache/polaris/issues/849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Implement GenericTableCatalogAdapter [polaris]

2025-04-05 Thread via GitHub
gh-yzou commented on code in PR #1264: URL: https://github.com/apache/polaris/pull/1264#discussion_r2023792725 ## service/common/src/main/java/org/apache/polaris/service/catalog/common/CatalogHandlerWrapper.java: ## @@ -0,0 +1,358 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] Fix updating the storage config [polaris]

2025-04-05 Thread via GitHub
XJDKC commented on code in PR #1191: URL: https://github.com/apache/polaris/pull/1191#discussion_r2006353669 ## polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java: ## @@ -240,6 +246,21 @@ public Builder setStorageConfigurationInfo( } a

Re: [PR] Polaris Spark Plugin: setup repository code structure and build [polaris]

2025-04-05 Thread via GitHub
sfc-gh-yzou commented on PR #1190: URL: https://github.com/apache/polaris/pull/1190#issuecomment-2738188457 @snazy I believe the scala style build is only needed if the source file i am going to pack contains scala code, right now the scala version is only used to pull the corresponding spa

Re: [PR] Refactor EntityCache into an interface [polaris]

2025-04-05 Thread via GitHub
flyrain commented on code in PR #1193: URL: https://github.com/apache/polaris/pull/1193#discussion_r2001891576 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/EntityCacheInterface.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundati

[PR] Let `PurgeCommand` inspect the results [polaris]

2025-04-05 Thread via GitHub
snazy opened a new pull request, #1226: URL: https://github.com/apache/polaris/pull/1226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

Re: [I] Publish Polaris BillOfMaterials (BOM) [polaris]

2025-04-05 Thread via GitHub
snazy closed issue #788: Publish Polaris BillOfMaterials (BOM) URL: https://github.com/apache/polaris/issues/788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] API Spec: Add ConnectionConfigInfo to ExternalCatalog [polaris]

2025-04-05 Thread via GitHub
gh-yzou commented on code in PR #1026: URL: https://github.com/apache/polaris/pull/1026#discussion_r2004697164 ## spec/polaris-management-service.yml: ## @@ -850,9 +850,92 @@ components: - $ref: "#/components/schemas/Catalog" - type: object propertie

  1   2   >