singhpk234 merged PR #1988:
URL: https://github.com/apache/polaris/pull/1988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.
MonkeyCanCode opened a new pull request, #1999:
URL: https://github.com/apache/polaris/pull/1999
Currently if an end-user try to rerun `regenerate.sh` (as part of polaris
repair or OpenAPI code regen, it will keep adding new headers to the existed
README.nd. As this file is not part of the
MonkeyCanCode commented on PR #1966:
URL: https://github.com/apache/polaris/pull/1966#issuecomment-3034493090
Nice work on this piece. The approach looks good. Here are my two cents:
1. I think the word "random" may be a bit misleading, as the underlying hash
function `murmur3_32_fixed` i
eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2184275829
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
dimas-b commented on PR #1988:
URL: https://github.com/apache/polaris/pull/1988#issuecomment-3034358771
@singhpk234 : Please feel free to merge after you review the updated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
dimas-b commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2184268464
##
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##
@@ -151,7 +152,8 @@ public void testCreateCatalogSuffici
dimas-b commented on code in PR #1998:
URL: https://github.com/apache/polaris/pull/1998#discussion_r2184266898
##
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##
@@ -106,25 +106,25 @@ public Catalog asCatalog() {
CatalogProperties.builde
dimas-b commented on PR #1984:
URL: https://github.com/apache/polaris/pull/1984#issuecomment-3034345669
AFAIK, anybody is welcome to review PRs and post comments. A formal reviewer
assignment is not necessary for that.
Committers (who can formally approve PRs) can already assign PRs t
dimas-b commented on PR #1988:
URL: https://github.com/apache/polaris/pull/1988#issuecomment-3034327668
Just FYI: https://lists.apache.org/thread/0cyrzft2oon28otxlmmhvd5671rd3r3d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dimas-b commented on PR #1988:
URL: https://github.com/apache/polaris/pull/1988#issuecomment-3034324009
Thanks for the updated description, @adnanhemani ! Nice find!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
adnanhemani commented on PR #1958:
URL: https://github.com/apache/polaris/pull/1958#issuecomment-3034307181
Seems like Quarkus community has picked up this issue and is working on a
fix. If it goes through and fixes our issues, I'm assuming we can just upgrade
to that version and abandon th
adnanhemani commented on code in PR #1988:
URL: https://github.com/apache/polaris/pull/1988#discussion_r2184221167
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##
@@ -100,17 +99,18 @@ private void i
github-actions[bot] commented on PR #1585:
URL: https://github.com/apache/polaris/pull/1585#issuecomment-3034196055
This PR is stale because it has been open 30 days with no activity. Remove
stale label or comment or this will be closed in 5 days.
--
This is an automated message from the
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2183986323
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2183985231
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -86,18 +102,32 @@ public static List>
getAllConfigurations() {
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2183985168
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2183984877
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -86,18 +102,32 @@ public static List>
getAllConfigurations() {
eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2183971283
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2183970346
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2183969935
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -86,18 +102,32 @@ public static List>
getAllConfigurations() {
@S
eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2183969681
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -86,18 +102,32 @@ public static List>
getAllConfigurations() {
@S
eric-maynard merged PR #1982:
URL: https://github.com/apache/polaris/pull/1982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
gh-yzou merged PR #1997:
URL: https://github.com/apache/polaris/pull/1997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
gh-yzou commented on code in PR #1997:
URL: https://github.com/apache/polaris/pull/1997#discussion_r2183935286
##
plugins/spark/v3.5/regtests/setup.sh:
##
@@ -129,11 +135,27 @@ else
echo 'Setting spark conf...'
# Instead of clobbering existing spark conf, just comment it a
poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183931995
##
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##
@@ -151,7 +152,8 @@ public void testCreateCatalo
flyrain commented on code in PR #1997:
URL: https://github.com/apache/polaris/pull/1997#discussion_r2183913715
##
plugins/spark/v3.5/regtests/setup.sh:
##
@@ -129,11 +135,27 @@ else
echo 'Setting spark conf...'
# Instead of clobbering existing spark conf, just comment it a
poojanilangekar commented on PR #1984:
URL: https://github.com/apache/polaris/pull/1984#issuecomment-3033900256
I am not sure if this requires another vote, but the ability to assign
reviewers to a PR will be more useful when compared to the ability to trigger
CI runs.
--
This is an au
poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183890890
##
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##
@@ -151,7 +152,8 @@ public void testCreateCatalo
poojanilangekar commented on PR #1998:
URL: https://github.com/apache/polaris/pull/1998#issuecomment-3033895186
CC: @dimas-b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
poojanilangekar opened a new pull request, #1998:
URL: https://github.com/apache/polaris/pull/1998
Encountered the issue while adding additional validations to
`ExternalCatalog`. The `CatalogEntity::Builder` checks if the `Catalog::type`
is set to `INTERNAL`, if not it defaults to `EXTERNAL
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2183138817
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
dimas-b commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183864223
##
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##
@@ -151,7 +152,8 @@ public void testCreateCatalogSuffici
poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183861940
##
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##
@@ -151,7 +152,8 @@ public void testCreateCatalo
dimas-b commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183847008
##
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##
@@ -151,7 +152,8 @@ public void testCreateCatalogSuffici
dimas-b commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183845545
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -699,16 +701,10 @@ private Map
extractSecretReferences(
/**
* @
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183844374
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183844374
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183711477
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183711477
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183707842
##
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##
@@ -151,7 +152,8 @@ public void testCreateCatalo
gh-yzou opened a new pull request, #1997:
URL: https://github.com/apache/polaris/pull/1997
Spark can use the Spark Client with --jars and --packages use case, the
regression test today only covers the --jars use case.
This PR adds regression test with the --packages use case.
--
This
flyrain commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183701261
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183698535
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -699,16 +701,10 @@ private Map
extractSecretReferences(
/**
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183678022
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183671882
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
flyrain commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183620406
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
eric-maynard commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183601124
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundatio
eric-maynard commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183599691
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundatio
snazy commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183527659
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183509153
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on PR #1913:
URL: https://github.com/apache/polaris/pull/1913#issuecomment-3033197284
This is not the final PR for non-AWS S3 :) We should certainly add CLI
support, but probably in a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond t
dimas-b commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183493990
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2183482251
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -699,16 +701,10 @@ private Map
extractSecretReferences(
/**
* @
flyrain commented on PR #1913:
URL: https://github.com/apache/polaris/pull/1913#issuecomment-3033103020
Thanks for doing this. I think it's the right direction. We could also make
CLI to support new fields, which could be done as a followup.
--
This is an automated message from the Apache
flyrain commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183406772
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
flyrain commented on code in PR #1913:
URL: https://github.com/apache/polaris/pull/1913#discussion_r2183406772
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/StsClientsPool.java:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
dimas-b merged PR #1996:
URL: https://github.com/apache/polaris/pull/1996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
dimas-b commented on PR #1996:
URL: https://github.com/apache/polaris/pull/1996#issuecomment-3032882751
Merging based on 3 approvals... If other reviewers find issues, we can
certainly follow up with fixes.
--
This is an automated message from the Apache Git Service.
To respond to the mes
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2183143095
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2183141121
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2183138817
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2183123442
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
dimas-b commented on PR #1913:
URL: https://github.com/apache/polaris/pull/1913#issuecomment-3032327083
@eric-maynard PTAL :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
adutra commented on PR #1996:
URL: https://github.com/apache/polaris/pull/1996#issuecomment-3031590719
Thanks @jparkzz for this PR – and for your patience 😄 Leaving it open for a
few more hours in case someone wants to review.
--
This is an automated message from the Apache Git Service.
T
fabio-rizzo-01 commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2182192409
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace
jparkzz commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182176835
##
helm/polaris/README.md:
##
@@ -335,13 +335,19 @@ ct install --namespace polaris --debug --charts
./helm/polaris \
| metrics.enabled | bool | `true` | Specifies whe
adutra commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182151135
##
helm/polaris/README.md:
##
@@ -335,13 +335,19 @@ ct install --namespace polaris --debug --charts
./helm/polaris \
| metrics.enabled | bool | `true` | Specifies whet
jparkzz commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182140984
##
helm/polaris/values.yaml:
##
@@ -528,8 +528,14 @@ persistence:
relationalJdbc:
# -- The secret name to pull the database connection properties from.
sec
adutra commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182128580
##
helm/polaris/values.yaml:
##
@@ -528,8 +528,14 @@ persistence:
relationalJdbc:
# -- The secret name to pull the database connection properties from.
secr
jparkzz commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182118679
##
helm/polaris/values.yaml:
##
@@ -528,8 +528,14 @@ persistence:
relationalJdbc:
# -- The secret name to pull the database connection properties from.
sec
adutra commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182103365
##
helm/polaris/values.yaml:
##
@@ -528,8 +528,14 @@ persistence:
relationalJdbc:
# -- The secret name to pull the database connection properties from.
secr
jparkzz commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182097201
##
helm/polaris/README.md:
##
@@ -335,13 +335,20 @@ ct install --namespace polaris --debug --charts
./helm/polaris \
| metrics.enabled | bool | `true` | Specifies whe
adutra commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182086669
##
helm/polaris/README.md:
##
@@ -335,13 +335,20 @@ ct install --namespace polaris --debug --charts
./helm/polaris \
| metrics.enabled | bool | `true` | Specifies whet
jparkzz commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182075544
##
helm/polaris/values.yaml:
##
@@ -528,8 +528,14 @@ persistence:
relationalJdbc:
# -- The secret name to pull the database connection properties from.
sec
adutra commented on code in PR #1996:
URL: https://github.com/apache/polaris/pull/1996#discussion_r2182053620
##
helm/polaris/values.yaml:
##
@@ -528,8 +528,14 @@ persistence:
relationalJdbc:
# -- The secret name to pull the database connection properties from.
secr
75 matches
Mail list logo