[jira] [Commented] (SOLR-15254) Random deadlock during cores initialization

2021-07-20 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384517#comment-17384517 ] Mark Robert Miller commented on SOLR-15254: --- I've got that workaround I think.

[GitHub] [solr] madrob commented on a change in pull request #227: SOLR-15550 Save submitter trace in ObjectReleaseTracker

2021-07-20 Thread GitBox
madrob commented on a change in pull request #227: URL: https://github.com/apache/solr/pull/227#discussion_r673477241 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java ## @@ -196,7 +198,13 @@ public void execute(final Runnable command) { S

[GitHub] [solr-operator] HoustonPutman opened a new pull request #293: Add option for Ingress TLS termination for common endpoint.

2021-07-20 Thread GitBox
HoustonPutman opened a new pull request #293: URL: https://github.com/apache/solr-operator/pull/293 Resolves #268 Still needs documentation. But this gives the user the ability to set a TLS secret to do TLS termination at the ingress for the common-endpoint only. -- This i

[jira] [Resolved] (SOLR-15549) Old SolrJ implementations (8.x) are incompatible with 9.0 Clouds

2021-07-20 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-15549. --- Fix Version/s: 8.10 Resolution: Fixed SolrJ 8.10 is now compatible with 9.x Clouds. U

[jira] [Commented] (SOLR-15549) Old SolrJ implementations (8.x) are incompatible with 9.0 Clouds

2021-07-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384450#comment-17384450 ] ASF subversion and git services commented on SOLR-15549: Commit 1

[GitHub] [solr] HoustonPutman merged pull request #224: SOLR-15549: Better error message for missing ZK nodes in ZkStateReader.

2021-07-20 Thread GitBox
HoustonPutman merged pull request #224: URL: https://github.com/apache/solr/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [solr] anshumg commented on a change in pull request #224: SOLR-15549: Better error message for missing ZK nodes in ZkStateReader.

2021-07-20 Thread GitBox
anshumg commented on a change in pull request #224: URL: https://github.com/apache/solr/pull/224#discussion_r673407575 ## File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc ## @@ -170,6 +170,11 @@ Upgrade is to be done using Collection API MIGRATESTATEFORMAT actio

[GitHub] [solr-operator] thelabdude opened a new pull request #292: Add config options to enable TLS from cert files mounted to a dir on each pod by a cert-manager extension

2021-07-20 Thread GitBox
thelabdude opened a new pull request #292: URL: https://github.com/apache/solr-operator/pull/292 Fixes #291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [solr] athrog commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-20 Thread GitBox
athrog commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-883624248 Both good points, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr-operator] thelabdude opened a new issue #291: Config options to enable TLS from files in a mounted directory instead of from a secret

2021-07-20 Thread GitBox
thelabdude opened a new issue #291: URL: https://github.com/apache/solr-operator/issues/291 One emerging pattern in the K8s ecosystem I've noticed is to have a cert-manager extension that issues a unique TLS certificate for each pod. Typically how this works is the cert-manager extension w

[GitHub] [solr] HoustonPutman commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-20 Thread GitBox
HoustonPutman commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-883620391 > Regarding minio Yeah, I changed a few things and got it closer to working, but I guess that problem was the last and unsolvable hurdle... > Regarding the AwsReg

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #227: SOLR-15550 Save submitter trace in ObjectReleaseTracker

2021-07-20 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #227: URL: https://github.com/apache/solr/pull/227#discussion_r673387063 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ObjectReleaseTracker.java ## @@ -57,49 +55,55 @@ public static void clear() { * @

[GitHub] [solr] marcosfpr commented on a change in pull request #228: SOLR-15496 LTRRescorer unnecessarily (re)creates Comparator

2021-07-20 Thread GitBox
marcosfpr commented on a change in pull request #228: URL: https://github.com/apache/solr/pull/228#discussion_r673383681 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -131,31 +146,12 @@ public TopDocs rescore(IndexSearcher searcher, TopDocs

[GitHub] [solr] marcosfpr commented on a change in pull request #228: SOLR-15496 LTRRescorer unnecessarily (re)creates Comparator

2021-07-20 Thread GitBox
marcosfpr commented on a change in pull request #228: URL: https://github.com/apache/solr/pull/228#discussion_r673372216 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -53,6 +53,21 @@ public LTRRescorer(LTRScoringQuery scoringQuery) { th

[GitHub] [solr] marcosfpr commented on a change in pull request #228: SOLR-15496 LTRRescorer unnecessarily (re)creates Comparator

2021-07-20 Thread GitBox
marcosfpr commented on a change in pull request #228: URL: https://github.com/apache/solr/pull/228#discussion_r673372216 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -53,6 +53,21 @@ public LTRRescorer(LTRScoringQuery scoringQuery) { th

[GitHub] [solr] athrog commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-20 Thread GitBox
athrog commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-883594327 I'll take a look at the async API issue you described. Most of my testing lately (in the Solr 9 codebase) has been with the synchronous APIs, so that's a good callout. Regardin

[GitHub] [solr] athrog commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-20 Thread GitBox
athrog commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-883590462 Regarding minio, I saw this too in my testing (I tried to make it work before moving to S3Mock). Their handling of "directory-like" structure is pretty incompatible with this project.

[GitHub] [solr] HoustonPutman commented on pull request #120: SOLR-15089: Allow backup/restoration to Amazon's S3 blobstore

2021-07-20 Thread GitBox
HoustonPutman commented on pull request #120: URL: https://github.com/apache/solr/pull/120#issuecomment-883573183 Been testing this out some more, and am finding some issues: - Using the async API (not sure about synchronous), I'm seeing `status: 0` when the backup actually fails. Th

[jira] [Commented] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2021-07-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384401#comment-17384401 ] David Smiley commented on SOLR-12386: - To be clear, my callous "who cares" was only a

[GitHub] [solr] cpoerschke commented on a change in pull request #227: SOLR-15550 Save submitter trace in ObjectReleaseTracker

2021-07-20 Thread GitBox
cpoerschke commented on a change in pull request #227: URL: https://github.com/apache/solr/pull/227#discussion_r673293571 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java ## @@ -148,6 +148,8 @@ public static ExecutorService newMDCAwareCachedThrea

[jira] [Commented] (SOLR-15549) Old SolrJ implementations (8.x) are incompatible with 9.0 Clouds

2021-07-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384398#comment-17384398 ] ASF subversion and git services commented on SOLR-15549: Commit 9

[GitHub] [solr-operator] HoustonPutman closed issue #259: Ephemeral storage should extend to ZK instance

2021-07-20 Thread GitBox
HoustonPutman closed issue #259: URL: https://github.com/apache/solr-operator/issues/259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman merged pull request #284: Add ephemeral option for zk storage.

2021-07-20 Thread GitBox
HoustonPutman merged pull request #284: URL: https://github.com/apache/solr-operator/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr] madrob commented on a change in pull request #227: SOLR-15550 Save submitter trace in ObjectReleaseTracker

2021-07-20 Thread GitBox
madrob commented on a change in pull request #227: URL: https://github.com/apache/solr/pull/227#discussion_r673288008 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java ## @@ -196,7 +198,13 @@ public void execute(final Runnable command) { S

[GitHub] [solr] cpoerschke commented on a change in pull request #228: SOLR-15496 LTRRescorer unnecessarily (re)creates Comparator

2021-07-20 Thread GitBox
cpoerschke commented on a change in pull request #228: URL: https://github.com/apache/solr/pull/228#discussion_r673272242 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java ## @@ -53,6 +53,21 @@ public LTRRescorer(LTRScoringQuery scoringQuery) { t

[GitHub] [solr-operator] HoustonPutman closed issue #264: Specifiy/Create a service account used by the created SolrCloud

2021-07-20 Thread GitBox
HoustonPutman closed issue #264: URL: https://github.com/apache/solr-operator/issues/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman merged pull request #283: Ability to customize serviceAccountName for SolrCloud and SolrPrometheusExporter

2021-07-20 Thread GitBox
HoustonPutman merged pull request #283: URL: https://github.com/apache/solr-operator/pull/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] HoustonPutman commented on issue #264: Specifiy/Create a service account used by the created SolrCloud

2021-07-20 Thread GitBox
HoustonPutman commented on issue #264: URL: https://github.com/apache/solr-operator/issues/264#issuecomment-883503503 Good to know. So in the linked PR I added the ability to create the necessary ServiceAccount when deploying the `solr` helm chart, but the operator itself does not c

[GitHub] [solr-operator] chaicesan opened a new issue #290: Allow configuration of zookeeper cluster configs via values.yaml

2021-07-20 Thread GitBox
chaicesan opened a new issue #290: URL: https://github.com/apache/solr-operator/issues/290 As it stands we can't configure the lower level zookeeper cluster properties (e.g. zoo.cfg) via the solr-operator. I realised this recently when I was debugging one of our services and decided it's w

[jira] [Comment Edited] (SOLR-15496) LTRRescorer unnecessarily (re)creates ScoreDoc Comparator objects

2021-07-20 Thread Marcos Felipe Pontes Rezende (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384315#comment-17384315 ] Marcos Felipe Pontes Rezende edited comment on SOLR-15496 at 7/20/21, 2:58 PM:

[jira] [Commented] (SOLR-15496) LTRRescorer unnecessarily (re)creates ScoreDoc Comparator objects

2021-07-20 Thread Marcos Felipe Pontes Rezende (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384315#comment-17384315 ] Marcos Felipe Pontes Rezende commented on SOLR-15496: - Hello everyone

[GitHub] [solr] marcosfpr opened a new pull request #228: SOLR-15496 LTRRescorer unnecessarily (re)creates ScoreDoc Comparator …

2021-07-20 Thread GitBox
marcosfpr opened a new pull request #228: URL: https://github.com/apache/solr/pull/228 …objects https://issues.apache.org/jira/browse/SOLR-15496 # Description A static instance of the comparator(s) could be created and reused. # Solution I just

[jira] [Commented] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2021-07-20 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384283#comment-17384283 ] Mark Robert Miller commented on SOLR-12386: --- That’s actually the story of SolrC

[jira] [Comment Edited] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2021-07-20 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384274#comment-17384274 ] Mark Robert Miller edited comment on SOLR-12386 at 7/20/21, 1:54 PM: --

[jira] [Comment Edited] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2021-07-20 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384274#comment-17384274 ] Mark Robert Miller edited comment on SOLR-12386 at 7/20/21, 1:53 PM: --

[jira] [Comment Edited] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2021-07-20 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384274#comment-17384274 ] Mark Robert Miller edited comment on SOLR-12386 at 7/20/21, 1:52 PM: --

[jira] [Commented] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2021-07-20 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384274#comment-17384274 ] Mark Robert Miller commented on SOLR-12386: --- Who cares? Not many, I’ll agree wi

[jira] [Commented] (SOLR-12386) Test fails for "Can't find resource" for files in the _default configset

2021-07-20 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384270#comment-17384270 ] Mark Robert Miller commented on SOLR-12386: --- Zookeeper coordinates. It’s one of

[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException

2021-07-20 Thread GitBox
dsmiley commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-883013519 > Is this an is or ought statement? "ought". It's a minor nuisance really. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-20 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r672482454 ## File path: solr/test-framework/src/java/org/apache/solr/util/RandomizeSSL.java ## @@ -104,10 +105,10 @@ public SSLRandomizer(double ssl, double clientAu

[GitHub] [solr] madrob commented on pull request #216: SOLR-15535: remove rawtypes warnings in 'grouping' code

2021-07-20 Thread GitBox
madrob commented on pull request #216: URL: https://github.com/apache/solr/pull/216#issuecomment-882803411 I tried to mess around with this a bit by creating a wrapping class, but couldn't get it to work very cleanly so let's stick with this approach and maybe can revisit in the future. Th

[GitHub] [solr-operator] HoustonPutman merged pull request #287: Upgrade default Solr version to 8.9

2021-07-20 Thread GitBox
HoustonPutman merged pull request #287: URL: https://github.com/apache/solr-operator/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[jira] [Resolved] (SOLR-15554) How to create a Report

2021-07-20 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett resolved SOLR-15554. -- Resolution: Not A Problem Again, please use the user mailing list to ask these question

[GitHub] [solr] madrob commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException

2021-07-20 Thread GitBox
madrob commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-882802608 > if getCurrentSchemaModificationVersion throws an exception, then its caller doesn't have to catch the exception; Is this an _is_ or _ought_ statement? In other words, are you

[GitHub] [solr-operator] HoustonPutman closed issue #286: Remove deprecations for the v0.4.0 release

2021-07-20 Thread GitBox
HoustonPutman closed issue #286: URL: https://github.com/apache/solr-operator/issues/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman closed issue #285: Upgrade the default version of Solr

2021-07-20 Thread GitBox
HoustonPutman closed issue #285: URL: https://github.com/apache/solr-operator/issues/285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman merged pull request #288: Remove deprecations for v0.4.0 release.

2021-07-20 Thread GitBox
HoustonPutman merged pull request #288: URL: https://github.com/apache/solr-operator/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr] dsmiley commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-20 Thread GitBox
dsmiley commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r672775627 ## File path: solr/test-framework/src/java/org/apache/solr/util/RandomizeSSL.java ## @@ -104,10 +105,10 @@ public SSLRandomizer(double ssl, double clientAuth,

[GitHub] [solr-operator] alittlec commented on issue #53: Allow Solr to be run across Availability Zones

2021-07-20 Thread GitBox
alittlec commented on issue #53: URL: https://github.com/apache/solr-operator/issues/53#issuecomment-882472454 hi - is there any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [solr] madrob commented on a change in pull request #227: SOLR-15550 Save submitter trace in ObjectReleaseTracker

2021-07-20 Thread GitBox
madrob commented on a change in pull request #227: URL: https://github.com/apache/solr/pull/227#discussion_r672783290 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java ## @@ -196,7 +198,13 @@ public void execute(final Runnable command) { S

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-20 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r672741219 ## File path: solr/benchmark/build.gradle ## @@ -0,0 +1,140 @@ +/* Review comment: *Moderate OSS Vulnerability:*   ### pkg:maven/com.goo

[GitHub] [solr] markrmiller commented on pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-20 Thread GitBox
markrmiller commented on pull request #214: URL: https://github.com/apache/solr/pull/214#issuecomment-882730941 bq. Otherwise, it seems a new module would be more appropriate. You don't back up that statement with any support, other than: bq. test-framework is about publishing

[GitHub] [solr] dsmiley commented on pull request #225: SOLR-15538 Update Lucene Preview Release dependency

2021-07-20 Thread GitBox
dsmiley commented on pull request #225: URL: https://github.com/apache/solr/pull/225#issuecomment-883026028 Thanks for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [solr] dsmiley commented on a change in pull request #227: SOLR-15550 Save submitter trace in ObjectReleaseTracker

2021-07-20 Thread GitBox
dsmiley commented on a change in pull request #227: URL: https://github.com/apache/solr/pull/227#discussion_r672780636 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java ## @@ -196,7 +198,13 @@ public void execute(final Runnable command) {

[jira] [Created] (SOLR-15554) How to create a Report

2021-07-20 Thread Irfan1 (Jira)
Irfan1 created SOLR-15554: - Summary: How to create a Report Key: SOLR-15554 URL: https://issues.apache.org/jira/browse/SOLR-15554 Project: Solr Issue Type: Improvement Security Level: Public (D

[jira] [Resolved] (SOLR-15553) How to create a Report

2021-07-20 Thread Atri Sharma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atri Sharma resolved SOLR-15553. Resolution: Not A Bug Please use users mailing list for questions. > How to create a Report >

[jira] [Created] (SOLR-15553) How to create a Report

2021-07-20 Thread Irfan Gazi (Jira)
Irfan Gazi created SOLR-15553: - Summary: How to create a Report Key: SOLR-15553 URL: https://issues.apache.org/jira/browse/SOLR-15553 Project: Solr Issue Type: Improvement Security Level: P

[GitHub] [solr] dsmiley commented on a change in pull request #227: SOLR-15550 Save submitter trace in ObjectReleaseTracker

2021-07-20 Thread GitBox
dsmiley commented on a change in pull request #227: URL: https://github.com/apache/solr/pull/227#discussion_r672780636 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java ## @@ -196,7 +198,13 @@ public void execute(final Runnable command) {

[GitHub] [solr] dsmiley commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException

2021-07-20 Thread GitBox
dsmiley commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-883013519 > Is this an is or ought statement? "ought". It's a minor nuisance really. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [solr-operator] HoustonPutman merged pull request #287: Upgrade default Solr version to 8.9

2021-07-20 Thread GitBox
HoustonPutman merged pull request #287: URL: https://github.com/apache/solr-operator/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr] markrmiller commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-20 Thread GitBox
markrmiller commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r672482454 ## File path: solr/test-framework/src/java/org/apache/solr/util/RandomizeSSL.java ## @@ -104,10 +105,10 @@ public SSLRandomizer(double ssl, double clientAu

[GitHub] [solr] madrob commented on pull request #221: SOLR-15258: ConfigSetService operations ought to throw IOException

2021-07-20 Thread GitBox
madrob commented on pull request #221: URL: https://github.com/apache/solr/pull/221#issuecomment-882802608 > if getCurrentSchemaModificationVersion throws an exception, then its caller doesn't have to catch the exception; Is this an _is_ or _ought_ statement? In other words, are you

[GitHub] [solr-operator] HoustonPutman closed issue #286: Remove deprecations for the v0.4.0 release

2021-07-20 Thread GitBox
HoustonPutman closed issue #286: URL: https://github.com/apache/solr-operator/issues/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman merged pull request #288: Remove deprecations for v0.4.0 release.

2021-07-20 Thread GitBox
HoustonPutman merged pull request #288: URL: https://github.com/apache/solr-operator/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr] dsmiley commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-20 Thread GitBox
dsmiley commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r672775627 ## File path: solr/test-framework/src/java/org/apache/solr/util/RandomizeSSL.java ## @@ -104,10 +105,10 @@ public SSLRandomizer(double ssl, double clientAuth,

[GitHub] [solr] madrob commented on pull request #216: SOLR-15535: remove rawtypes warnings in 'grouping' code

2021-07-20 Thread GitBox
madrob commented on pull request #216: URL: https://github.com/apache/solr/pull/216#issuecomment-882803411 I tried to mess around with this a bit by creating a wrapping class, but couldn't get it to work very cleanly so let's stick with this approach and maybe can revisit in the future. Th

[GitHub] [solr-operator] alittlec commented on issue #53: Allow Solr to be run across Availability Zones

2021-07-20 Thread GitBox
alittlec commented on issue #53: URL: https://github.com/apache/solr-operator/issues/53#issuecomment-882472454 hi - is there any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [solr] madrob commented on a change in pull request #227: SOLR-15550 Save submitter trace in ObjectReleaseTracker

2021-07-20 Thread GitBox
madrob commented on a change in pull request #227: URL: https://github.com/apache/solr/pull/227#discussion_r672783290 ## File path: solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java ## @@ -196,7 +198,13 @@ public void execute(final Runnable command) { S

[GitHub] [solr-operator] HoustonPutman closed issue #285: Upgrade the default version of Solr

2021-07-20 Thread GitBox
HoustonPutman closed issue #285: URL: https://github.com/apache/solr-operator/issues/285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-20 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #214: URL: https://github.com/apache/solr/pull/214#discussion_r672741219 ## File path: solr/benchmark/build.gradle ## @@ -0,0 +1,140 @@ +/* Review comment: *Moderate OSS Vulnerability:*   ### pkg:maven/com.goo

[GitHub] [solr] markrmiller commented on pull request #214: SOLR-15428: Integrate the OpenJDK JMH micro benchmark framework for m…

2021-07-20 Thread GitBox
markrmiller commented on pull request #214: URL: https://github.com/apache/solr/pull/214#issuecomment-882730941 bq. Otherwise, it seems a new module would be more appropriate. You don't back up that statement with any support, other than: bq. test-framework is about publishing

[GitHub] [solr] dsmiley commented on pull request #225: SOLR-15538 Update Lucene Preview Release dependency

2021-07-20 Thread GitBox
dsmiley commented on pull request #225: URL: https://github.com/apache/solr/pull/225#issuecomment-883026028 Thanks for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.