anshumg commented on pull request #225:
URL: https://github.com/apache/solr/pull/225#issuecomment-909863732
@markrmiller - Do you plan to update this to prerelease8 (considering
that's available)?
Assuming that doesn't break anything else, and this patch works, might be
worth to me
[
https://issues.apache.org/jira/browse/SOLR-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-2534:
Issue Type: Improvement (was: Bug)
> Add min() and max() on strings
> --
>
>
[
https://issues.apache.org/jira/browse/SOLR-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407725#comment-17407725
]
Selvamohan Neethiraj commented on SOLR-12848:
-
+1 for the patch.
I have verif
[
https://issues.apache.org/jira/browse/SOLR-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407715#comment-17407715
]
Chris M. Hostetter commented on SOLR-15602:
---
Huh ... obviously that last commen
[
https://issues.apache.org/jira/browse/SOLR-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407712#comment-17407712
]
Chris M. Hostetter commented on SOLR-15602:
---
{{testDocker}} isn't happy ... but
[
https://issues.apache.org/jira/browse/SOLR-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-15602:
--
Attachment: SOLR-15602.testDocker-fixes.patch
Status: Open (was: Open)
attachi
sonatype-lift[bot] commented on a change in pull request #254:
URL: https://github.com/apache/solr/pull/254#discussion_r699714106
##
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##
@@ -828,6 +828,7 @@ void initIndex(boolean passOnPreviousState, boolean reloa
thelabdude commented on pull request #318:
URL: https://github.com/apache/solr-operator/pull/318#issuecomment-909688647
> Would be good to add a changelog entry as well.
>
> Awesome work with the fsnotify stuff. It looks like that is a BSD3
licensed library, so I think you need to in
thelabdude commented on a change in pull request #318:
URL: https://github.com/apache/solr-operator/pull/318#discussion_r699711318
##
File path: helm/solr-operator/templates/deployment.yaml
##
@@ -64,6 +64,10 @@ spec:
{{- if .Values.mTLS.insecureSkipVerify }}
[
https://issues.apache.org/jira/browse/SOLR-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407702#comment-17407702
]
Chris M. Hostetter commented on SOLR-15610:
---
{quote}Are you just targeting 9.0
thelabdude commented on a change in pull request #318:
URL: https://github.com/apache/solr-operator/pull/318#discussion_r699702285
##
File path: helm/solr-operator/templates/deployment.yaml
##
@@ -64,6 +64,10 @@ spec:
{{- if .Values.mTLS.insecureSkipVerify }}
[
https://issues.apache.org/jira/browse/SOLR-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407698#comment-17407698
]
Jan Høydahl commented on SOLR-15607:
Is the proposal to change the default for indent
[
https://issues.apache.org/jira/browse/SOLR-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407692#comment-17407692
]
Houston Putman commented on SOLR-15610:
---
+1
I think this would be great. Would def
HoustonPutman commented on a change in pull request #312:
URL: https://github.com/apache/solr-operator/pull/312#discussion_r699692536
##
File path: controllers/util/solr_tls_util.go
##
@@ -27,171 +27,217 @@ import (
)
const (
- SolrTlsCertMd5Annotation= "solr.apac
thelabdude commented on a change in pull request #312:
URL: https://github.com/apache/solr-operator/pull/312#discussion_r699691075
##
File path: controllers/util/solr_tls_util.go
##
@@ -27,171 +27,217 @@ import (
)
const (
- SolrTlsCertMd5Annotation= "solr.apache.
HoustonPutman commented on a change in pull request #318:
URL: https://github.com/apache/solr-operator/pull/318#discussion_r699685355
##
File path: helm/solr-operator/templates/deployment.yaml
##
@@ -64,6 +64,10 @@ spec:
{{- if .Values.mTLS.insecureSkipVerify }}
thelabdude commented on a change in pull request #312:
URL: https://github.com/apache/solr-operator/pull/312#discussion_r699690548
##
File path: controllers/solrprometheusexporter_controller.go
##
@@ -434,53 +458,133 @@ func (r *SolrPrometheusExporterReconciler)
buildSecretWat
thelabdude commented on a change in pull request #312:
URL: https://github.com/apache/solr-operator/pull/312#discussion_r699689067
##
File path: controllers/solrcloud_controller.go
##
@@ -960,80 +950,160 @@ func (r *SolrCloudReconciler)
indexAndWatchForTLSSecret(mgr ctrl.Manag
[
https://issues.apache.org/jira/browse/SOLR-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407666#comment-17407666
]
Chris M. Hostetter commented on SOLR-15610:
---
The crux of this change would simp
Chris M. Hostetter created SOLR-15610:
-
Summary: Support json formatted logging via conf: add
log4j-layout-template-json to 'server'
Key: SOLR-15610
URL: https://issues.apache.org/jira/browse/SOLR-15610
HoustonPutman commented on a change in pull request #312:
URL: https://github.com/apache/solr-operator/pull/312#discussion_r699669943
##
File path: controllers/solrcloud_controller.go
##
@@ -960,80 +950,160 @@ func (r *SolrCloudReconciler)
indexAndWatchForTLSSecret(mgr ctrl.Ma
thelabdude opened a new pull request #318:
URL: https://github.com/apache/solr-operator/pull/318
Fixes #317
Use `fsnotify` to watch the mTLS `tls.crt` file (mounted from a secret) to
hot reload the certificate for the Http client used to make calls to Solr.
For files loaded f
sonatype-lift[bot] commented on a change in pull request #254:
URL: https://github.com/apache/solr/pull/254#discussion_r699665335
##
File path: solr/benchmark/src/java/org/apache/solr/bench/BaseBenchState.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundati
[
https://issues.apache.org/jira/browse/SOLR-15609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-15609:
--
Attachment: SOLR-15609.patch
SOLR-15609.8x.patch
Status: Open (
Chris M. Hostetter created SOLR-15609:
-
Summary: Upgrade log4j -> 2.14.1
Key: SOLR-15609
URL: https://issues.apache.org/jira/browse/SOLR-15609
Project: Solr
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SOLR-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407620#comment-17407620
]
David Eric Pugh commented on SOLR-15607:
One thought I had, what if we make in
[
https://issues.apache.org/jira/browse/SOLR-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407619#comment-17407619
]
David Eric Pugh commented on SOLR-15607:
Thanks [~janhoy] for the feedback. Th
dweiss commented on a change in pull request #275:
URL: https://github.com/apache/solr/pull/275#discussion_r699614087
##
File path: gradle/java/jar-manifest.gradle
##
@@ -61,8 +61,9 @@ subprojects {
"Specification-Version" : project.baseVersion,
dweiss commented on a change in pull request #275:
URL: https://github.com/apache/solr/pull/275#discussion_r699608834
##
File path: gradle/java/jar-manifest.gradle
##
@@ -61,8 +61,9 @@ subprojects {
"Specification-Version" : project.baseVersion,
dweiss commented on a change in pull request #275:
URL: https://github.com/apache/solr/pull/275#discussion_r699607305
##
File path: gradle/generation/local-settings.gradle
##
@@ -35,26 +35,48 @@ configure(rootProject) {
def testsJvms = (int) Math.max(1d, Math.min(cpus
[
https://issues.apache.org/jira/browse/SOLR-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407611#comment-17407611
]
Jan Høydahl commented on SOLR-15607:
The general URL behavior for this page is that t
dweiss commented on a change in pull request #275:
URL: https://github.com/apache/solr/pull/275#discussion_r699603869
##
File path: gradle/generation/javacc.gradle
##
@@ -129,17 +115,33 @@ configure(project(":solr:core")) {
// We always regenerate, no need to declare outputs
dweiss commented on a change in pull request #275:
URL: https://github.com/apache/solr/pull/275#discussion_r699602425
##
File path: build.gradle
##
@@ -183,6 +184,7 @@ apply from: file('gradle/hacks/solr.findbugs.gradle')
apply from: file('gradle/hacks/wipe-temp.gradle')
appl
[
https://issues.apache.org/jira/browse/SOLR-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407589#comment-17407589
]
David Eric Pugh commented on SOLR-15607:
This looks great to me. The one change
[
https://issues.apache.org/jira/browse/SOLR-15599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-15599.
---
Fix Version/s: 8.10
Resolution: Done
> Upgrade AWS SDK from v1 to v2 for the S3 Reposi
[
https://issues.apache.org/jira/browse/SOLR-15599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407578#comment-17407578
]
ASF subversion and git services commented on SOLR-15599:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-15608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-15608:
-
Parent: SOLR-13138
Issue Type: Sub-task (was: Task)
> Remove deprecated CloudSolrClient.Builder(
[
https://issues.apache.org/jira/browse/SOLR-15599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407550#comment-17407550
]
ASF subversion and git services commented on SOLR-15599:
Commit b
Mike Drob created SOLR-15608:
Summary: Remove deprecated CloudSolrClient.Builder() constructor
Key: SOLR-15608
URL: https://issues.apache.org/jira/browse/SOLR-15608
Project: Solr
Issue Type: Task
markrmiller commented on pull request #254:
URL: https://github.com/apache/solr/pull/254#issuecomment-909438956
@madrob updated pr, not merged up to master this time yet as the last time
that bit me.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/SOLR-15600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407515#comment-17407515
]
Jan Høydahl commented on SOLR-15600:
[~dsmiley], please read the email to private
([
cpoerschke commented on pull request #276:
URL: https://github.com/apache/solr/pull/276#issuecomment-909377241
> Does this need a CHANGES entry?
Good question. Yeah, might as well have one, no harm in having one.
--
This is an automated message from the Apache Git Service.
To respo
[
https://issues.apache.org/jira/browse/SOLR-15600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407496#comment-17407496
]
David Smiley commented on SOLR-15600:
-
Yes. Maybe we should first solicit our commun
madrob commented on a change in pull request #275:
URL: https://github.com/apache/solr/pull/275#discussion_r699392924
##
File path: build.gradle
##
@@ -20,15 +20,15 @@ import java.time.format.DateTimeFormatter
plugins {
id "base"
- id "com.palantir.consistent-versions" v
janhoy opened a new pull request #38:
URL: https://github.com/apache/solr-site/pull/38
Co-authored-by: David Smiley
Co-authored-by: Christine Poerschke
Co-authored-by: Houston Putman
(#36)
--
This is an automated message from the Apache Git Service.
To respond to the message,
thelabdude opened a new issue #317:
URL: https://github.com/apache/solr-operator/issues/317
If Solr has mTLS configured with ClientAuth `Need` the the Solr operator pod
needs a client cert that Solr pods trust. We added support for loading said
cert from a secret in v0.3.0, see (#256). The
janhoy merged pull request #38:
URL: https://github.com/apache/solr-site/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
madrob closed pull request #273:
URL: https://github.com/apache/solr/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
[
https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407461#comment-17407461
]
ASF subversion and git services commented on SOLR-13209:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407458#comment-17407458
]
ASF subversion and git services commented on SOLR-13209:
Commit 2
spyk commented on a change in pull request #242:
URL: https://github.com/apache/solr/pull/242#discussion_r698497679
##
File path:
solr/contrib/ltr/src/java/org/apache/solr/ltr/model/MultipleAdditiveTreesModel.java
##
@@ -292,10 +291,10 @@ private static float scoreNode(float[]
thelabdude commented on a change in pull request #312:
URL: https://github.com/apache/solr-operator/pull/312#discussion_r698804396
##
File path: controllers/controller_utils_test.go
##
@@ -184,46 +182,6 @@ func expectDeployment(t *testing.T, g *gomega.GomegaWithT,
requests cha
[
https://issues.apache.org/jira/browse/SOLR-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-13209.
--
Fix Version/s: 8.10
main (9.0)
Resolution: Fixed
Thanks to everybody that wor
janhoy merged pull request #24:
URL: https://github.com/apache/solr/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sol
janhoy merged pull request #36:
URL: https://github.com/apache/solr-site/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
HoustonPutman closed issue #223:
URL: https://github.com/apache/solr-operator/issues/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
HoustonPutman merged pull request #316:
URL: https://github.com/apache/solr-operator/pull/316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issu
madrob commented on a change in pull request #254:
URL: https://github.com/apache/solr/pull/254#discussion_r698717978
##
File path:
solr/benchmark/src/java/org/apache/solr/bench/generators/StringsDSL.java
##
@@ -0,0 +1,305 @@
+/*
+ * Licensed to the Apache Software Foundation
HoustonPutman commented on issue #223:
URL: https://github.com/apache/solr-operator/issues/223#issuecomment-908658951
Both prerequisites are now in. The v0.4.0 release should solve this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
HoustonPutman merged pull request #37:
URL: https://github.com/apache/solr-site/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
dweiss commented on a change in pull request #277:
URL: https://github.com/apache/solr/pull/277#discussion_r698541218
##
File path: build.gradle
##
@@ -20,7 +20,7 @@ import java.time.format.DateTimeFormatter
plugins {
id "base"
- id "com.palantir.consistent-versions" ver
HoustonPutman merged pull request #311:
URL: https://github.com/apache/solr-operator/pull/311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issu
HoustonPutman commented on a change in pull request #248:
URL: https://github.com/apache/solr/pull/248#discussion_r698537736
##
File path:
solr/core/src/java/org/apache/solr/search/grouping/CommandHandler.java
##
@@ -216,6 +225,9 @@ private void searchWithTimeLimiter(Query que
HoustonPutman merged pull request #271:
URL: https://github.com/apache/solr/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubs
HoustonPutman closed issue #290:
URL: https://github.com/apache/solr-operator/issues/290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-un
alextu commented on a change in pull request #277:
URL: https://github.com/apache/solr/pull/277#discussion_r698578438
##
File path: build.gradle
##
@@ -20,7 +20,7 @@ import java.time.format.DateTimeFormatter
plugins {
id "base"
- id "com.palantir.consistent-versions" ver
[
https://issues.apache.org/jira/browse/SOLR-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-15111.
Fix Version/s: main (9.0)
Resolution: Fixed
Thanks for the contribution Andras. Too many con
[
https://issues.apache.org/jira/browse/SOLR-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407369#comment-17407369
]
ASF subversion and git services commented on SOLR-15111:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407364#comment-17407364
]
ASF subversion and git services commented on SOLR-15111:
Commit b
janhoy merged pull request #24:
URL: https://github.com/apache/solr/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sol
[
https://issues.apache.org/jira/browse/SOLR-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-15111:
--
Assignee: Jan Høydahl
> Use JDK8 Base64 instead of own implementation
> --
[
https://issues.apache.org/jira/browse/SOLR-15600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407317#comment-17407317
]
Jan Høydahl commented on SOLR-15600:
I like the "submit a PR" suggestion. So that wou
[
https://issues.apache.org/jira/browse/SOLR-15600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407314#comment-17407314
]
Jan Høydahl commented on SOLR-15600:
I merged the PR to staging, see [https://solr.st
janhoy merged pull request #36:
URL: https://github.com/apache/solr-site/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
dweiss commented on a change in pull request #277:
URL: https://github.com/apache/solr/pull/277#discussion_r699189769
##
File path: gradle/generate-defaults.gradle
##
@@ -42,6 +42,7 @@ configure(rootProject) {
"systemProp.file.encoding=UTF-8",
[
https://issues.apache.org/jira/browse/SOLR-15412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407200#comment-17407200
]
Ishan Chattopadhyaya commented on SOLR-15412:
-
I likely won't have time for t
alextu commented on a change in pull request #277:
URL: https://github.com/apache/solr/pull/277#discussion_r699108383
##
File path: gradle/generate-defaults.gradle
##
@@ -42,6 +42,7 @@ configure(rootProject) {
"systemProp.file.encoding=UTF-8",
dweiss commented on a change in pull request #277:
URL: https://github.com/apache/solr/pull/277#discussion_r699061855
##
File path: solr/solr-ref-guide/build.gradle
##
@@ -215,20 +216,21 @@ check.dependsOn checkLocalJavadocLinksSite, checkSite
// Hook site building to assemble
dweiss commented on a change in pull request #277:
URL: https://github.com/apache/solr/pull/277#discussion_r699060499
##
File path: build.gradle
##
@@ -20,7 +20,7 @@ import java.time.format.DateTimeFormatter
plugins {
id "base"
- id "com.palantir.consistent-versions" ver
79 matches
Mail list logo
