noblepaul commented on a change in pull request #160:
URL: https://github.com/apache/solr/pull/160#discussion_r738934725
##
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##
@@ -564,7 +641,7 @@ public HttpCachingConfig getHttpCachingConfig() {
sonatype-lift[bot] commented on a change in pull request #160:
URL: https://github.com/apache/solr/pull/160#discussion_r738934602
##
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##
@@ -168,140 +197,180 @@ public static SolrConfig
noblepaul commented on a change in pull request #160:
URL: https://github.com/apache/solr/pull/160#discussion_r738931310
##
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##
@@ -158,6 +166,27 @@ public static SolrConfig
noblepaul commented on a change in pull request #160:
URL: https://github.com/apache/solr/pull/160#discussion_r738931062
##
File path: solr/core/src/resources/EditableSolrConfigAttributes.json
##
@@ -56,10 +56,6 @@
"enableLazyFieldLoading":1,
markrmiller opened a new pull request #377:
URL: https://github.com/apache/solr/pull/377
The way I had done this depended on other issues, so I did other workarounds
and kept a bunch of individual lingers.
--
This is an automated message from the Apache Git Service.
To respond to the
noblepaul commented on a change in pull request #160:
URL: https://github.com/apache/solr/pull/160#discussion_r738927739
##
File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java
##
@@ -730,12 +730,11 @@ protected void postReadInform() {
* Loads the copy
[
https://issues.apache.org/jira/browse/SOLR-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435677#comment-17435677
]
Roman Voronin commented on SOLR-15635:
--
Thank you! \{score=none} works well. Patch for classic join
HoustonPutman opened a new pull request #359:
URL: https://github.com/apache/solr-operator/pull/359
Resolves #303
Still needs a bit of love, but the bulk of the work should be there.
TODO:
- [ ] Documentation & Changelog entry
- [ ] Cleaning up logic around restarts
mkhludnev commented on pull request #376:
URL: https://github.com/apache/solr/pull/376#issuecomment-954160826
Hi, @dsmiley @NazerkeBS!
You review is quite appreciated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/SOLR-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-15635:
Status: Patch Available (was: Open)
> clearing SolrRequestInfo.clearRequestInfo() twice
mkhludnev opened a new pull request #376:
URL: https://github.com/apache/solr/pull/376
https://issues.apache.org/jira/browse/SOLR-15635
* SOLR-15635: close hooks are invoked twice if SolrRequestInfo cleared
twice.
# Description
User impact: `/export?q={!join
gerlowskija commented on issue #347:
URL: https://github.com/apache/solr-operator/issues/347#issuecomment-954098069
+1 from me:
I think taking it out makes sense - especially if it was primarily a means
of getting backups into S3 (which we now have other options for). The idea of
[
https://issues.apache.org/jira/browse/SOLR-15718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435599#comment-17435599
]
Cassandra Targett commented on SOLR-15718:
--
> However, there may be other reasons to upgrade to
[
https://issues.apache.org/jira/browse/SOLR-15141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435576#comment-17435576
]
David Eric Pugh commented on SOLR-15141:
Does SolrJ need to support both? I use SolrJ so I
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435575#comment-17435575
]
Jan Høydahl commented on SOLR-15730:
Anyone who like refactoring and defining new grade modules and
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435528#comment-17435528
]
Gus Heck commented on SOLR-15730:
-
+1 the size of solrj, and especially the fact that it carries around
[
https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435506#comment-17435506
]
David Smiley commented on SOLR-15215:
-
> Until then, is it possible to mark Netty as an "optional"
[
https://issues.apache.org/jira/browse/SOLR-15718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435493#comment-17435493
]
Jan Høydahl commented on SOLR-15718:
{quote}So if I understand this right then direct rolling
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435479#comment-17435479
]
Jan Høydahl commented on SOLR-15730:
And here is the full list from {{gw -q dependencies
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435475#comment-17435475
]
Jan Høydahl commented on SOLR-15730:
Current SolrJ dependencies:
!Skjermbilde 2021-10-28 kl.
[
https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15730:
---
Attachment: Skjermbilde 2021-10-28 kl. 15.38.40.png
> Modularize SolrJ
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-15722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435463#comment-17435463
]
ASF subversion and git services commented on SOLR-15722:
Commit
noblepaul merged pull request #374:
URL: https://github.com/apache/solr/pull/374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-9459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435455#comment-17435455
]
Jan Høydahl commented on SOLR-9459:
---
As I can see, it is apache-rat that still keeps us on some old
[
https://issues.apache.org/jira/browse/SOLR-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15729:
---
Parent: SOLR-15730
Issue Type: Sub-task (was: Task)
> Mark Netty as optional in SolrJ POM
>
Jan Høydahl created SOLR-15731:
--
Summary: Separate out a solrj-jdbc module
Key: SOLR-15731
URL: https://issues.apache.org/jira/browse/SOLR-15731
Project: Solr
Issue Type: Sub-task
Jan Høydahl created SOLR-15730:
--
Summary: Modularize SolrJ
Key: SOLR-15730
URL: https://issues.apache.org/jira/browse/SOLR-15730
Project: Solr
Issue Type: Task
Security Level: Public
[
https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435446#comment-17435446
]
Jan Høydahl commented on SOLR-15215:
Looking at this again. I think we need an umbrella "Modularize
[
https://issues.apache.org/jira/browse/SOLR-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-15676.
Fix Version/s: 8.11
main (9.0)
Resolution: Fixed
>
[
https://issues.apache.org/jira/browse/SOLR-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435444#comment-17435444
]
ASF subversion and git services commented on SOLR-15676:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435442#comment-17435442
]
ASF subversion and git services commented on SOLR-15676:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435443#comment-17435443
]
ASF subversion and git services commented on SOLR-15676:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435430#comment-17435430
]
ASF subversion and git services commented on SOLR-15676:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435429#comment-17435429
]
ASF subversion and git services commented on SOLR-15676:
Commit
cpoerschke merged pull request #331:
URL: https://github.com/apache/solr/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-15676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435428#comment-17435428
]
ASF subversion and git services commented on SOLR-15676:
Commit
cpoerschke merged pull request #329:
URL: https://github.com/apache/solr/pull/329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15223:
---
Attachment: (was: Skjermbilde 2021-10-28 kl. 15.38.40.png)
> Deprecate HttpSolrClient, mark
[
https://issues.apache.org/jira/browse/SOLR-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15223:
---
Attachment: Skjermbilde 2021-10-28 kl. 15.38.40.png
> Deprecate HttpSolrClient, mark httpcomponents
Jan Høydahl created SOLR-15729:
--
Summary: Mark Netty as optional in SolrJ POM
Key: SOLR-15729
URL: https://issues.apache.org/jira/browse/SOLR-15729
Project: Solr
Issue Type: Task
Security
dsmiley edited a comment on pull request #330:
URL: https://github.com/apache/solr/pull/330#issuecomment-953847165
I just found another today: `org.apache.solr.handler.ContentStreamLoader`.
There is another CSL that is used!
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/SOLR-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-13925.
Resolution: Won't Fix
Closing as won't fix as 9.0 will not have a separate maven build and this is
[
https://issues.apache.org/jira/browse/SOLR-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-11579.
Resolution: Won't Fix
Closing this, as the upcoming 9.0 release will not have duplicate maven
janhoy closed pull request #368:
URL: https://github.com/apache/solr/pull/368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy commented on pull request #368:
URL: https://github.com/apache/solr/pull/368#issuecomment-953847811
Closing, see JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/SOLR-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-15717.
Resolution: Not A Problem
> Fix resource leak due to Files.find
>
dsmiley commented on pull request #330:
URL: https://github.com/apache/solr/pull/330#issuecomment-953847165
I just found another today: `ContentStreamLoader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/SOLR-15728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-15728:
--
Assignee: Jan Høydahl
> Remove dead, unused log rotation code from SolrCLI
>
janhoy opened a new pull request #375:
URL: https://github.com/apache/solr/pull/375
https://issues.apache.org/jira/browse/SOLR-15728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/SOLR-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435404#comment-17435404
]
Jan Høydahl commented on SOLR-15717:
Thinking some more, this isn't really a leak, it is just that
Jan Høydahl created SOLR-15728:
--
Summary: Remove dead, unused log rotation code from SolrCLI
Key: SOLR-15728
URL: https://issues.apache.org/jira/browse/SOLR-15728
Project: Solr
Issue Type: Task
janhoy commented on a change in pull request #371:
URL: https://github.com/apache/solr/pull/371#discussion_r738375211
##
File path:
solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponseSerializer.java
##
@@ -34,42 +33,32 @@
* "Unknown" elements for the Javabin
janhoy commented on a change in pull request #371:
URL: https://github.com/apache/solr/pull/371#discussion_r738370235
##
File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc
##
@@ -181,6 +181,8 @@ The only reason QEC supported the data directory was to
support
dsmiley commented on a change in pull request #372:
URL: https://github.com/apache/solr/pull/372#discussion_r738347507
##
File path:
solr/core/src/java/org/apache/solr/security/PermissionNameProvider.java
##
@@ -48,6 +48,7 @@
SECURITY_EDIT_PERM("security-edit", null),
[
https://issues.apache.org/jira/browse/SOLR-15608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435368#comment-17435368
]
Jan Høydahl commented on SOLR-15608:
I plan to merge this to 'main' tomorrow, so if others want to
janhoy commented on a change in pull request #371:
URL: https://github.com/apache/solr/pull/371#discussion_r738234381
##
File path:
solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponseSerializer.java
##
@@ -34,40 +33,22 @@
* "Unknown" elements for the Javabin
janhoy commented on a change in pull request #371:
URL: https://github.com/apache/solr/pull/371#discussion_r738220950
##
File path:
solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponseSerializer.java
##
@@ -34,40 +33,22 @@
* "Unknown" elements for the Javabin
janhoy commented on a change in pull request #371:
URL: https://github.com/apache/solr/pull/371#discussion_r738208768
##
File path:
solr/core/src/java/org/apache/solr/cloud/OverseerSolrResponseSerializer.java
##
@@ -34,40 +33,22 @@
* "Unknown" elements for the Javabin
[
https://issues.apache.org/jira/browse/SOLR-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435270#comment-17435270
]
Jan Høydahl edited comment on SOLR-13070 at 10/28/21, 9:09 AM:
---
I'm just
[
https://issues.apache.org/jira/browse/SOLR-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435270#comment-17435270
]
Jan Høydahl commented on SOLR-13070:
I'm just saying that it can be broken into two parts. First add
[
https://issues.apache.org/jira/browse/SOLR-15719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-15719.
Fix Version/s: 8.11
main (9.0)
Resolution: Fixed
>
[
https://issues.apache.org/jira/browse/SOLR-15719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435245#comment-17435245
]
ASF subversion and git services commented on SOLR-15719:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435241#comment-17435241
]
ASF subversion and git services commented on SOLR-15719:
Commit
cpoerschke merged pull request #370:
URL: https://github.com/apache/solr/pull/370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
64 matches
Mail list logo