[GitHub] [solr] noblepaul commented on a change in pull request #593: SOLR-15950 Create SOLR_HOME/filestore lazily on first use

2022-02-04 Thread GitBox
noblepaul commented on a change in pull request #593: URL: https://github.com/apache/solr/pull/593#discussion_r800029923 ## File path: solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java ## @@ -572,7 +578,16 @@ private void ensurePackageStoreDir(Path solrHome)

[jira] [Commented] (SOLR-12901) Make UnifiedHighlighter the default

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487424#comment-17487424 ] ASF subversion and git services commented on SOLR-12901: Commit 4

[jira] [Commented] (SOLR-15949) Use Java 17 in docker

2022-02-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487421#comment-17487421 ] David Smiley commented on SOLR-15949: - openjdk:17-slim it is then, I suppose.  Unfort

[jira] [Commented] (SOLR-15587) Replicas end up with base_url as http on client side even if cluster state says https when using the HttpClusterStateProvider

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487384#comment-17487384 ] ASF subversion and git services commented on SOLR-15587: Commit 7

[GitHub] [solr] thelabdude merged pull request #460: SOLR-15587: Don't use the UrlScheme singleton on the client-side

2022-02-04 Thread GitBox
thelabdude merged pull request #460: URL: https://github.com/apache/solr/pull/460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] thelabdude commented on a change in pull request #460: SOLR-15587: Don't use the UrlScheme singleton on the client-side

2022-02-04 Thread GitBox
thelabdude commented on a change in pull request #460: URL: https://github.com/apache/solr/pull/460#discussion_r799910426 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java ## @@ -469,6 +469,7 @@ public boolean split(ClusterState clusterS

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799890106 ## File path: solr/core/src/java/org/apache/solr/search/FunctionRangeQuery.java ## @@ -36,12 +36,11 @@ final ValueSourceRangeFilter rangeFilt; boolean ca

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799890106 ## File path: solr/core/src/java/org/apache/solr/search/FunctionRangeQuery.java ## @@ -36,12 +36,11 @@ final ValueSourceRangeFilter rangeFilt; boolean ca

[GitHub] [solr] janhoy commented on pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-04 Thread GitBox
janhoy commented on pull request #596: URL: https://github.com/apache/solr/pull/596#issuecomment-1030443616 Did a bunch of 8_11 mappings, now there are only 25 pages left without a mapping. Some should point to landing pages which still does not exist in the new guide I think. -- This i

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799884140 ## File path: solr/core/src/test/org/apache/solr/search/TestMainQueryCaching.java ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799882766 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -866,8 +876,48 @@ public BitDocSet getLiveDocSet() throws IOException {

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799881581 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -866,8 +876,48 @@ public BitDocSet getLiveDocSet() throws IOException {

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799880606 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -866,8 +876,48 @@ public BitDocSet getLiveDocSet() throws IOException {

[GitHub] [solr] madrob commented on pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
madrob commented on pull request #592: URL: https://github.com/apache/solr/pull/592#issuecomment-1030383561 Yea, I'm super excited about this, it's starting to look like a pretty nice boost to what we do! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [solr] madrob commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
madrob commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799827730 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -866,8 +876,48 @@ public BitDocSet getLiveDocSet() throws IOException {

[GitHub] [solr] magibney commented on pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
magibney commented on pull request #592: URL: https://github.com/apache/solr/pull/592#issuecomment-1030362953 @madrob thanks very much for the review! I believe I've addressed all the concerns you raised. The only one I feel certain might merit more attention is the question of MatchAllDoc

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799820941 ## File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java ## @@ -89,13 +87,13 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode sc

[jira] [Commented] (SOLR-15983) ClassCastException in UpdateLog$LogReplayer.doReplay

2022-02-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487312#comment-17487312 ] David Smiley commented on SOLR-15983: - Sorry, but UpdateRequestProcessor's are not de

[GitHub] [solr] madrob commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
madrob commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799819737 ## File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java ## @@ -89,13 +87,13 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode sco

[GitHub] [solr] janhoy commented on pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-04 Thread GitBox
janhoy commented on pull request #596: URL: https://github.com/apache/solr/pull/596#issuecomment-1030355421 > I think you deleted the script in your last commit... Yea, moved it into the folder, but forgot to git add it :) Now it's back -- This is an automated message from the Apac

[GitHub] [solr] dsmiley merged pull request #579: SOLR-12901: make hl.method=unified the default

2022-02-04 Thread GitBox
dsmiley merged pull request #579: URL: https://github.com/apache/solr/pull/579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (SOLR-13138) Remove deprecated code prior to 9.0

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487310#comment-17487310 ] ASF subversion and git services commented on SOLR-13138: Commit 1

[jira] [Commented] (SOLR-12901) Make UnifiedHighlighter the default

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487309#comment-17487309 ] ASF subversion and git services commented on SOLR-12901: Commit 1

[GitHub] [solr] dsmiley commented on a change in pull request #589: SOLR-15124: Fix ThreadDumpHandlerTest

2022-02-04 Thread GitBox
dsmiley commented on a change in pull request #589: URL: https://github.com/apache/solr/pull/589#discussion_r799811504 ## File path: solr/core/src/test/org/apache/solr/handler/admin/ThreadDumpHandlerTest.java ## @@ -245,21 +253,18 @@ public void doTestOwnableSync(final boolean

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799808853 ## File path: solr/core/src/java/org/apache/solr/search/FunctionRangeQuery.java ## @@ -36,12 +36,11 @@ final ValueSourceRangeFilter rangeFilt; boolean

[GitHub] [solr-site] uschindler commented on pull request #70: SOLR-15557 Old refguide page redirects

2022-02-04 Thread GitBox
uschindler commented on pull request #70: URL: https://github.com/apache/solr-site/pull/70#issuecomment-1030328423 I figured out: RewriteMap is not allowed in htaccess files. I used them quite often on huge servers before I changed to maps in nginx. -- This is an automated message from

[GitHub] [solr-site] uschindler edited a comment on pull request #70: SOLR-15557 Old refguide page redirects

2022-02-04 Thread GitBox
uschindler edited a comment on pull request #70: URL: https://github.com/apache/solr-site/pull/70#issuecomment-1030325070 For such long redirect maps it might be better to put them into a separate file. Like with email alias tables as known from postfix, a hashmap using a dbm file might be

[GitHub] [solr-site] uschindler commented on pull request #70: SOLR-15557 Old refguide page redirects

2022-02-04 Thread GitBox
uschindler commented on pull request #70: URL: https://github.com/apache/solr-site/pull/70#issuecomment-1030325070 For sich long redirect maps it might be better to put them into a separate file. Like with email values a hashmap using a dbm file might be better. There's also RedirectMap:

[GitHub] [solr] HoustonPutman commented on pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-04 Thread GitBox
HoustonPutman commented on pull request #596: URL: https://github.com/apache/solr/pull/596#issuecomment-1030315882 I think you deleted the script in your last commit... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (SOLR-15973) Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

2022-02-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15973: Resolution: Fixed Status: Resolved (was: Patch Available) Doesn't apply to branch_8_11 - s

[GitHub] [solr] risdenk commented on pull request #591: SOLR-15973: Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

2022-02-04 Thread GitBox
risdenk commented on pull request #591: URL: https://github.com/apache/solr/pull/591#issuecomment-1030299269 @thelabdude this doesn't apply to `branch_8_11` at least not in the current form. The `TestSchemaDesignerConfigSetHelper#testDownloadAndZip` issue was only introduced on `main`. The

[jira] [Commented] (SOLR-15973) Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

2022-02-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487262#comment-17487262 ] Kevin Risden commented on SOLR-15973: - Fixed in 9.0, 9x, main. Need to figure out bac

[jira] [Updated] (SOLR-15973) Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

2022-02-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15973: Fix Version/s: 9.0 > Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows >

[jira] [Commented] (SOLR-15973) Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487261#comment-17487261 ] ASF subversion and git services commented on SOLR-15973: Commit e

[jira] [Commented] (SOLR-15973) Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487260#comment-17487260 ] ASF subversion and git services commented on SOLR-15973: Commit 5

[GitHub] [solr] risdenk closed pull request #591: SOLR-15973: Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

2022-02-04 Thread GitBox
risdenk closed pull request #591: URL: https://github.com/apache/solr/pull/591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [solr] risdenk commented on pull request #591: SOLR-15973: Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

2022-02-04 Thread GitBox
risdenk commented on pull request #591: URL: https://github.com/apache/solr/pull/591#issuecomment-1030282781 Fixed in 0b18725ea29185c6af981943ab1471624f71b260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (SOLR-15973) Fix TestSchemaDesignerConfigSetHelper#testDownloadAndZip failure on Windows

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487259#comment-17487259 ] ASF subversion and git services commented on SOLR-15973: Commit 0

[jira] [Commented] (SOLR-15558) Solr stop doesn't handle zombie processes

2022-02-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487256#comment-17487256 ] Mike Drob commented on SOLR-15558: -- [~cjcowie] - thanks for the patch, I've committed th

[jira] [Resolved] (SOLR-15558) Solr stop doesn't handle zombie processes

2022-02-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15558. -- Fix Version/s: 9.0 8.11.2 Resolution: Fixed > Solr stop doesn't handle zombie

[jira] [Commented] (SOLR-15558) Solr stop doesn't handle zombie processes

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487255#comment-17487255 ] ASF subversion and git services commented on SOLR-15558: Commit a

[jira] [Commented] (SOLR-15558) Solr stop doesn't handle zombie processes

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487253#comment-17487253 ] ASF subversion and git services commented on SOLR-15558: Commit 5

[jira] [Commented] (SOLR-15558) Solr stop doesn't handle zombie processes

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487251#comment-17487251 ] ASF subversion and git services commented on SOLR-15558: Commit c

[jira] [Commented] (SOLR-15558) Solr stop doesn't handle zombie processes

2022-02-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487252#comment-17487252 ] ASF subversion and git services commented on SOLR-15558: Commit 9

[GitHub] [solr] madrob closed pull request #250: SOLR-15558: Identify zombie processes when stopping

2022-02-04 Thread GitBox
madrob closed pull request #250: URL: https://github.com/apache/solr/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #597: SOLR-15983: synchronise LogUpdateProcessor's toLog member use

2022-02-04 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #597: URL: https://github.com/apache/solr/pull/597#discussion_r799742111 ## File path: solr/core/src/java/org/apache/solr/update/processor/LogUpdateProcessorFactory.java ## @@ -108,7 +108,9 @@ public void processAdd(AddU

[GitHub] [solr] betulince commented on pull request #594: SOLR-15853 Solr paramset impl

2022-02-04 Thread GitBox
betulince commented on pull request #594: URL: https://github.com/apache/solr/pull/594#issuecomment-1030255616 Of course, I think it would be useful to ask on the dev list and get everyone's opinion to find the most suitable name. Also, we can change the icon too :-) Eric Pugh *

[jira] [Resolved] (SOLR-15915) Move ref guide away from using jcenter repo

2022-02-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15915. -- Resolution: Not A Problem If we move away from Jekyll to Antora then we don't need to worry about JCent

[jira] [Commented] (SOLR-15983) ClassCastException in UpdateLog$LogReplayer.doReplay

2022-02-04 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487212#comment-17487212 ] Christine Poerschke commented on SOLR-15983: bq. ... keep {{toLog}} as a {{Na

[GitHub] [solr] cpoerschke opened a new pull request #597: SOLR-15983: synchronise LogUpdateProcessor's toLog member use

2022-02-04 Thread GitBox
cpoerschke opened a new pull request #597: URL: https://github.com/apache/solr/pull/597 https://issues.apache.org/jira/browse/SOLR-15983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (SOLR-15983) ClassCastException in UpdateLog$LogReplayer.doReplay

2022-02-04 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487196#comment-17487196 ] Christine Poerschke commented on SOLR-15983: interpretation: * the update pr

[jira] [Created] (SOLR-15983) ClassCastException in UpdateLog$LogReplayer.doReplay

2022-02-04 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-15983: -- Summary: ClassCastException in UpdateLog$LogReplayer.doReplay Key: SOLR-15983 URL: https://issues.apache.org/jira/browse/SOLR-15983 Project: Solr

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799627099 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] janhoy commented on pull request #250: SOLR-15558: Identify zombie processes when stopping

2022-02-04 Thread GitBox
janhoy commented on pull request #250: URL: https://github.com/apache/solr/pull/250#issuecomment-1030139879 Have you run the entire test suite, including `TestSolrCLIRunExample`, which seems to start the example using the bin/solr script and then stop it again... -- This is an automated

[jira] [Comment Edited] (SOLR-15967) Add rpm repo for red hat based distros

2022-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485758#comment-17485758 ] Martin Häcker edited comment on SOLR-15967 at 2/4/22, 4:17 PM:

[jira] [Commented] (SOLR-15558) Solr stop doesn't handle zombie processes

2022-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487155#comment-17487155 ] Jan Høydahl commented on SOLR-15558: As long as this is tested on relevant platforms

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799609711 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799607786 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java ## @@ -229,19 +230,19 @@ public static void createJoinField(FacetRequest.Domain

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799607211 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java ## @@ -287,24 +288,23 @@ public static void createGraphField(FacetRequest.Domain

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799607211 ## File path: solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java ## @@ -287,24 +288,23 @@ public static void createGraphField(FacetRequest.Domain

[jira] [Commented] (SOLR-15558) Solr stop doesn't handle zombie processes

2022-02-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487128#comment-17487128 ] Mike Drob commented on SOLR-15558: -- [~janhoy] - candidate for 9.0 (and 8.11.2 while we'r

[jira] [Assigned] (SOLR-15558) Solr stop doesn't handle zombie processes

2022-02-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob reassigned SOLR-15558: Assignee: Mike Drob > Solr stop doesn't handle zombie processes >

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799561070 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -1405,14 +1446,32 @@ private void getDocListC(QueryResult qr, QueryComman

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799560079 ## File path: solr/core/src/test/org/apache/solr/core/ExitableDirectoryReaderTest.java ## @@ -98,7 +102,15 @@ public void testCacheAssumptions() throws Excep

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799557771 ## File path: solr/core/src/test/org/apache/solr/search/TestMainQueryCaching.java ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799556562 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -1299,6 +1302,41 @@ public DocList getDocList(Query query, List filterLi

[jira] [Resolved] (SOLR-13437) fork noggit code to Solr

2022-02-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-13437. -- Fix Version/s: 8.2 Resolution: Fixed This was fixed in 8.2, resolving the issue. > fork noggit

[GitHub] [solr] madrob commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

2022-02-04 Thread GitBox
madrob commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r799513478 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -1299,6 +1302,41 @@ public DocList getDocList(Query query, List filterList

[GitHub] [solr] epugh edited a comment on pull request #594: SOLR-15853 Solr paramset impl

2022-02-04 Thread GitBox
epugh edited a comment on pull request #594: URL: https://github.com/apache/solr/pull/594#issuecomment-1030043563 This is Super Exciting!I am going to go through and test this, but probably not till Monday. One thing is, I wonder, now that we are exposing this in the UI, I won

[GitHub] [solr] epugh commented on pull request #594: SOLR-15853 Solr paramset impl

2022-02-04 Thread GitBox
epugh commented on pull request #594: URL: https://github.com/apache/solr/pull/594#issuecomment-1030043563 This is Super Exciting!I am going to go through and test this, but probably not till Monday. One thing is, I wonder, now that we are exposing this in the UI, I wonder if

[GitHub] [solr] madrob commented on a change in pull request #529: SOLR-12336 Remove Filter from Solr

2022-02-04 Thread GitBox
madrob commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r799502566 ## File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java ## @@ -89,13 +87,13 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode sco

[jira] [Commented] (SOLR-15982) Add endTime value to the backup result

2022-02-04 Thread Artem Abeleshev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487091#comment-17487091 ] Artem Abeleshev commented on SOLR-15982: https://github.com/apache/solr/pull/595

[jira] [Commented] (SOLR-15557) Figure out how to handle ref guide page renames/redirects

2022-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487089#comment-17487089 ] Jan Høydahl commented on SOLR-15557: See [solr-site PR #70|https://github.com/apache/

[jira] [Comment Edited] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487085#comment-17487085 ] Jan Høydahl edited comment on SOLR-15556 at 2/4/22, 1:54 PM: -

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487085#comment-17487085 ] Jan Høydahl commented on SOLR-15556: I took a shot at SOLR-15557, generating redirect

[GitHub] [solr] janhoy opened a new pull request #596: SOLR-15557 Script to generate refguide page .htaccess redirects

2022-02-04 Thread GitBox
janhoy opened a new pull request #596: URL: https://github.com/apache/solr/pull/596 https://issues.apache.org/jira/browse/SOLR-15557 See https://github.com/apache/solr-site/pull/70 for the output of this script given the input files as of today -- This is an automated message

[GitHub] [solr] ackepenek commented on a change in pull request #594: SOLR-15853 Solr paramset impl

2022-02-04 Thread GitBox
ackepenek commented on a change in pull request #594: URL: https://github.com/apache/solr/pull/594#discussion_r799464952 ## File path: solr/webapp/web/partials/query.html ## @@ -23,6 +23,18 @@ + +Choose Paramset to Apply +

[GitHub] [solr] ackepenek commented on a change in pull request #594: SOLR-15853 Solr paramset impl

2022-02-04 Thread GitBox
ackepenek commented on a change in pull request #594: URL: https://github.com/apache/solr/pull/594#discussion_r799454017 ## File path: solr/webapp/web/js/angular/controllers/paramsets.js ## @@ -0,0 +1,88 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [solr] ijioio commented on pull request #595: Add end time value to backup response

2022-02-04 Thread GitBox
ijioio commented on pull request #595: URL: https://github.com/apache/solr/pull/595#issuecomment-1029979243 This is an example of response containing `endTime` field: ```json { "responseHeader": { "status": 0, "QTime": 1 }, "success": {

[GitHub] [solr] ijioio commented on pull request #595: Add end time value to backup response

2022-02-04 Thread GitBox
ijioio commented on pull request #595: URL: https://github.com/apache/solr/pull/595#issuecomment-1029976420 An alternative is to initialize and fill `endTime` value within the `aggregateResults` call, but in that case time spend for downloading/copying config will be not taken into account

[GitHub] [solr] ijioio opened a new pull request #595: Add end time value to backup response

2022-02-04 Thread GitBox
ijioio opened a new pull request #595: URL: https://github.com/apache/solr/pull/595 https://issues.apache.org/jira/browse/SOLR-15982 # Description Adding new field `endTime` to collection backup response (response is actually an aggregated result of responses from multiple nod

[GitHub] [solr] betulince commented on pull request #594: Solr paramset impl

2022-02-04 Thread GitBox
betulince commented on pull request #594: URL: https://github.com/apache/solr/pull/594#issuecomment-1029972852 You can also check this newly added feature from the screenshots I have added. ![Screenshot from 2022-02-04 16-08-15](https://user-images.githubusercontent.com/44343912/152

[GitHub] [solr] betulince opened a new pull request #594: Solr paramset impl

2022-02-04 Thread GitBox
betulince opened a new pull request #594: URL: https://github.com/apache/solr/pull/594 https://issues.apache.org/jira/browse/SOLR-15853 # Description A screen where paramset can be created has been added to the admin tool. You can set a new paramset on this screen and bring th

[jira] [Updated] (SOLR-15982) Add endTime value to the backup result

2022-02-04 Thread Artem Abeleshev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Abeleshev updated SOLR-15982: --- Description: Previously there was a backup size issue solved SOLR-15842. Within the fix an a

[jira] [Updated] (SOLR-15982) Add endTime value to the backup result

2022-02-04 Thread Artem Abeleshev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Abeleshev updated SOLR-15982: --- Description: Previously there was a backup size issue solved SOLR-15842. Within the fix an a

[jira] [Updated] (SOLR-15982) Add endTime value to the backup result

2022-02-04 Thread Artem Abeleshev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Abeleshev updated SOLR-15982: --- Description: Previously there was a backup size issue solved SOLR-15842. Within the fix an a

[jira] [Created] (SOLR-15982) Add endTime value to the backup result

2022-02-04 Thread Artem Abeleshev (Jira)
Artem Abeleshev created SOLR-15982: -- Summary: Add endTime value to the backup result Key: SOLR-15982 URL: https://issues.apache.org/jira/browse/SOLR-15982 Project: Solr Issue Type: Improveme

[jira] [Commented] (SOLR-15557) Figure out how to handle ref guide page renames/redirects

2022-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486943#comment-17486943 ] Jan Høydahl commented on SOLR-15557: Did a first round on this in the PR, assigning r

[GitHub] [solr-site] janhoy opened a new pull request #70: SOLR-15557 Old refguide page redirects

2022-02-04 Thread GitBox
janhoy opened a new pull request #70: URL: https://github.com/apache/solr-site/pull/70 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[jira] [Assigned] (SOLR-15557) Figure out how to handle ref guide page renames/redirects

2022-02-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-15557: -- Assignee: Jan Høydahl > Figure out how to handle ref guide page renames/redirects > --

[GitHub] [solr] colvinco commented on pull request #250: SOLR-15558: Identify zombie processes when stopping

2022-02-04 Thread GitBox
colvinco commented on pull request #250: URL: https://github.com/apache/solr/pull/250#issuecomment-1029795985 Thank you, changes made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] colvinco commented on a change in pull request #250: SOLR-15558: Identify zombie processes when stopping

2022-02-04 Thread GitBox
colvinco commented on a change in pull request #250: URL: https://github.com/apache/solr/pull/250#discussion_r799289796 ## File path: solr/bin/solr ## @@ -884,8 +887,12 @@ function stop_solr() { sleep 10 fi - CHECK_PID=`ps auxww | awk '{print $2}' | grep -w $SOLR_PID

[jira] [Commented] (SOLR-15856) Reproducing test failure for TestRandomDVFaceting

2022-02-04 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486871#comment-17486871 ] Adrien Grand commented on SOLR-15856: - If you are looking for a quick fix that doesn'