[jira] [Updated] (SOLR-16439) Cloud Node does not have Core, the admin UI cannot be displayed properly due to cores.sort

2022-09-29 Thread Shiming Li (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shiming Li updated SOLR-16439: -- Description:   !image-2022-09-30-13-51-56-616.png|width=1153,height=200! was:  

[jira] [Created] (SOLR-16439) Cloud Node does not have Core, the admin UI cannot be displayed properly due to cores.sort

2022-09-29 Thread Shiming Li (Jira)
Shiming Li created SOLR-16439: - Summary: Cloud Node does not have Core, the admin UI cannot be displayed properly due to cores.sort Key: SOLR-16439 URL: https://issues.apache.org/jira/browse/SOLR-16439

[GitHub] [solr] dsmiley commented on pull request #1047: SOLR-16229: Abort requests on exception

2022-09-29 Thread GitBox
dsmiley commented on PR #1047: URL: https://github.com/apache/solr/pull/1047#issuecomment-1263069989 Should this be catching RuntimeException as well so we can capture these too? For example processErrorsAndResponse can throw RemoteSolrException (which subclasses RuntimeException). --

[jira] [Comment Edited] (SOLR-13219) LTR FieldLengthFeature causes NullPointerException with documents that do not have the requested field

2022-09-29 Thread Tomasz Elendt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611273#comment-17611273 ] Tomasz Elendt edited comment on SOLR-13219 at 9/29/22 11:04 PM: I've been

[jira] [Comment Edited] (SOLR-13219) LTR FieldLengthFeature causes NullPointerException with documents that do not have the requested field

2022-09-29 Thread Tomasz Elendt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611273#comment-17611273 ] Tomasz Elendt edited comment on SOLR-13219 at 9/29/22 11:03 PM: I've been

[jira] [Comment Edited] (SOLR-13219) LTR FieldLengthFeature causes NullPointerException with documents that do not have the requested field

2022-09-29 Thread Tomasz Elendt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611273#comment-17611273 ] Tomasz Elendt edited comment on SOLR-13219 at 9/29/22 11:01 PM: I've been

[jira] [Comment Edited] (SOLR-13219) LTR FieldLengthFeature causes NullPointerException with documents that do not have the requested field

2022-09-29 Thread Tomasz Elendt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611273#comment-17611273 ] Tomasz Elendt edited comment on SOLR-13219 at 9/29/22 10:57 PM: I've been

[jira] [Comment Edited] (SOLR-13219) LTR FieldLengthFeature causes NullPointerException with documents that do not have the requested field

2022-09-29 Thread Tomasz Elendt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611273#comment-17611273 ] Tomasz Elendt edited comment on SOLR-13219 at 9/29/22 10:56 PM: I've been

[jira] [Commented] (SOLR-13219) LTR FieldLengthFeature causes NullPointerException with documents that do not have the requested field

2022-09-29 Thread Tomasz Elendt (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611273#comment-17611273 ] Tomasz Elendt commented on SOLR-13219: -- I've been investigating a similar issue, although not in the

[GitHub] [solr] tflobbe commented on a diff in pull request #1046: SOLR-16435: Add Request timeout to Http2SolrClient

2022-09-29 Thread GitBox
tflobbe commented on code in PR #1046: URL: https://github.com/apache/solr/pull/1046#discussion_r984037079 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -519,7 +525,11 @@ private Request makeRequest(SolrRequest solrRequest, String

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1049: SOLR-16392: Refactor and update v2 ADDREPLICAPROP API

2022-09-29 Thread GitBox
sonatype-lift[bot] commented on PR #1049: URL: https://github.com/apache/solr/pull/1049#issuecomment-1262792679 :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-29 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611228#comment-17611228 ] Jason Gerlowski edited comment on SOLR-16347 at 9/29/22 8:32 PM: - Thanks

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1027: Add logs and comments to split workflow

2022-09-29 Thread GitBox
sonatype-lift[bot] commented on PR #1027: URL: https://github.com/apache/solr/pull/1027#issuecomment-1262761446 :warning: **312 God Classes** were detected by Lift in this project. [Visit the Lift web

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-29 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611228#comment-17611228 ] Jason Gerlowski commented on SOLR-16347: Thanks for the vote David! I should probably summarize

[GitHub] [solr] gerlowskija opened a new pull request, #1049: SOLR-16392: Refactor and update v2 ADDREPLICAPROP API

2022-09-29 Thread GitBox
gerlowskija opened a new pull request, #1049: URL: https://github.com/apache/solr/pull/1049 # Description The Solr community is engaged in an ongoing effort to make Solr's v2 API more REST-ful and intuitive for users so that it can eventually serve as a viable v1 replacement. This

[GitHub] [solr] anshumg commented on a diff in pull request #1046: SOLR-16435: Add Request timeout to Http2SolrClient

2022-09-29 Thread GitBox
anshumg commented on code in PR #1046: URL: https://github.com/apache/solr/pull/1046#discussion_r983956769 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -519,7 +525,11 @@ private Request makeRequest(SolrRequest solrRequest, String

[jira] [Commented] (SOLR-16392) Cosmetic, REST-fulness improvements to v2 shard, replica, and replicaprop CRUD APIs

2022-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611213#comment-17611213 ] ASF subversion and git services commented on SOLR-16392: Commit

[GitHub] [solr] gerlowskija merged pull request #1035: SOLR-16392: Support REST-ful path lookup in V2HttpCall

2022-09-29 Thread GitBox
gerlowskija merged PR #1035: URL: https://github.com/apache/solr/pull/1035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] gerlowskija commented on a diff in pull request #1035: SOLR-16392: Support REST-ful path lookup in V2HttpCall

2022-09-29 Thread GitBox
gerlowskija commented on code in PR #1035: URL: https://github.com/apache/solr/pull/1035#discussion_r983949445 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -520,13 +527,14 @@ && shouldAuthorize() HttpServletResponse resp = response;

[GitHub] [solr] tflobbe commented on a diff in pull request #1047: SOLR-16229: Abort requests on exception

2022-09-29 Thread GitBox
tflobbe commented on code in PR #1047: URL: https://github.com/apache/solr/pull/1047#discussion_r983941212 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -451,22 +451,24 @@ public NamedList request(SolrRequest solrRequest, String

[GitHub] [solr] tflobbe commented on a diff in pull request #1047: SOLR-16229: Abort requests on exception

2022-09-29 Thread GitBox
tflobbe commented on code in PR #1047: URL: https://github.com/apache/solr/pull/1047#discussion_r983938498 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -477,6 +479,13 @@ public NamedList request(SolrRequest solrRequest, String

[GitHub] [solr-sandbox] anshumg merged pull request #46: Fix log message printed when mirroring skipped for large doc

2022-09-29 Thread GitBox
anshumg merged PR #46: URL: https://github.com/apache/solr-sandbox/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr-sandbox] gerlowskija opened a new pull request, #46: Fix log message printed when mirroring skipped for large doc

2022-09-29 Thread GitBox
gerlowskija opened a new pull request, #46: URL: https://github.com/apache/solr-sandbox/pull/46 The logging call was missing a needed template argument for the docId. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] dsmiley commented on a diff in pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-09-29 Thread GitBox
dsmiley commented on code in PR #1048: URL: https://github.com/apache/solr/pull/1048#discussion_r983869369 ## solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java: ## @@ -741,16 +766,29 @@ public boolean split(ClusterState clusterState, ZkNodeProps

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-09-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17611155#comment-17611155 ] David Smiley commented on SOLR-16347: - +1 to merge to branch_9x when you wish. > Add JAX-RS

[GitHub] [solr] dsmiley commented on a diff in pull request #1047: SOLR-16229: Abort requests on exception

2022-09-29 Thread GitBox
dsmiley commented on code in PR #1047: URL: https://github.com/apache/solr/pull/1047#discussion_r983854892 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -451,22 +451,24 @@ public NamedList request(SolrRequest solrRequest, String

[GitHub] [solr] dsmiley commented on a diff in pull request #1047: SOLR-16229: Abort requests on exception

2022-09-29 Thread GitBox
dsmiley commented on code in PR #1047: URL: https://github.com/apache/solr/pull/1047#discussion_r983848418 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -477,6 +479,13 @@ public NamedList request(SolrRequest solrRequest, String

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-09-29 Thread GitBox
sonatype-lift[bot] commented on PR #1048: URL: https://github.com/apache/solr/pull/1048#issuecomment-1262489752 :warning: **313 God Classes** were detected by Lift in this project. [Visit the Lift web

[GitHub] [solr-sandbox] anshumg merged pull request #45: Check docSize against max before mirroring

2022-09-29 Thread GitBox
anshumg merged PR #45: URL: https://github.com/apache/solr-sandbox/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1035: SOLR-16392: Support REST-ful path lookup in V2HttpCall

2022-09-29 Thread GitBox
sonatype-lift[bot] commented on code in PR #1035: URL: https://github.com/apache/solr/pull/1035#discussion_r983704304 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -520,13 +527,14 @@ && shouldAuthorize() HttpServletResponse resp = response;

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1035: SOLR-16392: Support REST-ful path lookup in V2HttpCall

2022-09-29 Thread GitBox
sonatype-lift[bot] commented on PR #1035: URL: https://github.com/apache/solr/pull/1035#issuecomment-1262455730 :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web

[GitHub] [solr] madrob commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-09-29 Thread GitBox
madrob commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1262420305 > If so, this is the kind of thing we'd ideally test via Docker; a real integration test Or BATS. https://github.com/apache/solr/blob/main/solr/packaging/test/test_modules.bats#L35

[GitHub] [solr] bruno-roustant commented on a diff in pull request #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-09-29 Thread GitBox
bruno-roustant commented on code in PR #1048: URL: https://github.com/apache/solr/pull/1048#discussion_r983671635 ## solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java: ## @@ -741,16 +766,29 @@ public boolean split(ClusterState clusterState,

[GitHub] [solr] bruno-roustant opened a new pull request, #1048: SOLR-16438: Support optional split.setPreferredLeaders prop in shard split command.

2022-09-29 Thread GitBox
bruno-roustant opened a new pull request, #1048: URL: https://github.com/apache/solr/pull/1048 - Introduce the optional split.setPreferredLeaders prop on CollectionAdminRequest#SplitShard. - Make SplitShardCommand support it and set the preferredLeader property on other replicas of each

[jira] [Updated] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2022-09-29 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-16438: -- Description: Currently, shard split always create a first replica for each sub-shard on the

[jira] [Created] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2022-09-29 Thread Bruno Roustant (Jira)
Bruno Roustant created SOLR-16438: - Summary: Shard split should be able to set preferred leaders on other replicas Key: SOLR-16438 URL: https://issues.apache.org/jira/browse/SOLR-16438 Project: Solr

[GitHub] [solr] dsmiley commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-09-29 Thread GitBox
dsmiley commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1262374558 Is there a test? I'm not insisting; just wondering if you thought about it. I suspect maybe it's because the security manager in tests allows access to CWD (maybe?) but not in a

[jira] [Resolved] (SOLR-16428) IgnoreLargeDocumentsProcessorFactory should have a "permissive" mode

2022-09-29 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-16428. Fix Version/s: 9.2 main (10.0) Resolution: Fixed >

[GitHub] [solr-sandbox] gerlowskija commented on pull request #45: Check docSize against max before mirroring

2022-09-29 Thread GitBox
gerlowskija commented on PR #45: URL: https://github.com/apache/solr-sandbox/pull/45#issuecomment-1262132825 > Does it make more sense to call the param ignoreMirroringError ? I thought about a name like `ignoreMirroringError` but ended up discarding that option because, well, that