[jira] [Commented] (SOLR-15748) Create v2 equivalent of v1 'CLUSTERSTATUS' (or document alternatives)

2022-10-11 Thread Joshua Ouma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616212#comment-17616212 ] Joshua Ouma commented on SOLR-15748: Hi [~gerlowskija] I have thought of two possible

[jira] [Comment Edited] (SOLR-15748) Create v2 equivalent of v1 'CLUSTERSTATUS' (or document alternatives)

2022-10-11 Thread Joshua Ouma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616190#comment-17616190 ] Joshua Ouma edited comment on SOLR-15748 at 10/12/22 5:48 AM: -

[jira] [Comment Edited] (SOLR-15748) Create v2 equivalent of v1 'CLUSTERSTATUS' (or document alternatives)

2022-10-11 Thread Joshua Ouma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616190#comment-17616190 ] Joshua Ouma edited comment on SOLR-15748 at 10/12/22 5:43 AM: -

[jira] [Comment Edited] (SOLR-15748) Create v2 equivalent of v1 'CLUSTERSTATUS' (or document alternatives)

2022-10-11 Thread Joshua Ouma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616190#comment-17616190 ] Joshua Ouma edited comment on SOLR-15748 at 10/12/22 5:26 AM: -

[jira] [Commented] (SOLR-15748) Create v2 equivalent of v1 'CLUSTERSTATUS' (or document alternatives)

2022-10-11 Thread Joshua Ouma (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616190#comment-17616190 ] Joshua Ouma commented on SOLR-15748: I'm thinking  of solving this by creating a Clus

[jira] [Updated] (SOLR-16456) ZkNodeProps to implement MapWriter and ZkDistributedQueue.offer() to support MapWriter

2022-10-11 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-16456: -- Description: 100% of the time we are submitting a JSON payload using {{Utils.toJSON()}} > ZkNodeProps

[jira] [Updated] (SOLR-16456) ZkNodeProps to implement MapWriter and ZkDistributedQueue.offer() to support MapWriter

2022-10-11 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-16456: -- Summary: ZkNodeProps to implement MapWriter and ZkDistributedQueue.offer() to support MapWriter (was:

[jira] [Updated] (SOLR-16388) Add OpenAPI annotations to v2 "per-core" APIs

2022-10-11 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-16388: Labels: newdev (was: ) > Add OpenAPI annotations to v2 "per-core" APIs > -

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275292151 integration test is actually working - see failure in https://github.com/apache/solr/pull/1066 and this PR here builds on https://github.com/apache/solr/pull/1066 and fixes it -- This is

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275291936 test failure is expected - is resolved by https://github.com/apache/solr/pull/1044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275291318 @dsmiley @janhoy @HoustonPutman - can you please double check my `solr/docker/templates/Dockerfile.body.template` changes? it looks good to me and shouldn't be an issue w/ backwards compat.

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275281453 `SOLR_SERVER_DIR="/opt/solr-${SOLR_VERSION}/server" \` added to handle Jetty home looking at canonical path -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275281158 `SOLR_SERVER_DIR="/opt/solr-${SOLR_VERSION}/server" \` added to handle Jetty home looking at canonical path -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275260913 > I remember rubbing into this with @markrmiller i think we left a comment in the security policy about it? don't see a comment in there. but the issue is `/opt/solr` vs `/opt/solr-10

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992765842 ## solr/solrj/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java: ## @@ -100,10 +100,11 @@ public synchronized CloudSolrClient getCloudSolrClient(String zkHost)

[GitHub] [solr] madrob commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
madrob commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275258741 I remember rubbing into this with @markrmiller i think we left a comment in the security policy about it? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275220386 Error running locally `./gradlew -p solr/docker testDocker`: ``` java.security.AccessControlException: access denied ("java.io.FilePermission" "/opt/solr-10.0.0-SNAPSHOT/server/star

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275219606 Error running locally `./gradlew -p solr/docker testDocker`: ``` java.security.AccessControlException: access denied ("java.io.FilePermission" "/opt/solr-10.0.0-SNAPSHOT/server/star

[jira] [Updated] (SOLR-16458) Cosmetic, REST-fulness improvements to v2 node APIs

2022-10-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16458: --- Description: As mentioned on SOLR-15781, the v2 API currently has an experimental designatio

[jira] [Created] (SOLR-16458) Cosmetic, REST-fulness improvements to v2 node APIs

2022-10-11 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-16458: -- Summary: Cosmetic, REST-fulness improvements to v2 node APIs Key: SOLR-16458 URL: https://issues.apache.org/jira/browse/SOLR-16458 Project: Solr Issue Ty

[GitHub] [solr] epugh commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
epugh commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992714597 ## solr/solrj/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java: ## @@ -100,10 +100,11 @@ public synchronized CloudSolrClient getCloudSolrClient(String zkHost) {

[jira] [Updated] (SOLR-16391) Cosmetic, REST-fulness improvements to v2 collection+core CRUD and status APIs

2022-10-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16391: --- Summary: Cosmetic, REST-fulness improvements to v2 collection+core CRUD and status APIs (was

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1067: SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI

2022-10-11 Thread GitBox
sonatype-lift[bot] commented on PR #1067: URL: https://github.com/apache/solr/pull/1067#issuecomment-1275156820 :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GF44DHTGJHP3YTJV80G35B

[GitHub] [solr] jeanielamwh commented on a diff in pull request #1067: SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI

2022-10-11 Thread GitBox
jeanielamwh commented on code in PR #1067: URL: https://github.com/apache/solr/pull/1067#discussion_r992652919 ## solr/webapp/web/js/angular/controllers/query.js: ## @@ -169,6 +169,9 @@ solrAdminApp.controller('QueryController', purgeParams(params, ["q.alt", "qf", "mm", "

[jira] [Updated] (SOLR-16390) Cosmetic, REST-fulness improvements to v2 cluster and clusterprop APIs

2022-10-11 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16390: --- Description: As mentioned on SOLR-15781, the v2 API currently has an experimental designatio

[GitHub] [solr] epugh commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
epugh commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992649981 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -309,11 +309,10 @@ public static T assertResponseValues( public static void uploadKey

[GitHub] [solr] jeanielamwh closed pull request #768: Add hl.queryFieldPattern input to Admin UI

2022-10-11 Thread GitBox
jeanielamwh closed pull request #768: Add hl.queryFieldPattern input to Admin UI URL: https://github.com/apache/solr/pull/768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [solr] jeanielamwh commented on pull request #768: Add hl.queryFieldPattern input to Admin UI

2022-10-11 Thread GitBox
jeanielamwh commented on PR #768: URL: https://github.com/apache/solr/pull/768#issuecomment-1275098304 Closed in favor of #1067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [solr] dsmiley commented on pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
dsmiley commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1275097753 BTW, there are *other* needlessly specific declarations of SolrClient subclasses as well. I can see this PR focuses on HttpSolrClient. Maybe you'll do others (like Http2SolrClient etc.) in

[GitHub] [solr] jeanielamwh opened a new pull request, #1067: SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI

2022-10-11 Thread GitBox
jeanielamwh opened a new pull request, #1067: URL: https://github.com/apache/solr/pull/1067 https://issues.apache.org/jira/browse/SOLR-16409 # Description Expose all highlighting parameters in the Query UI * Show all common highlighting parameters * Include an

[GitHub] [solr] epugh commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
epugh commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992644882 ## solr/core/src/test/org/apache/solr/TestDistributedSearch.java: ## @@ -1711,7 +1710,7 @@ public void test() throws Exception { tdate_b, "stats.calcdis

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275090735 The docker test failure gave no details :) ``` 2022-10-11T17:27:59.2856817Z > Task :solr:docker:dockerBuild UP-TO-DATE 2022-10-11T17:28:01.2858986Z 2022-10-11T17:28:01.2860970

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992642897 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -309,11 +309,10 @@ public static T assertResponseValues( public static void uploadK

[GitHub] [solr] epugh commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
epugh commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992641891 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -309,11 +309,10 @@ public static T assertResponseValues( public static void uploadKey

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275087180 I'm planning to merge this with https://github.com/apache/solr/pull/1044 since without the changes from https://github.com/apache/solr/pull/1044 - this PR will fail by itself. -- This is

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
sonatype-lift[bot] commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275087332 :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GF40VHYEAVFQES70JG7Y8P

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
sonatype-lift[bot] commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275052935 :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GF3Z916QHNYQFBA3KCE29P

[GitHub] [solr] risdenk commented on pull request #1039: SOLR-16427: Evaluate and fix errorprone rules - part 2

2022-10-11 Thread GitBox
risdenk commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1275052269 > It'd help reviewing if you did the work in separate commits. That way I could look at the commits and maybe review some commits of interest to me. > For example inlining deprecated metho

[jira] [Comment Edited] (SOLR-16305) MODIFYCOLLECTION with 'property.*' changes can't change values used in config file variables (even though they can be set during collection CREATE)

2022-10-11 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615992#comment-17615992 ] Chris M. Hostetter edited comment on SOLR-16305 at 10/11/22 5:34 PM: --

[jira] [Comment Edited] (SOLR-16305) MODIFYCOLLECTION with 'property.*' changes can't change values used in config file variables (even though they can be set during collection CREATE)

2022-10-11 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615992#comment-17615992 ] Chris M. Hostetter edited comment on SOLR-16305 at 10/11/22 5:32 PM: --

[jira] [Commented] (SOLR-16305) MODIFYCOLLECTION with 'property.*' changes can't change values used in config file variables (even though they can be set during collection CREATE)

2022-10-11 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615992#comment-17615992 ] Chris M. Hostetter commented on SOLR-16305: --- {quote}AFAIK the propagation of `p

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992564452 ## solr/core/src/test/org/apache/solr/filestore/TestDistribPackageStore.java: ## @@ -309,11 +309,10 @@ public static T assertResponseValues( public static void uploadK

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16457: Affects Version/s: (was: 9.1) > solr.data.home should not be set to empty string in bin/solr >

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1275021455 Thanks @dsmiley and @madrob for prompting for an integration test. My fix didn't work and was found by integration tests after fixing the security policy. I'm pushing up a change soon buildi

[GitHub] [solr] joshgog commented on a diff in pull request #1064: SOLR-11657: Added @Deprecated annotation

2022-10-11 Thread GitBox
joshgog commented on code in PR #1064: URL: https://github.com/apache/solr/pull/1064#discussion_r992573990 ## solr/solrj/src/java/org/apache/solr/common/util/ContentStream.java: ## @@ -19,10 +19,13 @@ import java.io.IOException; import java.io.InputStream; import java.io.Read

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16457: Description: solr.data.home should not be set to empty string in bin/solr since that causes the se

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16457: Summary: solr.data.home should not be set to empty string in bin/solr (was: solr.data.home should

[GitHub] [solr-sandbox] gerlowskija merged pull request #49: Redact properties before string-ifying or logging

2022-10-11 Thread GitBox
gerlowskija merged PR #49: URL: https://github.com/apache/solr-sandbox/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string

2022-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16457: Status: Patch Available (was: Open) > solr.data.home should not be set to empty string > -

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274992957 Created https://issues.apache.org/jira/browse/SOLR-16457 and https://github.com/apache/solr/pull/1066 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [solr] risdenk opened a new pull request, #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk opened a new pull request, #1066: URL: https://github.com/apache/solr/pull/1066 https://issues.apache.org/jira/browse/SOLR-16457 TODO - check solr.cmd to see if it has the same issue. This was found while looking at https://github.com/apache/solr/pull/1044 -- This is

[jira] [Created] (SOLR-16457) solr.data.home should not be set to empty string

2022-10-11 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-16457: --- Summary: solr.data.home should not be set to empty string Key: SOLR-16457 URL: https://issues.apache.org/jira/browse/SOLR-16457 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string

2022-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16457: Fix Version/s: 9.1 > solr.data.home should not be set to empty string > ---

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string

2022-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16457: Priority: Blocker (was: Major) > solr.data.home should not be set to empty string > --

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274972996 > So solr.data.home needs to be set or we need to figure out how to unset it completely to ensure that the security policy doesn't think "" is ok. I think I found the bug in `bin/solr`

[jira] [Commented] (SOLR-16305) MODIFYCOLLECTION with 'property.*' changes can't change values used in config file variables (even though they can be set during collection CREATE)

2022-10-11 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615955#comment-17615955 ] Andrzej Bialecki commented on SOLR-16305: - AFAIK the propagation of `property.*`

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274956428 wow so I tracked this down to a potentially really ugly security policy bug... https://github.com/apache/solr/blob/main/solr/server/etc/security.policy#L199 ``` permission ja

[jira] [Commented] (SOLR-16440) Sporadic test failures with PRS

2022-10-11 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615941#comment-17615941 ] Ishan Chattopadhyaya commented on SOLR-16440: - ```ishan@x1extreme ~/code/solr

[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
dsmiley commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992533454 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java: ## @@ -2747,7 +2747,7 @@ protected void waitForAllWarmingSearchers() throws Inter

[jira] [Comment Edited] (SOLR-16440) Sporadic test failures with PRS

2022-10-11 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615941#comment-17615941 ] Ishan Chattopadhyaya edited comment on SOLR-16440 at 10/11/22 4:15 PM:

[jira] [Commented] (SOLR-16392) Cosmetic, REST-fulness improvements to v2 shard, replica, and replicaprop CRUD APIs

2022-10-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615930#comment-17615930 ] ASF subversion and git services commented on SOLR-16392: Commit e

[GitHub] [solr] gerlowskija merged pull request #1065: SOLR-16392: Minor CollectionsHandler cleanup

2022-10-11 Thread GitBox
gerlowskija merged PR #1065: URL: https://github.com/apache/solr/pull/1065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[GitHub] [solr] joshgog commented on pull request #1064: SOLR-11657: Added @Deprecated annotation

2022-10-11 Thread GitBox
joshgog commented on PR #1064: URL: https://github.com/apache/solr/pull/1064#issuecomment-1274896964 > @joshgog I added this to the changes file, how do you want to be credited? I'm OK with` (Joshua Ouma via Eric Pugh)` -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (SOLR-8803) OOM killer for Windows

2022-10-11 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-8803: --- Status: Patch Available (was: Patch Available) Updated patch, I hope the final draft.  Now includes C

[GitHub] [solr-sandbox] gerlowskija opened a new pull request, #49: Redact properties before string-ifying or logging

2022-10-11 Thread GitBox
gerlowskija opened a new pull request, #49: URL: https://github.com/apache/solr-sandbox/pull/49 Prior to this commit, certain log messages during Producer/Consumer startup contained potentially sensitive information, such as SSL passwords, etc. This commit amends the string-ification

[GitHub] [solr] epugh commented on pull request #1064: SOLR-11657: Added @Deprecated annotation

2022-10-11 Thread GitBox
epugh commented on PR #1064: URL: https://github.com/apache/solr/pull/1064#issuecomment-1274846877 @joshgog I added this to the changes file, how do you want to be credited? @dsmiley can you review? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274833300 I don't know how to test this w/ BATS - since we have mixed security policies in build dirs :/ I don't know which security policy rule is allowing this to work in the tests. I would guess in

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1065: SOLR-16392: Minor CollectionsHandler cleanup

2022-10-11 Thread GitBox
sonatype-lift[bot] commented on PR #1065: URL: https://github.com/apache/solr/pull/1065#issuecomment-1274815855 :warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GF3N26Q844E15AF1AWRH9T

[GitHub] [solr] gerlowskija commented on pull request #1065: SOLR-16392: Minor CollectionsHandler cleanup

2022-10-11 Thread GitBox
gerlowskija commented on PR #1065: URL: https://github.com/apache/solr/pull/1065#issuecomment-1274797954 Still waiting on some tests running locally, but will merge when those finish up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [solr-sandbox] gerlowskija merged pull request #48: Check batch-size against "max" before mirroring

2022-10-11 Thread GitBox
gerlowskija merged PR #48: URL: https://github.com/apache/solr-sandbox/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[GitHub] [solr-sandbox] gerlowskija commented on pull request #48: Check batch-size against "max" before mirroring

2022-10-11 Thread GitBox
gerlowskija commented on PR #48: URL: https://github.com/apache/solr-sandbox/pull/48#issuecomment-1274775794 > I was thinking about checking the size of the Solr request in MURPF.getInstance() and setting a bool to make the URP a no-op at the start but this solution is fine for now.

[GitHub] [solr-sandbox] gerlowskija commented on a diff in pull request #48: Check batch-size against "max" before mirroring

2022-10-11 Thread GitBox
gerlowskija commented on code in PR #48: URL: https://github.com/apache/solr-sandbox/pull/48#discussion_r992391682 ## crossdc-producer/src/test/java/org/apache/solr/crossdc/SolrAndKafkaIntegrationTest.java: ## @@ -245,6 +246,25 @@ public void testMirroringUpdateProcessor() throw

[GitHub] [solr] epugh commented on pull request #1062: Fix documentation irrelevant minor mistake

2022-10-11 Thread GitBox
epugh commented on PR #1062: URL: https://github.com/apache/solr/pull/1062#issuecomment-1274751016 @jebnix want to try and incorporate one of those references into the docs to explain why 31 instead of 32? -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Commented] (SOLR-16440) Sporadic test failures with PRS

2022-10-11 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615833#comment-17615833 ] Ishan Chattopadhyaya commented on SOLR-16440: - There are sporadic situations

[GitHub] [solr] gerlowskija opened a new pull request, #1065: SOLR-16392: Minor CollectionsHandler cleanup

2022-10-11 Thread GitBox
gerlowskija opened a new pull request, #1065: URL: https://github.com/apache/solr/pull/1065 https://issues.apache.org/jira/browse/SOLR-16392 # Description CollectionsHandler.handleRequestBody had an unnecessary switch-case statement that cluttered thing up, instead of leaning o

[GitHub] [solr] risdenk commented on pull request #1044: SOLR-16433: Security Manager prevents Solr SQL from working

2022-10-11 Thread GitBox
risdenk commented on PR #1044: URL: https://github.com/apache/solr/pull/1044#issuecomment-1274710727 Well @madrob thanks for the pointer - weirdly https://github.com/apache/solr/blob/main/solr/packaging/test/test_modules.bats#L35 doesn't fail. I would expect it to :( I'll keep digging.

[jira] [Commented] (SOLR-16433) Security Manager prevents Solr SQL from working

2022-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615811#comment-17615811 ] Kevin Risden commented on SOLR-16433: - Ah yea that might be true. From what I underst

[jira] [Commented] (SOLR-16432) Upgrade the gradle wrapper in the build from 7.2.0 to 7.5.1 or later

2022-10-11 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615808#comment-17615808 ] Kevin Risden commented on SOLR-16432: - {quote}Does gradle not have some mechanism for

[GitHub] [solr] risdenk commented on pull request #1062: Fix documentation irrelevant minor mistake

2022-10-11 Thread GitBox
risdenk commented on PR #1062: URL: https://github.com/apache/solr/pull/1062#issuecomment-1274676990 <32GB so 31GB is correct. Some references as to the why: * https://blog.codecentric.de/35gb-heap-less-32gb-java-jvm-memory-oddities * https://blog.foundev.pro/2021/02/03/heap-size-around

[GitHub] [solr] Stefan4solr commented on pull request #151: SOLR-15437: ReRanking/LTR does not work in combination with custom sort and SolrCloud

2022-10-11 Thread GitBox
Stefan4solr commented on PR #151: URL: https://github.com/apache/solr/pull/151#issuecomment-1274516075 We're also affected by this bug and first of all we're wondering: Is anyone still working on these PRs? Furthermore while the Solution proposed in the PRs 151/171 also covers many c

[GitHub] [solr] joshgog commented on pull request #1064: SOLR-11657: Added @Deprecated annotation

2022-10-11 Thread GitBox
joshgog commented on PR #1064: URL: https://github.com/apache/solr/pull/1064#issuecomment-1274512830 Sure, am working on that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
sonatype-lift[bot] commented on code in PR #1012: URL: https://github.com/apache/solr/pull/1012#discussion_r992155605 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java: ## @@ -2747,7 +2747,7 @@ protected void waitForAllWarmingSearchers() th

[GitHub] [solr] epugh commented on pull request #1062: Fix documentation irrelevant minor mistake

2022-10-11 Thread GitBox
epugh commented on PR #1062: URL: https://github.com/apache/solr/pull/1062#issuecomment-1274463463 If 31 is an intentional choice, maybe clarifying that in the ref guide? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] epugh commented on pull request #1062: Fix documentation irrelevant minor mistake

2022-10-11 Thread GitBox
epugh commented on PR #1062: URL: https://github.com/apache/solr/pull/1062#issuecomment-1274463032 At first glance this fix makes sense... HOwever, am wondering if maybe the choice of *31* is an intentional thing?I.e, use 31 to avoid the 32 thing? Any thoughts @risdenk or @elyograg

[GitHub] [solr] epugh commented on pull request #1063: Fix typo in the the Ulimit Settings section

2022-10-11 Thread GitBox
epugh commented on PR #1063: URL: https://github.com/apache/solr/pull/1063#issuecomment-1274458238 Thank @jebnix for this documentation fix. Feel free to tag me on ref guide fixes ;-). -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [solr] epugh merged pull request #1063: Fix typo in the the Ulimit Settings section

2022-10-11 Thread GitBox
epugh merged PR #1063: URL: https://github.com/apache/solr/pull/1063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] epugh commented on pull request #1050: SOLR-16439: Cloud Node does not have Core, the admin UI cannot be displayed properly

2022-10-11 Thread GitBox
epugh commented on PR #1050: URL: https://github.com/apache/solr/pull/1050#issuecomment-1274456012 This all makes sense to me... @cpoerschke do you want to merge this one? Or I can.. ;-). I never could duplicate it, but it *seems* good! -- This is an automated message from the Apache

[GitHub] [solr] epugh commented on pull request #1064: SOLR-11657: Added @Deprecated annotation

2022-10-11 Thread GitBox
epugh commented on PR #1064: URL: https://github.com/apache/solr/pull/1064#issuecomment-1274446126 Can you reformat this to indicate what people *should* use instead?I searched for `@deprecated` and found a bunch of examples in the source like. See how nice the Javadocs are to cue you

[GitHub] [solr] epugh commented on pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

2022-10-11 Thread GitBox
epugh commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1274436928 @dsmiley I think I am done! Only had to touch 105 files ;-). I have a list of improvements I'd like to make, but those can be for follow up PR's... -- This is an automated message from t

[jira] [Created] (SOLR-16456) ZkNodeProps to implement MapWriter and ZkDistributedQueue to support MapWriter

2022-10-11 Thread Noble Paul (Jira)
Noble Paul created SOLR-16456: - Summary: ZkNodeProps to implement MapWriter and ZkDistributedQueue to support MapWriter Key: SOLR-16456 URL: https://issues.apache.org/jira/browse/SOLR-16456 Project: Solr