[jira] [Commented] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620731#comment-17620731 ] Kevin Risden commented on SOLR-16464: - This just made it into 9.1. Regarding hadoop-auth and

[jira] [Commented] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620725#comment-17620725 ] ASF subversion and git services commented on SOLR-16464: Commit

[jira] [Updated] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16464: Component/s: Hadoop Integration > Upgrade commons-text to 1.10.0 > --

[jira] [Commented] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620724#comment-17620724 ] ASF subversion and git services commented on SOLR-16464: Commit

[jira] [Updated] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16464: Fix Version/s: 9.1 (was: 9.2) > Upgrade commons-text to 1.10.0 >

[jira] [Commented] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620721#comment-17620721 ] Ishan Chattopadhyaya commented on SOLR-16463: - Sure, Jan. Feel free to hold up the release

[jira] [Commented] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620722#comment-17620722 ] ASF subversion and git services commented on SOLR-16464: Commit

[GitHub] [solr] risdenk commented on pull request #1088: SOLR-16473: Fix race condition in shard split when a sub-shard is put in recovery state.

2022-10-19 Thread GitBox
risdenk commented on PR #1088: URL: https://github.com/apache/solr/pull/1088#issuecomment-1284914074 Is this at all related to https://github.com/apache/lucene-solr/pull/1277 and https://issues.apache.org/jira/browse/SOLR-14278 it looks like this is missing a test -- This is an

[GitHub] [solr] risdenk commented on a diff in pull request #1045: SOLR-16420: {!mlt_content}

2022-10-19 Thread GitBox
risdenk commented on code in PR #1045: URL: https://github.com/apache/solr/pull/1045#discussion_r1000113482 ## solr/core/src/test/org/apache/solr/search/mlt/CloudMLTQContentParserTest.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (SOLR-16481) Upgrade Bats to 1.8.0

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620703#comment-17620703 ] ASF subversion and git services commented on SOLR-16481: Commit

[jira] [Updated] (SOLR-16481) Upgrade Bats to 1.8.0

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16481: Fix Version/s: 9.2 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Updated] (SOLR-16481) Upgrade Bats to 1.8.0

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16481: Fix Version/s: main (10.0) > Upgrade Bats to 1.8.0 > - > >

[jira] [Commented] (SOLR-16481) Upgrade Bats to 1.8.0

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620701#comment-17620701 ] ASF subversion and git services commented on SOLR-16481: Commit

[GitHub] [solr] risdenk merged pull request #1091: SOLR-16481: Upgrade Bats to 1.8.0

2022-10-19 Thread GitBox
risdenk merged PR #1091: URL: https://github.com/apache/solr/pull/1091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-16481) Upgrade Bats to 1.8.0

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620699#comment-17620699 ] Kevin Risden commented on SOLR-16481: - PR https://github.com/apache/solr/pull/1091 > Upgrade Bats to

[jira] [Updated] (SOLR-16481) Upgrade Bats to 1.8.0

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16481: Status: Patch Available (was: Open) > Upgrade Bats to 1.8.0 > - > >

[jira] [Updated] (SOLR-16481) Upgrade Bats to 1.8.0

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16481: Priority: Minor (was: Major) > Upgrade Bats to 1.8.0 > - > >

[jira] [Created] (SOLR-16481) Upgrade Bats to 1.8.0

2022-10-19 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-16481: --- Summary: Upgrade Bats to 1.8.0 Key: SOLR-16481 URL: https://issues.apache.org/jira/browse/SOLR-16481 Project: Solr Issue Type: Task Security Level:

[GitHub] [solr] patsonluk opened a new pull request, #1095: SOLR-16478 : Further changes to avoid PRS entry writes from overseer

2022-10-19 Thread GitBox
patsonluk opened a new pull request, #1095: URL: https://github.com/apache/solr/pull/1095 https://issues.apache.org/jira/browse/SOLR-16478 # Description For further improvements based on https://issues.apache.org/jira/browse/SOLR-16414, there are places that we should remove

[jira] [Commented] (SOLR-16456) ZkNodeProps to implement MapWriter and ZkDistributedQueue.offer() to support MapWriter

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620681#comment-17620681 ] ASF subversion and git services commented on SOLR-16456: Commit

[jira] [Assigned] (SOLR-16456) ZkNodeProps to implement MapWriter and ZkDistributedQueue.offer() to support MapWriter

2022-10-19 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-16456: - Assignee: Noble Paul > ZkNodeProps to implement MapWriter and ZkDistributedQueue.offer() to

[jira] [Commented] (SOLR-16456) ZkNodeProps to implement MapWriter and ZkDistributedQueue.offer() to support MapWriter

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620680#comment-17620680 ] ASF subversion and git services commented on SOLR-16456: Commit

[GitHub] [solr] noblepaul merged pull request #1072: SOLR-16456: ZkNodeProps to implement MapWriter and DistributedQueue support MapWriter

2022-10-19 Thread GitBox
noblepaul merged PR #1072: URL: https://github.com/apache/solr/pull/1072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-16452) Keep prs state of latest version

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620649#comment-17620649 ] ASF subversion and git services commented on SOLR-16452: Commit

[jira] [Commented] (SOLR-16452) Keep prs state of latest version

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620648#comment-17620648 ] ASF subversion and git services commented on SOLR-16452: Commit

[jira] [Commented] (SOLR-16452) Keep prs state of latest version

2022-10-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620647#comment-17620647 ] ASF subversion and git services commented on SOLR-16452: Commit

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620645#comment-17620645 ] Joel Bernstein commented on SOLR-15733: --- All the tests have been moved. 463 files have now be moved

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620640#comment-17620640 ] Joel Bernstein commented on SOLR-15733: --- The module is starting to take shape:

[GitHub] [solr] janhoy commented on pull request #1090: SOLR-16463: Workaround for serious crash on JDK17+

2022-10-19 Thread GitBox
janhoy commented on PR #1090: URL: https://github.com/apache/solr/pull/1090#issuecomment-1284643327 > Could we maybe make this only be applied after Java 17? I think we have Java version checks before, so it should be a simple if statement. > > This would be a good exercise for JDK

[jira] [Commented] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620627#comment-17620627 ] Uwe Schindler commented on SOLR-16463: -- bq. I really hope this bug gets fixed in 17. I fear we'll be

[jira] [Comment Edited] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620626#comment-17620626 ] Uwe Schindler edited comment on SOLR-16463 at 10/19/22 10:13 PM: - Thanks,

[jira] [Commented] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620626#comment-17620626 ] Uwe Schindler commented on SOLR-16463: -- Thanks, Jan. This is exactly my own I just want to add: In

[GitHub] [solr-docker] uschindler commented on pull request #11: Dockerfile workaround to avoid crashes for SOLR 9.0.0 on JDK17

2022-10-19 Thread GitBox
uschindler commented on PR #11: URL: https://github.com/apache/solr-docker/pull/11#issuecomment-1284609594 Looks ok. Did you get any feedback from user mailing list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620614#comment-17620614 ] David Smiley commented on SOLR-16464: - To make a risk determination, I think one of us needs to look

[jira] [Commented] (SOLR-16477) Collection RENAME api creates broken alias

2022-10-19 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620611#comment-17620611 ] Alex Deparvu commented on SOLR-16477: - I am working on a PR for this > Collection RENAME api creates

[GitHub] [solr] HoustonPutman commented on pull request #1094: SOLR-15733: WIP

2022-10-19 Thread GitBox
HoustonPutman commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1284588558 Agreed, modules is not for solrj code, its for server modules. We don't have a solrj folder that hosts sub-folders yet (but we will starting in Solr 10), so it should just be called

[GitHub] [solr] risdenk commented on a diff in pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
risdenk commented on code in PR #953: URL: https://github.com/apache/solr/pull/953#discussion_r41029 ## solr/core/src/test/org/apache/solr/core/QueryResultKeyTest.java: ## @@ -134,7 +134,6 @@ public void testRandomQueryKeyEquality() { assertKeyNotEquals(aa, bb);

[GitHub] [solr-docker] janhoy commented on a diff in pull request #11: Dockerfile workaround to avoid crashes for SOLR 9.0.0 on JDK17

2022-10-19 Thread GitBox
janhoy commented on code in PR #11: URL: https://github.com/apache/solr-docker/pull/11#discussion_r39993 ## 9.0/Dockerfile: ## @@ -131,6 +131,9 @@ RUN set -ex; \ apt-get -y install acl dirmngr lsof procps wget netcat gosu tini jattach; \ rm -rf

[GitHub] [solr] risdenk commented on pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
risdenk commented on PR #953: URL: https://github.com/apache/solr/pull/953#issuecomment-1284581400 While reviewing this change and the casts - found there were a smattering of raw `assert ...` in tests that really should be `assertTrue(...)` and then those could be simplified. So

[GitHub] [solr] risdenk commented on pull request #1094: SOLR-15733: WIP

2022-10-19 Thread GitBox
risdenk commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1284578666 Shouldn't these all be similar to https://github.com/apache/solr/tree/main/solr/solrj-zookeeper? looks like these ended up in modules? -- This is an automated message from the Apache Git

[GitHub] [solr] risdenk commented on pull request #1094: SOLR-15733: WIP

2022-10-19 Thread GitBox
risdenk commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1284575694 I would have waited for after https://github.com/apache/solr/pull/953 potentially but if they are straight moves - might not be an issue. git may just handle it :) -- This is an

[jira] [Created] (SOLR-16479) Support for `repository` parameter in v2 api for restores

2022-10-19 Thread Josh Souza (Jira)
Josh Souza created SOLR-16479: - Summary: Support for `repository` parameter in v2 api for restores Key: SOLR-16479 URL: https://issues.apache.org/jira/browse/SOLR-16479 Project: Solr Issue Type:

[jira] [Commented] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620596#comment-17620596 ] Jan Høydahl commented on SOLR-16463: David, there is a risk of wack-a-mole for sure, we still don't

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620593#comment-17620593 ] Joel Bernstein commented on SOLR-15733: --- Started a PR: https://github.com/apache/solr/pull/1094.

[GitHub] [solr] joel-bernstein opened a new pull request, #1094: SOLR-15733: WIP

2022-10-19 Thread GitBox
joel-bernstein opened a new pull request, #1094: URL: https://github.com/apache/solr/pull/1094 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution

[jira] [Commented] (SOLR-16464) Upgrade commons-text to 1.10.0

2022-10-19 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620585#comment-17620585 ] Cassandra Targett commented on SOLR-16464: -- If the CVE behind this is not a risk for Solr, could

[GitHub] [solr] risdenk commented on pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
risdenk commented on PR #953: URL: https://github.com/apache/solr/pull/953#issuecomment-1284528274 6492b9a68252f92db11fbee074acbbbf05680a51 fixes a bunch of casts and some raw `assert` lines that I found along the way in the stream/sql test files that I was looking at. -- This is an

[GitHub] [solr] risdenk commented on a diff in pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
risdenk commented on code in PR #953: URL: https://github.com/apache/solr/pull/953#discussion_r999897558 ## solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java: ## @@ -425,22 +424,22 @@ public void testBasicSelect() throws Exception { tuples =

[GitHub] [solr-docker] HoustonPutman commented on a diff in pull request #11: Dockerfile workaround to avoid crashes for SOLR 9.0.0 on JDK17

2022-10-19 Thread GitBox
HoustonPutman commented on code in PR #11: URL: https://github.com/apache/solr-docker/pull/11#discussion_r999891917 ## 9.0/Dockerfile: ## @@ -131,6 +131,9 @@ RUN set -ex; \ apt-get -y install acl dirmngr lsof procps wget netcat gosu tini jattach; \ rm -rf

[GitHub] [solr] risdenk commented on a diff in pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
risdenk commented on code in PR #953: URL: https://github.com/apache/solr/pull/953#discussion_r999871914 ## solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java: ## @@ -425,22 +424,22 @@ public void testBasicSelect() throws Exception { tuples =

[GitHub] [solr] risdenk commented on pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
risdenk commented on PR #953: URL: https://github.com/apache/solr/pull/953#issuecomment-1284493030 > `assertEquals(3, tuple.getLong("myId").longValue());` > Is it better than cast? Just asking. Overall, I'm ok with your changes. I like that. I didn't try that option. I'll make

[GitHub] [solr] mkhludnev commented on pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
mkhludnev commented on PR #953: URL: https://github.com/apache/solr/pull/953#issuecomment-1284483387 @risdenk why do you think about `assertEquals(3, tuple.getLong("myId").longValue());` Is it better than cast? Just asking. Overall, I'm ok with your changes. -- This is an automated

[GitHub] [solr] mkhludnev commented on a diff in pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
mkhludnev commented on code in PR #953: URL: https://github.com/apache/solr/pull/953#discussion_r999858122 ## solr/core/src/test/org/apache/solr/handler/ReplicationTestHelper.java: ## @@ -202,15 +199,16 @@ public static NamedList getDetails(SolrClient s) throws Exception {

[jira] [Commented] (SOLR-16474) Resolving some external entities in Solr/Jetty configuration files currently does not work

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620524#comment-17620524 ] Kevin Risden commented on SOLR-16474: - [~veita] not sure I understand the issue here. What code in

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1093: SOLR-16446: Avoid redundant state.json update for PRS collection creation

2022-10-19 Thread GitBox
sonatype-lift[bot] commented on PR #1093: URL: https://github.com/apache/solr/pull/1093#issuecomment-1284472278 :warning: **313 God Classes** were detected by Lift in this project. [Visit the Lift web

[jira] [Created] (SOLR-16478) Further changes to avoid PRS entry writes from overseer

2022-10-19 Thread Patson Luk (Jira)
Patson Luk created SOLR-16478: - Summary: Further changes to avoid PRS entry writes from overseer Key: SOLR-16478 URL: https://issues.apache.org/jira/browse/SOLR-16478 Project: Solr Issue Type:

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620507#comment-17620507 ] Joel Bernstein commented on SOLR-15733: --- Ah, so by enabling sql, streaming would also be enabled.

[GitHub] [solr] madrob commented on a diff in pull request #1089: SOLR-16475 Make the default replica placement plugin configurable

2022-10-19 Thread GitBox
madrob commented on code in PR #1089: URL: https://github.com/apache/solr/pull/1089#discussion_r999818589 ## solr/packaging/test/test_placement_plugin.bats: ## @@ -0,0 +1,49 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [solr] risdenk commented on a diff in pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
risdenk commented on code in PR #953: URL: https://github.com/apache/solr/pull/953#discussion_r999816766 ## solr/core/src/test/org/apache/solr/handler/ReplicationTestHelper.java: ## @@ -202,15 +199,16 @@ public static NamedList getDetails(SolrClient s) throws Exception {

[GitHub] [solr] risdenk commented on pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
risdenk commented on PR #953: URL: https://github.com/apache/solr/pull/953#issuecomment-1284423921 @mkhludnev so two items from your review that I haven't addressed. One I don't think I can fix. The other I'm open to changing to static imports if really desired. Changes like

[GitHub] [solr] patsonluk opened a new pull request, #1093: SOLR-16446: Avoid redundant state.json update for PRS collection creation

2022-10-19 Thread GitBox
patsonluk opened a new pull request, #1093: URL: https://github.com/apache/solr/pull/1093 Copied from 8.8 PR https://github.com/fullstorydev/lucene-solr/pull/173 https://issues.apache.org/jira/browse/SOLR-16446 # Description It is found that the existing

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620501#comment-17620501 ] Kevin Risden commented on SOLR-15733: - so my understanding is that these just end up being "maven

[jira] [Comment Edited] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620500#comment-17620500 ] Joel Bernstein edited comment on SOLR-15733 at 10/19/22 6:33 PM: - If sql

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620500#comment-17620500 ] Joel Bernstein commented on SOLR-15733: --- If sql was enabled, would it automatically enable

[jira] [Comment Edited] (SOLR-16472) Remove redundant state.json update For PRS collection creation

2022-10-19 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620499#comment-17620499 ] Patson Luk edited comment on SOLR-16472 at 10/19/22 6:30 PM: - Sorry! This is

[jira] [Resolved] (SOLR-16472) Remove redundant state.json update For PRS collection creation

2022-10-19 Thread Patson Luk (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patson Luk resolved SOLR-16472. --- Resolution: Duplicate Sorry! This is actually a duplicate of #16446 > Remove redundant state.json

[jira] [Commented] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620491#comment-17620491 ] Cassandra Targett commented on SOLR-16463: -- I understand the workaround is simpler in a lot of

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620490#comment-17620490 ] Kevin Risden commented on SOLR-15733: - On the server side - for things like REINDEXCOLLECTION - not

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620489#comment-17620489 ] Kevin Risden commented on SOLR-15733: - I think it could be two (or three) solrj pieces: *

[GitHub] [solr] risdenk commented on pull request #1091: Bats Upgrade

2022-10-19 Thread GitBox
risdenk commented on PR #1091: URL: https://github.com/apache/solr/pull/1091#issuecomment-1284398805 Threw this together as an example for https://github.com/apache/solr/pull/1089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [solr] risdenk commented on a diff in pull request #1089: SOLR-16475 Make the default replica placement plugin configurable

2022-10-19 Thread GitBox
risdenk commented on code in PR #1089: URL: https://github.com/apache/solr/pull/1089#discussion_r999795723 ## solr/packaging/test/test_placement_plugin.bats: ## @@ -0,0 +1,49 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [solr] risdenk opened a new pull request, #1091: Bats Upgrade

2022-10-19 Thread GitBox
risdenk opened a new pull request, #1091: URL: https://github.com/apache/solr/pull/1091 https://issues.apache.org/jira/browse/SOLR-X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620486#comment-17620486 ] David Smiley commented on SOLR-16463: - I really hope this bug gets fixed in 17. I fear we'll be just

[jira] [Comment Edited] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620481#comment-17620481 ] Joel Bernstein edited comment on SOLR-15733 at 10/19/22 5:54 PM: - One

[jira] [Comment Edited] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620481#comment-17620481 ] Joel Bernstein edited comment on SOLR-15733 at 10/19/22 5:52 PM: - One

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620481#comment-17620481 ] Joel Bernstein commented on SOLR-15733: --- One other issue I can think of is the REINDEXCOLLECTION

[jira] [Commented] (SOLR-15733) Separate out a solrj-streaming module

2022-10-19 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620479#comment-17620479 ] Joel Bernstein commented on SOLR-15733: --- [~krisden], I'd like to finally get this ticket going.

[GitHub] [solr] risdenk commented on a diff in pull request #1089: SOLR-16475 Make the default replica placement plugin configurable

2022-10-19 Thread GitBox
risdenk commented on code in PR #1089: URL: https://github.com/apache/solr/pull/1089#discussion_r999757597 ## solr/packaging/test/test_placement_plugin.bats: ## @@ -0,0 +1,49 @@ +#!/usr/bin/env bats + +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [solr] uschindler commented on pull request #1090: SOLR-16463: Workaround for serious crash on JDK17+

2022-10-19 Thread GitBox
uschindler commented on PR #1090: URL: https://github.com/apache/solr/pull/1090#issuecomment-1284320160 > I also hope that the `-XX:CompileCommand=exclude` is supported even on JDK11 (I can validate this of course). _EDIT_ Started bin/solr on both JDK11 and JDK17. Yes, that there

[jira] [Commented] (SOLR-12767) Deprecate min_rf parameter and always include the achieved rf in the response

2022-10-19 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620463#comment-17620463 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-12767: -- The problem is that "doesn't

[jira] [Commented] (SOLR-16476) Don't need commons-text dependency in solr-core

2022-10-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620455#comment-17620455 ] Kevin Risden commented on SOLR-16476: - [~tflobbe] I think was also digging into this a bit. This is

[jira] [Commented] (SOLR-16476) Don't need commons-text dependency in solr-core

2022-10-19 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620454#comment-17620454 ] Eric Pugh commented on SOLR-16476: -- i didn't know that we could manipulate the JS on the fly like that,

[jira] [Created] (SOLR-16477) Collection RENAME api creates broken alias

2022-10-19 Thread Alex Deparvu (Jira)
Alex Deparvu created SOLR-16477: --- Summary: Collection RENAME api creates broken alias Key: SOLR-16477 URL: https://issues.apache.org/jira/browse/SOLR-16477 Project: Solr Issue Type: Bug

[GitHub] [solr-docker] uschindler commented on a diff in pull request #11: Dockerfile workaround to avoid crashes for SOLR 9.0.0 on JDK17

2022-10-19 Thread GitBox
uschindler commented on code in PR #11: URL: https://github.com/apache/solr-docker/pull/11#discussion_r999685525 ## 9.0/Dockerfile: ## @@ -131,6 +131,9 @@ RUN set -ex; \ apt-get -y install acl dirmngr lsof procps wget netcat gosu tini jattach; \ rm -rf

[jira] [Created] (SOLR-16476) Don't need commons-text dependency in solr-core

2022-10-19 Thread David Smiley (Jira)
David Smiley created SOLR-16476: --- Summary: Don't need commons-text dependency in solr-core Key: SOLR-16476 URL: https://issues.apache.org/jira/browse/SOLR-16476 Project: Solr Issue Type:

[GitHub] [solr-docker] HoustonPutman commented on a diff in pull request #11: Dockerfile workaround to avoid crashes for SOLR 9.0.0 on JDK17

2022-10-19 Thread GitBox
HoustonPutman commented on code in PR #11: URL: https://github.com/apache/solr-docker/pull/11#discussion_r999629398 ## 9.0/Dockerfile: ## @@ -131,6 +131,9 @@ RUN set -ex; \ apt-get -y install acl dirmngr lsof procps wget netcat gosu tini jattach; \ rm -rf

[GitHub] [solr] janhoy commented on pull request #1090: SOLR-16463: Workaround for serious crash on JDK17+

2022-10-19 Thread GitBox
janhoy commented on PR #1090: URL: https://github.com/apache/solr/pull/1090#issuecomment-1284163969 Have not tested these changes other than seeing that bin/solr on macos runs without crashing :) So I'll rely on static review for Windows, hoping there are no typos anywhere. I also

[GitHub] [solr-docker] janhoy commented on pull request #11: Workaround to avoid crashes for SOLR 9 on JDK17

2022-10-19 Thread GitBox
janhoy commented on PR #11: URL: https://github.com/apache/solr-docker/pull/11#issuecomment-1284157785 Awaiting feedback from users whether the workaround solves the issue at hand. We shold also document the workaround somewhere, probably an ANNOUNCE to users list and a news item to

[GitHub] [solr] janhoy commented on a diff in pull request #1089: SOLR-16475 Make the default replica placement plugin configurable

2022-10-19 Thread GitBox
janhoy commented on code in PR #1089: URL: https://github.com/apache/solr/pull/1089#discussion_r999584109 ## solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java: ## @@ -562,8 +566,33 @@ public static AssignStrategy createAssignStrategy(CoreContainer

[jira] [Commented] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17620399#comment-17620399 ] Jan Høydahl commented on SOLR-16463: For 9.1 I created a PR to hardcode the workaround in bin/solr,

[GitHub] [solr] janhoy opened a new pull request, #1090: SOLR-16463: Workaround for serious crash on JDK17+

2022-10-19 Thread GitBox
janhoy opened a new pull request, #1090: URL: https://github.com/apache/solr/pull/1090 https://issues.apache.org/jira/browse/SOLR-16463 Hardcode the JVM flag in `bin/solr[.cmd]` from Solr 9.1, to workaround

[GitHub] [solr] risdenk commented on a diff in pull request #953: SOLR-16311: Simplify assert statement

2022-10-19 Thread GitBox
risdenk commented on code in PR #953: URL: https://github.com/apache/solr/pull/953#discussion_r999567154 ## solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java: ## @@ -425,22 +424,22 @@ public void testBasicSelect() throws Exception { tuples =

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1089: SOLR-16475 Make the default replica placement plugin configurable

2022-10-19 Thread GitBox
HoustonPutman commented on code in PR #1089: URL: https://github.com/apache/solr/pull/1089#discussion_r999563220 ## solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java: ## @@ -562,8 +566,33 @@ public static AssignStrategy createAssignStrategy(CoreContainer

[jira] [Updated] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16463: --- Description: Solr 9+ under JDK 17+ may crash frequently, during JVM Hotspot optimization of

[jira] [Updated] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16463: --- Description: Solr 9+ under JDK 17+ may crash frequently, during JVM Hotspot optimization of

[jira] [Updated] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16463: --- Description: Solr 9+ under JDK 17+ may crash frequently, during JVM Hotspot optimization of

[jira] [Updated] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16463: --- Issue Type: Bug (was: Improvement) > Serious crash on JDK17+ due to JIT on caffeinecache >

[jira] [Updated] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16463: --- Summary: Serious crash on JDK17+ due to JIT on caffeinecache (was: Provide a jre11 version of Solr

[jira] [Updated] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16463: --- Fix Version/s: 9.1 > Serious crash on JDK17+ due to JIT on caffeinecache >

[jira] [Updated] (SOLR-16463) Serious crash on JDK17+ due to JIT on caffeinecache

2022-10-19 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16463: --- Priority: Blocker (was: Major) > Serious crash on JDK17+ due to JIT on caffeinecache >

  1   2   >