joshgog commented on PR #1144:
URL: https://github.com/apache/solr/pull/1144#issuecomment-1345132463
Hi @gerlowskija ,
Thank you for the update. I have been following the conversation on
[SOLR-16531](https://issues.apache.org/jira/browse/SOLR-16531) since it
involves this PR
--
[
https://issues.apache.org/jira/browse/SOLR-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-16099:
---
Assignee: Kevin Risden
> HTTP Client threads can hang in Jetty's
[
https://issues.apache.org/jira/browse/SOLR-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16099:
Status: Patch Available (was: Open)
> HTTP Client threads can hang in Jetty's
risdenk opened a new pull request, #1230:
URL: https://github.com/apache/solr/pull/1230
https://issues.apache.org/jira/browse/SOLR-16099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
patsonluk opened a new pull request, #1229:
URL: https://github.com/apache/solr/pull/1229
https://issues.apache.org/jira/browse/SOLR-16582
# Description
Logs can somethings be a bit too noisy on SolrCore#execute which prints info
on each response.
In our usage, `/get`
Patson Luk created SOLR-16582:
-
Summary: Add marker to request logging of SolrCore#execute
Key: SOLR-16582
URL: https://issues.apache.org/jira/browse/SOLR-16582
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-15787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645532#comment-17645532
]
David Smiley commented on SOLR-15787:
-
FileSystemConfigSetService already exists; you separated it
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645506#comment-17645506
]
Gabriel Magno commented on SOLR-16567:
--
I was able to implement a fix for this bug, with a
epugh commented on code in PR #1213:
URL: https://github.com/apache/solr/pull/1213#discussion_r1044891360
##
solr/example/films/vectors/create_dataset.py:
##
@@ -0,0 +1,48 @@
+from sentence_transformers import SentenceTransformer, util
+import torch
+
+from films import *
+
sonatype-lift[bot] commented on code in PR #1213:
URL: https://github.com/apache/solr/pull/1213#discussion_r1044884523
##
solr/example/films/vectors/create_dataset.py:
##
@@ -0,0 +1,48 @@
+from sentence_transformers import SentenceTransformer, util
+import torch
+
+from films
gabrielmagno commented on PR #1213:
URL: https://github.com/apache/solr/pull/1213#issuecomment-1344828965
Gradlew returned and error:
```
Execution failed for task ':solr:example:rat'.
> Detected license header issues (skip with
-Pvalidation.rat.failOnError=false):
Unknown
dsmiley commented on code in PR #146:
URL: https://github.com/apache/solr/pull/146#discussion_r1044864840
##
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##
@@ -148,4 +283,12 @@ protected Long getCurrentSchemaModificationVersion(
return null;
[
https://issues.apache.org/jira/browse/SOLR-16574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-16574:
Assignee: Eric Pugh
> Demonstrate Dense Vectors and KNN as part of the Films example
>
stillalex commented on PR #1155:
URL: https://github.com/apache/solr/pull/1155#issuecomment-1344809731
> Ahhh, no I think this is a misunderstanding. I exactly copied the work
that is actually done. CoreContainer.getCore() set's incRefCount to true and
triggers SolrCore.open(). If you set
gabrielmagno commented on PR #1213:
URL: https://github.com/apache/solr/pull/1213#issuecomment-1344809165
Hey @epugh !
I've created a new model and have put the Python scripts that were used to
create the model and calculate the films vectors inside a subfolder called
`vectors`.
[
https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645482#comment-17645482
]
Kevin Risden commented on SOLR-15955:
-
[
https://issues.apache.org/jira/browse/SOLR-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645481#comment-17645481
]
Kevin Risden commented on SOLR-16099:
-
Arvind-Avinash opened a new pull request, #1228:
URL: https://github.com/apache/solr/pull/1228
Fixed a minor grammatical issue.
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with
[
https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645477#comment-17645477
]
Shawn Heisey commented on SOLR-9509:
I love shellcheck. I do sometimes disable some of the "style"
Arvind-Avinash opened a new pull request, #1227:
URL: https://github.com/apache/solr/pull/1227
Corrected the typos in the date-time formats
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're
janhoy commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1044748495
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -0,0 +1,29 @@
+package org.apache.solr.opentelemetry;
+
+import
[
https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645449#comment-17645449
]
Jan Høydahl commented on SOLR-9509:
---
I put up a new PR for review [GitHub Pull Request
[
https://issues.apache.org/jira/browse/SOLR-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645446#comment-17645446
]
ASF subversion and git services commented on SOLR-16581:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16581:
Fix Version/s: 9.2
> Upgrade OWASP dependency check to 7.4.1
>
[
https://issues.apache.org/jira/browse/SOLR-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16581:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Upgrade OWASP dependency
janhoy commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1044742060
##
solr/bin/solr:
##
@@ -2153,16 +2160,17 @@ function start_solr() {
SOLR_JETTY_ADDL_CONFIG="$3"
# define default GC_TUNE
- if [ -z ${GC_TUNE+x} ]; then # I think
janhoy commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1044739591
##
solr/bin/solr:
##
@@ -1821,7 +1825,7 @@ fi
# otherwise let this script proceed to process the user request
#
if [ -n "${EXAMPLE:-}" ] && [ "$SCRIPT_CMD" == "start"
HoustonPutman commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1044738129
##
solr/bin/solr:
##
@@ -841,25 +846,26 @@ function stop_solr() {
DIR="$1"
SOLR_PORT="$2"
- THIS_STOP_PORT="${STOP_PORT:-$(expr $SOLR_PORT - 1000)}"
+
janhoy commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1044737218
##
solr/bin/solr:
##
@@ -841,25 +846,26 @@ function stop_solr() {
DIR="$1"
SOLR_PORT="$2"
- THIS_STOP_PORT="${STOP_PORT:-$(expr $SOLR_PORT - 1000)}"
+
janhoy commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1044735101
##
solr/bin/solr:
##
@@ -729,6 +733,7 @@ function jetty_port() {
# useful for doing cross-platform work from the command-line using Java
function run_tool() {
+ #
janhoy commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1044732306
##
solr/bin/solr:
##
@@ -73,25 +74,26 @@ fi
# Resolve symlinks to this script
while [ -h "$SOLR_SCRIPT" ] ; do
- ls=`ls -ld "$SOLR_SCRIPT"`
+ ls=$(ls -ld
[
https://issues.apache.org/jira/browse/SOLR-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16581:
Fix Version/s: main (10.0)
> Upgrade OWASP dependency check to 7.4.1
>
[
https://issues.apache.org/jira/browse/SOLR-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645442#comment-17645442
]
ASF subversion and git services commented on SOLR-16581:
Commit
risdenk merged PR #1226:
URL: https://github.com/apache/solr/pull/1226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
risdenk commented on PR #1226:
URL: https://github.com/apache/solr/pull/1226#issuecomment-1344633895
> Exciting what we can do with the new report format
its not that exciting :) it just doesn't have JS so it makes it possible to
read right from the Jenkins job instead of downloading
janhoy commented on PR #1223:
URL: https://github.com/apache/solr/pull/1223#issuecomment-1344629883
Perhaps we should modify all our "Check xxx" Jenkins jobs to do `check
integrationTests`? Or should `check` include `integrationTests`?
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/SOLR-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16581:
Description: Dependency Check 7.4.0 added a Jenkins format
risdenk commented on code in PR #1226:
URL: https://github.com/apache/solr/pull/1226#discussion_r1044679162
##
gradle/validation/owasp-dependency-check/exclusions.xml:
##
@@ -51,4 +51,25 @@
^pkg:maven/org\.carrot2\.shaded/carrot2\-guava@.*$
cpe:/a:google:guava
+
debe commented on PR #1155:
URL: https://github.com/apache/solr/pull/1155#issuecomment-1344569141
> @debe thank you for taking a look!
>
> First off, mockito is troublesome. we can take it out completely if there
is a way to setup solr without it. I added it only for the transient
[
https://issues.apache.org/jira/browse/SOLR-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645407#comment-17645407
]
Kevin Risden commented on SOLR-16581:
-
PR https://github.com/apache/solr/pull/1226
> Upgrade OWASP
[
https://issues.apache.org/jira/browse/SOLR-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16581:
Status: Patch Available (was: Open)
> Upgrade OWASP dependency check to 7.4.1
>
Kevin Risden created SOLR-16581:
---
Summary: Upgrade owasp dependency check to 7.4.1
Key: SOLR-16581
URL: https://issues.apache.org/jira/browse/SOLR-16581
Project: Solr
Issue Type: Task
[
https://issues.apache.org/jira/browse/SOLR-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16581:
Summary: Upgrade OWASP dependency check to 7.4.1 (was: Upgrade owasp
dependency check to 7.4.1)
stillalex commented on PR #1155:
URL: https://github.com/apache/solr/pull/1155#issuecomment-1344548353
@debe thank you for taking a look!
First off, mockito is troublesome. we can take it out completely if there is
a way to setup solr without it. I added it only for the transient
risdenk opened a new pull request, #1226:
URL: https://github.com/apache/solr/pull/1226
https://issues.apache.org/jira/browse/SOLR-X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
janhoy commented on PR #1225:
URL: https://github.com/apache/solr/pull/1225#issuecomment-1344512480
There's a bug somewhere, trying to hunt down...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-9509:
-
Assignee: Jan Høydahl
> Fix problems in shell scripts reported by "shellcheck"
>
janhoy opened a new pull request, #1225:
URL: https://github.com/apache/solr/pull/1225
https://issues.apache.org/jira/browse/SOLR-9509
I used a shellcheck plugin to IntelliJ to fix these. I skipped several
suggestions since I don't want to use "new" switches for various tools which
epugh commented on PR #1220:
URL: https://github.com/apache/solr/pull/1220#issuecomment-1344483969
> You added to the Builder but never consumed it! Do this in CloudSolrClient
which is the base of the new & old impls.
>
> You said we do not _use_ this property but I believe you mean
[
https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645345#comment-17645345
]
Jan Høydahl commented on SOLR-9509:
---
Hi [~rmp91] , [~tkurosaka] and others. There is now actually a
risdenk commented on PR #1223:
URL: https://github.com/apache/solr/pull/1223#issuecomment-133165
> Don't we have at least nightly Jenkins runs of ./gradlew integrationTests ?
not that I could find from a quick check of the jobs here:
https://ci-builds.apache.org/job/Solr/
--
janhoy commented on PR #1223:
URL: https://github.com/apache/solr/pull/1223#issuecomment-1344439697
Don't we have at least nightly Jenkins runs of `./gradlew integrationTests` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mpetris commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044557278
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -555,23 +658,41 @@ public boolean isCoreLoading(String name) {
}
public void
gerlowskija commented on PR #1144:
URL: https://github.com/apache/solr/pull/1144#issuecomment-1344416469
Hi @joshgog
Just wanted to give you a short update on my lack of progress on this.
It is definitely still on my radar, but I've been a little distracted
recently focusing
gerlowskija commented on PR #1196:
URL: https://github.com/apache/solr/pull/1196#issuecomment-1344414507
Hi @bszabo97
Just wanted to give you a short update on my lack of progress on this.
It is definitely still on my radar, but I've been a little distracted
recently focusing
gerlowskija commented on PR #1126:
URL: https://github.com/apache/solr/pull/1126#issuecomment-1344412977
Hi @Jdurham2843
Just wanted to give you a short update on my lack of progress on this.
It is definitely still on my radar, but I've been a little distracted
recently
gerlowskija commented on PR #1119:
URL: https://github.com/apache/solr/pull/1119#issuecomment-1344407206
Hi @iamsanjay
Just wanted to give you a short update on my lack of progress on this. It
is definitely still on my radar, but there are a few things that are holding it
up at
bruno-roustant commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044526330
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -555,23 +658,41 @@ public boolean isCoreLoading(String name) {
}
public void
mpetris commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044522720
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -555,23 +658,41 @@ public boolean isCoreLoading(String name) {
}
public void
mpetris commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044515521
##
solr/core/src/java/org/apache/solr/core/SolrCores.java:
##
@@ -555,23 +658,41 @@ public boolean isCoreLoading(String name) {
}
public void
debe commented on PR #1155:
URL: https://github.com/apache/solr/pull/1155#issuecomment-1344368444
Hi @stillalex,
I've changed your proposed benchmark a little bit. See
[main](https://github.com/apache/solr/compare/main...tboeghk:solr:main-bench?expand=1)
and
janhoy commented on code in PR #1177:
URL: https://github.com/apache/solr/pull/1177#discussion_r101376
##
CONTRIBUTING.md:
##
@@ -0,0 +1,34 @@
+# Contribute To Solr
+
+Thank you for your interest in contributing to the Apache Solr project. Solr
continues to improve via the
ben-manes commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044281175
##
solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java:
##
@@ -70,10 +80,15 @@ public TransientSolrCoreCacheDefault(CoreContainer
coreContainer)
bruno-roustant commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044259391
##
solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java:
##
@@ -70,10 +80,15 @@ public TransientSolrCoreCacheDefault(CoreContainer
ben-manes commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044256199
##
solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java:
##
@@ -70,10 +80,15 @@ public TransientSolrCoreCacheDefault(CoreContainer
coreContainer)
bruno-roustant commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044250179
##
solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java:
##
@@ -47,6 +49,14 @@ public class TransientSolrCoreCacheDefault extends
bruno-roustant commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044244530
##
solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java:
##
@@ -70,10 +80,15 @@ public TransientSolrCoreCacheDefault(CoreContainer
bruno-roustant commented on code in PR #1155:
URL: https://github.com/apache/solr/pull/1155#discussion_r1044244530
##
solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java:
##
@@ -70,10 +80,15 @@ public TransientSolrCoreCacheDefault(CoreContainer
janhoy commented on PR #1168:
URL: https://github.com/apache/solr/pull/1168#issuecomment-1344026969
Also, I'm wondering. Could we not let this module register itself as
`GlobalTracer` if enabled? I mean, if you enable the module with
`-Dsolr.modules=opentelemetry` then chances are you want
janhoy commented on PR #1168:
URL: https://github.com/apache/solr/pull/1168#issuecomment-1344021399
This is one step closer commit.
How to you propse we add tests for this? It does not feel necessary to mock
a collector to prove that traces are sent. We have to trust the library...
janhoy commented on code in PR #1168:
URL: https://github.com/apache/solr/pull/1168#discussion_r1044217897
##
solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java:
##
@@ -0,0 +1,29 @@
+package org.apache.solr.opentelemetry;
+
+import
71 matches
Mail list logo
