dsmiley commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1063955335
##
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##
@@ -259,6 +260,14 @@ public FileVisitResult postVisitDirectory(Path dir,
IOException
[
https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655649#comment-17655649
]
Vassil Velichkov edited comment on SOLR-16463 at 1/7/23 5:15 AM:
-
It
[
https://issues.apache.org/jira/browse/SOLR-16463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655649#comment-17655649
]
Vassil Velichkov commented on SOLR-16463:
-
It seems the OpenJDK bug is fixed, the ticket waits
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655640#comment-17655640
]
David Smiley commented on SOLR-16531:
-
What are the gaps with app-per-ConfigSet?
> Performance
[
https://issues.apache.org/jira/browse/SOLR-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter reassigned SOLR-6312:
Assignee: Chris M. Hostetter
> CloudSolrServer doesn't honor updatesToLeaders
[
https://issues.apache.org/jira/browse/SOLR-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655612#comment-17655612
]
Chris M. Hostetter edited comment on SOLR-6312 at 1/7/23 12:56 AM:
---
I've
[
https://issues.apache.org/jira/browse/SOLR-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655612#comment-17655612
]
Chris M. Hostetter commented on SOLR-6312:
--
I've been working on this a bit over the past few
[
https://issues.apache.org/jira/browse/SOLR-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655611#comment-17655611
]
ASF subversion and git services commented on SOLR-6312:
---
Commit
metapox commented on PR #1274:
URL: https://github.com/apache/solr/pull/1274#issuecomment-1374280899
@mkhludnev Thanks for review!
> Pls put to comment the failed ones.
Are you satisfied with this?
before
```
./gradlew test --tests
magibney commented on code in PR #1279:
URL: https://github.com/apache/solr/pull/1279#discussion_r1063821975
##
solr/core/src/java/org/apache/solr/util/CryptoKeys.java:
##
@@ -295,15 +304,28 @@ public PublicKey getPublicKey() {
return publicKey;
}
-public
risdenk commented on PR #1239:
URL: https://github.com/apache/solr/pull/1239#issuecomment-1374159212
Tested the latest changes on Mac and Windows and both pass (`.\gradlew test
--tests TestConfigSetService`)
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655584#comment-17655584
]
Noble Paul edited comment on SOLR-16531 at 1/6/23 9:25 PM:
---
{quote}shows enough
risdenk commented on code in PR #1239:
URL: https://github.com/apache/solr/pull/1239#discussion_r1063815270
##
solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java:
##
@@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName)
throws IOException {
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655584#comment-17655584
]
Noble Paul commented on SOLR-16531:
---
{quote}shows enough promise that it'd make sense to extend the
risdenk commented on PR #1279:
URL: https://github.com/apache/solr/pull/1279#issuecomment-1374120814
> Should we switch the algorithm from no padding to something with padding?
probably at some point. I don't really want to tackle that with this. This
at least cleans up the build
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655580#comment-17655580
]
Jason Gerlowski commented on SOLR-16531:
Alright, wanted to post another update on my progress to
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-16531:
---
Attachment: jaxrs-integration-with-app-per-configset-flamegraph.html
> Performance
[
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-16531:
---
Attachment: vanilla-jaxrs-integration-flamegraph.html
> Performance degradation due to
[
https://issues.apache.org/jira/browse/SOLR-16613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16613:
Status: Patch Available (was: Open)
> CryptoKeys should handle RSA padding for OpenJ9
>
risdenk commented on code in PR #1279:
URL: https://github.com/apache/solr/pull/1279#discussion_r1063768185
##
solr/core/src/test/org/apache/solr/cloud/TestRSAKeyPair.java:
##
@@ -36,26 +38,29 @@ public void testGenKeyPair() throws Exception {
public void
risdenk opened a new pull request, #1279:
URL: https://github.com/apache/solr/pull/1279
https://issues.apache.org/jira/browse/SOLR-16613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-16613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16613:
Description:
I'm looking into the TestRSAKeyPair and TestPKIAuthenticationPlugin test
failures on
[
https://issues.apache.org/jira/browse/SOLR-16613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16613:
Description:
I'm looking into the TestRSAKeyPair and TestPKIAuthenticationPlugin test
failures on
Kevin Risden created SOLR-16613:
---
Summary: CryptoKeys should handle RSA padding for OpenJ9
Key: SOLR-16613
URL: https://issues.apache.org/jira/browse/SOLR-16613
Project: Solr
Issue Type: Task
mkhludnev commented on PR #1274:
URL: https://github.com/apache/solr/pull/1274#issuecomment-1374073171
@metapox can you confirm that you run tests? Pls put to comment the failed
ones. Just to double check before merge.
Appreciate your effort!
--
This is an automated message from the
janhoy commented on PR #14:
URL: https://github.com/apache/solr-docker/pull/14#issuecomment-1374041464
@ritchieaxon Do you want to update the checksum to match the new version.
Then, once Solr 9.2 ships, probably in February-ish, we can merge this. I'll
convert it to a draft for now, to
[
https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655562#comment-17655562
]
ASF subversion and git services commented on SOLR-9509:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-9509.
---
Fix Version/s: 9.2
Resolution: Fixed
> Fix problems in shell scripts reported by "shellcheck"
[
https://issues.apache.org/jira/browse/SOLR-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1765#comment-1765
]
ASF subversion and git services commented on SOLR-9509:
---
Commit
janhoy merged PR #1225:
URL: https://github.com/apache/solr/pull/1225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-16535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16535.
Fix Version/s: main (10.0)
Resolution: Fixed
> Remove jaegertracer-configurator module
[
https://issues.apache.org/jira/browse/SOLR-16535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1763#comment-1763
]
ASF subversion and git services commented on SOLR-16535:
Commit
janhoy merged PR #1272:
URL: https://github.com/apache/solr/pull/1272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mkhludnev commented on code in PR #1274:
URL: https://github.com/apache/solr/pull/1274#discussion_r1063606970
##
solr/core/src/test/org/apache/solr/search/TestCollapseQParserPlugin.java:
##
@@ -440,6 +440,13 @@ private void testDoubleCollapse(String group) {
}
private
justinrsweeney commented on PR #1267:
URL: https://github.com/apache/solr/pull/1267#issuecomment-1373888188
> This would be a pretty scary feature to use for me (since there are times
where modifying cluster state manually can be unfortunately necessary).
>
> But overall I have a few
[
https://issues.apache.org/jira/browse/SOLR-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655499#comment-17655499
]
Michael Gibney commented on SOLR-15254:
---
Thanks for offering/thinking of this! I think it might
HoustonPutman commented on code in PR #1267:
URL: https://github.com/apache/solr/pull/1267#discussion_r1063543337
##
solr/solrj/src/test/org/apache/solr/common/cloud/SolrZkClientCompressedDataTest.java:
##
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation
HoustonPutman commented on PR #507:
URL: https://github.com/apache/solr-operator/pull/507#issuecomment-1373790132
Ok, big win. Much like the solr tests, the e2e tests are now completely
reproducable with all possible inputs (random seed, operator/solr image,
kubernetes version, etc), and
noblepaul commented on code in PR #819:
URL: https://github.com/apache/solr/pull/819#discussion_r1063436306
##
solr/core/src/java/org/apache/solr/search/facet/Constants.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
noblepaul commented on code in PR #1243:
URL: https://github.com/apache/solr/pull/1243#discussion_r1063434858
##
solr/core/src/test-files/solr/solr.xml:
##
@@ -35,11 +35,6 @@
${connTimeout:15000}
-
Review Comment:
> I don't think this should require
[
https://issues.apache.org/jira/browse/SOLR-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655446#comment-17655446
]
ASF subversion and git services commented on SOLR-16165:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655445#comment-17655445
]
ASF subversion and git services commented on SOLR-16165:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-16165:
--
Fix Version/s: 9.1.1
(was: 9.2)
> Deadlock in SlotAcc initialization
>
[
https://issues.apache.org/jira/browse/SOLR-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655443#comment-17655443
]
ASF subversion and git services commented on SOLR-16165:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17655444#comment-17655444
]
ASF subversion and git services commented on SOLR-16165:
Commit
cpoerschke merged PR #1268:
URL: https://github.com/apache/solr/pull/1268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
henrik242 commented on code in PR #1255:
URL: https://github.com/apache/solr/pull/1255#discussion_r1063397791
##
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##
@@ -124,18 +124,18 @@ public KnnVectorsFormat
getKnnVectorsFormatForField(String field) {
janhoy commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1063389460
##
solr/bin/solr:
##
@@ -2153,16 +2160,17 @@ function start_solr() {
SOLR_JETTY_ADDL_CONFIG="$3"
# define default GC_TUNE
- if [ -z ${GC_TUNE+x} ]; then # I think
janhoy commented on code in PR #1225:
URL: https://github.com/apache/solr/pull/1225#discussion_r1063389460
##
solr/bin/solr:
##
@@ -2153,16 +2160,17 @@ function start_solr() {
SOLR_JETTY_ADDL_CONFIG="$3"
# define default GC_TUNE
- if [ -z ${GC_TUNE+x} ]; then # I think
49 matches
Mail list logo
